Thanks for the simplified test case. I've pushed it at 02e73d4
On Mon, Aug 16, 2021 at 10:31 PM David Blaikie wrote:
> Perhaps the test case could be stripped down a bit?
>
> template
> class Array {};
>
> template
> class S {};
>
> template
> Array Make();
>
> void Call() {
> Array> v = Mak
Author: rtrieu
Date: Fri Oct 18 18:47:49 2019
New Revision: 375326
URL: http://llvm.org/viewvc/llvm-project?rev=375326&view=rev
Log:
Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:"
Extend -Wparentheses to cover mixing bitwise-and and bitwise-or with the
conditional o
Author: rtrieu
Date: Fri Oct 18 17:57:23 2019
New Revision: 375318
URL: http://llvm.org/viewvc/llvm-project?rev=375318&view=rev
Log:
New tautological warning for bitwise-or with non-zero constant always true.
Taking a value and the bitwise-or it with a non-zero constant will always
result in a no
Author: rtrieu
Date: Tue Oct 1 19:32:15 2019
New Revision: 373421
URL: http://llvm.org/viewvc/llvm-project?rev=373421&view=rev
Log:
Revert r368237 - Update fix-it hints for std::move warnings.
r368237 attempted to improve fix-its for move warnings, but introduced some
regressions to -Wpessimizin
Author: rtrieu
Date: Fri Sep 20 21:18:54 2019
New Revision: 372454
URL: http://llvm.org/viewvc/llvm-project?rev=372454&view=rev
Log:
Fix bad APInt compare.
APInt comparison require both to have the same bitwidth. Since only the value
is needed, use the compare function APInt::isSameValue instead
Author: rtrieu
Date: Fri Sep 20 20:02:26 2019
New Revision: 372453
URL: http://llvm.org/viewvc/llvm-project?rev=372453&view=rev
Log:
Merge and improve code that detects same value in comparisons.
-Wtautological-overlap-compare and self-comparison from -Wtautological-compare
relay on detecting the
Author: rtrieu
Date: Fri Sep 20 19:37:10 2019
New Revision: 372448
URL: http://llvm.org/viewvc/llvm-project?rev=372448&view=rev
Log:
Improve -Wtautological-overlap-compare
Allow this warning to detect a larger number of constant values, including
negative numbers, and handle non-int types better.
Author: rtrieu
Date: Mon Aug 19 17:28:21 2019
New Revision: 369316
URL: http://llvm.org/viewvc/llvm-project?rev=369316&view=rev
Log:
Fix typo. "piont" => "point"
Found by Chris Morris (cwmorris).
Modified:
clang-tools-extra/trunk/clang-tidy/abseil/DurationConversionCastCheck.cpp
clang-t
Author: rtrieu
Date: Wed Aug 7 18:45:31 2019
New Revision: 368244
URL: http://llvm.org/viewvc/llvm-project?rev=368244&view=rev
Log:
Inline diagnostic text into .td file. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/tr
Author: rtrieu
Date: Wed Aug 7 17:12:51 2019
New Revision: 368237
URL: http://llvm.org/viewvc/llvm-project?rev=368237&view=rev
Log:
Update fix-it hints for std::move warnings.
Fix -Wpessimizing-move and -Wredundant-move when warning on initializer lists.
The new fix-it hints for removing the std
To avoid confusion, there's both a LLVM Type and a Clang Type. The LLVM
Type is used in the LLVM IR while the Clang Type represents types in a
language, like C++.
The Clang Doxygen pages have this hierarchy, although it's truncated
because Type is so large, but you can click through to get the mi
Author: rtrieu
Date: Wed Jul 10 19:54:15 2019
New Revision: 365727
URL: http://llvm.org/viewvc/llvm-project?rev=365727&view=rev
Log:
Increase the number of parser diagnostics.
The reserved range for parser diagnostics is getting close to being filled,
so increase the space for them.
Modified:
Author: rtrieu
Date: Fri Jun 21 17:32:19 2019
New Revision: 364119
URL: http://llvm.org/viewvc/llvm-project?rev=364119&view=rev
Log:
[ODRHash] Skip some typedef types.
In some cases, a typedef only strips aways a keyword for a type, keeping the
same name as the root record type. This causes some
Author: rtrieu
Date: Thu May 30 19:23:33 2019
New Revision: 362187
URL: http://llvm.org/viewvc/llvm-project?rev=362187&view=rev
Log:
Redirect test output to /dev/null
Modified:
cfe/trunk/test/Driver/armv8.1m.main.s
Modified: cfe/trunk/test/Driver/armv8.1m.main.s
URL:
http://llvm.org/viewvc/
some sort of cycle breaking infrastructure -
> >> so that if the same type is seen more than once (eg: classes have
> >> members that have pointers back to the outer class type, etc) they
> >> don't cause indefinite cycles? Should that infrastructure have caug
ers back to the outer class type, etc) they
> don't cause indefinite cycles? Should that infrastructure have caught
> these cases & avoided the redundant work?
>
> I'm curious to understand better how these things work/overlap/or don't.
>
> On Fri, May
Author: rtrieu
Date: Fri May 3 21:22:33 2019
New Revision: 359960
URL: http://llvm.org/viewvc/llvm-project?rev=359960&view=rev
Log:
Reduce amount of work ODR hashing does.
When a FunctionProtoType is in the original type in a DecayedType, the decayed
type is a PointerType which points back the o
Author: rtrieu
Date: Wed May 1 16:33:49 2019
New Revision: 359740
URL: http://llvm.org/viewvc/llvm-project?rev=359740&view=rev
Log:
Consume unexpected "template" keywords after "using"
The parser was dealing with unexpected "template" keywords after "using"
keywords too late and putting the pars
Author: rtrieu
Date: Thu Mar 14 21:26:02 2019
New Revision: 356231
URL: http://llvm.org/viewvc/llvm-project?rev=356231&view=rev
Log:
Remove an assert in template pack deduction during nested instantiation.
Modified:
cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp
cfe/trunk/test/SemaTem
Author: rtrieu
Date: Thu Jan 10 17:32:35 2019
New Revision: 350913
URL: http://llvm.org/viewvc/llvm-project?rev=350913&view=rev
Log:
Fix header issues.
Several headers would fail to compile if other headers were not previously
included. The usual issue is that a class is forward declared, but th
Author: rtrieu
Date: Wed Jan 9 20:53:10 2019
New Revision: 350797
URL: http://llvm.org/viewvc/llvm-project?rev=350797&view=rev
Log:
Remove unnecessary include.
QuerySession.h does not need anything from Query.h, so it does not need to
include it.
Modified:
clang-tools-extra/trunk/clang-quer
Author: rtrieu
Date: Wed Jan 9 19:23:25 2019
New Revision: 350792
URL: http://llvm.org/viewvc/llvm-project?rev=350792&view=rev
Log:
Refactor declarations of ASTContext allocate functions into its own header.
Forward declarations of the allocate functions combine with the forward
declaration of t
s in the coding standard - is there any particular
> other motivation for this? (Given you've been doing layering cleanup - I'm
> wondering fi this is an interesting workaround for some layering problems,
> for instance?)
>
> On Sat, Dec 29, 2018 at 1:05 PM Richard Trie
Author: rtrieu
Date: Fri Dec 28 18:02:30 2018
New Revision: 350143
URL: http://llvm.org/viewvc/llvm-project?rev=350143&view=rev
Log:
Add vtable anchor to classes.
Modified:
cfe/trunk/include/clang/AST/DeclCXX.h
cfe/trunk/include/clang/AST/DeclTemplate.h
cfe/trunk/include/clang/Lex/Mod
Author: rtrieu
Date: Fri Dec 14 20:25:19 2018
New Revision: 349237
URL: http://llvm.org/viewvc/llvm-project?rev=349237&view=rev
Log:
Fix includes and dependencies for libclang
Remove unneeded includes
Add needed include
Remove dependency on Serialization
Modified:
cfe/trunk/tools/libclang/CI
Author: rtrieu
Date: Fri Dec 14 18:30:16 2018
New Revision: 349230
URL: http://llvm.org/viewvc/llvm-project?rev=349230&view=rev
Log:
Move static analyzer core diagnostics to common.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticCommonKinds.td
cfe/trunk/include/clang/Basic/DiagnosticFr
Author: rtrieu
Date: Thu Dec 13 19:35:10 2018
New Revision: 349125
URL: http://llvm.org/viewvc/llvm-project?rev=349125&view=rev
Log:
Fix up diagnostics.
Move some diagnostics around between Diagnostic*Kinds.td files. Diagnostics
used in multiple places were moved to DiagnosticCommonKinds.td. Di
Author: rtrieu
Date: Tue Dec 11 18:53:59 2018
New Revision: 348907
URL: http://llvm.org/viewvc/llvm-project?rev=348907&view=rev
Log:
Move PCHContainerOperations from Frontend to Serialization
Fix a layering violation. Frontend depends on Serialization, so anything used
by both should be in Seria
Author: rtrieu
Date: Mon Dec 10 19:18:39 2018
New Revision: 348827
URL: http://llvm.org/viewvc/llvm-project?rev=348827&view=rev
Log:
Move CodeGenOptions from Frontend to Basic
Basic uses CodeGenOptions and should not depend on Frontend.
Added:
cfe/trunk/include/clang/Basic/CodeGenOptions.def
Author: rtrieu
Date: Fri Dec 7 21:05:03 2018
New Revision: 348685
URL: http://llvm.org/viewvc/llvm-project?rev=348685&view=rev
Log:
Move diagnostic enums into Basic.
Move enums from */*Diagnostic.h to Basic/Diagnostic*.h. Basic/AllDiagnostics.h
needs all the enums and moving the sources to Basi
Author: rtrieu
Date: Wed Dec 5 22:32:40 2018
New Revision: 348459
URL: http://llvm.org/viewvc/llvm-project?rev=348459&view=rev
Log:
Remove unnecessary include.
Modified:
cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperatio
Author: rtrieu
Date: Wed Dec 5 22:12:20 2018
New Revision: 348458
URL: http://llvm.org/viewvc/llvm-project?rev=348458&view=rev
Log:
Remove CodeGen dependencies on Sema.
Move diagnostics from Sema to Frontend (or Common) so that CodeGen no longer
needs to include the Sema diagnostic IDs.
Modifie
Author: rtrieu
Date: Mon Dec 3 20:53:18 2018
New Revision: 348238
URL: http://llvm.org/viewvc/llvm-project?rev=348238&view=rev
Log:
Remove unnecessary include.
Modified:
cfe/trunk/lib/CodeGen/CodeGenTypes.h
Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.h
URL:
http://llvm.org/viewvc/llvm-pro
Author: rtrieu
Date: Tue Nov 27 20:36:31 2018
New Revision: 347728
URL: http://llvm.org/viewvc/llvm-project?rev=347728&view=rev
Log:
Move LoopHint.h from Sema to Parse
struct LoopHint was only used within Parse and not in any of the Sema or
Codegen files. In the non-Parse files where it was incl
Author: rtrieu
Date: Tue Nov 27 20:14:29 2018
New Revision: 347727
URL: http://llvm.org/viewvc/llvm-project?rev=347727&view=rev
Log:
[CodeGen] Fix included headers.
Remove the included Parse header because CodeGen should not depend on Parse.
Instead, include the Lex headers that it needs instead.
Author: rtrieu
Date: Tue Nov 27 19:59:35 2018
New Revision: 347726
URL: http://llvm.org/viewvc/llvm-project?rev=347726&view=rev
Log:
[diagtool] Remove unneeded header includes.
Modified:
cfe/trunk/tools/diagtool/ListWarnings.cpp
cfe/trunk/tools/diagtool/TreeView.cpp
Modified: cfe/trunk/t
I have reverted this in r345691 because it caused test
CodeGen/mingw-long-double.c to start failing.
Command Output (stderr):
--
/usr/local/google/clang/install/llvm/tools/clang/test/CodeGen/mingw-long-double.c:36:11:
error: MSC64: expected string not found in input
// MSC64: define dso_local doub
Author: rtrieu
Date: Tue Oct 30 19:10:51 2018
New Revision: 345691
URL: http://llvm.org/viewvc/llvm-project?rev=345691&view=rev
Log:
Revert r345676 due to test failure.
This was causing CodeGen/mingw-long-double.c to start failing.
Removed:
cfe/trunk/test/CodeGen/win64-i128.c
Modified:
c
Author: rtrieu
Date: Tue Oct 30 16:01:15 2018
New Revision: 345669
URL: http://llvm.org/viewvc/llvm-project?rev=345669&view=rev
Log:
Silence unused variable warnings. NFC
Modified:
cfe/trunk/lib/CodeGen/CGExprScalar.cpp
Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp
URL:
http://llvm.org/
Author: rtrieu
Date: Wed Oct 24 18:08:00 2018
New Revision: 345228
URL: http://llvm.org/viewvc/llvm-project?rev=345228&view=rev
Log:
[Sema] Fix -Wcomma for C89
There is a small difference in the scope flags for C89 versus the other C/C++
dialects. This change ensures that the -Wcomma warning won
Author: rtrieu
Date: Tue Oct 23 19:07:41 2018
New Revision: 345111
URL: http://llvm.org/viewvc/llvm-project?rev=345111&view=rev
Log:
[Sema] Fix -Wcomma in dependent context
When there is a dependent type inside a cast, the CastKind becomes CK_Dependent
instead of CK_ToVoid. This fix will check t
Author: rtrieu
Date: Mon Oct 22 18:26:28 2018
New Revision: 344987
URL: http://llvm.org/viewvc/llvm-project?rev=344987&view=rev
Log:
[CodeGen] Attach InlineHint to more functions
For instantiated functions, search the template pattern to see if it marked
inline to determine if InlineHint attribut
Author: rtrieu
Date: Fri Oct 19 19:15:58 2018
New Revision: 344828
URL: http://llvm.org/viewvc/llvm-project?rev=344828&view=rev
Log:
Make -Wfor-loop-analysis work with C++17
For now, disable the "variable in loop condition not modified" warning to not
be emitted when there is a structured binding
Author: rtrieu
Date: Fri Sep 21 18:50:52 2018
New Revision: 342794
URL: http://llvm.org/viewvc/llvm-project?rev=342794&view=rev
Log:
Update smart pointer detection for thread safety analysis.
Objects are determined to be smart pointers if they have both a star and arrow
operator. Some implementa
Author: rtrieu
Date: Fri Sep 21 14:20:33 2018
New Revision: 342774
URL: http://llvm.org/viewvc/llvm-project?rev=342774&view=rev
Log:
Make compare function in r342648 have strict weak ordering.
Comparison functions used in sorting algorithms need to have strict weak
ordering. Remove the assert an
Author: rtrieu
Date: Thu Sep 13 18:15:28 2018
New Revision: 342199
URL: http://llvm.org/viewvc/llvm-project?rev=342199&view=rev
Log:
[ODRHash] Fix early exit that skipped code.
There is a bit of code at the end of AddDeclaration that should be run on
every exit of the function. However, there wa
Author: rtrieu
Date: Wed Sep 5 15:14:46 2018
New Revision: 341498
URL: http://llvm.org/viewvc/llvm-project?rev=341498&view=rev
Log:
Remove unnecessary options from test RUN lines.
These tests do not check the color printing, so color options should not
be used when running them.
Modified:
c
LLVM :: CodeGen/AMDGPU/mubuf-legalize-operands.mir
>
> Please have a look?
> The builder was already red and did not send notifications on this.
>
> Thanks
>
> Galina
>
> On Tue, Sep 4, 2018 at 3:54 PM Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wr
Author: rtrieu
Date: Wed Sep 5 14:55:09 2018
New Revision: 341496
URL: http://llvm.org/viewvc/llvm-project?rev=341496&view=rev
Log:
Add triple to test case.
This test uses enums, which have different behavior when targeting different
systems. Specifying a triple will give predictable behavior t
Author: rtrieu
Date: Tue Sep 4 15:53:19 2018
New Revision: 341421
URL: http://llvm.org/viewvc/llvm-project?rev=341421&view=rev
Log:
[ODRHash] Extend hash to support all Type's.
Added:
cfe/trunk/test/Modules/odr_hash-gnu.cpp
cfe/trunk/test/Modules/odr_hash-vector.cpp
cfe/trunk/test/Mo
Author: rtrieu
Date: Wed Aug 29 18:57:52 2018
New Revision: 341013
URL: http://llvm.org/viewvc/llvm-project?rev=341013&view=rev
Log:
Ensure canonical type is actually canonical.
ASTContext::applyObjCProtocolQualifiers will return a canonical type when given
a canonical type and an array of canoni
Author: rtrieu
Date: Tue Aug 21 15:55:26 2018
New Revision: 340357
URL: http://llvm.org/viewvc/llvm-project?rev=340357&view=rev
Log:
Add space to TemplateArgument dump
Add a missing space when dumping a template argument which is a template
expansion. Found during debugging so no test.
Modified
Author: rtrieu
Date: Thu Aug 9 18:30:10 2018
New Revision: 339409
URL: http://llvm.org/viewvc/llvm-project?rev=339409&view=rev
Log:
Fix size calculation from r339380
r339380 changed the trailing types of ParsedAttr to use llvm::TrailingObjects.
However, it did not copy over one of the size attri
Author: rtrieu
Date: Wed Jul 25 15:52:05 2018
New Revision: 337978
URL: http://llvm.org/viewvc/llvm-project?rev=337978&view=rev
Log:
[ODRHash] Support hashing enums.
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/trunk/include/clang/AST/ODRHash.h
cfe/trunk/include/clang/Basic/Diagno
Author: rtrieu
Date: Mon Jul 9 18:40:50 2018
New Revision: 336632
URL: http://llvm.org/viewvc/llvm-project?rev=336632&view=rev
Log:
[ODRHash] Merge the two function hashes into one.
Functions that are a sub-Decl of a record were hashed differently than other
functions. This change keeps the Add
Author: rtrieu
Date: Mon Jul 9 15:09:33 2018
New Revision: 336610
URL: http://llvm.org/viewvc/llvm-project?rev=336610&view=rev
Log:
Rename function calls missed in r336605
NextIsLatest -> isFirst
Modified:
cfe/trunk/include/clang/AST/Decl.h
Modified: cfe/trunk/include/clang/AST/Decl.h
URL:
Author: rtrieu
Date: Fri Jul 6 17:17:25 2018
New Revision: 336475
URL: http://llvm.org/viewvc/llvm-project?rev=336475&view=rev
Log:
Check returned type is valid before using it.
Add a .isNull() check to returned QualType. Fixes PR38077
Modified:
cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp
Author: rtrieu
Date: Wed Jun 6 20:20:30 2018
New Revision: 334160
URL: http://llvm.org/viewvc/llvm-project?rev=334160&view=rev
Log:
Change return value of trivial visibility check.
Previous, if no Decl's were checked, visibility was set to false. Switch it
so that in cases of no Decl's, return
Author: rtrieu
Date: Wed Jun 6 17:20:58 2018
New Revision: 334151
URL: http://llvm.org/viewvc/llvm-project?rev=334151&view=rev
Log:
[ODRHash] Adjust info stored for FunctionTemplateDecl.
Avoid storing information for definitions since those can be out-of-line and
vary between modules even when t
Author: rtrieu
Date: Tue May 29 18:12:26 2018
New Revision: 333486
URL: http://llvm.org/viewvc/llvm-project?rev=333486&view=rev
Log:
[ODRHash] Support FunctionTemplateDecl in records.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
Author: rtrieu
Date: Tue May 29 15:43:00 2018
New Revision: 333471
URL: http://llvm.org/viewvc/llvm-project?rev=333471&view=rev
Log:
Check pointer null-ness before dereferencing it.
-Warc-repeated-use-of-weak may trigger a segmentation fault when the Decl
being checked is outside of a function sc
Author: rtrieu
Date: Mon May 14 16:21:48 2018
New Revision: 332310
URL: http://llvm.org/viewvc/llvm-project?rev=332310&view=rev
Log:
Enable control flow pruning of float overflow warnings.
Like other conversion warnings, allow float overflow warnings to be disabled
in known dead paths of template
Author: rtrieu
Date: Mon May 7 17:29:21 2018
New Revision: 331706
URL: http://llvm.org/viewvc/llvm-project?rev=331706&view=rev
Log:
Move test input file into same directory as test. NFC
Added:
cfe/trunk/test/Frontend/Inputs/resource_dir_with_cfi_blacklist/
cfe/trunk/test/Frontend/Inputs
Author: rtrieu
Date: Wed Apr 25 16:50:55 2018
New Revision: 330887
URL: http://llvm.org/viewvc/llvm-project?rev=330887&view=rev
Log:
Switch to Clang's isDigit function.
std::isdigit can be overloaded, causing the template deduction to fail. Use
Clang's isDigit function which to avoid this. Swit
Author: rtrieu
Date: Tue Apr 24 17:31:15 2018
New Revision: 330789
URL: http://llvm.org/viewvc/llvm-project?rev=330789&view=rev
Log:
[ODRHash] Hash template arguments of methods.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
cfe/
Author: rtrieu
Date: Fri Apr 13 15:34:43 2018
New Revision: 330074
URL: http://llvm.org/viewvc/llvm-project?rev=330074&view=rev
Log:
[ODRHash] Support pointer and reference types.
Recommit r328404 which was reverted in rL328404. r329869 fixed the issue that
caused the revert.
Modified:
cfe/
Author: rtrieu
Date: Wed Apr 11 19:26:49 2018
New Revision: 329869
URL: http://llvm.org/viewvc/llvm-project?rev=329869&view=rev
Log:
[ODRHash] Skip more types hashing TypedefType
To get the underlying type for TypedefType's, also skip ElaboratedType's.
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
Author: rtrieu
Date: Wed Mar 28 22:14:17 2018
New Revision: 328763
URL: http://llvm.org/viewvc/llvm-project?rev=328763&view=rev
Log:
Refactor some code for a warning. NFC.
Use range-based for-loops instead of iterators to walk over vectors.
Switch the key of the DenseMap so a custom key handler
Author: rtrieu
Date: Tue Mar 27 21:16:13 2018
New Revision: 328688
URL: http://llvm.org/viewvc/llvm-project?rev=328688&view=rev
Log:
Fix some handling of AST nodes with diagnostics.
The diagnostic system for Clang can already handle many AST nodes. Instead
of converting them to strings first, ju
Author: rtrieu
Date: Fri Mar 23 17:52:44 2018
New Revision: 328404
URL: http://llvm.org/viewvc/llvm-project?rev=328404&view=rev
Log:
[ODRHash] Support pointer and reference types.
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/lib/AST/ODRH
Author: rtrieu
Date: Wed Mar 14 20:00:55 2018
New Revision: 327598
URL: http://llvm.org/viewvc/llvm-project?rev=327598&view=rev
Log:
Refactoring code around move/copy initialization. NFC.
Use an enum parameter instead of a bool for more control on how the copy elision
functions work. Extract th
Author: rtrieu
Date: Wed Mar 14 17:09:26 2018
New Revision: 327593
URL: http://llvm.org/viewvc/llvm-project?rev=327593&view=rev
Log:
[CFG] Allow CallExpr's to be looked up in CFG's
r327343 changed the handling for CallExpr in a CFG, which prevented lookups for
CallExpr while other Stmt kinds stil
adds
> > a null check to prevent a crash on invalid.
> >
> > Richard
> >
> > On Mon, Feb 5, 2018 at 6:58 PM, Richard Trieu via cfe-commits
> > wrote:
> >>
> >> Author: rtrieu
> >> Date: Mon Feb 5 18:58:21 2018
> >> New Rev
Author: rtrieu
Date: Wed Feb 21 21:50:29 2018
New Revision: 325742
URL: http://llvm.org/viewvc/llvm-project?rev=325742&view=rev
Log:
[ODRHash] Fix hashing for friend functions.
When hashing a templated function, use the hash of the function it was
instantiated from.
Added:
cfe/trunk/test/Mod
Author: rtrieu
Date: Wed Feb 21 21:32:25 2018
New Revision: 325741
URL: http://llvm.org/viewvc/llvm-project?rev=325741&view=rev
Log:
[ODRHash] Handle some template weirdness.
Build the index off of DeclarationName instead of Decl pointers. When finding
an UnresolvedLookupExprClass, hash it as if
Hi Hans,
If there's still time for rc3, I'd like to get this crash fix in. This
adds a null check to prevent a crash on invalid.
Richard
On Mon, Feb 5, 2018 at 6:58 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Mon Feb
Author: rtrieu
Date: Tue Feb 13 11:53:40 2018
New Revision: 325040
URL: http://llvm.org/viewvc/llvm-project?rev=325040&view=rev
Log:
Update StmtProfile.cpp to handle zero template arguments.
Treat having no templates arguments differently than having zero template
arguments when profiling.
Modif
Author: rtrieu
Date: Mon Feb 5 18:58:21 2018
New Revision: 324308
URL: http://llvm.org/viewvc/llvm-project?rev=324308&view=rev
Log:
Fix crash on invalid.
Don't call a method when the pointer is null.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/test/SemaCXX/lambda-expressions.cpp
Thanks, Eric.
On Wed, Jan 24, 2018 at 3:11 PM, Eric Fiselier wrote:
> Sorry for the breakage. Fixed in r323389.
>
> On Wed, Jan 24, 2018 at 4:08 PM, Eric Fiselier wrote:
>
>> Looking.
>>
>> On Wed, Jan 24, 2018 at 3:52 PM, Richard Trieu wrote:
>>
>>> Hi Eric,
>>>
>>> I am getting a build failu
Hi Eric,
I am getting a build failure after this revision:
llvm/projects/libcxx/include/tuple:175:27: error: no return statement in
constexpr function
static constexpr bool __can_bind_reference() {
^
1 error generated.
It looks like if the #if in __can_bind_referenc
Author: rtrieu
Date: Tue Jan 23 13:58:56 2018
New Revision: 323267
URL: http://llvm.org/viewvc/llvm-project?rev=323267&view=rev
Log:
Fix test Driver/solaris-ld.c
Allow test to accept calls to ld without full path.
Modified:
cfe/trunk/test/Driver/solaris-ld.c
Modified: cfe/trunk/test/Driver/
Hans,
I recommend merging this revision into the release. It fixes an assertion
error when mixing modules and blocks.
Richard
On Fri, Jan 19, 2018 at 12:46 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Fri Jan 19 12:46:19 2018
&g
Hans,
I recommend merging this revision into the release. It fixes an infinite
loop in Scope::dump()
Richard
On Wed, Jan 17, 2018 at 8:28 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Wed Jan 17 20:28:56 2018
> New Revision:
Author: rtrieu
Date: Fri Jan 19 12:46:19 2018
New Revision: 322984
URL: http://llvm.org/viewvc/llvm-project?rev=322984&view=rev
Log:
Allow BlockDecl in CXXRecord scope to have no access specifier.
Using a BlockDecl in a default member initializer causes it to be attached to
CXXMethodDecl without
Author: rtrieu
Date: Wed Jan 17 20:28:56 2018
New Revision: 322813
URL: http://llvm.org/viewvc/llvm-project?rev=322813&view=rev
Log:
Fix Scope::dump()
The dump function for Scope only has 20 out of the 24 flags. Since it looped
until no flags were left, having an unknown flag lead to an infinite
URA Takumi
wrote:
> If r322350 is temporary fix, I suggest r321395 may be reverted in
> release_60. Richard, how do you think?
>
> On Wed, Jan 17, 2018 at 4:27 AM Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> There was a different, possib
y this test isn't supported on
> windows?
>
> On Fri, Jan 12, 2018 at 1:50 PM Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rtrieu
>> Date: Fri Jan 12 13:49:20 2018
>> New Revision: 322405
>>
>> URL:
Author: rtrieu
Date: Tue Jan 16 11:53:06 2018
New Revision: 322593
URL: http://llvm.org/viewvc/llvm-project?rev=322593&view=rev
Log:
Add context to why test was disabled on Windows
test/Modules/odr_hash-Friend.cpp triggers an assertion in MicrosoftMangle.cpp
This has been reported in PR35939
Mo
ons with definitions
> inline and the friend declaration site - doesn't a similar issue occur with
> member functions of templates that are not instantiated in some (similar)
> contexts?
>
> Is there a common solution that could be used for both cases?
>
>
> On Thu, Jan 11,
Author: rtrieu
Date: Fri Jan 12 15:13:33 2018
New Revision: 322420
URL: http://llvm.org/viewvc/llvm-project?rev=322420&view=rev
Log:
Try to suppress Windows testing again.
Modified:
cfe/trunk/test/Modules/odr_hash-Friend.cpp
Modified: cfe/trunk/test/Modules/odr_hash-Friend.cpp
URL:
http://l
Author: rtrieu
Date: Fri Jan 12 13:49:20 2018
New Revision: 322405
URL: http://llvm.org/viewvc/llvm-project?rev=322405&view=rev
Log:
Disable test for Windows to fix Windows buildbots.
Modified:
cfe/trunk/test/Modules/odr_hash-Friend.cpp
Modified: cfe/trunk/test/Modules/odr_hash-Friend.cpp
UR
issue as well.
>
> Please let me know if there is anything I can do to get this fixed quickly.
>
> /Eric
>
> On Wed, Jan 3, 2018 at 5:20 PM, Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Vedant,
>>
>> I'm looking in
Author: rtrieu
Date: Thu Jan 11 20:42:27 2018
New Revision: 322350
URL: http://llvm.org/viewvc/llvm-project?rev=322350&view=rev
Log:
[ODRHash] Don't hash friend functions.
In certain combinations of templated classes and friend functions, the body
of friend functions does not get propagated along
Author: rtrieu
Date: Fri Jan 5 19:20:59 2018
New Revision: 321924
URL: http://llvm.org/viewvc/llvm-project?rev=321924&view=rev
Log:
Test case for r321396
Any hashing for methods should be able to compile this test case without
emitting an error. Since the class and method come from the same hea
> 2 errors generated.
>
> I'm not sure how to act on this, because it looks like the error is saying
> that a definition in 'std.list' is incompatible with itself.
>
> I've temporarily disabled building with modules enabled on the bot. Could
> you take a look?
&g
Author: rtrieu
Date: Fri Dec 22 17:35:32 2017
New Revision: 321396
URL: http://llvm.org/viewvc/llvm-project?rev=321396&view=rev
Log:
[ODRHash] Disable hashing on methods.
Turn off hashing for class methods, but leave it on for other functions. This
should get the buildbot to green for the time b
Author: rtrieu
Date: Fri Dec 22 16:41:01 2017
New Revision: 321395
URL: http://llvm.org/viewvc/llvm-project?rev=321395&view=rev
Log:
[ODRHash] Support ODR violation detection in functions.
Extend the hashing to functions, which allows detection of function definition
mismatches across modules. T
Author: rtrieu
Date: Thu Dec 21 14:38:29 2017
New Revision: 321319
URL: http://llvm.org/viewvc/llvm-project?rev=321319&view=rev
Log:
[ODRHash] Canonicalize Decl's before processing.
Canonicalizing the Decl before processing it as part of the hash should reduce
issues with non-canonical types show
Author: rtrieu
Date: Fri Dec 8 19:02:21 2017
New Revision: 320239
URL: http://llvm.org/viewvc/llvm-project?rev=320239&view=rev
Log:
Revert r320230 to fix buildbots.
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/trunk/include/clang/AST/ODRHash.h
cfe/trunk/include/clang/Basic/Diagno
Author: rtrieu
Date: Fri Dec 8 17:29:40 2017
New Revision: 320230
URL: http://llvm.org/viewvc/llvm-project?rev=320230&view=rev
Log:
[ODRHash] Support ODR violation detection in functions.
Extend the hashing to functions, which allows detection of function definition
mismatches across modules.
M
1 - 100 of 298 matches
Mail list logo
