[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

2019-07-15 Thread Robbie Gibson via Phabricator via cfe-commits
rkgibson2 added a comment. I don't think I have commit access. Could someone land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 ___ cfe-commits

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

2019-07-15 Thread Robbie Gibson via Phabricator via cfe-commits
rkgibson2 updated this revision to Diff 209777. rkgibson2 added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

2019-07-12 Thread Robbie Gibson via Phabricator via cfe-commits
rkgibson2 updated this revision to Diff 209504. rkgibson2 added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

2019-07-12 Thread Robbie Gibson via Phabricator via cfe-commits
rkgibson2 updated this revision to Diff 209496. rkgibson2 added a comment. Respond to comments and change detection method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 Files:

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

2019-07-12 Thread Robbie Gibson via Phabricator via cfe-commits
rkgibson2 marked an inline comment as done. rkgibson2 added a comment. In D64632#1582793 , @benhamilton wrote: > Thanks for the fix. One question: how does the real Clang parser deal with > this case? Is it something that's actually ambiguous in the

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

2019-07-12 Thread Robbie Gibson via Phabricator via cfe-commits
rkgibson2 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64632 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index: