[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot added a comment. I've pushed some WIP change to inform that I'm still working on this topic :) Not sure if I also need to submit a comment to publish what I've marked as "done" via checkboxes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot updated this revision to Diff 556283. robot marked 3 inline comments as done. robot added a comment. Herald added a project: clang. WIP - several improvements I thought it might be a good idea to give an update even though this is still work in progress. - Don't print `virtual` for added d

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot added a comment. > so you could replace the logic that prints the return type + arg list with > `printType(functype, class, methodname)` (from AST.h). That should pick up > noexcept etc. I've tried it and it's not obvious to me how to do it properly: Since `printType` wants to print the

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot marked an inline comment as done. robot added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DeclarePureVirtuals.cpp:58 + + const llvm::ArrayRef Tokens = + TokBuf.expandedTokens(MethodDeclRange); sammccall wrote: > robot wrote:

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot planned changes to this revision. robot marked 3 inline comments as done. robot added a comment. I'm working on the comments, but it will take a while. Comment at: clang-tools-extra/clangd/refactor/tweaks/DeclarePureVirtuals.cpp:58 + + const llvm::ArrayRef Tokens = +

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot updated this revision to Diff 532575. robot added a comment. Remove left-over test file of other ptch from CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153152/new/ https://reviews.llvm.org/D153152 Files: clang-tools-extra/c

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot updated this revision to Diff 532199. robot added a comment. Remove left-over file of other patch from CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153152/new/ https://reviews.llvm.org/D153152 Files: clang-tools-extra/clang

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot added a comment. This change is not done, I need some advice: - I don't understand why there are two levels of data structures in an entry of the final overriders map, hence I can't properly name the variables nor do I fully understand what I'm doing there. - It's not clear if the tweak s

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot created this revision. robot added a reviewer: sammccall. Herald added subscribers: ChuanqiXu, kadircet, arphaman. Herald added a project: All. robot requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This tweak searches the

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot added inline comments. Comment at: test/asan/TestCases/intercept-rethrow-exception.cc:48 + // memcpy is intercepted by asan which performs checks on src and dst + using T = int[1000]; + T x {}; vitalybuka wrote: > You can include #include > and use __as

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot marked an inline comment as done. robot added a comment. Have you had the time to review the second revision? Repository: rCRT Compiler Runtime https://reviews.llvm.org/D42644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot updated this revision to Diff 132990. robot added a comment. - Reformatted using clang-format - Fixed copy&waste error CHECK(REAL(__cxa_throw)) - moved test from asan unit test to lit tests Repository: rCRT Compiler Runtime https://reviews.llvm.org/D42644 Files: lib/asan/asan_interce

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot added a comment. In https://reviews.llvm.org/D42644#993506, @kubamracek wrote: > Cool. Can we get a lit test as well? This is our first patch so we're unfamiliar with the LLVM testing infrastructure. Could you please tell us what kind of test you'd like? An example would also be great.

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot created this revision. robot added a reviewer: cryptoad. robot added a project: Sanitizers. Herald added subscribers: Sanitizers, llvm-commits, hintonda, mgorny, kubamracek. Fixes Bug 32434 See https://bugs.llvm.org/show_bug.cgi?id=32434 Short summary: std::rethrow_exception does not use _