[PATCH] D84375: [git-clang-format] Add --diffstat parameter

2021-10-14 Thread Roland via Phabricator via cfe-commits
roligugus added a comment. @MyDeveloperDay Thanks for the follow-up! I've rebased on latest main. Out of curiosity, as I am trying to wrap my head around the llvm workflow: Could I `arc land ...` myself once you sign off with "ready to land" even if I don't have llvm commit rights? If so, pleas

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

2021-10-14 Thread Roland via Phabricator via cfe-commits
roligugus updated this revision to Diff 379892. roligugus added a comment. [git-clang-format] Rebase D84375 on latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84375/new/ https://reviews.llvm.org/D84375

[PATCH] D111853: [NFC][Interpreter] Remove unused CompilerInvocation

2021-10-14 Thread Roland via Phabricator via cfe-commits
roligugus created this revision. roligugus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111853 Files: clang/lib/Interpreter/Interpreter.cpp Index: clang/lib/Interprete

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

2021-04-29 Thread Roland via Phabricator via cfe-commits
roligugus requested review of this revision. roligugus added a comment. @JakeMerdichAMD, @MyDeveloperDay Sorry to bother with a re-review. Did not know how to ask this. Jake accepted this patch last August and it has been sitting in "ready to land" since then. I was assuming that it'll automatic

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

2020-07-22 Thread Roland via Phabricator via cfe-commits
roligugus added a project: clang-format. roligugus marked an inline comment as done. roligugus added inline comments. Comment at: clang/tools/clang-format/git-clang-format:101 help='print a diff instead of applying the changes') + p.add_argument('--diffstat', a

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

2020-07-22 Thread Roland via Phabricator via cfe-commits
roligugus created this revision. roligugus added reviewers: klimek, aheejin. Herald added a project: clang. Herald added a subscriber: cfe-commits. [git-clang-format][PR46815] Add diffstat functionality Adding a --diffstat parameter to git-clang-format that essentially uses git diff --stat, i.e.