[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

romanovvlad added a comment. In D104601#2917065 , @Meinersbur wrote: > Patch uploaded here: D107183 The patch resolves the issue. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

romanovvlad added a comment. Hi @Meinersbur, It seems the patch introduces one more regression. The following test doesn't pass on Windows: // RUN: %clang -E %s -o %t.ii // RUN: %clang %t.ii #include "string.h" int main() { return 0; } The following macro from vcruntime.h:

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad added a comment. @Anastasia Could you, please, merge the patch if it's OK with you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 ___ cfe-commits mailing list

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad marked an inline comment as done. romanovvlad added a comment. Could you merge it? I have no rights to do it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 ___ cfe-commits mailing list

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad updated this revision to Diff 177012. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 Files: lib/CodeGen/CGExpr.cpp test/CodeGenOpenCLCXX/address-space-deduction2.cl Index: test/CodeGenOpenCLCXX/address-space-deduction2.cl

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad added a comment. Backtrace: F7656050: stack CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad added a comment. Yes it's 1, but after addrspacecast alignment becomes not struct A but alignment of the pointer CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 ___ cfe-commits mailing

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad added a comment. I'm getting the same IR for both examples you provided. And for both load of X value is aligned on 4 bytes wo patch and on 1 byte with. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad updated this revision to Diff 176850. romanovvlad added a comment. Added new test case + formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 Files: lib/CodeGen/CGExpr.cpp test/CodeGenOpenCLCXX/address-space-deduction2.cl

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad added a comment. What bugs with unaligned pointers do you mean? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 ___ cfe-commits mailing list

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad created this revision. romanovvlad added reviewers: rjmccall, yaxunl, Anastasia. Herald added a subscriber: kosarev. When addresspacecast is generated resulting pointer should preserve TBAA information from original value. Repository: rC Clang https://reviews.llvm.org/D55262

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

romanovvlad added inline comments. Comment at: cfe/trunk/lib/CodeGen/CGExpr.cpp:4268 +DestTy.getAddressSpace(), ConvertType(DestTy)); +return MakeNaturalAlignPointeeAddrLValue(V, DestTy); + } Hi, It seems this code doesn't work correctly(repro at