[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

This revision was automatically updated to reflect the committed changes. Closed by commit rGae451454e32d: Create a warning flag for warn_conv_*_not_used (authored by rdwampler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

rdwampler added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1965 // handle [[likely]] / [[unlikely]] - if (FormatTok->is(tok::l_square)) + if (FormatTok->is(tok::l_square) && tryToParseSimpleAttribute()) parseSquare(); From

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b53495c4ba2: Perform ActOnConversionDeclarator after looking for any virtual functions it… (authored by rdwampler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79856: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdwampler abandoned this revision. This allows for suppressing warnings about the conversion function never being called if it overrides a virtual function in a base class. Repository: rG

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler updated this revision to Diff 263466. rdwampler added a comment. Fixed indentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78444/new/ https://reviews.llvm.org/D78444 Files: clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler updated this revision to Diff 263202. rdwampler added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78444/new/ https://reviews.llvm.org/D78444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler updated this revision to Diff 261731. rdwampler added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler updated this revision to Diff 258613. rdwampler added a comment. changed to check it overrides a virtual function in a base class and not just virtual. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78444/new/ https://reviews.llvm.org/D78444 Files:

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler created this revision. rdwampler added reviewers: saar.raz, aaron.ballman, doug.gregor, rsmith. rdwampler added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. This allows for suppressing warnings about the conversion function never being called if it overrides a

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler created this revision. rdwampler added a reviewer: rsmith. rdwampler added a project: clang. Herald added a subscriber: cfe-commits. These warnings are grouped under '-Wclass-conversion' to be compatiable with GCC 9. Repository: rG LLVM Github Monorepo

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

rdwampler added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1612 + Keywords.kw_final) || +isCpp11AttributeSpecifier(*Tok.Next)) return false; I think the issue r373922 was fixing is only related to the

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

rdwampler added a comment. In D64695#1605676 , @Manikishan wrote: > In D64695#1590948 , @Manikishan > wrote: > > > In D64695#1589818 , @lebedev.ri > > wrote: > > > > > In

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

rdwampler added a comment. Thanks! Can you update the documentation too? Comment at: lib/Tooling/Inclusions/HeaderIncludes.cpp:211 + Ret = 0; +} + return Ret; I think you can drop the else block and just return immediately from the for loop.

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

rdwampler added a comment. > Sorry, my mistake I meant that I have added Regex for priorities while > sorting and If I am not wrong I think IncludeCategories are used while > Regrouping after sorting the Includes. In addition to that in my case I have > to sort the includes In a particular

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

rdwampler added a comment. I am not quite sure why this change is required to sort the headers for NetBSD, you can set the priorities via `IncludeStyle.IncludeCategories`. Is that not sufficient? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

This revision was automatically updated to reflect the committed changes. Closed by commit rL357027: [clang-format] Add style option AllowShortLambdasOnASingleLine (authored by rdwampler, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

rdwampler added inline comments. Comment at: clang/include/clang/Format/Format.h:264 +/// If Else statements have no braces don't put them +/// on the same line. +/// \code These comments can be used to auto generate the corresponding sections in

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler added a comment. I don't have commit rights, can someone land this for me or would it be better to try and get commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 ___

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler updated this revision to Diff 191872. rdwampler added a comment. Rebased on master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2976 + +return Style.AllowShortLambdasOnASingleLine == FormatStyle::SLS_None || + Style.AllowShortLambdasOnASingleLine == FormatStyle::SLS_Inline || klimek wrote: > If

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler updated this revision to Diff 191629. rdwampler marked 2 inline comments as done. rdwampler added a comment. Changes since last revision: -rebased -Fall through when SLS_All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 Files:

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

rdwampler added a comment. Ping? Can somebody commit this for me? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186 ___ cfe-commits mailing list

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler marked an inline comment as done. rdwampler added inline comments. Comment at: clang/lib/Format/Format.cpp:649 LLVMStyle.AllowShortIfStatementsOnASingleLine = false; + LLVMStyle.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All;

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

rdwampler added a comment. In D58186#1405687 , @sylvestre.ledru wrote: > Do you have permissions on the repo? No, I would need someone to commit this for me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

rdwampler added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler updated this revision to Diff 187260. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/FormatToken.h

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

rdwampler created this revision. rdwampler added reviewers: eugene, sylvestre.ledru, djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. These changes were corrected directly in ClangFormatStyleOptions.rst (llvm-svn: 350192 and llvm-svn: 351976) but these sections can

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler updated this revision to Diff 185848. rdwampler added a comment. Update to include an option `Inline` to only put short lambda on a single line if used as an argument. See the following code style guide from catboost:

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler created this revision. rdwampler added reviewers: djasper, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option `AllowShortLambdasOnASingleLine` similar to the other `AllowShort*` options, but applied to C++ lambdas. I considered making this

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler updated this revision to Diff 102150. rdwampler added a comment. I was able to build and test this on a linux box. The issue was the whitespace surrounding the regex. On Linux, `(unavailable)` is not present. I.e, `FunctionDecl=foo:3:6 (ios, introduced=3.2, deprecated=4.1) (macos,

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler added a comment. Alex, I will look into it. Thanks! Repository: rL LLVM https://reviews.llvm.org/D33478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler marked 2 inline comments as done. rdwampler added a comment. I don't have commit access, but I would grateful if you can commit it. https://reviews.llvm.org/D33478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler updated this revision to Diff 102050. rdwampler added a comment. Remove an unnecessary check when determining a mismatch of availabilities Simplify invocation of FileCheck in availability.c https://reviews.llvm.org/D33478 Files: test/Index/availability.c tools/libclang/CIndex.cpp

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler marked an inline comment as done. rdwampler added inline comments. Comment at: test/Index/availability.c:20 // CHECK-2: (macos, introduced=10.4, deprecated=10.5, obsoleted=10.7) // CHECK-2: EnumConstantDecl=old_enum:6:3 (Definition) (deprecated)

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler updated this revision to Diff 101787. rdwampler marked 6 inline comments as done. rdwampler added a comment. This should resolve the bug (a conditional was inverted) in the last revision along with the other changes requested. https://reviews.llvm.org/D33478 Files:

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler updated this revision to Diff 101569. rdwampler added a comment. Rearrange `if` statements in `getCursorPlatformAvailabilityForDecl` to return early if we do not need to merge availability attributes. Use ranged for loop. https://reviews.llvm.org/D33478 Files:

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler added inline comments. Comment at: tools/libclang/CIndex.cpp:7322 + + for (int I = 0, E = AvailabilityAttrs.size(); I < E && I < availability_size; + ++I) { arphaman wrote: > You can use a ranged for loop here if you use `take_front`, e.g. > >