[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-code-object-version-linking.cu:12 +// RUN: llvm-link %t_0 %t_5 -o -| llvm-dis -o - | FileCheck -check-prefix=LINKED5 %s + +#include "Inputs/cuda.h" yaxunl wrote: > saiislam wrote: > > yaxu

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf616c3eeb43f: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5 (authored by saiislam). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 553991. saiislam marked 3 inline comments as done. saiislam added a comment. Minor fixes addressing reviewer's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D13973

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 553413. saiislam marked 2 inline comments as done. saiislam added a comment. Changed getImplicitArgsSize to use sizeof. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D13973

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:49 -static_assert(sizeof(AMDGPUImplicitArgsTy) == 56, - "Unexpected size of implicit arguments"); +enum IMPLICITAR

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8649-8650 + // code-object-version=X needs to be passed to clang-linker-wrapper to ensure + // that it is used by lld. + if (const Arg *A = Args.getLastArg(options::OPT_mcode_object_version_EQ)

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 553179. saiislam marked 7 inline comments as done. saiislam added a comment. Updated test case to check internalization of newly inserted global variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/ne

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 552344. saiislam marked 5 inline comments as done. saiislam added a comment. Used CreateConstInBoundsGEP1_32 for emitting GEP statements. Changed lambda function to simple fucntion body for defining the global variable. Repository: rG LLVM Github Monorep

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 552085. saiislam marked an inline comment as done. saiislam added a comment. Adressed reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D139730 Files: c

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam marked 4 inline comments as done. saiislam added inline comments. Comment at: clang/lib/CodeGen/Targets/AMDGPU.cpp:383 +CGM.getTarget().getTargetOpts().CodeObjectVersion, /*Size=*/32, +llvm::GlobalValue::WeakODRLinkage); +} yaxunl

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added a comment. In D139730#4597504 , @jhuber6 wrote: > Some nits. I'm assuming we're getting the code object in the backend now? > We'll need to make sure that `-Wl,--amdhsa-code-object-version` is passed to > the clang invocation inside of th

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 551597. saiislam marked 4 inline comments as done. saiislam added a comment. Changed ImplitArgs implementation using struct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17143-17145 + llvm::LoadInst *LD; + Constant *Offset, *Offset1; + Value *DP, *DP1; arsenm wrote: > Move down to define and initialize There are multiple uses of the same identifier. De

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 551266. saiislam marked 6 inline comments as done. saiislam added a comment. Updated the patch as per reviewers comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D139

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

saiislam added a comment. In D156928#4565506 , @jhuber6 wrote: > In D156928#4562239 , > @JonChesterfield wrote: > >> Or, the front end could define those objects directly, without importing IR >> files that defi

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added a comment. In D139730#4561622 , @arsenm wrote: > In D139730#4561619 , @arsenm wrote: > >> In D139730#4561575 , @jhuber6 >> wrote: >> >>> In D139730#4561573

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 547751. saiislam marked 5 inline comments as done. saiislam added a comment. Removed unused cov5 implicitargs fields. Added comments about EmitAMDGPUWorkGroupSize and ABI-agnostica code emission. Adressed reviewers' comments. Repository: rG LLVM Github Mo

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 547297. saiislam added a comment. Another attempt at cov5 support by using CodeGen for buitlin_amdgpu_workgroup_size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D139730

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

saiislam marked 2 inline comments as done. saiislam added a comment. In D156928#4555121 , @yaxunl wrote: > `-mcode-object-version=none` was intentionally designed to work with `clang > -cc1` only, since it does not work with clang driver if users link wi

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

saiislam created this revision. saiislam added reviewers: jhuber6, yaxunl. Herald added subscribers: tpr, dstuttard, kzhuravl. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald added a project: clang. -mcode-object

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

saiislam added a comment. @jdoerfert @RaviNarayanaswamy @ABataev Are there any features in this table which have been already implemented but have not been tagged? https://clang.llvm.org/docs/OpenMPSupport.html#openmp-5-1-implementation-details Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

saiislam accepted this revision. saiislam added a comment. Thank you @animeshk-amd! LGTM! As discussed in the multi-company OpenMP LLVM meeting, this is the right time to upgrade the default OpenMP spec version to 5.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8475 "triple=" + TC->getTripleString(), -"arch=" + Arch.str(), +"arch=" + getProcessorFromTargetID(TC->getTriple(), Arch).str(), "kind=" + Kind.str(), -

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8465-8470 +if (TC->getTriple().isAMDGPU()) { + for (StringRef Feature : llvm::split(Arch.split(':').second, ':')) { +FeatureArgs.emplace_back( +Args.MakeArgString(Featur

[PATCH] D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7116 if (Triple.isAMDGPU()) { -handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs); +handleAMDGPUCodeObjectVersionOptions(D, C.getArgs(), Cmd

[PATCH] D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP

saiislam updated this revision to Diff 490204. saiislam added a comment. Removed the unnecessary call to getArgs() and added test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142022/new/ https://reviews.llvm.org/D142022 Files: clang/lib/

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7085 if (Triple.isAMDGPU()) { -handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs); +handleAMDGPUCodeObjectVersionOptions(D, C.getArgs(), Cmd

[PATCH] D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP

saiislam created this revision. saiislam added reviewers: jhuber6, yaxunl. Herald added subscribers: kosarev, kerbowa, guansong, tpr, jvesely. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a reviewer:

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Mapping.cpp:50 -uint32_t getNumHardwareThreadsInBlock() { - return __builtin_amdgcn_workgroup_size_x(); -} +uint32_t getNumHardwareThreadsInBlock() { return external_get_local_size(0); } --

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added a comment. Thanks everyone for your review and comments! I am going to address all of them in a series of smaller patches starting with D140784 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam created this revision. saiislam added reviewers: jdoerfert, JonChesterfield, jhuber6, yaxunl. Herald added subscribers: kosarev, kerbowa, guansong, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: openmp-

[PATCH] D134974: [OpenMP] Add map clause to the LIT test on use_device_addr clause

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134974/new/ https://reviews.llvm.org/D134974 __

[PATCH] D135724: [HIP] Fix unbundling archive

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. Thank you! It is fixing our OpenMP smoke test failure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135724/new/ https://reviews.llvm.org/D135724

[PATCH] D134546: [clang-offload-bundler] extracting compatible bundle entry

saiislam added a comment. The patch looks fine to me. Please wait for @tra 's final review. On a different note, can this compatibility testing logic be moved to a llvm library instead of clang's? I want to use it in OpenMP's AMDGPU plugin, which now links llvm libraries by default.

[PATCH] D132643: [OpenMP] Extend lit test for parallel for simd construct

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. LGTM. Thank! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132643/new/ https://reviews.llvm.org/D132643 ___

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cecc6e8e27c: [OpenMP] Add lit test for metadirective device arch inspired (authored by animeshk-amd, committed by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131763/new/ https://reviews.llvm.org/D131763 __

[PATCH] D132607: [OffloadPackager] Add ability to extract images from other file types

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132607/new/ https://reviews.llvm.org/D132607 __

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

saiislam added a comment. In D131763#3719323 , @jdoerfert wrote: > In D131763#3719140 , @saiislam > wrote: > >> In D131763#3719132 , @jdoerfert >> wrote: >> >>> This doe

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

saiislam added a comment. In D131763#3719132 , @jdoerfert wrote: > This doesn't actually test much, only once case/compilation is covered. In > the second function nothing specific to LLVM as impl is checked. The second function, is the only place in ll

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

saiislam accepted this revision. saiislam added a comment. Thanks, LGTM! In the multi-company OpenMP meeting, it was decided to defer this update. So, please don't land this patch yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129635/new/ http

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

saiislam added a comment. In D128090#3648210 , @jhuber6 wrote: > Sorry never noticed this revision. The purpose of this patch seems to be > supporting something like this > > clang input.c -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 > -m

[PATCH] D127304: [LinkerWrapper] Embed OffloadBinaries for OpenMP offloading images

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127304/new/ https://reviews.llvm.org/D127304 __

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

saiislam updated this revision to Diff 438004. saiislam added a comment. clang-formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128090/new/ https://reviews.llvm.org/D128090 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Dr

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

saiislam created this revision. saiislam added reviewers: jdoerfert, JonChesterfield, jhuber6, yaxunl. Herald added a subscriber: guansong. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clan

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam updated this revision to Diff 433401. saiislam added a comment. Added the multi-entry logic in libomptarget. Yet to move the image compatibility testing to plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124525/new/ https://reviews.

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam added a comment. Thanks for the detailed review. I will update rest of the patch soon. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:613-614 CmdArgs.push_back("-shared"); + std::string ArchArg = std::string("-plugin-opt=mcpu=").append(Arch.str

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam updated this revision to Diff 432352. saiislam marked 8 inline comments as done. saiislam added a comment. Addressed some simple review changes. Will update remaining in the next iteration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam updated this revision to Diff 431975. saiislam added a comment. Changed the embedding scheme to add ImageInfo field in __tgt_device_image. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124525/new/ https://reviews.llvm.org/D124525 Files:

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125050/new/ https://reviews.llvm.org/D125050 __

[PATCH] D125092: [OpenMP] Add basic support for properly handling static libraries

saiislam added a comment. > Ideally we could just put this on the linker itself, but nvlink doesn't seem > to support .a files. Yes, nvlink does not support archives. So we used a wrapper to extract cubin files from the archive and pass them to nvlink. Please see, Clang Nvlink Wrapper

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam added a comment. In D124525#3491170 , @jhuber6 wrote: > I'm suggesting instead we define a new `__tgt_device_image` and a new > `__tgt_register_lib` function to support this. This new `__tgt_device_image` > will simply contain a pointer to an o

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

saiislam added a comment. Looks good to me. Will it work with `-fno-openmp`? Sometimes `-fno-openmp` is used by the end-user to override system provided `-fopenmp` flag for some translation units. Please have a look at following examples: // RUN: %clang -### -target x86_64-linux-gnu \ // R

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

saiislam added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

saiislam added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

saiislam added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

saiislam added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam added a comment. In D124525#3478469 , @yaxunl wrote: > need a test for the generated registration code Yes, I will add tests. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1161 -LinkedImages.push_b

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam created this revision. saiislam added reviewers: jdoerfert, JonChesterfield, jhuber6, yaxunl. Herald added a subscriber: guansong. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects

[PATCH] D123387: [clang-offload-bundler] fix "no output file" issue with -outputs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6cbdee5761: [clang-offload-bundler] fix "no output file" issue with -outputs (authored by scchan, committed by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D123387: [clang-offload-bundler] fix "no output file" issue with -outputs

saiislam accepted this revision. saiislam added a comment. In D123387#3439069 , @yaxunl wrote: > Does this mean without this fix clang-offload-bundler emits an error if > -outputs option not given? How could the lit tests passed? I think lit tests were

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

saiislam added a comment. Hey @jhuber6 , as discussed in multi-company meeting, I think that we will need at least an arch field somewhere in this. We would like to create multi-arch binaries so that runtime can load the compatible one on its own. You may even consider using TargetID Format

[PATCH] D120697: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a02abf06ff9: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous… (authored by saiislam). Herald added a project: All. R

[PATCH] D120697: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library

saiislam created this revision. saiislam added reviewers: yaxunl, jdoerfert, JonChesterfield. Herald added a subscriber: guansong. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. `hip-openmp-compatible` flag treats hip and

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

saiislam added a comment. Will it be possible to use Bundle Entry ID format [1] for naming sections and being sort of the the primary key to refer an offload object? The arch string following the triple will be just offload-arch (or march, or mcpu) for others, but for amdgpu it may contain some

[PATCH] D119256: [OpenMP][Clang] Move partial support of reverse offload to a future version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4db88a54b6d4: [OpenMP][Clang] Move partial support of reverse offload to a future version (authored by saiislam). Repository: rG LLVM Github Monor

[PATCH] D119256: [OpenMP][Clang] Move partial support of reverse offload to a future version

saiislam created this revision. saiislam added reviewers: ABataev, jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. saiislam requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. OpenMP Spec 5.2

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae9c0740648f: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading (authored by saiislam). Repository: rG LLVM Github Monor

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

saiislam updated this revision to Diff 405591. saiislam marked an inline comment as done. saiislam added a comment. Restored device ancestor codegen unit test with requires reverese_offload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118887/new/

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

saiislam added inline comments. Comment at: clang/test/OpenMP/target_device_codegen.cpp:43-47 - // CHECK-NOT: call i32 @__tgt_target_mapper(%struct.ident_t* @{{.+}}, - // CHECK: call void @__omp_offloading_{{.+}}_l46() - // CHECK-NOT: call i32 @__tgt_target_mapper(%s

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

saiislam created this revision. saiislam added reviewers: ABataev, jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. OpenMP Spec 5.0 [2.12.5, Restrictio

[PATCH] D116544: [Clang] Introduce Clang Linker Wrapper Tool

saiislam added a comment. Can you please add this tool's doc in clang/docs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116544/new/ https://reviews.llvm.org/D116544 ___ cfe-commits mailing list cfe-com

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

saiislam added a comment. It seems that this patch along with D117156 and D117246 is giving `patch application failed` error [https://buildkite.com/llvm-project/diff-checks/builds/82688]. `arc patch` is also giving the same er

[PATCH] D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0731f6ba4f57: [Doc] Add documentation for the clang-offload-wrapper tool (NFC) (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117120/n

[PATCH] D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC)

saiislam added a comment. Ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117120/new/ https://reviews.llvm.org/D117120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC)

saiislam created this revision. saiislam added reviewers: sdmitriev, jdoerfert, grokos, JonChesterfield, carlo.bertolli, vzakhari. Herald added a subscriber: arphaman. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Add t

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG876b5ea96bf5: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective… (authored by saiislam). Repository: rG LLVM Github Mon

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 398897. saiislam added a comment. 1. Used a common diagnostic warning `warn_unknown_declare_variant_isa_trait` for ParseOpenMP and SemaOpenMP for decalre variant and metadirectives. 2. Split lit codegen tests into two files, one requiring amdgpu-registered

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +StringRef ISATrait) {}; +TargetOMPContext OMPCtx(ASTContext, std::move(DiagUnknownTrait

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 398614. saiislam added a comment. Fixed the lit test failing in pre-check build bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/ https://reviews.llvm.org/D116549 Files: clang/include/clang/Bas

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 398179. saiislam marked an inline comment as done. saiislam added a comment. Added diagnostic remarks for when ISA trait is not selected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/ https://revie

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 397912. saiislam added a comment. Herald added a subscriber: jvesely. Added target specific tests for ISA traits, for CPU as well as GPU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/ https://revie

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam added a comment. In D116549#3218281 , @jdoerfert wrote: > Can you make the test check for the diagnose message? Also, do we have a test > to verify an isa trait is properly handled? I don't see a point in adding a diagnostic message when a feat

[PATCH] D116540: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49f23afdc345: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam added a comment. In D111545#3218961 , @MyDeveloperDay wrote: > Nit: That is more correct, but actually, you normally make the comment match > the param name (I think there might even be a clang-tidy check for that?) > > i.e. > > /*isBitCodeSD

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32357266fd05: [Clang][NFC] Fix multiline comment prefixes in function headers (authored by saiislam). Changed prior to commit: https://reviews.llv

[PATCH] D116540: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP

saiislam added a comment. In D116540#3217689 , @jdoerfert wrote: > In D116540#3217684 , @saiislam > wrote: > >> 1. I don't know why "pgi" is present here as a vendor. Should it be renamed >> as nvidia instead? @

[PATCH] D116540: [OpenMP] Add nvidia as a compiler vendor for OpenMP

saiislam updated this revision to Diff 397108. saiislam added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. 1. Added nec as compiler vendor. 2. Fixed clang test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam created this revision. saiislam added reviewers: jdoerfert, alokmishra.besu, cchen, JonChesterfield. Herald added subscribers: guansong, yaxunl. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Passing any feature

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam updated this revision to Diff 397073. saiislam added a comment. Updated comments as per suggestion. Apologies for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111545/new/ https://reviews.llvm.org/D111545 Files: clang/lib/Dri

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:617 + // Find nvlink and pass it as "--nvlink-command=" argument of clang-nvlink-wrapper. + auto NvlinkBin = getToolChain().GetProgramPath("nvlink"); + const char *NvlinkPath = M

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rGf56548829c4c: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378979. saiislam added a comment. clang-format(ed). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/ https://reviews.llvm.org/D111488 Files: clang/lib/Driver/ToolChains/Cuda.cpp clang/tools/clang

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378978. saiislam marked 5 inline comments as done. saiislam added a comment. Thanks, Michael and Artem! 1. Changed nvlink-command to nvlink-path. 2. Answered queries and done refactoring as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam updated this revision to Diff 378957. saiislam added a comment. Used comment style for named parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111545/new/ https://reviews.llvm.org/D111545 Files: clang/lib/Driver/ToolChains/AMDGP

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:120 + /* bitcode SDL?*/ true, + /* PostClang Link? */ false); // Add an intermediate output file. -

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam created this revision. saiislam added a reviewer: MyDeveloperDay. Herald added subscribers: kerbowa, nhaehnle, jvesely. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Cleanup of D105191

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378633. saiislam added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/ https://reviews.llvm.org/D111488 Files: clang/lib/Driver/ToolChains/Cuda.cpp clang/tools/clang-nvlink

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378630. saiislam marked 4 inline comments as done. saiislam added a comment. 1. Changed the option from path to nvlink-command. 2. Command line arguments are now parsed using proper API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam created this revision. saiislam added reviewers: Meinersbur, ye-luo, JonChesterfield. saiislam requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Added support of a "--path=" option in clan

  1   2   3   >