sanwou01 added subscribers: dmgreen, sanwou01.
sanwou01 added a comment.
Hi, we've got a ~6% regression in SPEC INT 2006 462.libquantum on AArch64 (both
-flto and -Ofast) that comes back to this change. See here for a reproducer
https://godbolt.org/z/dq98Gqqxn (-fno-vectorize is not strictly
sanwou01 added a comment.
+1 on eagerly awaiting a fix. a 3% regression on astar (AArch64, LTO) bisects
to @lebedev.ri 's revert:
https://reviews.llvm.org/rG6270b3a1eafaba4279e021418c5a2c5a35abc002 .
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sanwou01 added a comment.
SPEC 2017 on AArch64 is neutral on the geomean. The only slight worry is
omnetpp with a 1% regression, but this is balanced by a .8% improvement on mcf.
Other changes are in the noise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sanwou01 added a comment.
I know this has already been reverted but just FYI that I've bisected a ~2%
regression in SPEC2017 x264_r on AArch64 to this commit. Presumably this is due
to the extra unrolling / cost modelling issue already mentioned?
Repository:
rG LLVM Github Monorepo
CHANGES
sanwou01 accepted this revision.
sanwou01 added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for fixing this! Could you wait a day or two before committing to
allow others to comment?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2939fc13c8f6: [AArch64] Add IR intrinsics for
sq(r)dmulh_lane(q) (authored by sanwou01).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71469/new/
sanwou01 updated this revision to Diff 240902.
sanwou01 retitled this revision from "[AArch64] Add sq(r)dmulh_lane(q) LLVM IR
intrinsics" to "[AArch64] Add IR intrinsics for sq(r)dmulh_lane(q)".
sanwou01 edited the summary of this revision.
sanwou01 added a comment.
Address Eli's feedback;
sanwou01 marked 2 inline comments as done.
sanwou01 added a comment.
Thanks Eli.
> The "trick" is something like the following?
> [...]
Yeah, that's exactly right. Your assessment of the options (dedicated pass,
"volatile") matches our thinking as well. I'll update the commit message to
make
This revision was automatically updated to reflect the committed changes.
Closed by commit rGecfd6d3e8418: [clang] Set function attributes on SEH filter
functions correctly. (authored by sanwou01).
Changed prior to commit:
https://reviews.llvm.org/D72786?vs=238431=238817#toc
Repository:
rG
sanwou01 added a comment.
ping?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71469/new/
https://reviews.llvm.org/D71469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sanwou01 updated this revision to Diff 238431.
sanwou01 added a comment.
Fix tests, thanks rnk
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72786/new/
https://reviews.llvm.org/D72786
Files:
clang/lib/CodeGen/CGException.cpp
sanwou01 created this revision.
sanwou01 added a reviewer: rnk.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When compiling with -munwind-tables, the SEH filter funclet needs the uwtable
function attribute, which gets automatically added if we use
sanwou01 created this revision.
Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, hiraditya,
kristof.beyls.
Herald added projects: clang, LLVM.
sanwou01 added reviewers: SjoerdMeijer, dmgreen, t.p.northover.
Currently, sqdmulh_lane and friends from the ACLE (implemented in
sanwou01 added a comment.
Thanks for your comments Reid. Please find my responses inline. I'll spin a new
patch addressing your comments soonish.
Comment at: include/clang/Basic/SourceLocation.h:336
+ bool hasManager() const { return SrcMgr != nullptr; }
/// \pre This
sanwou01 added a comment.
Hi Diana,
Thanks! Will do :)
Sanne
https://reviews.llvm.org/D31709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sanwou01 updated this revision to Diff 95549.
sanwou01 added a comment.
Don't include the changes from https://reviews.llvm.org/D31709 and
https://reviews.llvm.org/D32159 in this patch (oops).
https://reviews.llvm.org/D31501
Files:
include/clang/Basic/Diagnostic.h
sanwou01 updated this revision to Diff 95548.
sanwou01 added a comment.
Herald added subscribers: mgorny, klimek.
Rebase on top of https://reviews.llvm.org/D31709 and
https://reviews.llvm.org/D32159
https://reviews.llvm.org/D31501
Files:
include/clang/Basic/Diagnostic.h
sanwou01 created this revision.
Herald added subscribers: mgorny, klimek.
https://reviews.llvm.org/D32159
Files:
include/clang/Frontend/CompilerInvocation.h
include/clang/Frontend/DiagnosticOptions.h
lib/Frontend/CMakeLists.txt
lib/Frontend/CompilerInvocation.cpp
sanwou01 updated this revision to Diff 95541.
sanwou01 added a comment.
Rebased and clang-formatted.
https://reviews.llvm.org/D31709
Files:
include/clang/Basic/SourceLocation.h
include/clang/Frontend/DiagnosticRenderer.h
include/clang/Frontend/TextDiagnostic.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299754: Skip Unicode character expansion in assembly files
(authored by sanwou01).
Changed prior to commit:
https://reviews.llvm.org/D31765?vs=94501=94505#toc
Repository:
rL LLVM
sanwou01 added reviewers: rnk, rsmith.
sanwou01 added a comment.
Hi Salman,
This essentially looks good to me. I don't think I'm the right person to LGTM
this however, so I've added some reviewers who might be able to have a look.
Thanks,
Sanne
https://reviews.llvm.org/D31496
sanwou01 created this revision.
Move the DiagnosticRenderer and its dependents to using FullSourceLocs
instead of a SourceLocation and SourceManager pointer. The changeset is
rather large but entirely mechanical.
This is step one to allow DiagnosticRenderer to take either
llvmn::SMLocs or
sanwou01 added a comment.
Hi Oli,
Thanks for taking a look! You're right, -w and -Werror could be implemented by
passing them as MCTargetOptions flags.
This patch is indeed intended to enable -W options to promote or silence
(categories of) warnings. To enable that, the first step is to be
sanwou01 created this revision.
Herald added a subscriber: aemerson.
Add initial support for printing assembly diagnostics using the
DiagnosticsEngine infrastructure. Add support for -w (no warnings) and
-Werror (warnings are errors) and print a summary with the number of
errors and warnings.
sanwou01 abandoned this revision.
sanwou01 added a comment.
Please see https://reviews.llvm.org/D30167 for an attempt to test this from llc.
https://reviews.llvm.org/D29770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sanwou01 updated this revision to Diff 88188.
sanwou01 added a comment.
Use clang_cc1 -verify for testing as suggested by @rnk.
@echristo, llc does use the same diags interfaces as clang, however, it is
lacking the infrastructure to make use of LocCookies.
In any case, I think this test is
sanwou01 added a comment.
This tests the improved inline asm diagnostics from
https://reviews.llvm.org/D29769.
https://reviews.llvm.org/D29770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sanwou01 created this revision.
Add a test for improved inline assembly diagnostics in llvm.
https://reviews.llvm.org/D29770
Files:
test/Misc/inline-asm-diags.c
Index: test/Misc/inline-asm-diags.c
===
--- /dev/null
+++
sanwou01 updated this revision to Diff 87461.
sanwou01 added a comment.
Update the tests. Note that the diagnostics for backend errors are missing the
"instantiated into assembly here" messages. This is unfortunate but expected:
the origin information is no longer available at this stage.
sanwou01 created this revision.
Herald added a subscriber: mehdi_amini.
Add a test for improved inline assembly diagnostics in llvm.
https://reviews.llvm.org/D29415
Files:
test/Misc/inline-asm-diags.c
Index: test/Misc/inline-asm-diags.c
30 matches
Mail list logo
