https://github.com/perry-ca approved this pull request.
This works on z/OS. Thanks for fixing it.
https://github.com/llvm/llvm-project/pull/111975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -302,6 +305,17 @@ class RealFileSystem : public FileSystem {
return Storage;
}
+ ErrorOr> openFileForRead(const Twine &Name,
perry-ca wrote:
np. I was misreading the diff. I didn't see it was a private member function.
It looked like a file scop
@@ -302,6 +305,17 @@ class RealFileSystem : public FileSystem {
return Storage;
}
+ ErrorOr> openFileForRead(const Twine &Name,
perry-ca wrote:
Thanks, Could you mark this as static.
https://github.com/llvm/llvm-project/pull/111723
___
@@ -117,8 +117,12 @@ FileSystem::~FileSystem() = default;
ErrorOr>
FileSystem::getBufferForFile(const llvm::Twine &Name, int64_t FileSize,
- bool RequiresNullTerminator, bool IsVolatile) {
- auto F = openFileForRead(Name);
+
@@ -324,6 +330,17 @@ ErrorOr RealFileSystem::status(const Twine &Path) {
ErrorOr>
RealFileSystem::openFileForRead(const Twine &Name) {
+ SmallString<256> RealName, Storage;
perry-ca wrote:
Can you put this code into a static function or even a private member
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/111035
>From e8d355c9cd165e0a255bbbfb5b0126cf7b1461a6 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Wed, 2 Oct 2024 12:56:43 -0500
Subject: [PATCH 1/7] initial work for pragma export & _Export keyword
---
clang/in
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/82
>From 360bab981d8ec36e17aa4fbadbb4feef42c5d135 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Fri, 4 Oct 2024 10:09:32 -0500
Subject: [PATCH 1/2] Add z/OS customization file
---
clang/include/clang/Driver/Dr
https://github.com/perry-ca closed
https://github.com/llvm/llvm-project/pull/111053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca edited
https://github.com/llvm/llvm-project/pull/82
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca edited
https://github.com/llvm/llvm-project/pull/111035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca edited
https://github.com/llvm/llvm-project/pull/111053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/82
On z/OS, the location of the system libraries and side decks (aka equivalent to
libc, etc) are not in a predefined location. The system does have a default
location but sysadmins can change this and frequentl
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/111035
>From e8d355c9cd165e0a255bbbfb5b0126cf7b1461a6 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Wed, 2 Oct 2024 12:56:43 -0500
Subject: [PATCH 1/7] initial work for pragma export & _Export keyword
---
clang/in
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/111053
- set the default on z/OS to use the XL pragma semantics
- add in additional pragma pack values such as twobyte & reset supported by XL
on z/OS
>From 8f5b11f92dec5072d50a7930fa501c9039b6af26 Mon Sep 17 00:00:0
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/111035
>From e8d355c9cd165e0a255bbbfb5b0126cf7b1461a6 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Wed, 2 Oct 2024 12:56:43 -0500
Subject: [PATCH 1/6] initial work for pragma export & _Export keyword
---
clang/in
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/111035
>From e8d355c9cd165e0a255bbbfb5b0126cf7b1461a6 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Wed, 2 Oct 2024 12:56:43 -0500
Subject: [PATCH 1/5] initial work for pragma export & _Export keyword
---
clang/in
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/111035
The z/OS operating system uses the linker to control what symbols are exported
from shared libraries. The compilation step sets a bit on each symbol that
should be exported from a shared library and then the
perry-ca wrote:
> > sorry this is same as #107906 (with a bigger impact radius, as you're also
> > changing getBufferForFile) and doesn't address any of the issues mention
> > about explaining the semantics of `IsText` or justification for changing
> > the core VFS interfaces, for an operation
perry-ca wrote:
> @perry-ca raised some concerns in #109664 about this functionality requiring
> some context awareness, I don't think any of those is addressed by this patch
> either. Pretty much all of the callers apart from ASTReader is just using
> `IsText = true`.
It just happens that 90
https://github.com/perry-ca closed
https://github.com/llvm/llvm-project/pull/109852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
perry-ca wrote:
Thanks for the offer David. I do have permission now. I held off merging
yesterday because the builds were all broken from some other change. The
builds all pass now. I'll merge it.
https://github.com/llvm/llvm-project/pull/109852
___
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/109852
>From f8bb9d99ae9b9e8fd546d8a5a801681c721cb11d Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Fri, 13 Sep 2024 16:49:02 -0500
Subject: [PATCH] use errc instead of hard coded text for messages
---
clang/test/
https://github.com/perry-ca closed
https://github.com/llvm/llvm-project/pull/107613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/109852
Several lit tests look for messages with text generated from strerror() such as
"no such file or directory". The value can change slightly from system to
system. Use the llvm-lit macro `%errc_` instead.
Thi
@@ -24,6 +24,7 @@
//
// FIXME: Path handling should work on all platforms.
// REQUIRES: system-linux
+// UNSUPPORTED: target={{.*}}-zos{{.*}}
perry-ca wrote:
Unless we can prove that is the case, it is better to stick with the more
selective condition. I don
perry-ca wrote:
@abhina-sree could you review this. Thanks
https://github.com/llvm/llvm-project/pull/107916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
perry-ca wrote:
@mgorny could you review this too. Thanks.
https://github.com/llvm/llvm-project/pull/107613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/107916
Set up these tests so these are marked as unsupported when targeting z/OS.
Most would already be unsupported if you ran lit on z/OS. However, they also
need to be unsupported if the default triple is z/OS.
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/107613
>From 27f31954976948e4e0d194db5da6bc550b4c2200 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Fri, 6 Sep 2024 10:54:07 -0500
Subject: [PATCH 1/4] clone the alias option too
---
clang/lib/Driver/Driver.cpp
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/107613
>From 27f31954976948e4e0d194db5da6bc550b4c2200 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Fri, 6 Sep 2024 10:54:07 -0500
Subject: [PATCH 1/3] clone the alias option too
---
clang/lib/Driver/Driver.cpp
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/107613
>From 27f31954976948e4e0d194db5da6bc550b4c2200 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Fri, 6 Sep 2024 10:54:07 -0500
Subject: [PATCH 1/2] clone the alias option too
---
clang/lib/Driver/Driver.cpp
perry-ca wrote:
@redstar @abhina-sree Could you review this. Thanks
https://github.com/llvm/llvm-project/pull/107613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/107613
>From 27f31954976948e4e0d194db5da6bc550b4c2200 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Fri, 6 Sep 2024 10:54:07 -0500
Subject: [PATCH 1/2] clone the alias option too
---
clang/lib/Driver/Driver.cpp
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/107613
>From 27f31954976948e4e0d194db5da6bc550b4c2200 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Fri, 6 Sep 2024 10:54:07 -0500
Subject: [PATCH 1/2] clone the alias option too
---
clang/lib/Driver/Driver.cpp
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/107613
An example of this is the -mpure-code option. Without a config file being
used, an error message will print `-mpure-code`. But if a config file is used,
the error message will print `-mexecute-only`.
>From
@@ -0,0 +1,84 @@
+// RUN: %clang_cc1 -triple s390x-ibm-zos -fzos-extensions -emit-llvm -O2 < %s
| FileCheck %s --check-prefix=X64
perry-ca wrote:
Does this test need to be some complicated?
https://github.com/llvm/llvm-project/pull/96063
_
@@ -7097,10 +7098,14 @@ static bool
handleMSPointerTypeQualifierAttr(TypeProcessingState &State,
else if (Attrs[attr::UPtr])
ASIdx = LangAS::ptr32_uptr;
} else if (PtrWidth == 64 && Attrs[attr::Ptr32]) {
-if (Attrs[attr::UPtr])
+if (Triple.isOSzOS()) {
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH 1/4] Set the default arch for z/OS to be arch10
---
clang/CMakeLis
perry-ca wrote:
I removed the additional use of CLANG_SYSTEMZ_DEFAULT_ARCH and left that for a
separate discussion. The only code clean up left here is the elimination of
the `CPU` member that wasn't used.
https://github.com/llvm/llvm-project/pull/89854
___
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH 1/3] Set the default arch for z/OS to be arch10
---
clang/CMakeLis
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH 1/2] Set the default arch for z/OS to be arch10
---
clang/CMakeLis
@@ -11,6 +11,8 @@
//
//===--===//
+#include "clang/Config/config.h"
perry-ca wrote:
That was my preference too except clang/Config/config.h has a clause that it
can only be included once an
@@ -11,6 +11,8 @@
//
//===--===//
+#include "clang/Config/config.h"
perry-ca wrote:
This is needed for the change in SystemZ.h to replace the hard coded `"z10"`
string with the CLANG_SYSTEM
perry-ca wrote:
@MaskRay no worries. This brittle test issue was a reason I trying to keep the
default for zLinux unchanged by this.
I have posted a new commit that eliminates the cmake variable for z/OS.
https://github.com/llvm/llvm-project/pull/89854
perry-ca wrote:
I removed the ability to make z/OS default arch configurable at build time. We
don't really need it and this makes the code simpler.
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH 1/2] Set the default arch for z/OS to be arch10
---
clang/CMakeLis
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH] Set the default arch for z/OS to be arch10
---
clang/CMakeLists.t
perry-ca wrote:
ping @MaskRay ^^^
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/90990
These test cases are testing features not available when either targeting the
s390x-ibm-zos target or use tools/features not available on the z/OS operating
system. In a couple cases the lit test had a number
perry-ca wrote:
@MaskRay Got it.
The problem with that solution is that if you use --target you won't get the
correct arch. This would be a problem for any cross compilation. For example,
say you cross compile from zLinux (which wouldn't have the config file), the
arch would be arch8. A
perry-ca wrote:
@owenca @mydeveloperday Thanks for testing on Windows and taking the time to
review the PR.
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
perry-ca wrote:
ping @MaskRay. Thanks
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
perry-ca wrote:
> We don't normally commit in clang-format with a unit test
I assume you mean "without a unit test". In this case the unit test is the
existing test cases. Some fail on z/OS because the files are not read in as
text. It's not really possible to detect this issue on other pla
@@ -413,8 +413,9 @@ static bool format(StringRef FileName, bool
ErrorOnIncompleteFormat = false) {
// On Windows, overwriting a file with an open file mapping doesn't work,
// so read the whole file into memory when formatting in-place.
ErrorOr> CodeOrErr =
- !Outpu
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/90128
>From bf3ed6819301d9fcc7e001b9e6676d5f4ce66c4d Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Thu, 25 Apr 2024 15:58:05 -0500
Subject: [PATCH] treat text files as text files so autoconversion is done
---
clan
perry-ca wrote:
Failed at `FAIL: BOLT :: RISCV/fake-label-no-entry.c` this time. I'll give it
a day or so and try again.
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
perry-ca wrote:
> LGTM, but check why the following test in checks failed: `FAIL: BOLT ::
> RISCV/unnamed-sym-no-entry.c`
Looks unrelated. I'm kicking off another build.
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
c
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/90128
>From 2d7034366547b176f89b076eb60bcb44424fae11 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Thu, 25 Apr 2024 15:58:05 -0500
Subject: [PATCH] treat text files as text files so autoconversion is done
---
clan
https://github.com/perry-ca edited
https://github.com/llvm/llvm-project/pull/89995
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca edited
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/90128
To support auto-conversion on z/OS text files need to be opened as text files.
These changes will fix a number of LIT failures due to text files not being
converted to the internal code page.
- update a number
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/89995
Update the wrappers for the C std headers so that they always forward to the
z/OS system headers.
>From 3c947fb397b8d5fa3744aa9eb130eac4894bd300 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Wed, 24 Apr 2024
perry-ca wrote:
> We are trying to remove such cmake variables in favor of configuration file.
I'm not sure which configuration file(s) you are referring to. I assume you
mean the cache files in clang/cmake/caches. If so, I don't think we want to
put it there because `CLANG_SYSTEMZ_ZOS_DEFAU
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/89854
The default arch level on z/OS is arch10. Update the code so z/OS has arch10
without changing the default for zLinux.
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
D
perry-ca wrote:
Was this PR meant to change the behaviour for c++11/14?
https://github.com/llvm/llvm-project/pull/73018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -374,10 +376,10 @@ static __inline fp_t __compiler_rt_fmax(fp_t x, fp_t y) {
#endif
}
-#elif defined(QUAD_PRECISION) && defined(CRT_HAS_TF_MODE)
+#elif defined(QUAD_PRECISION)
perry-ca wrote:
I've put up #77981 for review.
https://github.com/llvm/llvm-pro
perry-ca wrote:
Thanks. I don't have write access yet. Would you be able to merge this.
https://github.com/llvm/llvm-project/pull/77554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/77554
>From 7ba4d61bd2beda03ba0fcefc9ca5c1ff08ffd48e Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 9 Jan 2024 20:59:28 -0600
Subject: [PATCH 1/6] Generate __multc3 for z/OS
---
compiler-rt/lib/builtins/divtc3
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/77554
>From 7ba4d61bd2beda03ba0fcefc9ca5c1ff08ffd48e Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 9 Jan 2024 20:59:28 -0600
Subject: [PATCH 1/5] Generate __multc3 for z/OS
---
compiler-rt/lib/builtins/divtc3
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/77554
>From 7ba4d61bd2beda03ba0fcefc9ca5c1ff08ffd48e Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 9 Jan 2024 20:59:28 -0600
Subject: [PATCH 1/4] Generate __multc3 for z/OS
---
compiler-rt/lib/builtins/divtc3
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/77554
>From 7ba4d61bd2beda03ba0fcefc9ca5c1ff08ffd48e Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 9 Jan 2024 20:59:28 -0600
Subject: [PATCH 1/3] Generate __multc3 for z/OS
---
compiler-rt/lib/builtins/divtc3
@@ -976,6 +976,46 @@ void CodeGenModule::Release() {
Context.getTypeSizeInChars(Context.getWideCharType()).getQuantity();
getModule().addModuleFlag(llvm::Module::Error, "wchar_size", WCharWidth);
+ if (getTriple().isOSzOS()) {
+getModule().addModuleFlag(llvm::Modu
https://github.com/perry-ca approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/72906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
73 matches
Mail list logo
