SebastianPerta added a comment.
@cor3ntin can I close it?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129689/new/
https://reviews.llvm.org/D129689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
SebastianPerta added a comment.
>>are you planning to update the patch
Yes, sorry about the delay. I will update the patch before the end of the week.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129689/new/
https://reviews.llvm.org/D129689
SebastianPerta added a comment.
>>But can you add some test coverage for this?
In clang\test\Headers\limits.cpp there is:
_Static_assert(USHRT_MAX == (unsigned short)~0ULL, "");
However as I said this needs a 16 bits target. Looking at the RUN commands at
the top of the file I think I can solve
SebastianPerta added a comment.
>> Additionally, the type of a character constant in C is int.
This means that char32_t c4 = U'\U00064321'; is invalid in C. I know that is
clang more strict with the standard than GCC, however I would like to mention
that in GCC the value is not truncated to 16
SebastianPerta added a comment.
>> Regarding testing, it seems like this should change the diagnostic emitted
>> for long x = 'abc' from "Character constant too long for its type" to
>> "Multi-character character constant" when the target is AVR?
Currently on RL78 it returns this warning withou
SebastianPerta created this revision.
SebastianPerta added reviewers: aaron.ballman, sammccall, DaanDeMeyer.
Herald added a subscriber: dylanmckay.
Herald added a project: All.
SebastianPerta requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
