[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-24 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: Thanks for the approval @jansvoboda11! Would you mind merging the change? I don't have the required permissions... https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-18 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72400 >From f260093f23fe599f2b91bbe0bf06304387549a22 Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Mon, 11 Apr 2022 16:53:24 +0200 Subject: [PATCH] [libclang] Compute the right spelling location Locati

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-18 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: @jansvoboda11 since you've most recently touched this part of the code, would you mind having a look at the change? https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [Rewrite] Fix offset computation in RemoveText (PR #73827)

2024-04-18 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/73827 >From f31443bb4de3cec4e7d98ac3c147f09a7ca297fe Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Wed, 16 Aug 2023 13:34:10 + Subject: [PATCH] [Rewrite] Fix offset computation in RemoveText When r

[clang] [Rewrite] Fix offset computation in RemoveText (PR #73827)

2024-04-18 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: @jansvoboda11 this is another PR where I would appreciate your feedback if you can find the time. https://github.com/llvm/llvm-project/pull/73827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-19 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72400 >From dd0f87b25733b4569b89ce445630ee843e3bfb2b Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Mon, 11 Apr 2022 16:53:24 +0200 Subject: [PATCH] [libclang] Compute the right spelling location Locati

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-19 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: Thanks for the review @jansvoboda11; I've added an entry in the release notes and a unit test. https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-22 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72400 >From cc15f9bb8b37fb1b68bd33241ab37e98d57d274c Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Mon, 11 Apr 2022 16:53:24 +0200 Subject: [PATCH] [libclang] Compute the right spelling location Locati

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-22 Thread Sebastian Poeplau via cfe-commits
@@ -1292,6 +1292,31 @@ void func() {} EXPECT_EQ(attrCount, 1); } +TEST_F(LibclangParseTest, clang_getSpellingLocation) { + std::string fileName = "main.c"; + WriteFile(fileName, "#define X(value) int x = value;\nX(42)\n"); + + ClangTU = clang_parseTranslationUnit(Index, f

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-01-19 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: Ping https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Rewrite] Fix offset computation in RemoveText (PR #73827)

2024-01-19 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: Ping https://github.com/llvm/llvm-project/pull/73827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

2023-11-23 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: It should, yes. https://github.com/llvm/llvm-project/pull/72401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

2023-11-24 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72401 >From df8bfc2cdb1488d3ad037ea26bad48e658e5d3c8 Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Wed, 17 Aug 2022 19:22:53 +0200 Subject: [PATCH] [clang] Add missing LinkageSpec case to getCursorKindF

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

2023-11-24 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: I've added an entry to the release notes. https://github.com/llvm/llvm-project/pull/72401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

2023-11-24 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: By the way, I don't have permission to merge, so feel free to do it when you think it's ready. https://github.com/llvm/llvm-project/pull/72401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [libclang] Compute the right spelling location (PR #72400)

2023-11-28 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: I just discovered #28205 which should be fixed by this change. https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Rewrite] Fix offset computation in RemoveText (PR #73827)

2023-11-29 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau created https://github.com/llvm/llvm-project/pull/73827 When removing a source range from the RewriterBuffer, Clang needs to compute the size of the actual range in the RewriterBuffer (as new elements may have been inserted at any position of the original ra

[clang] [libclang] Compute the right spelling location (PR #72400)

2023-11-15 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau created https://github.com/llvm/llvm-project/pull/72400 Locations inside macro expansions have different spelling/expansion locations. Apply a FIXME to make the libclang function clang_getSpellingLocation return the right spelling location, and adapt the tes

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

2023-11-15 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau created https://github.com/llvm/llvm-project/pull/72401 The LinkageSpec case was omitted, and there is a declared CXCursor_Kind for it. Adapt the testsuite drivers to print mangled names for declarations with extern linkage. Also update the test baseline for

[clang] [libclang] Compute the right spelling location (PR #72400)

2023-11-15 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72400 >From db1f8becea210494ae42619cba3ad697cddc07bf Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Mon, 11 Apr 2022 16:53:24 +0200 Subject: [PATCH] [libclang] Compute the right spelling location Locati