[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

skatrak abandoned this revision. skatrak added a comment. I'll close this patch now, since the agreed approach has been to try using the `IsolatedFromAbove` trait and not to add an interface modifying the CSE pass behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

This revision was automatically updated to reflect the committed changes. Closed by commit rG9058762789c0: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

This revision was automatically updated to reflect the committed changes. Closed by commit rG29aa749087be: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to… (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

This revision was automatically updated to reflect the committed changes. Closed by commit rG094a63a20bf5: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1472

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 556657. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D147219 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Frontend/O

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 556656. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 556655. skatrak added a comment. Rebase and address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flan

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak added a comment. Thank you for the review. After I address your last comment my plan is to land this and the other two accepted REQUIRES patches that depended on it. Is there a preferred approach as to how to go about it? I could rebase them all and wait until the pre-merge builds finis

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 556543. skatrak added a comment. Remove leftover comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib/Lowe

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak added a comment. Thank you Kiran for having a look at this! In D147218#4643257 , @kiranchandramohan wrote: > Could you add to the summary that the `atomic` related handling is done > elsewhere. Done. > Could you expand the tests to cover the

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 556542. skatrak marked 3 inline comments as done. skatrak added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/inc

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 556436. skatrak added a comment. Update patch. Ping for review and unblocking remaining accepted REQUIRES patches, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/

[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

skatrak added a comment. Thank you for your comments @jsjodin and @kiranchandramohan , I created an RFC here to try to get consensus on what the best solution shoul

[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

skatrak created this revision. skatrak added reviewers: ftynse, kiranchandramohan, jsjodin, domada, agozillon, raghavendhra, TIFitis, shraiysh. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurah

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 552427. skatrak added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOp

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 552411. skatrak marked an inline comment as done. skatrak added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 551968. skatrak added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D147219 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Fron

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 551506. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib/Lower/Bridge.cpp fl

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 551502. skatrak marked an inline comment as done. skatrak added a comment. Update to split generic MLIR into its own patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D14

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 551500. skatrak added a comment. Rebase and address conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551497. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551454. skatrak added a comment. Rebase patch to fix unrelated build error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak requested review of this revision. skatrak marked 11 inline comments as done. skatrak added a comment. I think the change of approach to initialize the `OpenMPIRBuilderConfig` through the `amendOperation()` flow (rather than directly inside of `ModuleTranslation::getOpenMPBuilder()`) aft

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551150. skatrak added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CG

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 551147. skatrak added a comment. Herald added subscribers: gysit, Dinistro. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D147219 Files: clang/lib/CodeGen/C

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 551113. skatrak added a comment. Change parent and update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/l

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551088. skatrak added a comment. Herald added subscribers: gysit, Dinistro. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/C

[PATCH] D157493: Revert "Revert "[Flang][Sema] Move directive sets to a shared location""

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5a524b8b5e9: Revert "Revert "[Flang][Sema] Move directive sets to a shared location"" (authored by skatrak). Changed prior to commit: https://reviews.llvm.org/D157493?vs=548561&id=548962#toc Repositor

[PATCH] D157493: Revert "Revert "[Flang][Sema] Move directive sets to a shared location""

skatrak created this revision. skatrak added a reviewer: kiranchandramohan. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. skatrak requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1, jdoerfert. Heral

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec70627dd177: [Flang][Sema] Move directive sets to a shared location (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak added a comment. In D157090#4562088 , @kiranchandramohan wrote: > This looks OK. The only concern is whether we will lose the ability to inline > the code for set membership. Can these sets be put in a header file with > `inline constexpr`? Th

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak updated this revision to Diff 547686. skatrak added a comment. Declare sets as `inline` inside of header file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157090/new/ https://reviews.llvm.org/D157090 Files: clang/docs/tools/clang-forma

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak updated this revision to Diff 547181. skatrak added a comment. Add missing newline at end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157090/new/ https://reviews.llvm.org/D157090 Files: clang/docs/tools/clang-formatted-files.t

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak created this revision. skatrak added reviewers: kiranchandramohan, jsjodin, domada, agozillon, TIFitis, raghavendhra. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. skatrak requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribe

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63ca93c7d1d1: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags (authored by skatrak). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

skatrak added a comment. This patch has been triggering a seemingly unrelated build error in libcxx, even after multiple rebases. Can I land it as-is or is this error something I should address first? Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

skatrak updated this revision to Diff 538564. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154591/new/ https://reviews.llvm.org/D154591 Files: clang/docs/OffloadingDesign.rst clang/include/clang/Basic/LangOpti

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

skatrak updated this revision to Diff 538135. skatrak added a comment. Rebase and fix issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154591/new/ https://reviews.llvm.org/D154591 Files: clang/docs/OffloadingDesign.rst clang/include/clang

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

skatrak updated this revision to Diff 537768. skatrak added a comment. Rebase to try resolving build failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154591/new/ https://reviews.llvm.org/D154591 Files: clang/docs/OffloadingDesign.rst cla

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

skatrak created this revision. skatrak added reviewers: jsjodin, jdoerfert, kiranchandramohan. Herald added subscribers: gysit, Dinistro, bviyer, sunshaoce, Moerafaat, zero9178, bzcheeseman, mattd, gchakrabarti, awarzynski, sdasgup3, asavonic, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatian

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 534512. skatrak added a comment. Update to integrate with changes to parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 531717. skatrak added a comment. Rebasde to fix build error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib/L

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak requested review of this revision. skatrak added a comment. Changing status to "Request Review" again due to some significant changes to the approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D1472

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 531437. skatrak added a comment. Update patch to integrate with related patch D149337 and address reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak added a comment. Thank you for the feedback. I expect I will be able to refactor the `analyzeOpenMPDeclarative()` function to OpenMP.cpp as suggested, but I'll bring that together with other changes to make it integrate cleanly with the latest changes to D149337

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 527854. skatrak added a comment. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. Update and remove OpenMP dialect dependency from the generic LLVM IR translation. Followed @kiranchandramohan's suggestion in the comments for D

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 527380. skatrak added a comment. Update with latest main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clan

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak marked 2 inline comments as done. skatrak added a comment. Thank you for the comments, they should have all been addressed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 527354. skatrak added a comment. Rebase and address reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5291 +Function *OpenMPIRBuilder::createRegisterRequires(StringRef Name) { + // Skip the creation of the registration function if this is device codegen jsjodin wrote: > Perhap

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 520398. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib/Lower/Bridge.cpp fl

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 520374. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 520337. skatrak added a comment. Remove handling of `atomic_default_mem_order`, as it's now done in semantics. Fix conflicts with changes to parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/ne

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 518698. skatrak added a comment. Rebase. Disable some known failing 'declare target' tests temporarily until they are fixed by parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://re

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 518677. skatrak edited the summary of this revision. skatrak added a comment. Herald added subscribers: bviyer, Moerafaat, zero9178, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 517844. skatrak added a comment. Remove leftover unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib/Low

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 517616. skatrak added a comment. Remove checks from lowering that belong in semantic analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/f

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 516730. skatrak added a comment. Try undoing last change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib/Lowe

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 516729. skatrak added a comment. Herald added subscribers: llvm-commits, cfe-commits, bviyer, Moerafaat, zero9178, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartb

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak added a comment. I have been able to track down the failed `lld.wasm::stub_library.s` unit test to be due to the buildbot picking up line endings for the `lld/test/wasm/Inputs/libstub.so` to be Windows ones ("\r\n"), so the condition `if (mbref.getBuffer().starts_with("#STUB\n"))` in `l

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 515684. skatrak added a comment. Avoid creating registration function for the device. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpe

[PATCH] D147941: [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang

This revision was automatically updated to reflect the committed changes. skatrak marked 2 inline comments as done. Closed by commit rG2266f4a3b38f: [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 512805. skatrak added a comment. Add unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGO

[PATCH] D147941: [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang

skatrak marked 4 inline comments as done. skatrak added a comment. In D147941#4255622 , @awarzynski wrote: > In the context of LLVM, I would normally associate "pass" with something > else. I'm not that familiar with offloading, so perhaps that's the la

[PATCH] D147941: [Flang][Driver][OpenMP] Enable flags for filtering of offloading passes in flang

skatrak updated this revision to Diff 512399. skatrak added a comment. Address reviewer's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147941/new/ https://reviews.llvm.org/D147941 Files: clang/include/clang/Driver/Options.td flang/te

[PATCH] D147941: [Flang][Driver][OpenMP] Enable flags for filtering of offloading passes in flang

skatrak added a comment. In D147941#4255458 , @awarzynski wrote: > Could you add tests that demonstrate what these options actually do? Thank you for the quick review! These options just modify which `flang-new -fc1` invocations are produced by the dri

[PATCH] D147941: [Flang][Driver][OpenMP] Enable flags for filtering of offloading passes in flang

skatrak created this revision. skatrak added reviewers: dpalermo, jsjodin, domada, agozillon, TIFitis, awarzynski. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. skatrak requested review of this revision. Herald added a

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak created this revision. skatrak added reviewers: dpalermo, jsjodin, domada, agozillon. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. skatrak requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. skatrak marked an inline comment as done. Closed by commit rG33be83415c9b: [flang][driver][openmp] Write MLIR for -save-temps (authored by skatrak). Repository: rG L

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak marked 3 inline comments as done. skatrak added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:103 + std::error_code ec; + llvm::ToolOutputFile out(outDir + outFile, ec, llvm::sys::fs::OF_Text); + if (ec) awarzynski wrote: > skatra

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak updated this revision to Diff 508099. skatrak added a comment. Herald added subscribers: Moerafaat, zero9178, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, nicolasvasilache, a

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak added a comment. @awarzynski, can you confirm whether your concerns have been addressed? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146075/new/ https://reviews.llvm.org/D146075 ___

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak added a comment. Thanks again for helping improving this patch. I made most of the changes requested, and tried to clarify a bit better the approach followed for this implementation, to see if it is acceptable or if some more fundamental changes have to be done. Comm

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak updated this revision to Diff 507365. skatrak marked 6 inline comments as done. skatrak added a comment. Changes to tests and path manipulation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146075/new/ https://reviews.llvm.org/D146075 File

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak marked 4 inline comments as done. skatrak added a comment. Thank you for the feedback! I'll wait for confirmation before landing this patch, in case there are further comments relating to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak updated this revision to Diff 507001. skatrak added a comment. Address reviewers comments and update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146075/new/ https://reviews.llvm.org/D146075 Files: clang/include/clang/Driver/Optio

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak created this revision. skatrak added reviewers: gregrodgers, dpalermo, domada, jsjodin, agozillon, kiranchandramohan, awarzynski. Herald added subscribers: sunshaoce, bzcheeseman, rriddle, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. skatrak requ

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

skatrak added inline comments. Comment at: flang/test/Driver/omp-frontend-forwarding.f90:15 +! CHECK: "{{[^"]*}}flang-new" "-fc1" "-triple" "amdgcn-amd-amdhsa" {{.*}} "-fopenmp" {{.*}} "-fopenmp-is-device" {{.*}}.f90" +! CHECK: "{{[^"]*}}clang-offload-packager" {{.*}} "--image=

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

skatrak added a comment. In D143493#4110323 , @awarzynski wrote: > In D143493#4110272 , @skatrak wrote: > >> It is introduced to the arguments list in `Clang::AddPreprocessingOptions` >> in certain cases to add

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

skatrak added a comment. In D143493#4110230 , @awarzynski wrote: > In what cases would this flag be used in practice? I've scanned Clang and > couldn't find any answers. It is introduced to the arguments list in `Clang::AddPreprocessingOptions` in cer

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

skatrak created this revision. skatrak added reviewers: dpalermo, jsjodin, domada, raghavendhra. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. skatrak requested review of this revision. Herald added