shahidiqbal13 wrote:
Hi @AaronBallman
Can you pls explain me your previous response _"It would be better for us to
associate the data with catch statements specifically because there's a lot
fewer of those than there are variable declarations in general."_
I mean storing the ellipsis's locati
shahidiqbal13 wrote:
Hi @cor3ntin ,
I tried but didn't work as per design, Can you pls review this , I m not
updating the Decl , updating the VarDecl
https://github.com/llvm/llvm-project/pull/80976
___
cfe-commits mailing list
cfe-commits@lists.llvm.
@@ -41,7 +41,7 @@ void TestCatch2() {
try {
}
// CHECK-NEXT:CXXCatchStmt
-// CHECK-NEXT: NULL
+// CHECK-NEXT: VarDecl {{.*}} ''
shahidiqbal13 wrote:
Can't do much here , its intently being created the var of unknown type
https://github.com/l
@@ -16983,7 +16983,7 @@ VarDecl *Sema::BuildExceptionDeclaration(Scope *S,
/// ActOnExceptionDeclarator - Parsed the exception-declarator in a C++ catch
/// handler.
-Decl *Sema::ActOnExceptionDeclarator(Scope *S, Declarator &D) {
+Decl *Sema::ActOnExceptionDeclarator(Scope *S
@@ -271,6 +271,9 @@ void TextNodeDumper::Visit(const Decl *D) {
OS << " hidden";
if (D->isImplicit())
OS << " implicit";
+ if (const VarDecl *ND = dyn_cast(D))
+ if (ND->isEllipsisVariable())
+ OS << " catch_all";
shahidiqbal13 wrote:
Will do it
@@ -115,6 +115,10 @@ void JSONNodeDumper::Visit(const Decl *D) {
else if (D->isThisDeclarationReferenced())
JOS.attribute("isReferenced", true);
+ if (const VarDecl *ND = dyn_cast(D))
+ if (ND->isEllipsisVariable())
+ JOS.attribute("catch_all", true);
@@ -1474,6 +1478,16 @@ class VarDecl : public DeclaratorDecl, public
Redeclarable {
NonParmVarDeclBits.ExceptionVar = EV;
}
+ /// Determine the Ellipsis (...) or not
+ bool isEllipsisVariable() const {
+return isa(this) ? false : NonParmVarDeclBits.EllipsisVar;
+
@@ -1053,6 +1053,10 @@ class VarDecl : public DeclaratorDecl, public
Redeclarable {
LLVM_PREFERRED_TYPE(bool)
unsigned ExceptionVar : 1;
+/// To Check the ellipsis
shahidiqbal13 wrote:
Will do it , its expected
https://github.com/llvm/llvm-proje
@@ -1053,6 +1053,10 @@ class VarDecl : public DeclaratorDecl, public
Redeclarable {
LLVM_PREFERRED_TYPE(bool)
unsigned ExceptionVar : 1;
+/// To Check the ellipsis
+LLVM_PREFERRED_TYPE(bool)
+unsigned EllipsisVar : 1;
shahidiqbal13 wrote:
@@ -2698,9 +2698,16 @@ StmtResult Parser::ParseCXXCatchBlock(bool FnCatch) {
Declarator ExDecl(DS, Attributes, DeclaratorContext::CXXCatch);
ParseDeclarator(ExDecl);
ExceptionDecl = Actions.ActOnExceptionDeclarator(getCurScope(), ExDecl);
- } else
-ConsumeToken
shahidiqbal13 wrote:
Hi @cor3ntin to review the updated fix, will format it later
https://github.com/llvm/llvm-project/pull/80976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shahidiqbal13 updated
https://github.com/llvm/llvm-project/pull/80976
>From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001
From: Shahid Iqbal
Date: Thu, 16 Nov 2023 11:26:43 -0500
Subject: [PATCH 1/4] TESTING infra
---
clang/NOTES.txt | 2 ++
1 file chang
https://github.com/shahidiqbal13 updated
https://github.com/llvm/llvm-project/pull/80976
>From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001
From: Shahid Iqbal
Date: Thu, 16 Nov 2023 11:26:43 -0500
Subject: [PATCH 1/3] TESTING infra
---
clang/NOTES.txt | 2 ++
1 file chang
https://github.com/shahidiqbal13 created
https://github.com/llvm/llvm-project/pull/80976
- Raising for preliminary review (forget about formating)
- Fixed the '...' catch all ellipsis in catch stmt
- Will fix the failed testcases once we get agree on this
- I don't think we need to support for t
https://github.com/shahidiqbal13 closed
https://github.com/llvm/llvm-project/pull/72654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shahidiqbal13 wrote:
Hi @DrTodd13 ,
Any further needs to be done here ?? Can you please add more devs for reviewing
this
Thanks,
Shahid
https://github.com/llvm/llvm-project/pull/72654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
https://github.com/shahidiqbal13 updated
https://github.com/llvm/llvm-project/pull/72654
>From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001
From: Shahid Iqbal
Date: Thu, 16 Nov 2023 11:26:43 -0500
Subject: [PATCH 1/7] TESTING infra
---
clang/NOTES.txt | 2 ++
1 file chang
https://github.com/shahidiqbal13 updated
https://github.com/llvm/llvm-project/pull/72654
>From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001
From: Shahid Iqbal
Date: Thu, 16 Nov 2023 11:26:43 -0500
Subject: [PATCH 1/6] TESTING infra
---
clang/NOTES.txt | 2 ++
1 file chang
@@ -83,10 +85,29 @@ struct DOTGraphTraitsViewer
StringRef Name;
};
+static void shortenFileName(std::string &FN, unsigned char len = 250) {
+
+ FN = FN.substr(0, len);
+ if (nameObj.empty())
+nameObj.push_back(FN);
+
+ else {
+for (auto it = nameObj.begin(); it !=
https://github.com/shahidiqbal13 updated
https://github.com/llvm/llvm-project/pull/72654
>From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001
From: Shahid Iqbal
Date: Thu, 16 Nov 2023 11:26:43 -0500
Subject: [PATCH 1/5] TESTING infra
---
clang/NOTES.txt | 2 ++
1 file chang
@@ -94,7 +96,7 @@ void printGraphForFunction(Function &F, GraphT Graph,
StringRef Name,
raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF);
shahidiqbal13 wrote:
@DrTodd13 ,
Will change the fix later , need to think
https://github.com/llvm/llvm-proje
https://github.com/shahidiqbal13 updated
https://github.com/llvm/llvm-project/pull/72654
>From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001
From: Shahid Iqbal
Date: Thu, 16 Nov 2023 11:26:43 -0500
Subject: [PATCH 1/4] TESTING infra
---
clang/NOTES.txt | 2 ++
1 file chang
https://github.com/shahidiqbal13 updated
https://github.com/llvm/llvm-project/pull/72654
>From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001
From: Shahid Iqbal
Date: Thu, 16 Nov 2023 11:26:43 -0500
Subject: [PATCH 1/3] TESTING infra
---
clang/NOTES.txt | 2 ++
1 file chang
https://github.com/shahidiqbal13 created
https://github.com/llvm/llvm-project/pull/72654
This issue is raised by @DrTodd13
The code in include/llvm/Analysis/DOTGraphTraitsPass.h will exceed most normal
file system's maximum filename length of 255 if, e.g., the function's name is
that length.
Hi
Please add me to a collaborator list , since I cannot assign an issue to
myself. I just want to ensure that no one works that particular issue.
My github handle is : * shahidiqbal13*
Regards
Shahid Iqbal
___
cfe-commits mailing list
cfe-commits@list
https://github.com/shahidiqbal13 closed
https://github.com/llvm/llvm-project/pull/72533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shahidiqbal13 created
https://github.com/llvm/llvm-project/pull/72533
Just a Test git review , will abandoned
>From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001
From: Shahid Iqbal
Date: Thu, 16 Nov 2023 11:26:43 -0500
Subject: [PATCH] TESTING infra
---
Hi,
I want to contribute in LLVM-clang from bug fixes perspective but cannot
assign a ticket/issue in github , please add me to contributor list
My github user: *shahidiqbal13*
Regards,
Shahid Iqbal
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
28 matches
Mail list logo
