[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added a comment. I dont have commit access, would someone be able to commit on my behalf? Thank You. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 ___

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372749. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372720. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:27 +// THINLTO-OLDPM-NOT: PGOIndirectCallPromotion +// THINLTO-OLDPM: Unroll loops +// THINLTO-OLDPM-NOT: Unroll loops When printing out passes wit

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372696. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added a comment. @tejohnson would you be able to take another look at this again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 ___ cfe-commits mail

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 371315. sherwin-dc added a comment. - Consolidate test cases into one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-sample-thinlt

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc marked 2 inline comments as done. sherwin-dc added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-pref

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 371040. sherwin-dc added a comment. [PGO] Change tests to look at passes run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-sample

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added a comment. I have changed the unroll and icp tests to instead look at the passes that were run, which are shown with the `-mllvm -opt-bisect-limit=-1` flag. This should allow checking that the Loop Unrolling and Indirect Call Promotion passes are run with samplepgo but not thin

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 371036. sherwin-dc edited the summary of this revision. sherwin-dc added a comment. [PGO] Change tests to look at which passes were run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://revie

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:25 // Checks if loop unroll is invoked by normal compile, but not thinlto compile. // SAMPLEPGO-LABEL: define {{(dso_local )?}}void @unroll tejohnson wrote: > It see

[PATCH] D109234: Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc created this revision. Herald added subscribers: ormris, wenlei, pengfei, steven_wu, hiraditya, inglorion. sherwin-dc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I am working on a target in a downstream LLVM repo, and it see