[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

smeenai added a comment. Herald added a project: All. This is very belated, sorry :) Our shadowing warnings have special behavior for lambdas and local variables: the warning for lambdas shadowing uncaptured local variables falls under `-Wshadow-uncaptured-local`, which isn't turned on for

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

smeenai added a comment. In D126397#3547060 , @thakis wrote: > Even after this, you still have to explicitly set > `-DCMAKE_SYSTEM_NAME=Darwin` when building clang for mac/arm on mac/intel. > Given that the host and target systems are both mac, that's

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

This revision was automatically updated to reflect the committed changes. Closed by commit rG4baae166ce33: [pseudo] Fix pseudo-gen usage when cross-compiling (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126397/new/

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

smeenai added a comment. In D126397#3537843 , @sammccall wrote: > Thank you! I have been banging my head against this, I'm not entirely sure > why this works and my version doesn't. Ah, sorry for the duplicated work :( Thanks for the review!

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

smeenai added a comment. In D125667#3537678 , @smeenai wrote: > In D125667#3537655 , @sammccall > wrote: > >> I'll see if I can fix it quickly, else will revert (there are a couple of >> fixes stacked on top

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

smeenai created this revision. smeenai added reviewers: hokein, sammccall. Herald added a subscriber: mgorny. Herald added a project: All. smeenai requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Use the LLVM build

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

smeenai added a comment. In D125667#3537655 , @sammccall wrote: > I'll see if I can fix it quickly, else will revert (there are a couple of > fixes stacked on top already, so revert isn't quite clean) Thank you! I'll have some time to look at this a

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

smeenai added a comment. This breaks cross-compilation, because we're building `pseudo-gen` for the target but then trying to run it on the build machine. You'll need to do something like TableGen does (see https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/CrossCompile.cmake

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

smeenai resigned from this revision. smeenai added a comment. LGTM after changing to an error with a warning downgrade. Resigning to clear my queue, plus the Apple folks should get the final accept here :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Herald added a subscriber: abrachet. Herald added a reviewer: libc++. Herald added projects: libc++abi, libunwind, All. Herald added a reviewer: libc++abi. Herald added a reviewer:

[PATCH] D122931: [CMake][compiler-rt] Support for using in-tree libc++

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. (clearing my queue while there are unaddressed comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122931/new/

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

smeenai added a comment. If I check out this commit and then check out the previous commit, `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp` and `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp.expected` become modified in my working directory; their

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

smeenai added a comment. In D124563#3478623 , @aaronpuchert wrote: > So maybe we should simply remove > > # These test input files rely on two-byte Windows (CRLF) line endings. > clang-apply-replacements/Inputs/crlf/crlf.cpp text eol=crlf >

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

smeenai added a comment. The following files have their line endings (when checked out on disk) changed from CRLF to LF by this patch. Seems harmless, but I just wanted to confirm that it was expected:

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

smeenai added a comment. I don't think many people are gonna notice a warning in the general spew of CMake configuration, tbh. Would it be too disruptive to make this an error instead and have a CMake option you can pass to get rid of the error? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D122965: Corrected A Command

smeenai added a comment. Thanks for the typo fix! Comment at: clang/test/CodeGen/c-unicode.c:5 int \uaccess = 0; // ALLOWED: "곎ss": // ALLOWED-NOT: "\uaccess": ps-19 wrote: > Comment Line No: 5 is // ALLOWED: "곎ss": i think "곎ss" in istake here, >

[PATCH] D118005: [hmaptool] Fix string decoding for Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4c1cbff79d0: [hmaptool] Fix string decoding for Python 3 (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118005/new/

[PATCH] D118004: [hmaptool] Fix dumping

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c1d330431f5: [hmaptool] Fix dumping (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118004/new/ https://reviews.llvm.org/D118004

[PATCH] D118005: [hmaptool] Fix string decoding for Python 3

smeenai created this revision. smeenai added a reviewer: bruno. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Our "strings" were actually bytes, which made verbose dumping fail. Decode them so they actually become strings.

[PATCH] D118004: [hmaptool] Fix dumping

smeenai created this revision. smeenai added a reviewer: bruno. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was complaining about too many values to unpack, since our struct unpack format string specified six members, but we

[PATCH] D116882: [docs] [clang] Small documentation change for compilation databases

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8467952404c: [docs] [clang] Small documentation change for compilation databases (authored by croepha, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93164: [AST] Add generator for source location introspection

smeenai added a comment. In D93164#3252509 , @lancethepants wrote: > In D93164#3250945 , @andrew-wja > wrote: > >> In D93164#3048130 , @lancethepants >> wrote: >> >>> In

[PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

smeenai added a comment. Herald added a subscriber: JDevlieghere. I believe you landed the wrong commit. rG859ebca744e634dcc89a2294ffa41574f947bd62 looks like the previous versions of this diff, where lots of extraneous

[PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere. This doesn't seem like a correct revert. What command are you using to generate this? `git revert` is what you should be using, e.g.

[PATCH] D93164: [AST] Add generator for source location introspection

smeenai added inline comments. Comment at: clang/lib/Tooling/CMakeLists.txt:29-30 +if (NOT Python3_EXECUTABLE +OR WIN32 +OR APPLE +OR GENERATOR_IS_MULTI_CONFIG I'm looking at this commit in the context of https://bugs.llvm.org/show_bug.cgi?id=52106.

[PATCH] D109506: [clangd] Print current request context along with the stack trace

smeenai added a comment. In D109506#3086183 , @thakis wrote: > This doesn't build on windows: http://45.33.8.238/win/47615/step_4.txt > > Please take a look and revert for now if it takes a while to fix. I pushed rGba94b8bdffb4

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

smeenai added a comment. In D110663#3029076 , @MaskRay wrote: > Prefer unnormalized over normalized (@smeenai) To be clear, I wasn't advocating for one ordering over the other, just pointing out the similarity to the prior state of things :) @phosek

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path

smeenai added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:494 + std::string Ret(P); + // When LLVM_DEFAULT_TARGET_TRIPLE uses Debian multiarch style + // "x86_64-linux-gnu" (no vendor part), use the unnormalized This is effectively reverting

[PATCH] D89177: [cmake] Add support for multiple distributions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56f7e5a822b4: [cmake] Add support for multiple distributions (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 344666. smeenai added a comment. Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai marked 3 inline comments as done. smeenai added inline comments. Comment at: llvm/cmake/modules/LLVMDistributionSupport.cmake:39 +# default (unnamed) distribution. +set_property(GLOBAL PROPERTY LLVM_DISTRIBUTION_FOR_${target} " ") + endforeach()

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 344299. smeenai added a comment. Uppercase variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 343949. smeenai added a comment. Helper function to get install arg. TODO: Address other review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files:

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 343946. smeenai added a comment. Herald added subscribers: dcaballe, cota, teijeong. Rebase (comments not addressed yet; uploading a pure rebase for easier version comparison) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99322: [clang] Pass option directly to command. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33930a0787f6: [clang] Pass option directly to command. NFC (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99321: [clang] Always execute multi-stage install steps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0135bc996d82: [clang] Always execute multi-stage install steps (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D99322: [clang] Pass option directly to command. NFC

smeenai created this revision. smeenai added reviewers: beanz, phosek, tstellar. Herald added a subscriber: mgorny. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This code was written back when LLVM's minimum required CMake

[PATCH] D99321: [clang] Always execute multi-stage install steps

smeenai created this revision. smeenai added reviewers: beanz, phosek, tstellar. Herald added a subscriber: mgorny. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want installs to be executed even if binaries haven't changed,

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

smeenai added a comment. Got it, thanks for all the info! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96403/new/ https://reviews.llvm.org/D96403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

smeenai added a comment. In D96403#2638932 , @rprichard wrote: > In D96403#2638883 , @smeenai wrote: > >> With NDK r22, I only see libunwind.a for armv7. Will it be provided for >> other architectures in future

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

smeenai added subscribers: lanza, smeenai. smeenai added a comment. With NDK r22, I only see libunwind.a for armv7. Will it be provided for other architectures in future NDK versions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96403/new/

[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

smeenai added a comment. Hilariously enough, this breaks building compiler-rt itself inside LLVM's runtime builds setup for us. The runtimes build setup builds clang and then uses the just-built clang to build compiler-rt. That build fails to link since my just-built clang doesn't have

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a2a167b6ca7: [DirectoryWatcher] Increase timeout to make test less flaky (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

smeenai added a comment. In D97878#2602077 , @plotfi wrote: > This makes sense to me. I approve. Can we move the 3/60 seconds number to a > const int value set somewhere higher up in the file as a global with a > comment explaining this as well?

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

smeenai updated this revision to Diff 328283. smeenai added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/ https://reviews.llvm.org/D97878 Files:

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

smeenai created this revision. smeenai added reviewers: jkorous, arphaman, akyrtzi, gribozavr. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We've observed this test being significantly flaky on our Mac CI machines when we're

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

smeenai added a comment. In D92808#2593331 , @ahatanak wrote: > In D92808#2593204 , @thakis wrote: > >> FYI, we're seeing test failures caused by this patch in iOS/arm64 builds >> when arc is used (simulator is

[PATCH] D97817: [CMake] Rename check-clang-tools to check-clang-tools-extra

smeenai added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:81 -add_lit_testsuite(check-clang-tools "Running the Clang extra tools' regression tests" +add_lit_testsuite(check-clang-tools-extra "Running the Clang tools extra' regression tests"

[PATCH] D97817: [CMake] Rename check-clang-tools to check-clang-tools-extra

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM. If you care about eventually getting rid of the old `check-clang-tools` alias, you'd want to have a mailing list announcement/deprecation notices/etc. (I don't think leaving it

[PATCH] D95204: [lld-macho] Switch default to new Darwin port

smeenai added inline comments. Comment at: llvm/utils/gn/build/BUILD.gn:240 if (host_os == "mac") { - ldflags += [ "-fuse-ld=lld.darwinnew" ] + ldflags += [ "-fuse-ld=ld64.lld" ] } else { I'm pretty sure `-fuse-ld=ld64.lld` won't work ... the

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

smeenai added a comment. I saw this on LLVM Weekly, and I like it a lot :) Now if only Windows could case-correct their SDKs so we didn't need VFS overlays and symlinks for the linker... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

This revision was automatically updated to reflect the committed changes. Closed by commit rG0066a09579ca: [libc++] Give extern templates default visibility on gcc (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

smeenai added a comment. It's been a long time since I've contributed to libc++, and the pre-merge CI setup is a massive improvement over what we had before. A huge kudos to everyone who made it possible :) This is still showing up as Needs Review. I'm not sure if that's because of @EricWF's

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

smeenai updated this revision to Diff 316161. smeenai added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

smeenai added a comment. Sorry, I seem to have somehow blanked out on this diff entirely. Is it still relevant? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/ https://reviews.llvm.org/D35388

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

smeenai added a reviewer: compnerd. smeenai resigned from this revision. smeenai added a subscriber: compnerd. smeenai added a comment. I'm super excited to see this happen, but it's also well out of my review comfort zone, unfortunately. Adding @compnerd to take a look. Repository: rG LLVM

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

smeenai added a comment. In D45639#2360619 , @smeenai wrote: > In D45639#2360267 , @ldionne wrote: > >> - AppleClang prefers the headers in the SDK, and the library in the SDK. >> (The headers are currently still

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:121 + set(export_to_clangtargets EXPORT Clang${distribution}Targets) + set_property(GLOBAL PROPERTY CLANG${distribution}_HAS_EXPORTS True) endif() phosek

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90517: [clangd] Account for vendor in version string

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bd01b8184de: [clangd] Account for vendor in version string (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90517/new/

[PATCH] D90516: [clang] Limit scope of CLANG_VENDOR definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e4ab8e0152b: [clang] Limit scope of CLANG_VENDOR definition (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90528: [clangd] Fix check-clangd with no clang built

smeenai added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90528/new/ https://reviews.llvm.org/D90528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90518: [clangd] Make tests depend on Clang

smeenai abandoned this revision. smeenai added a comment. Cool, thanks for fixing it better! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90518/new/ https://reviews.llvm.org/D90518 ___ cfe-commits

[PATCH] D90518: [clangd] Make tests depend on Clang

smeenai created this revision. smeenai added reviewers: jkorous, kadircet, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. smeenai requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The clangd lit

[PATCH] D90516: [clang] Limit scope of CLANG_VENDOR definition

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek, tstellar. Herald added subscribers: cfe-commits, dexonsmith, mgorny. Herald added a project: clang. smeenai requested review of this revision. It's only used by Version.cpp, so limit the definition to just that one

[PATCH] D90517: [clangd] Account for vendor in version string

smeenai created this revision. smeenai added reviewers: sammccall, kadircet, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. smeenai requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The vendor will be prefixed

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

smeenai added a comment. In D45639#2360267 , @ldionne wrote: > - AppleClang prefers the headers in the SDK, and the library in the SDK. (The > headers are currently still shipped in the toolchain but they should be > ignored if you have a sufficiently

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Ping. Assuming everyone is okay with the direction, any comments on the change itself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. In D89177#2332675 , @beanz wrote: > In D89177#2332627 , @ldionne wrote: > >> That isn't what I meant. It's entirely okay for the runtimes to be driven >> via `AddExternalProject` like the

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a subscriber: ldionne. smeenai added a comment. In D89177#2326875 , @phosek wrote: > In D89177#2326832 , @smeenai wrote: > >> In D89177#2325566 , @phosek

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 298251. smeenai added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Reading up on the Ninja multi-config generator a bit, you can define your own build types, so you should be able to create e.g. one build type for LTO and another for PIC. You'd still need some external logic to define that you use the LTO mode for executables and the

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. In D89177#2325566 , @phosek wrote: > We've already considered introducing a similar mechanism so thank you for > working on this! There's one issue that I haven't figured out how to resolve > and I'd be interested in your

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek, tstellar. Herald added subscribers: llvm-commits, cfe-commits, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle,

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

smeenai added a comment. What was the conclusion for the comments about the priority level (100 vs. 101)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31413/new/ https://reviews.llvm.org/D31413 ___

[PATCH] D85362: [CMake] Print the autodetected host linker version

smeenai accepted this revision. smeenai added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85362/new/ https://reviews.llvm.org/D85362 ___ cfe-commits mailing list

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Oops, missed that I'd become a blocking reviewer for this (cos of requesting changes before). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

smeenai added a comment. Super late to the party here, sorry. I don't understand why the type of linking needs to be changed depending on if the library is static or shared. If a static library A depends on a static library B as PRIVATE, and then executable C links to A, CMake will make sure

[PATCH] D82694: [clang-shlib] Don't link with static clang libraries

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82694/new/ https://reviews.llvm.org/D82694

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

smeenai added inline comments. Comment at: llvm/docs/CodingStandards.rst:1600 + // Omit the braces, since the body is simple and clearly associated with the if. + if (isa(D)) +handleFunctionDecl(D); I'm late to the party here (and I haven't read the

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Requesting changes to remove from my review queue while the above comments are being addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

smeenai added inline comments. Comment at: lld/test/lit.site.cfg.py.in:16 config.target_triple = "@TARGET_TRIPLE@" -config.python_executable = "@Python3_EXECUTABLE@" -config.have_zlib = @HAVE_LIBZ@ +config.python_executable = "@PYTHON_EXECUTABLE@" +config.have_zlib =

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c9230dad169: Reland [libclang] Install both libclang.a and libclang.so when… (authored by zhuhan0, committed by smeenai). Changed prior to commit: https://reviews.llvm.org/D79059?vs=262506=262530#toc

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added a comment. Committed. Please let me know of any buildbot failure emails you receive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 ___

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added a comment. Do you need me to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 ___ cfe-commits mailing list

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Sorry for the delayed review here. I'm not the biggest fan of this cos it's encoding knowledge of `llvm_add_library`'s internal behavior (that it creates a `*_static` target if both STATIC

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

smeenai added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:52 + // The maximum size depends on size_type used. + static constexpr size_t SizeMax() { +return std::numeric_limits::max(); browneee wrote: > dexonsmith wrote: > > STL data

[PATCH] D78762: build: use `find_package(Python3)` if available

smeenai added a comment. In D78762#2006406 , @JDevlieghere wrote: > I talked to Saleem and he cleared up some of my concerns. Given that the > community seems to have agreed to support only Python 3, this change seems a > lot more reasonable. My

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8990feb125a: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON (authored by zhuhan0, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added a comment. Committed. Please forward any buildbot failure emails to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 ___ cfe-commits mailing

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added a comment. @zhuhan0, do you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 ___ cfe-commits mailing list

[PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. With the newer minimum CMake version, we can eliminate a bunch of the policy settings as well, but that can be a follow-up (especially given this isn't gonna ship for a few months).

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added reviewers: beanz, phosek. smeenai added subscribers: phosek, beanz. smeenai added a comment. This makes sense to me, but I'd like @beanz and/or @phosek to take a look as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

smeenai added a comment. Thanks for that explanation; that makes sense. Do you think that the `@interface J : I` would also ideally be an error then? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66831/new/ https://reviews.llvm.org/D66831

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

smeenai added a comment. Sorry for the late feedback here – we're in the process of testing with Clang 10 and noticed a behavior change caused by this commit. Consider the following piece of code: @protocol P @end @protocol Q @end @interface I @end @interface J : I

[PATCH] D74996: [arcconfig] Delete subproject arcconfigs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe34ddc09f464: [arcconfig] Delete subproject arcconfigs (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74996/new/

[PATCH] D74996: [arcconfig] Delete subproject arcconfigs

smeenai created this revision. smeenai added reviewers: jyknight, phosek, rnk. Herald added a reviewer: bollu. Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits.

<    1   2   3   4   5   6   7   8   >