Naysh marked an inline comment as done.
Naysh added inline comments.
Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:41
+// to the vector containing all candidate using declarations.
+if (AnonymousNamespaceDecl) {
+ diag(MatchedUsingDecl->get
Naysh marked an inline comment as done.
Naysh added inline comments.
Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13
+The style guide http://google.github.io/styleguide/cppguide.html#Aliases
discusses this
+issue in more detail
aaron.ballman
Naysh added inline comments.
Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13
+The style guide http://google.github.io/styleguide/cppguide.html#Aliases
discusses this
+issue in more detail
Eugene.Zelenko wrote:
> Missing link to guidelines,
@
Naysh created this revision.
Naysh added reviewers: EricWF, JonasToth.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
This patch adds an "Alias Free Headers" check, based off the guidelines at
http://google.github.io/styleguide/cppguide.html#Aliases, to the abseil module.
The purpose
Naysh updated this revision to Diff 177116.
Naysh retitled this revision from "[clang-tidy] check for using declaration
scope and qualification" to "[clang-tidy] check for using declaration
qualification".
Naysh edited the summary of this revision.
Naysh added a comment.
Based off the request to
Naysh created this revision.
Naysh added reviewers: EricWF, JonasToth.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
This patch adds four new, small checks corresponding to the guidelines in
https://abseil.io/tips/119.
The checks are:
- Alias Free Headers: makes sure header files do