tyb0807 added a comment.
The patch looks correct to me, but looking at
https://github.com/ARM-software/acle/blob/main/main/acle.md where all the ACLE
macros are defined, I'm not sure that `__ARM_FEATURE_RCPC` is there currently.
Maybe you also want to submit a patch there, or at least explain
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9a015ee1f948: [AArch64] Avoid scanning feature list for
target parsing (authored by tyb0807).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb93893e60f0c: [AArch64] Default HBC/MOPS features in clang
(authored by tyb0807).
Herald added a subscriber: MaskRay.
Herald added a project: All.
tyb0807 updated this revision to Diff 419866.
tyb0807 added a comment.
Herald added a subscriber: MaskRay.
Refactor fp16 feature handling and add more fp16 tests for v8.5 and later
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120864/new/
tyb0807 added a comment.
> Yeah that sounds good. Maybe aarch64-cortex-cpus.c might be a good start, to
> avoid having too many small files.
Oops, I went ahead and split to many small cortex test files. Not really sure
what would be better. What do you think @simon_tatham @fhahn @tmatheson ?
tyb0807 marked 2 inline comments as done.
tyb0807 added inline comments.
Comment at: clang/test/Driver/aarch64-archs.c:296
-// NO-LS64-NOT: "-target-feature" "+ls64"
-// LS64: "-target-feature" "+ls64"
-
tmatheson wrote:
> Looks like these were duplicate tests?
tyb0807 marked an inline comment as done.
tyb0807 added inline comments.
Comment at: clang/test/Driver/aarch64-cpus.c:2
+// Check target CPUs are correctly passed.
+// TODO: The files should be split up by categories, e.g. by architecture
versions, to avoid excessive test
//
tyb0807 created this revision.
tyb0807 added reviewers: dmgreen, lenary, tmatheson, simon_tatham, fhahn.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
tyb0807 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is
tyb0807 added a comment.
Thanks for making this change. However, I think a better split would be
- List Item
`aarch64-cpus.c` which contains cpu-specific test cases (usually with `-mcpu`
flag). Roughly this is until line 515, plus some last test cases from line 926
to end.
`aarch64-archs.c`
tyb0807 updated this revision to Diff 412592.
tyb0807 added a comment.
Update logic to define crypto extensions, strictly following the old
implementation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120864/new/
https://reviews.llvm.org/D120864
tyb0807 created this revision.
tyb0807 added reviewers: tmatheson, nickdesaulniers, chill.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
tyb0807 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As discussed in
tyb0807 updated this revision to Diff 412010.
tyb0807 added a comment.
Taking into account remarks from @tmatheson, I'm reverting my latest changes
consisting in caching architecture feature into a variable, which makes the
`getAArch64ArchFeaturesFrom*` interfaces more complicated.
I'd propose
tyb0807 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:269
success = getAArch64MicroArchFeaturesFromMcpu(
-D, getAArch64TargetCPU(Args, Triple, A), Args, Features);
+D, getAArch64TargetCPU(Args, Triple, A), Args, Features,
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8e10448cbbd9: [AArch64] Remove unused feature flags from
AArch64TargetInfo (authored by tyb0807).
Repository:
rG LLVM Github Monorepo
CHANGES
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG650aec687eb5: [ARM][AArch64] Add missing v8.x checks
(authored by tyb0807).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
tyb0807 updated this revision to Diff 410418.
tyb0807 added a comment.
Revert latest change, as it is likely that people still rely on
`ARM_FEATURE_CRYPTO`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118757/new/
https://reviews.llvm.org/D118757
tyb0807 updated this revision to Diff 410403.
tyb0807 added a comment.
Add checks for default ACLE macros for different architecture versions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116153/new/
https://reviews.llvm.org/D116153
Files:
tyb0807 added inline comments.
Comment at: clang/lib/Basic/Targets/ARM.cpp:958
case llvm::ARM::ArchKind::ARMV8_6A:
+ case llvm::ARM::ArchKind::ARMV8_7A:
case llvm::ARM::ArchKind::ARMV8_8A:
SjoerdMeijer wrote:
> tyb0807 wrote:
> > SjoerdMeijer wrote:
> > >
tyb0807 added inline comments.
Comment at: clang/lib/Basic/Targets/ARM.cpp:958
case llvm::ARM::ArchKind::ARMV8_6A:
+ case llvm::ARM::ArchKind::ARMV8_7A:
case llvm::ARM::ArchKind::ARMV8_8A:
SjoerdMeijer wrote:
> I see tests for the crypto stuff, but is
tyb0807 updated this revision to Diff 410310.
tyb0807 edited the summary of this revision.
tyb0807 added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116153/new/
https://reviews.llvm.org/D116153
Files:
tyb0807 marked 2 inline comments as done.
tyb0807 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:464-473
+ const char *v8691OrLater[] = {"+v8.6a", "+v8.7a", "+v8.8a",
+ "+v9.1a", "+v9.2a", "+v9.3a"};
auto Pos =
tyb0807 updated this revision to Diff 410225.
tyb0807 added a comment.
Cache architecture feature to avoid scanning the feature list over and over
again.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120111/new/
https://reviews.llvm.org/D120111
tyb0807 created this revision.
Herald added a subscriber: kristof.beyls.
tyb0807 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This implements minimum support in clang for default HBC/MOPS features
on v8.8-a/v9.3-a or later
tyb0807 updated this revision to Diff 409796.
tyb0807 added a comment.
Remove reference to unused ACLE macro `__ARM_FEATURE_CRYPTO`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118757/new/
https://reviews.llvm.org/D118757
Files:
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc70b93508901: [AArch64] ACLE feature macro for Armv8.8-A
MOPS (authored by tyb0807).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
tyb0807 updated this revision to Diff 407159.
tyb0807 added a comment.
Turn off warnings for negative tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118199/new/
https://reviews.llvm.org/D118199
Files:
clang/lib/Basic/Targets/AArch64.cpp
tyb0807 updated this revision to Diff 407155.
tyb0807 added a comment.
Fix buildbots failures
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118199/new/
https://reviews.llvm.org/D118199
Files:
clang/lib/Basic/Targets/AArch64.cpp
tyb0807 reopened this revision.
tyb0807 added a comment.
This revision is now accepted and ready to land.
Reverted due to buildbots failures
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118199/new/
https://reviews.llvm.org/D118199
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd379ec99085e: [AArch64] ACLE feature macro for Armv8.8-A
MOPS (authored by tyb0807).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
tyb0807 abandoned this revision.
tyb0807 added a comment.
This is superseded by https://reviews.llvm.org/D118199. Comments have been
addressed in the new patch. I should have commandeered this patch instead (did
not know about this, sorry...).
Repository:
rG LLVM Github Monorepo
CHANGES
tyb0807 marked 2 inline comments as done.
tyb0807 added inline comments.
Comment at: clang/lib/Basic/Targets/ARM.cpp:937
case llvm::ARM::ArchKind::ARMV9_2A:
getTargetDefinesARMV83A(Opts, Builder);
break;
SjoerdMeijer wrote:
> Perhaps unrelated to
tyb0807 updated this revision to Diff 405786.
tyb0807 edited the summary of this revision.
tyb0807 added a comment.
Add more tests
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116153/new/
https://reviews.llvm.org/D116153
Files:
clang/lib/Basic/Targets/ARM.cpp
tyb0807 added a comment.
TL;DR, I think these `Has*` flags have different meaning in different places of
the code base.
IIUC, these `Has*` flags from `clang/lib/Basic/Targets/AArch64.cpp` are used to
correctly set various macros from the processed command line options, notable
ones from ACLE,
tyb0807 created this revision.
Herald added a subscriber: kristof.beyls.
tyb0807 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This removes two feature flags from `AArch64TargetInfo` class:
- `HasHBC`: this feature does not involve
tyb0807 updated this revision to Diff 405085.
tyb0807 added a comment.
Remove prefix from tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118199/new/
https://reviews.llvm.org/D118199
Files:
clang/lib/Basic/Targets/AArch64.cpp
tyb0807 updated this revision to Diff 405083.
tyb0807 added a comment.
Update tests with `clang -Xclang -verify`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118199/new/
https://reviews.llvm.org/D118199
Files:
tyb0807 added inline comments.
Comment at: clang/lib/Basic/Targets/AArch64.cpp:229
MacroBuilder ) const {
+ // FIXME: this does not handle the case where MOPS is disabled using +nomops
+ Builder.defineMacro("__ARM_FEATURE_MOPS",
tyb0807 updated this revision to Diff 405080.
tyb0807 marked an inline comment as done.
tyb0807 added a comment.
Update tests with `clang_cc1 -verify`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118199/new/
https://reviews.llvm.org/D118199
tyb0807 updated this revision to Diff 404897.
tyb0807 added a comment.
Revert latest patchset, as it should be put into a separate commit for clarity
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118199/new/
https://reviews.llvm.org/D118199
tyb0807 updated this revision to Diff 404854.
tyb0807 added a comment.
Add support for `+nomops`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118199/new/
https://reviews.llvm.org/D118199
Files:
clang/lib/Basic/Targets/AArch64.cpp
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG51e188d079f6: [AArch64] Support for memset tagged intrinsic
(authored by tyb0807).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
tyb0807 updated this revision to Diff 404347.
tyb0807 added a comment.
Add more tests and update accordingly to change from ACLE specification:
`__builtin_arm_mops_memset_tag` requires _both_ MOPS and MTE features
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
tyb0807 updated this revision to Diff 403687.
tyb0807 marked 3 inline comments as done.
tyb0807 edited the summary of this revision.
tyb0807 added a comment.
Update link to the relevant section of ACLE specification
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
tyb0807 updated this revision to Diff 403686.
tyb0807 marked an inline comment as done.
tyb0807 added a comment.
Update accordingly to change from ACLE specification:
`__builtin_arm_mops_memset_tag` required _both_ MOPS and MTE features
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
tyb0807 added a comment.
Yes, https://reviews.llvm.org/D116160 is deprecated and will be abandoned.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118199/new/
https://reviews.llvm.org/D118199
___
tyb0807 created this revision.
Herald added a subscriber: kristof.beyls.
tyb0807 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This introduces the new __ARM_FEATURE_MOPS ACLE feature test macro,
which signals the availability of the new
tyb0807 marked an inline comment as done.
tyb0807 added inline comments.
Comment at: clang/test/CodeGen/aarch64-mops.c:3
+
+// RUN: %clang_cc1 -triple aarch64-arm-unknown-eabi -target-feature +mops -S
-emit-llvm -o - %s | FileCheck %s
+
SjoerdMeijer wrote:
> I
tyb0807 updated this revision to Diff 401973.
tyb0807 edited the summary of this revision.
tyb0807 added a comment.
Update reference to ACLE specification
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117753/new/
https://reviews.llvm.org/D117753
tyb0807 updated this revision to Diff 401851.
tyb0807 marked 2 inline comments as done.
tyb0807 added a comment.
`__ARM_FEATURE_MEMORY_TAGGING` not needed to enable
`__builtin_arm_mops_memset_tag`.
Follow variable naming convention.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
tyb0807 marked 3 inline comments as done.
tyb0807 added inline comments.
Comment at: clang/lib/Headers/arm_acle.h:734
+/* Memory Operations Intrinsics */
+#if __ARM_FEATURE_MOPS && __ARM_FEATURE_MEMORY_TAGGING
+#define __arm_mops_memset_tag(tagged_address, value, size)
tyb0807 marked 8 inline comments as done.
tyb0807 added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:836
+ // inside a bundle to prevent other passes to moving things in between.
+ MIBundleBuilder Bundler(MBB, MBBI);
+ auto =
tyb0807 added a comment.
Following Dave's comments above, this patch is now split to 4 different patches
https://reviews.llvm.org/D117753
https://reviews.llvm.org/D117757
https://reviews.llvm.org/D117763
https://reviews.llvm.org/D117764
and may now be abandoned.
Repository:
rG LLVM Github
tyb0807 updated this revision to Diff 401534.
tyb0807 edited the summary of this revision.
tyb0807 added a comment.
Update commit message to clarify context.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117753/new/
tyb0807 created this revision.
Herald added a subscriber: kristof.beyls.
tyb0807 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This introduces a new ACLE intrinsic for memset tagged (see
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc84b8be516bc: [AArch64] clang support for Armv8.8/9.3 MOPS
(authored by pratlucas, committed by tyb0807).
Repository:
rG LLVM Github Monorepo
tyb0807 created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
tyb0807 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This introduces clang command line support for the new Armv8.8-A and
Armv9.3-A
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
tyb0807 marked an inline comment as done.
Closed by commit rG2db4cf5962de: clang support for Armv8.8/9.3 HBC (authored by
tmatheson, committed by tyb0807).
tyb0807 marked 2 inline comments as done.
tyb0807 added inline comments.
Comment at: clang/lib/Basic/Targets/AArch64.cpp:666-675
+ HasHBC |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A ||
+ArchKind == llvm::AArch64::ArchKind::ARMV9_3A;
+
+ // Check features that
tyb0807 updated this revision to Diff 399341.
tyb0807 marked an inline comment as done.
tyb0807 added a comment.
Removed checks that set HBC flag based on the target architecture and unset it
if command line explicitly disables it. This is because HBC feature does not
require any new intrinsic in
tyb0807 updated this revision to Diff 398698.
tyb0807 edited the summary of this revision.
tyb0807 added a comment.
Update patch author in commit message.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116939/new/
https://reviews.llvm.org/D116939
tyb0807 updated this revision to Diff 398697.
tyb0807 added a comment.
Update patch author in commit message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116939/new/
https://reviews.llvm.org/D116939
Files:
clang/lib/Basic/Targets/AArch64.cpp
tyb0807 updated this revision to Diff 398693.
tyb0807 added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116939/new/
https://reviews.llvm.org/D116939
Files:
clang/lib/Basic/Targets/AArch64.cpp
tyb0807 updated this revision to Diff 398638.
tyb0807 added a comment.
Support for MOPS extension should be committed in a separate patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116939/new/
https://reviews.llvm.org/D116939
Files:
tyb0807 updated this revision to Diff 398624.
tyb0807 edited the summary of this revision.
tyb0807 added a comment.
Add more context to the patch summary
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116939/new/
https://reviews.llvm.org/D116939
tyb0807 updated this revision to Diff 398623.
tyb0807 edited the summary of this revision.
tyb0807 added a comment.
Remove Change-Id
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116939/new/
https://reviews.llvm.org/D116939
Files:
tyb0807 created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
tyb0807 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This introduces clang command line support for new Armv8.8-A and
Armv9.3-A Hinted
tyb0807 updated this revision to Diff 394120.
tyb0807 edited the summary of this revision.
tyb0807 added a comment.
Update commit message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115694/new/
https://reviews.llvm.org/D115694
Files:
tyb0807 updated this revision to Diff 394116.
tyb0807 added a comment.
Allow linting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115694/new/
https://reviews.llvm.org/D115694
Files:
clang/lib/Basic/Targets/AArch64.cpp
tyb0807 created this revision.
Herald added subscribers: dexonsmith, hiraditya, kristof.beyls.
tyb0807 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This commit should contain all the necessary boilerplate to make the
tyb0807 reopened this revision.
tyb0807 added a comment.
Hello all,
This commit has been reverted by https://reviews.llvm.org/rC345026. It was
reported that this broke the Chromium build (again). Have you had a look to fix
this, @HsiangKai?
Repository:
rC Clang
70 matches
Mail list logo
