[PATCH] D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.

sstefan1 closed this revision. sstefan1 added a comment. Commited in rGfbfb1c790982 . Forgot to add the revision link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86021/new/

[PATCH] D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.

sstefan1 added a comment. @nikic do you have a preference on any of the suggested names? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86021/new/ https://reviews.llvm.org/D86021 ___ cfe-commits mailing

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

sstefan1 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:38 + /// An OpenMP-IR-Builder instance. + llvm::OpenMPIRBuilder OMPBuilder; + jhuber6 wrote: > sstefan1 wrote: > > There's already an instance of `OpenMPIRBuilder` in

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

sstefan1 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:38 + /// An OpenMP-IR-Builder instance. + llvm::OpenMPIRBuilder OMPBuilder; + There's already an instance of `OpenMPIRBuilder` in `CGOpenMPRuntime`. Maybe just make it

[PATCH] D86769: [UpdateTestChecks] include { in function signature check line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7128e647063d: [UpdateTestChecks] include { in function signature check line (authored by sstefan1). Herald added subscribers: cfe-commits,

[PATCH] D83629: [Utils] Check function attributes in update_test_checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG937bad3594e7: [Utils] Check function attributes in update_test_checks (authored by sstefan1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

sstefan1 added a comment. Just in case you haven't seen already, `clang/test/OpenMP/barrier_codegen.cpp` needs to be updated as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81031/new/ https://reviews.llvm.org/D81031

[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6aab27ba851f: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder. (authored by sstefan1). Changed prior to

[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6aab27ba851f: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder. (authored by sstefan1). Changed prior to commit: https://reviews.llvm.org/D83176?vs=275549=276445#toc Repository: rG

[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

sstefan1 updated this revision to Diff 275549. sstefan1 added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83176/new/ https://reviews.llvm.org/D83176 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGExpr.cpp

[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

sstefan1 marked an inline comment as done. sstefan1 added a subscriber: hoyFB. sstefan1 added a comment. Since this is not a small change, I think it would be good if @hoyFB could test if this resolves the issue. There is one small issue though: Comment at:

[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

sstefan1 created this revision. sstefan1 added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, aaron.ballman, dexonsmith, guansong, hiraditya, yaxunl. Herald added projects: clang, LLVM. D82193 exposed a problem with global type

[PATCH] D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG72b51d6f93b5: OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime… (authored by sstefan1). Changed prior to commit: https://reviews.llvm.org/D75010?vs=250599=252572#toc

[PATCH] D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.

sstefan1 updated this revision to Diff 250599. sstefan1 added a comment. more tests couldn't get `update_test_checks.py` to update function signatures, even with the flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75010/new/

[PATCH] D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.

sstefan1 updated this revision to Diff 249695. sstefan1 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75010/new/ https://reviews.llvm.org/D75010