[PATCH] D93164: [AST] Add generator for source location introspection

steveire added inline comments. Comment at: clang/lib/Tooling/CMakeLists.txt:29-30 +if (NOT Python3_EXECUTABLE +OR WIN32 +OR APPLE +OR GENERATOR_IS_MULTI_CONFIG smeenai wrote: > I'm looking at this commit in the context of >

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

steveire added a comment. FYI - there's nothing "anti-inclusive" about East/West. In Qt I proposed a change which added properties to an object. Those properties in my change were named "Left"/"Right". The reviewer objected to those names because "scripts which are not Right-to-Left exist". So

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. Making a separate tool for this makes no sense. Especially as you are only proposing it to satisfy one (or are there more) vocal objector. The objections to this make no sense. If you don't want to use it, then don't enable it. That principle applies whether "the way

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. In D69764#2867109 , @MyDeveloperDay wrote: > In D69764#2863648 , @owenpan wrote: > >> Has this been tested against a large code base? It also needs an unqualified >> LGTM before it can

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. In D69764#2863266 , @aaron.ballman wrote: > In D69764#2863213 , @steveire wrote: > >> @MyDeveloperDay Does anything prevent this being merged, instead of just >> rebased? > > Please see

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. @MyDeveloperDay Does anything prevent this being merged, instead of just rebased? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___ cfe-commits mailing list

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5c7c5d8230: Widen `name` stencil to support `TypeLoc` nodes. (authored by SilensAngelusNex, committed by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

steveire added a comment. I'm not certain what strong opinions I've voiced on the mailing list about that. Was it just that I think `hasDescendant` can lead to unexpected matches and a more-specific matcher should always be used when available (such as `hasArgument`)? I do think `has`,

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

steveire added a reviewer: ymandel. steveire added a comment. Adding Yitzhak as a reviewer. I notice that at least the name of a cxxBaseSpecifier is not supported and I don't know if that (or lack of typeloc support) is desired in the Transformer design. Repository: rG LLVM Github Monorepo

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f65f42dd37a: Make `hasTypeLoc` matcher support more node types. (authored by SilensAngelusNex, committed by stephenkelly). Changed prior to

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. This looks good to me. I tried running it in clang-query, which crashes with a matcher like m binaryOperator(hasEitherOperand(hasTypeLoc(loc(asString("int") but it also crashes

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

steveire added a comment. Please run `llvm-project/clang/docs/tools/dump_ast_matchers.py` to generate updated documentation for this (there is a `urlopen(url)` which slows things down, so I usually comment that out when running it). Do you have this on a git clone somewhere? It's easier to

[PATCH] D101614: [clang-tidy][NFC] Simplify a lot of bugprone-sizeof-expression matchers

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. LGTM, but I think you could split it into 3 commits with a commit message saying what each is doing. "Simplify a lot of" doesn't say anything specific about what this patch does. It looks

[PATCH] D101614: [clang-tidy][NFC] Simplify a lot of bugprone-sizeof-expression matchers

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp:87 const auto IntegerExpr = ignoringParenImpCasts(integerLiteral()); - const auto ConstantExpr = expr(ignoringParenImpCasts( + const auto ConstantExpr =

[PATCH] D101572: Make `hasTypeLoc` matcher support nodes of type `CXXFunctionalCastExpr` and `CXXTemporaryObjectExpr`.

steveire added a comment. In D101572#2730012 , @SilensAngelusNex wrote: > Yes, the motivation for adding these is so I can use clang-transformer to > refactor a bunch of constructor calls to call a static factory method instead. > > // Before >

[PATCH] D101589: [AST] Add Concept-related locations to node introspection

steveire created this revision. steveire added a reviewer: njames93. Herald added a subscriber: mgrang. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This would be less complicated if the ReturnTypeRequirement were not a nested

[PATCH] D101572: Make `hasTypeLoc` matcher support nodes of type `CXXFunctionalCastExpr` and `CXXTemporaryObjectExpr`.

steveire added a reviewer: stephenkelly. steveire added a comment. According to llvm-project/clang/include/clang/AST$ git grep "TypeSourceInfo.*const" there are lots of other classes with `TypeSourceInfo` accessors which could be supported here. Should any others be supported? Is something

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

steveire added a comment. I implemented something like this recently too. The code I was trying to refactor was something like auto ii = 0; for (ii = 0; ii < thing.size(); ++ii) { // code } // code for (ii = 0; ii < thing.size(); ++ii) { // code } // code for (ii

[PATCH] D101346: [AST] Fix getExprLoc reported for cxxDependentScopeMemberExpr

steveire updated this revision to Diff 340994. steveire added a comment. Fix windows build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101346/new/ https://reviews.llvm.org/D101346 Files: clang/include/clang/AST/ExprCXX.h

[PATCH] D101365: [clang-query] Add check to prevent setting srcloc when no introspection is available.

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/unittests/clang-query/QueryParserTest.cpp:249 + EXPECT_EQ("dump ", Comps[3 + static_cast(HasIntrospection)].TypedText); +

[PATCH] D101346: [AST] Fix getExprLoc reported for cxxDependentScopeMemberExpr

steveire updated this revision to Diff 340762. steveire added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101346/new/ https://reviews.llvm.org/D101346 Files: clang/include/clang/AST/ExprCXX.h

[PATCH] D101346: [AST] Fix getExprLoc reported for cxxDependentScopeMemberExpr

steveire created this revision. steveire added a reviewer: rsmith. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All other CallExpr use the location of the member name as the getExprLoc: https://godbolt.org/z/jx16G9Gdr

[PATCH] D93325: Add srcloc output to clang-query

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d018c79ee5f: Add srcloc output to clang-query (authored by stephenkelly). Changed prior to commit:

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9676febb99d: [AST] Add DeclarationNameInfo to node introspection (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101049/new/

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

steveire updated this revision to Diff 340049. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101049/new/ https://reviews.llvm.org/D101049 Files: clang/include/clang/Tooling/NodeIntrospection.h

[PATCH] D101054: [AST] Sort introspection results without instantiating other data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35918bcb6f50: [AST] Sort introspection results without instantiating other data (authored by stephenkelly). Repository: rG LLVM Github Monorepo

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

steveire updated this revision to Diff 339793. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101049/new/ https://reviews.llvm.org/D101049 Files: clang/include/clang/Tooling/NodeIntrospection.h

[PATCH] D93325: Add srcloc output to clang-query

steveire updated this revision to Diff 339583. steveire added a comment. Herald added a subscriber: mgrang. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325 Files:

[PATCH] D101054: [AST] Sort introspection results without instantiating other data

steveire created this revision. steveire added a reviewer: njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid string allocation in particular, but also avoid attempting to impose any particular ordering based on

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

steveire updated this revision to Diff 339563. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101049/new/ https://reviews.llvm.org/D101049 Files: clang/include/clang/Tooling/NodeIntrospection.h

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

steveire created this revision. steveire added a reviewer: njames93. Herald added a subscriber: mgrang. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101049

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire added a comment. In D98774#2701853 , @thakis wrote: > I think it is? https://llvm.org/docs/GettingStarted.html#software lists it at > least. Thanks, I'll look into that soon and see how the buildbots respond. Repository: rG LLVM Github

[PATCH] D98774: [AST] De-duplicate empty node introspection

This revision was automatically updated to reflect the committed changes. Closed by commit rGaee6c86c4dc7: [AST] De-duplicate empty node introspection (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D98774?vs=331300=339559#toc Repository: rG LLVM Github

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

This revision was automatically updated to reflect the committed changes. Closed by commit rG21ce124e1e63: [AST] Add NestedNameSpecifierLoc accessors to node introspection (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93325: Add srcloc output to clang-query

steveire added a comment. @aaron.ballman ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire updated this revision to Diff 338631. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100712/new/ https://reviews.llvm.org/D100712 Files: clang/lib/Tooling/DumpTool/APIData.h

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire added inline comments. Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:280 STRING_LOCATION_STDPAIR(MethodDecl, getTypeSpecStartLoc()) })); // clang-format on steveire wrote: > njames93 wrote: > > I'm not entirely sure on the case,

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire updated this revision to Diff 338620. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100712/new/ https://reviews.llvm.org/D100712 Files: clang/lib/Tooling/DumpTool/APIData.h

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

This revision was automatically updated to reflect the committed changes. Closed by commit rG782c3e23ba09: [AST] Fix comparison to of SourceRanges in container (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100723/new/

[PATCH] D100720: [AST] Update introspection API to use const-ref for copyable types

This revision was automatically updated to reflect the committed changes. Closed by commit rGabacaef18162: [AST] Update introspection API to use const-ref for copyable types (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D100720?vs=338366=338613#toc Repository:

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire added inline comments. Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:280 STRING_LOCATION_STDPAIR(MethodDecl, getTypeSpecStartLoc()) })); // clang-format on njames93 wrote: > I'm not entirely sure on the case, but the windows bot

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire added inline comments. Comment at: clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py:57 InstanceDecoration = "*" -if CladeName == "TypeLoc": +if CladeName == "TypeLoc" or CladeName == "NestedNameSpecifierLoc": InstanceDecoration =

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

steveire added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:47 std::pair const ) const { - if (!LHS.first.isValid() || !RHS.first.isValid()) -return false; njames93 wrote: > Maybe we should assert the ranges (or locations) are

[PATCH] D100638: [AST][Introspection] Avoid creating temporary strings when comparing LocationCalls.

steveire added a comment. Your implementation is getting very complicated and it requires many comments. Also, if we get to this point in the execution of `RangeLessThan::operator()`, you're creating and populating two vectors for every two elements contained. I know it's `llvm::SmallVector`

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

steveire created this revision. steveire added a reviewer: njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100723 Files:

[PATCH] D100719: [Introspection] Dont emit json if unchanged.

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100719/new/ https://reviews.llvm.org/D100719

[PATCH] D100720: [AST] Update introspection API to use const-ref for copyable types

steveire created this revision. steveire added a reviewer: njames93. Herald added a subscriber: mgorny. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100720

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire created this revision. steveire added a reviewer: njames93. Herald added subscribers: mgrang, mgorny. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the GetLocations API to take instances by const-ref. This class

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire added inline comments. Comment at: clang/lib/Tooling/DumpTool/ASTSrcLocProcessor.cpp:172-176 + if (TypeLocBase && Node->getName() == "getLocalSourceRange") +continue; + if ((ASTClass->getName() == "PointerLikeTypeLoc" || + ASTClass->getName()

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd68942f1d79: [AST] Add TypeLoc support to node introspection (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D100516?vs=338049=338342#toc Repository: rG LLVM Github

[PATCH] D100688: [AST] Remove args from LocationCall

This revision was automatically updated to reflect the committed changes. Closed by commit rGebc6608fb790: [AST] Remove args from LocationCall (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100688/new/

[PATCH] D100688: [AST] Remove args from LocationCall

steveire created this revision. steveire added a reviewer: njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This class initially had args to be generic to future needs. In particular, I thought that source location

[PATCH] D100638: [AST][Introspection] Avoid creating temporary strings when comparing LocationCalls.

steveire added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:84 + + auto LI = Left.rbegin(), LE = Left.rend(), RI = Right.rbegin(); + for (; LI != LE; ++LI, ++RI) { njames93 wrote: > steveire wrote: > > Would it make sense to compare the

[PATCH] D100638: [AST][Introspection] Avoid creating temporary strings when comparing LocationCalls.

steveire added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:84 + + auto LI = Left.rbegin(), LE = Left.rend(), RI = Right.rbegin(); + for (; LI != LE; ++LI, ++RI) { Would it make sense to compare the sizes `(leftsize < rightsize) return

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire updated this revision to Diff 338049. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100516/new/ https://reviews.llvm.org/D100516 Files: clang/include/clang/Tooling/NodeIntrospection.h

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire updated this revision to Diff 338030. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100516/new/ https://reviews.llvm.org/D100516 Files: clang/include/clang/Tooling/NodeIntrospection.h

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire added inline comments. Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:1294 + +#ifndef _WIN32 +TEST(Introspection, SourceLocations_TypeOfTypeLoc) { njames93 wrote: > Can you add a comment explaining the issues with this test on windows

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire updated this revision to Diff 337923. steveire edited the summary of this revision. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100516/new/ https://reviews.llvm.org/D100516 Files:

[PATCH] D100548: [AST] Fix location call storage with common last-invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f6d69846747: [AST] Fix location call storage with common last-invocation (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D100548?vs=337713=337917#toc Repository: rG

[PATCH] D100423: [AST] Add a print method to Introspection LocationCall

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100423/new/ https://reviews.llvm.org/D100423

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire updated this revision to Diff 337720. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100516/new/ https://reviews.llvm.org/D100516 Files: clang/include/clang/Tooling/NodeIntrospection.h

[PATCH] D100548: [AST] Fix location call storage with common last-invocation

steveire created this revision. steveire added a reviewer: njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also fix the formatter to use the front element of a chained call instead of the back element. Repository: rG

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire created this revision. steveire added a reviewer: njames93. Herald added subscribers: mgrang, mgorny. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend the matchers gathering API for types to record template

[PATCH] D100423: [AST] Add a print method to Introspection LocationCall

steveire requested changes to this revision. steveire added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:26 +if (On->returnsPointer()) + OS << "->"; +else The reason for the

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

steveire added a comment. Indeed, I just this evening discovered the need for this to be stable across runs for testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100378/new/ https://reviews.llvm.org/D100378

[PATCH] D99231: [AST] Add introspection support for more base nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGf347f0e0b869: [AST] Add introspection support for more base nodes (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D99231?vs=336813=337537#toc Repository: rG LLVM Github

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) + return {}; njames93 wrote:

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire updated this revision to Diff 336813. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) + return {}; njames93 wrote:

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire updated this revision to Diff 336804. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D93325: Add srcloc output to clang-query

steveire updated this revision to Diff 336690. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325 Files: clang-tools-extra/clang-query/CMakeLists.txt

[PATCH] D93325: Add srcloc output to clang-query

steveire updated this revision to Diff 336652. steveire added a comment. Herald added a subscriber: mgorny. Herald added a project: clang-tools-extra. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire updated this revision to Diff 336651. steveire added a comment. Add locations for CXXBaseSpecifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f181086b5cb: [ASTMatchers] Add `cxxBaseSpecifier` matcher

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire added a comment. @njames93 ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

steveire added a comment. In D69218#2654638 , @nick wrote: > In D69218#2654614 , @steveire wrote: > >> @nick Sorry that getting these changes merged takes so long. >> >> @njames93 If you have an alternative way

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

steveire added a reviewer: steveire. steveire added a comment. Yes, please remove the line instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99715/new/ https://reviews.llvm.org/D99715 ___

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

steveire added a comment. @nick I think this also might need to be rebased again, sorry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

steveire added a comment. @nick Sorry that getting these changes merged takes so long. @njames93 If you have an alternative way forward, please let us know what it is. Otherwise, this LGTM too and we should merge it soon unless there are objections which haven't been addressed.

[PATCH] D98296: [clang-tidy] Simplify readability checks to not need ignoring* matchers

This revision was automatically updated to reflect the committed changes. Closed by commit rGea2225a10be9: [clang-tidy] Simplify readability checks to not need ignoring* matchers (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98296: [clang-tidy] Simplify readability checks to not need ignoring* matchers

steveire updated this revision to Diff 333696. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98296/new/ https://reviews.llvm.org/D98296 Files:

[PATCH] D97513: [CMake] Add ConfigVersion.cmake files

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. LGTM, thanks! I'll commit this on Wednesday if none of the other reviewers object by then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/

[PATCH] D97513: Add ConfigVersion.cmake files

steveire added inline comments. Comment at: flang/cmake/modules/CMakeLists.txt:15 # Generate FlangConfig.cmake for the build tree. +include(CMakePackageConfigHelpers) + Instead of including this multiple times, please add it to `AddLLVM.cmake`. That file is

[PATCH] D97513: Add ConfigVersion.cmake files

steveire added inline comments. Comment at: lld/cmake/modules/LLDConfigVersion.cmake.in:1 +set(PACKAGE_VERSION "@PACKAGE_VERSION@") + steveire wrote: > Did you consider using `write_basic_package_version_file` instead of adding > these files? Ah, sorry, I see

[PATCH] D97513: Add ConfigVersion.cmake files

steveire added inline comments. Herald added a subscriber: dcaballe. Comment at: lld/cmake/modules/LLDConfigVersion.cmake.in:1 +set(PACKAGE_VERSION "@PACKAGE_VERSION@") + Did you consider using `write_basic_package_version_file` instead of adding these files?

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire created this revision. steveire added a reviewer: njames93. Herald added a subscriber: mgorny. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace an assert for a CXXCtorInitializer SourceLocation with a condition, as

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

steveire added a comment. Does anything prevent this going in now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98775: [AST] Add introspection support for Decls

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c65dfc895d0: [AST] Add introspection support for Decls (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D98775?vs=332160=332469#toc Repository: rG LLVM Github Monorepo

[PATCH] D98775: [AST] Add introspection support for Decls

steveire updated this revision to Diff 332160. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98775/new/ https://reviews.llvm.org/D98775 Files: clang/include/clang/Tooling/NodeIntrospection.h

[PATCH] D98775: [AST] Add introspection support for Decls

steveire updated this revision to Diff 332119. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98775/new/ https://reviews.llvm.org/D98775 Files: clang/include/clang/Tooling/NodeIntrospection.h

[PATCH] D98827: [AST] Ensure that an empty json file is generated if compile errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG188405bc192d: [AST] Ensure that an empty json file is generated if compile errors (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire marked an inline comment as done. steveire added a comment. @thakis Do you have any more on this? Can we de-duplicate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98774/new/ https://reviews.llvm.org/D98774

[PATCH] D98827: [AST] Ensure that an empty json file is generated if compile errors

steveire added a comment. In D98827#2635303 , @njames93 wrote: > Are there any tests that ensure something is always outputted? The test verifies that the generated c++ either gives no introspection data or introspection data which the test expects.

[PATCH] D98775: [AST] Add introspection support for Decls

steveire updated this revision to Diff 331413. steveire added a comment. Herald added a subscriber: mgorny. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98775/new/ https://reviews.llvm.org/D98775 Files:

[PATCH] D98827: [AST] Ensure that an empty json file is generated if compile errors

steveire created this revision. steveire added a reviewer: njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98827 Files:

[PATCH] D69218: [clang][AST] Add `CXXBaseSpecifier` matcher support

steveire added reviewers: steveire, njames93. steveire added a comment. Could you rebase this? Parts of it were common with another patch which was merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire marked 4 inline comments as done. steveire added a comment. In D98774#2631898 , @thakis wrote: > Why were there two copies in the first place? What was the copy in the cmake > file good for, why wasn't the one written by generate_cxx_src_locs.py

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire updated this revision to Diff 331300. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98774/new/ https://reviews.llvm.org/D98774 Files: clang/lib/Tooling/CMakeLists.txt

[PATCH] D98775: [AST] Add introspection support for Decls

steveire created this revision. steveire added a reviewer: njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The test code has lots of interesting locations which are not yet introspected, but those will come later:

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire created this revision. steveire added reviewers: thakis, njames93. Herald added a subscriber: mgorny. steveire requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This way we can add support for other nodes without

  1   2   3   4   5   6   7   8   9   10   >