[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG282da837565f: [XCOFF][AIX] Issue an error when specifying an alias for a common symbol (authored by stephenpeckham). Changed prior to commit: http

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

stephenpeckham updated this revision to Diff 554299. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158739/new/ https://reviews.llvm.org/D158739 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/aix-common.c llvm/lib

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

stephenpeckham created this revision. stephenpeckham added reviewers: hubert.reinterpretcast, DiggerLin, jhenderson. Herald added subscribers: jeroen.dobbelaere, kbarton, hiraditya, nemanjai. Herald added a project: All. stephenpeckham requested review of this revision. Herald added projects: clang

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

stephenpeckham accepted this revision. stephenpeckham added a comment. This revision is now accepted and ready to land. I don't see any reason to check the OBJECT_MODE environment variable if the -X flag is used. What would the error be: "You specified a valid -X flag, but by the way, OBJECT_M

[PATCH] D86993: Document Clang's expectations of the C standard library.

stephenpeckham added a comment. Is memmove() expected to perform a lot worse than memcpy()? Why not just use memmove() all the time. In some library implementations, memcpy() and memmove() are the same function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D153600: Implement -frecord-command-line for XCOFF

stephenpeckham added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2338 // Emit bytes for llvm.commandline metadata. - emitModuleCommandLines(M); + if (!TM.getTargetTriple().isOSBinFormatXCOFF()) +emitModuleCommandLines(M); I wo

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

stephenpeckham added a comment. Do the -U and -D flags have any effect on the behavior of llvm-ranlib? Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:16 + +## Test OBJECT_MODE environment variable when adding symbol table +# RUN: env OBJECT_MODE=32 llvm-ranlib t_X32.

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

stephenpeckham added inline comments. Comment at: clang/docs/ReleaseNotes.rst:230 +- Introduced the ``-mroptr`` option to place constant objects with relocatable + address values in the read-only data section. This option is intended to + be used with the ``-fdata-sections`` op

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

stephenpeckham accepted this revision. stephenpeckham added a comment. This revision is now accepted and ready to land. I don't have issues with this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190