[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

sunho added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:211 + L->BufferOffset = + StrData - InputFile.getBufferStart(); // FIXME: this is wrong + L->BufferSize = L->BufferOffset + TokLen; v.g.vassilev wrote: > Is that an outdated comment? If not m

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. I think it makes more sense to use stable version of clang-format for that purpose but I'm not in a postion to decide as I don't work with format. Can you change the script to use latest clang-format for format codebase and revert this patch in the meantime? Currently, al

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. Wouldn't that mean llvm contributors have to format their code using clang-format built from top-of-tree source code before submitting the patch? Technically that script is for checking if the code has been formatted correctly. Repository: rG LLVM Github Monorepo CHA

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. I think buildbot is "formatting" the patch using clang-format-15. The tests of clang-format would be done with latest code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. This seems to be causing builtbot lint script error: https://buildkite.com/llvm-project/premerge-checks/builds/134501#01862630-8fa9-487c-99b1-9addbe6257d0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://rev

[PATCH] D143148: [clang-repl] Add basic multiline input support

sunho created this revision. Herald added a project: All. sunho retitled this revision from "Add multiline support in clang-repl" to "[clang-repl] Add basic multiline support". sunho edited the summary of this revision. sunho updated this revision to Diff 494983. sunho added a comment. sunho updat

[PATCH] D143144: [clang][lex] Add TryGrowLexerBuffer/SourceFileGrower

sunho created this revision. Herald added a project: All. sunho retitled this revision from "asdfasdf" to "[clang][lex] Add TryExpandBuffer callback". sunho edited the summary of this revision. sunho updated this revision to Diff 494978. sunho added a comment. sunho updated this revision to Diff 4

[PATCH] D141380: [clang-repl] XFAIL riscv targets in simple-exception test case

sunho added a subscriber: Hahnfeld. sunho added a comment. Maybe @Hahnfeld knows something as he added riscv support to clang-repl recently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141380/new/ https://reviews.llvm.org/D141380 __

[PATCH] D141380: [clang-repl] XFAIL riscv targets in simple-exception test case

sunho added a comment. Do you have an exception support in your libc and it's dynamically linked? I believe if clang-repl was able to execute the program, it must have successfully linked to cxxthrow symbols and so exception handling works correctly. Repository: rG LLVM Github Monorepo CHA

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sunho added a comment. In D130788#3732325 , @sbc100 wrote: > In D130788#3731232 , @sunho wrote: > >> In D130788#3730533 , @sbc100 wrote: >> >>> I'm not totally sure but I

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sunho added a comment. In D130788#3730533 , @sbc100 wrote: > I'm not totally sure but I think the change is responsible for the emscripten > integration bot failing `InterpreterTest.CatchException`: > https://logs.chromium.org/logs/emscripten-releases/b

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sunho added a comment. In D130788#3689820 , @dyung wrote: > In D130788#3689795 , @sunho wrote: > >> The test isn't supposed to be ran on windows -- we don't support exception >> on windows at all yet. I guess XFA

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sunho added a comment. In D130788#3689693 , @dyung wrote: > The test simple-exception.cpp is failing on the PS5 Windows bot after this > change. Can you take a look? > > I forced a build using the commit prior to yours which passed: > https://lab.llvm.o

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sunho added a comment. https://lab.llvm.org/buildbot/#/builders/98/builds/22588 fuschia build bot is happy with this change and I don't see new build breakages so far! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130788/new/ https://reviews.llvm.

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8f2e24e48fd: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON. (authored by sunho). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

sunho added a comment. @alanphipps I just confirmed that the buildbot failures were fixed by the new fix https://reviews.llvm.org/rG65c9265f4158. Could you check out if this fixes the failure on your end too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

sunho added a comment. In D130786#3688387 , @alanphipps wrote: > I'm still seeing a failure on my downstream Arm compiler on Linux in the unit > tests -- I thought I saw the same failure on the buildbots: > > FAIL: llvm_regressions :: > Clang-Unit/In

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

sunho added a comment. In D130786#3688019 , @probinson wrote: > If you're going to post a patch for review, you really should wait for > someone to review it before you land it. I rushed as bots were breaking on the upstream. Sorry about that. Reposit

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

sunho added a comment. https://reviews.llvm.org/D130788 this is the patch fyi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129242/new/ https://reviews.llvm.org/D129242 ___ cfe-commits mailing list cfe-

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

sunho added a comment. @uabelho The thing is we have to statically link libstdc++ in JIT stack, but this is not possible at the moment in many platforms. It's actually possible with a new generation linker called JITLink, but it has limited platform support. For now, I just sumbitted a patch di

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4191d661c746: [clang-repl] Disable execution unittests on unsuppor

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

sunho added a comment. In D129242#3686713 , @uabelho wrote: > In D129242#3686610 , @sunho wrote: > >> @uabelho Hi, that's a typeinfo symbol of libc++ abi. It's quite weird that >> __cxa_throw is availble while _Z

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

sunho added a comment. @uabelho Hi, that's a typeinfo symbol of libc++ abi. It's quite weird that __cxa_throw is availble while _ZTIPKc is not. Do you have some special setting regarding libc++ in your environment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cc3be8fa471: [clang-repl] Add host exception support check utility flag. (authored by sunho). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D129175: [ORC] Fix weak hidden symbols failure on PPC with runtimedyld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72ea1a721e00: [ORC] Fix weak hidden symbols failure on PPC with runtimedyld (authored by sunho). Herald added a project: clang. Herald added a subscr

[PATCH] D129049: [clang] Fix gcc-6 compilation error. (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG134363208b92: [clang] Fix gcc-6 compilation error. (NFC) (authored

[PATCH] D128589: [clang-repl] Support destructors of global objects.

sunho added inline comments. Comment at: clang/test/Interpreter/execute.cpp:22-23 +struct D { float f = 1.0; D *m = nullptr; D(){} ~D() { printf("D[f=%f, m=0x%llx]\n", f, reinterpret_cast(m)); }} d; +// CHECK: D[f=1.00, m=0x0] + Hahnfeld wrote: > I think i

[PATCH] D128589: [clang-repl] Support destructors of global objects.

sunho added a comment. This seems to be breaking builds in ppc bots. Invastigating right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128589/new/ https://reviews.llvm.org/D128589 ___ cfe-commits ma

[PATCH] D128589: [clang-repl] Support destructors of global objects.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9de8b05bfe0d: [clang-repl] Support destructors of global objects. (authored by sunho). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128589/new/ https://rev

[PATCH] D128589: [clang-repl] Support destructors of global objects.

sunho updated this revision to Diff 440047. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128589/new/ https://reviews.llvm.org/D128589 Files: clang/lib/Interpreter/IncrementalExecutor.cpp clang/lib/Interpreter/IncrementalExecutor.h clang/lib/Interpreter/Interpreter.cpp clang/test

[PATCH] D127207: [flang][driver] Fix support for `-x`

sunho added a comment. Hi! I'm not exactly sure what's going on. But, seems like build is failing here? https://lab.llvm.org/buildbot/#/builders/177/builds/5571 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127207/new/ https://reviews.llvm.org/D12

[PATCH] D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7bc00ce5cd41: [clang-repl] Remove memory leak of ASTContext/TargetMachine. (authored by sunho). Herald added a project: clang. Herald added a subscri