[PATCH] D88434: [clangd] Improve PopulateSwitch tweak to work on non-empty switches

tdeo marked 10 inline comments as done. tdeo added a comment. Thanks for the review! Please land this if there are no more issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88434/new/ https://reviews.llvm.org/D88434 ___ cfe-commits

[PATCH] D88434: [clangd] Improve PopulateSwitch tweak to work on non-empty switches

tdeo updated this revision to Diff 294959. tdeo added a comment. - Improve comments - In apply(), assert on the conditions we established in prepare() instead of proceeding. - Remove redundant tests and add new ones for value-dependent and GNU range cases. CHANGES SINCE LAST ACTION

[PATCH] D88434: [clangd] Improve PopulateSwitch tweak to work on non-empty switches

tdeo created this revision. tdeo added a reviewer: sammccall. tdeo added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. tdeo requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov.

[PATCH] D88383: [clangd] Add a tweak for filling in enumerators of a switch statement.

tdeo added a comment. In D88383#2297778 , @sammccall wrote: > In D88383#2297735 , @tdeo wrote: > >> @sammccall, I don't have commit access, so if this revision has no issues, >> can you land it? Thanks. > >

[PATCH] D88383: [clangd] Add a tweak for filling in enumerators of a switch statement.

tdeo added a comment. @sammccall, I don't have commit access, so if this revision has no issues, can you land it? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88383/new/ https://reviews.llvm.org/D88383 ___ cfe-commits mailing list

[PATCH] D88383: [clangd] Add a tweak for filling in enumerators of a switch statement.

tdeo updated this revision to Diff 294644. tdeo added a comment. - Check body is empty instead of having no case statements. - Null check the return value from SwitchStmt::getCond. - Insert replacement before the right bracket instead of the left one, for future improvements. CHANGES SINCE

[PATCH] D88383: [clangd] Add a tweak for filling in enumerators of a switch statement.

tdeo created this revision. tdeo added a reviewer: sammccall. tdeo added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang. tdeo requested review of this revision. Herald added subscribers: MaskRay,