[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

2023-01-02 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer added a comment. Sorry, I was away during the holidays but just pushed the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 ___ cfe-commits m

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

2023-01-02 Thread Tamas Berghammer via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf325b5b8cb1d: [clang-tidy] Support std::string_view in readability-redundant-string-cstr (authored by tberghammer). Repository: rG LLVM Github Mon

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

2023-01-02 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer updated this revision to Diff 485853. tberghammer added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 Files: clang-tools-extra/clang-tidy/readability/RedundantStringCStrC

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

2022-12-16 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer updated this revision to Diff 483553. tberghammer added a comment. Add wstring_view test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 Files: clang-tools-extra/clang-tidy/readability/Redun

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

2022-12-14 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer updated this revision to Diff 482871. tberghammer added a comment. Fix formatting type in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 Files: clang-tools-extra/clang-tidy/re

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

2022-12-14 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer updated this revision to Diff 482870. tberghammer added a comment. Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 Files: clang-tools-extra/clang-tidy/readability/Redundant

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

2022-12-14 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. tberghammer requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously we wer

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

2017-11-04 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer added a comment. I verified that https://reviews.llvm.org/D39545 will be fixing the problem on the LLDB side (previously we had no proper scoped enum support in LLDB) https://reviews.llvm.org/D39239 ___ cfe-commits mailing list cfe-comm

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

2017-11-02 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer added a comment. In https://reviews.llvm.org/D39239#911696, @CarlosAlbertoEnciso wrote: > Hi Tamas, > > Thanks very much for your message. > > In https://reviews.llvm.org/D39239#910797, @tberghammer wrote: > > > - Can you do a diff of the debug_info dump before and after your change?

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

2017-10-30 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer added a comment. 2 fairly random ideas without looking into it too much: - Can you do a diff of the debug_info dump before and after your change? Understanding what have changed should give us a pretty good clue about the issue. - My first guess is that after your change we emit DW_

[PATCH] D33385: __cxa_demangle: Fix constructor cv qualifier handling

2017-05-24 Thread Tamas Berghammer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL303737: __cxa_demangle: Fix constructor cv qualifier handling (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D33385?vs=99694&id=100067#toc Repository: rL LLVM https://r

[PATCH] D33385: __cxa_demangle: Fix constructor cv qualifier handling

2017-05-21 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer created this revision. Previously if we parsed a constructor then we set parsed_ctor_dtor_cv to true and never reseted it. This causes issue when a template argument references a constructor (e.g. type of lambda defined inside a constructor) as we will have the parsed_ctor_dtor_cv flag