[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172708. tlively added a dependency: D53630: [WebAssembly] Lower vselect. tlively added a comment. - Rebase onto SIMD reorganization Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp lib/Targ

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172280. tlively added a comment. - Wrap comment to 80 chars. Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp lib/Target/WebAssembly/WebAssemblyInstrSIMD.td test/CodeGen/WebAssembly/simd-

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC345804: [WebAssembly] Fix type names in truncation builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D53724?vs=172061&id=172074#toc Repository: rL LLVM

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL345804: [WebAssembly] Fix type names in truncation builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53724 Files:

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172072. tlively added a comment. - Wrap comments at col 80. Restore proper revision contents. Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp lib/Target/WebAssembly/WebAssemblyInstrSIMD.td

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively added inline comments. Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:587 +multiclass SIMDSelectPat { aheejin wrote: > Why do we need this pattern? Can't we also expand `SELECT` as we did for > `SELECT_CC` and `VSELECT`? It looks like the e

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

tlively updated this revision to Diff 172061. tlively added a comment. - Restore return types in names Repository: rC Clang https://reviews.llvm.org/D53724 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/bu

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172060. tlively added a comment. Herald added a subscriber: cfe-commits. - Restore return types in names Repository: rC Clang https://reviews.llvm.org/D53675 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

tlively added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:12528 + case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f32x4: + case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f64x2: { Value *Src = EmitScalarExpr(E->getArg(0)); aheejin wrote:

[PATCH] D53685: [WebAssembly] Bitselect and min/max builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL345301: [WebAssembly] Bitselect and min/max builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53685 Files: cfe/tru

[PATCH] D53722: [WebAssembly] Lower to target-independent saturating add

This revision was automatically updated to reflect the committed changes. Closed by commit rL345300: [WebAssembly] Lower to target-independent saturating add (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53722 File

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Use the same convention as all the other WebAssembly builtin names. Repository: rC Clang https://reviews.llvm.org/D53724 Files: inc

[PATCH] D53722: [WebAssembly] Lower to target-independent saturating add

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Goes along with https://reviews.llvm.org/D53721. Repository: rC Clang https://reviews.llvm.org/D53722 Files: lib/CodeGen/CGBuiltin.cpp test/

[PATCH] D53685: [WebAssembly] Bitselect and min/max builtins

tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:85 +BUILTIN(__builtin_wasm_bitselect, "V4iV4iV4iV4i", "nc") + aheejin wrote: > Do you think we need to provide this builtin also for other vector types? This builtin is inter

[PATCH] D53685: [WebAssembly] Bitselect and min/max intrinsics

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Repository: rC Clang https://reviews.llvm.org/D53685 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeG

[PATCH] D53009: [WebAssembly] Saturating float-to-int builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC344205: [WebAssembly] Saturating float-to-int builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D53009?vs=168738&id=169132#toc Repository: rC Clang htt

[PATCH] D53007: [WebAssembly][NFC] Rename test functions for builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL344009: [WebAssembly][NFC] Rename test functions for builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53007 Files:

[PATCH] D53009: [WebAssembly] Saturating float-to-int builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52959 and https://reviews.llvm.org/D53004. Repository: rC Clang https://reviews.llvm.org/D53009

[PATCH] D53007: [WebAssembly][NFC] Rename test functions for builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, jfb, sunfish, jgravelle-google, sbc100. Repository: rC Clang https://reviews.llvm.org/D53007 Files: test/CodeGen/builtins-wasm.c Index: test/CodeGen/builtins-wasm.c ==

[PATCH] D52913: [WebAssembly] abs and sqrt builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC343838: [WebAssembly] abs and sqrt builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D52913?vs=168402&id=168424#toc Repository: rC Clang https://review

[PATCH] D52913: [WebAssembly] abs and sqrt builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL343838: [WebAssembly] abs and sqrt builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52913 Files: cfe/trunk/includ

[PATCH] D52910: [WebAssembly] any_true and all_true builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL343837: [WebAssembly] any_true and all_true builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52910 Files: cfe/tru

[PATCH] D52858: [WebAssembly] saturating arithmetic builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL343836: [WebAssembly] saturating arithmetic builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52858 Files: cfe/tru

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC343835: [WebAssembly] __builtin_wasm_replace_lane_* builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D52856?vs=168387&id=168421#toc Repository: rC Clan

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL343834: [WebAssembly] __builtin_wasm_extract_lane_* builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52852 Files:

[PATCH] D52913: [WebAssembly] abs and sqrt builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff, craig.topper. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52910. Repository: rC Clang https://reviews.llvm.org/D52913 Files: include/clang

[PATCH] D52910: [WebAssembly] any_true and all_true builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff, craig.topper. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52858. Repository: rC Clang https://reviews.llvm.org/D52910 Files: include/clang

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

tlively added a comment. In https://reviews.llvm.org/D52856#1255905, @dschuff wrote: > W is int64_t (which is long long for wasm32 and would probably be long for > wasm64 since that would probably LP64 (like Linux) rather than LLP64 (Like > Win64). So if we want it to be the same for both wasm3

[PATCH] D52858: [WebAssembly] saturating arithmetic builtins

tlively updated this revision to Diff 168388. tlively added a comment. - Remove V:128: attributes Repository: rC Clang https://reviews.llvm.org/D52858 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/builtins

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

tlively updated this revision to Diff 168387. tlively added a comment. - Replace Wi with LLi and remove V:128: Repository: rC Clang https://reviews.llvm.org/D52856 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/Cod

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

tlively updated this revision to Diff 168385. tlively added a comment. - Replace Wi with LLi in signature string - Remove unnecessary V:128: attribute Repository: rC Clang https://reviews.llvm.org/D52852 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:55 +BUILTIN(__builtin_wasm_replace_lane_i32x4, "V4iV4iIii", "ncV:128:") +BUILTIN(__builtin_wasm_replace_lane_i64x2, "V2WiV2WiIiWi", "ncV:128:") +BUILTIN(__builtin_wasm_replace_lane_f32x4, "V4fV

[PATCH] D52858: [WebAssembly] saturating arithmetic builtins

tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:59 +BUILTIN(__builtin_wasm_add_saturate_s_i8x16, "V16cV16cV16c", "ncV:128:") +BUILTIN(__builtin_wasm_add_saturate_u_i8x16, "V16cV16cV16c", "ncV:128:") craig.topper wrote: > D

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:46 +BUILTIN(__builtin_wasm_extract_lane_s_i16x8, "iV8sIi", "ncV:128:") +BUILTIN(__builtin_wasm_extract_lane_u_i16x8, "iV8sIi", "ncV:128:") +BUILTIN(__builtin_wasm_extract_lane_i32x4, "iV4iIi",

[PATCH] D52858: [WebAssembly] saturating arithmetic builtins

tlively updated this revision to Diff 168224. tlively added a comment. - Rebase Repository: rC Clang https://reviews.llvm.org/D52858 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/builtins-wasm.c ==

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

tlively updated this revision to Diff 168223. tlively added a comment. - Force constant folding for lane Repository: rC Clang https://reviews.llvm.org/D52856 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/b

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

tlively updated this revision to Diff 168222. tlively marked an inline comment as done. tlively added a comment. - use isIntegerConstantExpr to force constant folding of lanes Repository: rC Clang https://reviews.llvm.org/D52852 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/Code

[PATCH] D52858: [WebAssembly] saturating arithmetic builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52856. Repository: rC Clang https://reviews.llvm.org/D52858 Files: include/clang/Basic/Builtin

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52852. Repository: rC Clang https://reviews.llvm.org/D52856 Files: include/clang/Basic/Builtin

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Repository: rC Clang https://reviews.llvm.org/D52852 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp

<    1   2   3   4   5