[clang] [llvm] [APFloat] Add support for f8E3M4 IEEE 754 type (PR #99698)

tschuett wrote: > @tschuett, Could you please help review this change? I did. I gave you the float reviewer of the house. https://github.com/llvm/llvm-project/pull/99698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

tschuett wrote: > > We are deprecating -Ofast and I would prefer to hint users first at > > conforming behaviour -O3 and then as last resort at -O3 with -ffast-math. > > @tschuett I'm sympathetic to this arguments, but I think it's no less > important to tell users in no uncertain terms how

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

tschuett wrote: We are deprecating -Ofast and I would prefer to hint users first at conforming behaviour -O3 and then as last resort at -O3 with -ffast-math. https://github.com/llvm/llvm-project/pull/98736 ___ cfe-commits mailing list

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

@@ -4428,10 +4428,14 @@ void Parser::ParseDeclarationSpecifiers( // constexpr, consteval, constinit specifiers case tok::kw_constexpr: - if (getLangOpts().C23) + if (getLangOpts().C23) { Diag(Tok, diag::warn_c23_compat_keyword) << Tok.getName(); -

[clang] [llvm] [mlir] [MLIR] Add f8E4M3 IEEE 754 type (PR #97118)

https://github.com/tschuett edited https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [APFloat] Add support for f8E4M3 IEEE 754 type (PR #97179)

@@ -136,6 +136,7 @@ static constexpr fltSemantics semIEEEquad = {16383, -16382, 113, 128}; static constexpr fltSemantics semFloat8E5M2 = {15, -14, 3, 8}; static constexpr fltSemantics semFloat8E5M2FNUZ = { 15, -15, 3, 8, fltNonfiniteBehavior::NanOnly,

[clang] [llvm] [APFloat] Add support for f8E4M3 IEEE 754 type (PR #97179)

https://github.com/tschuett edited https://github.com/llvm/llvm-project/pull/97179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [APFloat] Add support for f8E4M3 IEEE 754 type (PR #97179)

https://github.com/tschuett edited https://github.com/llvm/llvm-project/pull/97179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add f8E4M3 IEEE 754 type to llvm (PR #97179)

tschuett wrote: For reference the last type added: https://github.com/llvm/llvm-project/pull/95392 https://github.com/llvm/llvm-project/pull/97179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

tschuett wrote: If this is a new float type, could you please split out the apfloat changes in separate PR. https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [llvm][AArch64] Support -mcpu=apple-m4 (PR #95478)

tschuett wrote: It is a problem that is worth fixing long term. How to correctly model release versions and their optional dependencies. Furthermore, for the BTI example how remove features. https://github.com/llvm/llvm-project/pull/95478 ___

[clang] [llvm] [APFloat] Add APFloat support for FP4 data type (PR #95392)

@@ -69,8 +69,8 @@ enum class fltNonfiniteBehavior { // encodings do not distinguish between signalling and quiet NaN. NanOnly, - // This behavior is present in Float6E3M2FN and Float6E2M3FN types, - // which do not support Inf or NaN values. + // This behavior is

[clang] Improve error message for invalid lambda captures (PR #94865)

tschuett wrote: Needs a test. https://github.com/llvm/llvm-project/pull/94865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

@@ -3518,13 +3542,17 @@ APInt IEEEFloat::convertIEEEFloatToAPInt() const { myexponent = ::exponentZero(S) + bias; mysignificand.fill(0); } else if (category == fcInfinity) { -if (S.nonFiniteBehavior == fltNonfiniteBehavior::NanOnly) { +if (S.nonFiniteBehavior

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

@@ -3518,13 +3542,17 @@ APInt IEEEFloat::convertIEEEFloatToAPInt() const { myexponent = ::exponentZero(S) + bias; mysignificand.fill(0); } else if (category == fcInfinity) { -if (S.nonFiniteBehavior == fltNonfiniteBehavior::NanOnly) { +if (S.nonFiniteBehavior

[clang] [llvm] [IR] Add getelementptr nusw and nuw flags (PR #90824)

tschuett wrote: Could you please add a TODO here: https://github.com/llvm/llvm-project/blob/e3f42b02a4129947ca2dd820bfb63ffed83027b7/llvm/lib/CodeGen/MachineInstr.cpp#L565 Thanks. https://github.com/llvm/llvm-project/pull/90824 ___ cfe-commits mailing

[clang] [llvm] [x86] Add tan intrinsic part 4 (PR #90503)

@@ -674,6 +674,9 @@ # DEBUG-NEXT: .. opcode {{[0-9]+}} is aliased to {{[0-9]+}} # DEBUG-NEXT: .. the first uncovered type index: 1, OK # DEBUG-NEXT: .. the first uncovered imm index: 0, OK +# DEBUG-NEXT: G_FTAN (opcode {{[0-9]+}}): 1 type index, 0 imm indices

[clang] [llvm] [x86] Add tan intrinsic part 4 (PR #90503)

tschuett wrote: Firstly, it is a nit. The IRTranslator translates LLVM-IR into GMIR for GlobalIsel. Testing the IRTranslator is independent of any SDAG changes. https://github.com/llvm/llvm-project/pull/90503 ___ cfe-commits mailing list

[clang] [llvm] [x86] Add tan intrinsic part 4 (PR #90503)

tschuett wrote: Nit: the `declare` is not necessary anymore. You touched the IRTranslator without a test at, e.g., https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll https://github.com/llvm/llvm-project/pull/90503

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

@@ -18914,13 +18914,13 @@ This is an overloaded intrinsic. :: - declare <2 x double> @llvm.experimental.vector.splice.v2f64(<2 x double> %vec1, <2 x double> %vec2, i32 %imm) - declare @llvm.experimental.vector.splice.nxv4i32( %vec1, %vec2, i32 %imm) +

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

@@ -18779,13 +18779,13 @@ This is an overloaded intrinsic. :: - declare <2 x i8> @llvm.experimental.vector.reverse.v2i8(<2 x i8> %a) - declare @llvm.experimental.vector.reverse.nxv4i32( %a) + declare <2 x i8> @llvm.vector.reverse.v2i8(<2 x i8> %a) +

[clang] [clang] Fix high memory consumption during pack deduction (PR #88637)

@@ -831,7 +831,7 @@ class PackDeductionScope { if (IsPartiallyExpanded) PackElements += NumPartialPackArgs; else if (IsExpanded) - PackElements += *FixedNumExpansions; + PackElements += FixedNumExpansions.value_or(1); tschuett wrote:

[clang] [clang] Fix high memory consumption during pack deduction (PR #88637)

@@ -831,7 +831,7 @@ class PackDeductionScope { if (IsPartiallyExpanded) PackElements += NumPartialPackArgs; else if (IsExpanded) - PackElements += *FixedNumExpansions; + PackElements += FixedNumExpansions.value_or(1); tschuett wrote:

[clang] [clang] Allow builtin addc/subc to be constant evaluated (PR #81656)

tschuett wrote: The bigger issue is that it needs a test. Unfortunately, I am less familiar with the Clang test infrastructure. https://github.com/llvm/llvm-project/pull/81656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Allow builtin addc/subc to be constant evaluated (PR #81656)

@@ -12696,6 +12696,56 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E, return BuiltinOp == Builtin::BI__atomic_always_lock_free ? Success(0, E) : Error(E); } + case Builtin::BI__builtin_addcb: + case Builtin::BI__builtin_addcs: + case

[clang] [clang] Allow builtin addc/subc to be constant evaluated (PR #81656)

tschuett wrote: Sorry for the confusion, but the codegen test showed it makes sense what you are doing. https://github.com/llvm/llvm-project/pull/81656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Allow builtin addc/subc to be constant evaluated (PR #81656)

@@ -12691,6 +12691,56 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E, return BuiltinOp == Builtin::BI__atomic_always_lock_free ? Success(0, E) : Error(E); } + case Builtin::BI__builtin_addcb: + case Builtin::BI__builtin_addcs: + case

[clang] [clang] Allow builtin addc/subc to be constant evaluated (PR #81656)

@@ -12691,6 +12691,56 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E, return BuiltinOp == Builtin::BI__atomic_always_lock_free ? Success(0, E) : Error(E); } + case Builtin::BI__builtin_addcb: + case Builtin::BI__builtin_addcs: + case

[clang] [clang] Allow builtin addc/subc to be constant evaluated (PR #81656)

@@ -12691,6 +12691,56 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E, return BuiltinOp == Builtin::BI__atomic_always_lock_free ? Success(0, E) : Error(E); } + case Builtin::BI__builtin_addcb: + case Builtin::BI__builtin_addcs: + case

[clang] [clang] Allow builtin addc/subc to be constant evaluated (PR #81656)

tschuett wrote: Nice trick. https://github.com/llvm/llvm-project/pull/81656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

@@ -0,0 +1,66 @@ +// Check that -fsanitize=signed-integer-wrap instruments with -fwrapv +// RUN: %clang_cc1 -fwrapv -triple x86_64-apple-darwin -emit-llvm -o - %s -fsanitize=signed-integer-wrap | FileCheck %s --check-prefix=CHECK + +// Check that

[clang] [llvm] [Clang][RISCV] Move getVScaleRange logic into libLLVMFrontendDriver. NFC (PR #77327)

@@ -2,6 +2,7 @@ set(LLVM_LINK_COMPONENTS Support TargetParser FrontendOpenMP + FrontendDriver tschuett wrote: I would prefer putting it into FrontendDriver for style and as a precedence to encourage others to put more into the frontend.

[flang] [clang] [llvm] [compiler-rt] [libc] [clang-tools-extra] [lldb] [GlobalIsel] Combine select of binops (PR #76763)

tschuett wrote: I reverted the commit. https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [compiler-rt] [lldb] [llvm] [libc] [flang] [clang] [GlobalIsel] Combine select of binops (PR #76763)

tschuett wrote: The file was not changed by this PR and there is no `select` in the file. https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [compiler-rt] [lldb] [llvm] [libc] [flang] [clang] [GlobalIsel] Combine select of binops (PR #76763)

tschuett wrote: I had also issues with this test. There is also a GH issue: https://github.com/llvm/llvm-project/issues/76821. https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[flang] [lldb] [compiler-rt] [libc] [clang] [clang-tools-extra] [llvm] [GlobalIsel] Combine select of binops (PR #76763)

https://github.com/tschuett closed https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang] [clang-tools-extra] [llvm] [libc] [flang] [lldb] [GlobalIsel] Combine select of binops (PR #76763)

@@ -544,3 +544,154 @@ body: | %ext:_(s32) = G_ANYEXT %sel $w0 = COPY %ext(s32) ... +--- +# select cond, and(x, y), and(z, y) --> and (select cond, x, z), y +name:select_cond_and_x_y_and_z_y_and_select_x_z_y +body: | + bb.1: +

[compiler-rt] [clang] [clang-tools-extra] [llvm] [libc] [flang] [lldb] [GlobalIsel] Combine select of binops (PR #76763)

@@ -544,3 +544,154 @@ body: | %ext:_(s32) = G_ANYEXT %sel $w0 = COPY %ext(s32) ... +--- +# select cond, and(x, y), and(z, y) --> and (select cond, x, z), y +name:select_cond_and_x_y_and_z_y_and_select_x_z_y +body: | + bb.1: +

[compiler-rt] [clang] [clang-tools-extra] [llvm] [libc] [flang] [lldb] [GlobalIsel] Combine select of binops (PR #76763)

@@ -6548,6 +6534,54 @@ bool CombinerHelper::tryFoldBoolSelectToLogic(GSelect *Select, return false; } +bool CombinerHelper::tryFoldSelectOfBinOps(GSelect *Select, + BuildFnTy ) { + Register DstReg = Select->getReg(0); + Register

[compiler-rt] [clang] [clang-tools-extra] [llvm] [libc] [flang] [lldb] [GlobalIsel] Combine select of binops (PR #76763)

@@ -6548,6 +6534,54 @@ bool CombinerHelper::tryFoldBoolSelectToLogic(GSelect *Select, return false; } +bool CombinerHelper::tryFoldSelectOfBinOps(GSelect *Select, + BuildFnTy ) { + Register DstReg = Select->getReg(0); + Register

[clang-tools-extra] [lldb] [clang] [llvm] [libc] [compiler-rt] [flang] [GlobalIsel] Combine select of binops (PR #76763)

https://github.com/tschuett updated https://github.com/llvm/llvm-project/pull/76763 From e713bb6e2c36ec16c731217f0c3be19b040a03d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thorsten=20Sch=C3=BCtt?= Date: Tue, 2 Jan 2024 18:00:45 +0100 Subject: [PATCH 1/4] [GlobalIsel] Combine select of binops

[clang-tools-extra] [lldb] [clang] [llvm] [libc] [compiler-rt] [flang] [GlobalIsel] Combine select of binops (PR #76763)

tschuett wrote: Please review changes (C++ and mir) regarding flag handling. https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [lldb] [clang] [llvm] [libc] [compiler-rt] [flang] [GlobalIsel] Combine select of binops (PR #76763)

https://github.com/tschuett updated https://github.com/llvm/llvm-project/pull/76763 From e713bb6e2c36ec16c731217f0c3be19b040a03d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thorsten=20Sch=C3=BCtt?= Date: Tue, 2 Jan 2024 18:00:45 +0100 Subject: [PATCH 1/3] [GlobalIsel] Combine select of binops

[clang-tools-extra] [lldb] [clang] [llvm] [libc] [compiler-rt] [flang] [GlobalIsel] Combine select of binops (PR #76763)

https://github.com/tschuett updated https://github.com/llvm/llvm-project/pull/76763 From e713bb6e2c36ec16c731217f0c3be19b040a03d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thorsten=20Sch=C3=BCtt?= Date: Tue, 2 Jan 2024 18:00:45 +0100 Subject: [PATCH] [GlobalIsel] Combine select of binops ---

[clang] [clang][modules] Print library module manifest path. (PR #76451)

@@ -2164,6 +2164,12 @@ bool Driver::HandleImmediateArgs(const Compilation ) { return false; } + if (C.getArgs().hasArg(options::OPT_print_library_module_manifest_path)) { +llvm::outs() << "module: =" tschuett wrote: If the output starts with a /,

[clang] [clang][modules] Print library module manifest path. (PR #76451)

@@ -2164,6 +2164,12 @@ bool Driver::HandleImmediateArgs(const Compilation ) { return false; } + if (C.getArgs().hasArg(options::OPT_print_library_module_manifest_path)) { +llvm::outs() << "module: =" tschuett wrote: ```shell > clang

[clang] [clang][modules] Print library module manifest path. (PR #76451)

@@ -6135,6 +6141,40 @@ std::string Driver::GetProgramPath(StringRef Name, const ToolChain ) const { return std::string(Name); } +std::string Driver::GetModuleManifestPath(const Compilation , + const ToolChain ) const { + + switch

[clang] [clang][modules] Print library module manifest path. (PR #76451)

@@ -6135,6 +6141,40 @@ std::string Driver::GetProgramPath(StringRef Name, const ToolChain ) const { return std::string(Name); } +std::string Driver::GetModuleManifestPath(const Compilation , + const ToolChain ) const { + + switch

[clang] [clang][modules] Print library module manifest path. (PR #76451)

@@ -6135,6 +6141,40 @@ std::string Driver::GetProgramPath(StringRef Name, const ToolChain ) const { return std::string(Name); } +std::string Driver::GetModuleManifestPath(const Compilation , + const ToolChain ) const { + + switch

[clang] [clang][modules] Print library module manifest path. (PR #76451)

@@ -0,0 +1,15 @@ +// Test that -print-library-module-manifest-path finds the correct file. + +// RUN: %clang -print-library-module-manifest-path \ tschuett wrote: The trend seems to go to two dashes and there are no tests for 2 dashes.

[clang] [clang][modules] Print library module manifest path. (PR #76451)

@@ -0,0 +1,15 @@ +// Test that -print-library-module-manifest-path finds the correct file. + +// RUN: %clang -print-library-module-manifest-path \ tschuett wrote: --print-runtime-dir, --print-target-triple, --print-supported-cpus, and

[clang] [clang][modules] Print library module manifest path. (PR #76451)

@@ -602,6 +602,16 @@ class Driver { // FIXME: This should be in CompilationInfo. std::string GetProgramPath(StringRef Name, const ToolChain ) const; + /// GetModuleManifestPath - Lookup the name of the Standard library manifest. + /// + /// \param C - The compilation.

[llvm] [clang] [AArch64] Correctly mark Neoverse N2 as an Armv9.0a core (PR #75055)

@@ -94,6 +94,11 @@ Changes to the AArch64 Backend * Added support for Cortex-A520, Cortex-A720 and Cortex-X4 CPUs. +* Neoverse-N2 was incorrectly marked as an Armv8.5a core. This has been + changed to an Armv9.0a core. However, crypto options are not enabled + by default

[clang] [llvm] [AArch64] Correctly mark Neoverse N2 as an Armv9.0a core (PR #75055)

@@ -94,6 +94,11 @@ Changes to the AArch64 Backend * Added support for Cortex-A520, Cortex-A720 and Cortex-X4 CPUs. +* Neoverse-N2 was incorrectly marked as an Armv8.5a core. This has been + changed to an Armv9.0a core. However, crypto options are not enabled + by default

[flang] [clang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

tschuett wrote: Clang PRs often update the release notes and features. ala: The LLVM 19 release will not contain flang-new. https://github.com/llvm/llvm-project/pull/74377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [flang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

tschuett wrote: Are you going to add an entry to the [Release Nodes](https://github.com/llvm/llvm-project/blob/main/flang/docs/ReleaseNotes.md)? https://github.com/llvm/llvm-project/pull/74377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] e486e48 - [clang] fix deprecation

Author: Thorsten Schütt Date: 2022-08-09T17:42:55+02:00 New Revision: e486e48c3d9e99e4c17d365bbc4b429c8e5b5999 URL: https://github.com/llvm/llvm-project/commit/e486e48c3d9e99e4c17d365bbc4b429c8e5b5999 DIFF:

[clang] 955341a - test commit

Author: Thorsten Schütt Date: 2020-11-18T09:20:37+01:00 New Revision: 955341a722a0a204c79f6b948e4fe0f23bb56e30 URL: https://github.com/llvm/llvm-project/commit/955341a722a0a204c79f6b948e4fe0f23bb56e30 DIFF: