[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

tiagoma added a comment. Applying this patch seems to fix issues with C++20 as well. See https://github.com/llvm/llvm-project/issues/61969 Can we get it in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma added a comment. go for it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

tiagoma added a comment. In D54943#2959546 , @JonasToth wrote: > thanks for your testing! i will look at the `__unaligned` issue, not sure if > clang supports it, its an MSVC extension, is it? Yes it is. The clang frontend supports it. I am not sure

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

tiagoma added a comment. I am getting false positives with struct S{}; void f(__unaligned S*); void scope() { S s; f(); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

tiagoma added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:168 +*Variable, *Result.Context, DeclSpec::TQ_const, +QualifierTarget::Value, QualifierPolicy::Right)) { + Diag << *Fix;

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

tiagoma added a comment. Herald added a subscriber: shchenz. Can we get this in? I work in Microsoft Office and we have been using this checker and it works great! There are a couple of issues with it and I would like to contribute fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma updated this revision to Diff 322240. tiagoma added a comment. Add support for do/while Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma marked 5 inline comments as done. tiagoma added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17996 +format(ForSourceLong, Style)); +} + njames93 wrote: > MyDeveloperDay wrote: > > MyDeveloperDay wrote: > > >

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma updated this revision to Diff 321611. tiagoma added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma updated this revision to Diff 318563. tiagoma added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D95168: Add InsertBraces option

tiagoma added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2254 + + * ``BIS_WrapLikely`` (in configuration: ``WrapLikely``) +Insert braces if wrapping is likely curdeius wrote: > Shouldn't it be consistent with clang-tidy? So instead

[PATCH] D95168: Add InsertBraces option

tiagoma added a comment. Some background might be useful. I work at Microsoft (Office to be precise). We have our own fork of LLVM internally and I am starting to upstream some of the changes in our fork. > There's a clang-tidy check for it. Yes - readability-braces-around-statements. I would

[PATCH] D95168: Add InsertBraces option

tiagoma created this revision. tiagoma requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. InsertBraces will insert braces for single line control flow statements (currently if/else/for). It currently accepts the following options: - Never -