tskeith added inline comments.
Comment at: clang/include/clang/Driver/Options.td:4302
+def cpp : Flag<["-"], "cpp">, Group,
+ HelpText<"Always add standard macro predefinitions">;
+def nocpp : Flag<["-"], "nocpp">, Group,
This option affects command line macro d
tskeith added a comment.
> Would this option be used to extract debug/code-navigation info?
Yes, it's something related to mapping between symbols and source locations.
> Is there an equivalent in `clang` or `gfortran`?
Not that I know of.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
tskeith added inline comments.
Comment at: flang/test/Driver/std2018.f90:9
+! RUN: %flang_fc1 -pedantic %s 2>&1 | FileCheck %s --check-prefix=GIVEN
+! RUN: not %flang_fc1 -std=90 %s 2>&1 | FileCheck %s --check-prefix=WRONG
+
You need to make sure these work wit
tskeith added inline comments.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293
+ driverPath = driverPath.substr(0, driverPath.size() - 9);
+ return driverPath.append("/../tools/flang/include/flang/");
+}
tskeith wrote:
> arnamoy10 wrote:
> > tskeith w
tskeith added inline comments.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293
+ driverPath = driverPath.substr(0, driverPath.size() - 9);
+ return driverPath.append("/../tools/flang/include/flang/");
+}
arnamoy10 wrote:
> tskeith wrote:
> > Does this
tskeith added inline comments.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293
+ driverPath = driverPath.substr(0, driverPath.size() - 9);
+ return driverPath.append("/../tools/flang/include/flang/");
+}
Does this work for an install? I think there th
tskeith added a comment.
`-fget-symbols-sources` is not a debug option, it's intended for integrating
with IDEs like vscode. So I think the original name is better. Unlike the
"dump" options it actually is an action and not something that is intended to
produce debug output on the way to doing
tskeith accepted this revision.
tskeith added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96875/new/
https://reviews.llvm.org/D96875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
tskeith added a comment.
Please make sure the test works with f18 also.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:294
+// We only allow 2018 as the given standard
+if (standard.equals("2018")) {
+ res.SetStandard();
This should be "f201
tskeith added inline comments.
Comment at: flang/test/Flang-Driver/fdefault.f90:4
+
+! REQUIRES: new-flang-driver
+
awarzynski wrote:
> tskeith wrote:
> > Can't this work with the f18 driver too? That's the best way to ensure they
> > are consistent.
> I think t
tskeith added inline comments.
Comment at: flang/test/Flang-Driver/fdefault.f90:10
+! RUN: not %flang-new -fsyntax-only -fdefault-double-8 %s 2>&1 | FileCheck %s
--check-prefix=DOUBLE
+! RUN: mkdir -p %t/dir-flang-new && %flang-new -fsyntax-only -module-dir
%t/dir-flang-new -f
tskeith added inline comments.
Comment at: flang/test/Flang-Driver/fdefault.f90:4
+
+! REQUIRES: new-flang-driver
+
Can't this work with the f18 driver too? That's the best way to ensure they are
consistent.
Comment at: flang/test/Flang-Driver
tskeith added inline comments.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:254
+ if (args.hasArg(clang::driver::options::OPT_fdefault_real_8))
+res.defaultKinds().set_defaultRealKind(8);
+ if (args.hasArg(clang::driver::options::OPT_fdefault_integer_8)) {
tskeith added inline comments.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:234
+ // -J/module-dir option
+ auto &moduleDir = res.moduleDir();
auto moduleDirList =
In my opinion, using mutable references like this make the code hard to
understand.
tskeith added inline comments.
Comment at: clang/include/clang/Driver/Options.td:4231
+def flarge_sizes : Flag<["-"],"flarge-sizes">, Group,
+ HelpText<"Set the default KIND for INTEGER to 8.">;
}
That's not what -flarge-sizes does. Here is the description fro
tskeith added inline comments.
Comment at: flang/tools/f18/f18.cpp:541
driver.debugNoSemantics = true;
-} else if (arg == "-funparse") {
+} else if (arg == "-funparse" || arg == "-fdebug_unparse") {
driver.dumpUnparse = true;
This should be
tskeith added inline comments.
Comment at: flang/include/flang/Frontend/CompilerInstance.h:105
/// {
+ Fortran::semantics::SemanticsContext &semaChecking() const { return
*semantics_; }
awarzynski wrote:
> tskeith wrote:
> > `semanticsContext` would be a b
tskeith added inline comments.
Comment at: clang/include/clang/Driver/Options.td:1018
+ an USE statement. The default is the current
directory.}]>,Group;
+def module_dir : Separate<["-"], "module-dir">,
Flags<[FlangOption,FC1Option]>, MetaVarName<"">, Alias;
def dsym_dir : J
tskeith added inline comments.
Comment at: clang/include/clang/Driver/Options.td:4133
def fconvert_EQ : Joined<["-"], "fconvert=">, Group;
-def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-length-">,
Group;
+def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-len
tskeith added inline comments.
Comment at: flang/test/Flang-Driver/include-header.f90:59
+#endif
+end
`-I` also is supposed to affect INCLUDE lines so it would be good to have a
test for that too. They are handled during preprocessing and so can be tested
the s
tskeith added inline comments.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:228
+ // Note: GCC drops anything following an end-of-line character.
+ llvm::StringRef::size_type End = MacroBody.find_first_of("\n\r");
+ MacroBody = MacroBody.substr(0, End);
--
tskeith requested changes to this revision.
tskeith added inline comments.
This revision now requires changes to proceed.
Comment at: flang/include/flang/Frontend/CompilerInstance.h:11
+
+#include "flang/Frontend/CompilerInvocation.h"
+
Why is this called "Fronte
22 matches
Mail list logo