Hi there,
Could someone take a look at http://reviews.llvm.org/D15883 and
http://reviews.llvm.org/D15781. I was halfway through the review process,
with Logan (on to: line) as my main reviewer, but he seems to have become
unresponsive.
I was told by Logan to submit patch D15883 first, so as not t
timonvo added a comment.
Could someone please take a look at this patch as well as
http://reviews.llvm.org/D15781? Thanks!
http://reviews.llvm.org/D15883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
timonvo added a comment.
Hi compnerd, thanks for getting back to me. I've updated the code.
I was wondering though, where did you see @nbjoerg's comment? I couldn't find
any reference to it here or on cfe-commits.
http://reviews.llvm.org/D15883
__
timonvo updated this revision to Diff 48015.
timonvo added a comment.
Guard ARM EHABI enums using \#ifs (compnerd/nbjoerg's advice).
http://reviews.llvm.org/D15883
Files:
lib/Headers/unwind.h
Index: lib/Headers/unwind.h
===
---
timonvo updated this revision to Diff 48026.
timonvo added a comment.
Added local macro for enhanced readability.
http://reviews.llvm.org/D15883
Files:
lib/Headers/unwind.h
Index: lib/Headers/unwind.h
===
--- lib/Headers/unwind.
timonvo added a comment.
Note that I avoided using a local macro at first because I didn't want to
export any additional symbols/macros from this file. But I've moved to use one
now. Note that I changed the name slightly to be more in line with libunwind's
naming (it uses _LIBUNWIND_ARM_EHABI a
timonvo updated this revision to Diff 49215.
timonvo added a comment.
That's basically the Diff 48015 I had at some point. Reverted back to it now.
Now this patch doesn't declare any macros anymore.
http://reviews.llvm.org/D15883
Files:
lib/Headers/unwind.h
Index: lib/Headers/unwind.h
=
timonvo added a comment.
I don't have commit access. Can I land this CL myself somehow without commit
access (e.g. using arc), or will you have to submit it for me?
http://reviews.llvm.org/D15883
___
cfe-commits mailing list
cfe-commits@lists.llvm.
timonvo created this revision.
timonvo added a reviewer: logan.
timonvo added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
Adds a number of constants, defined in the ARM EHABI spec, to the Clang
lib/Headers/unwind.h header. This is prerequisite for landing
http://review
timonvo added a comment.
In http://reviews.llvm.org/D15883#319445, @rengolin wrote:
> Tests?
Sure, I could add some. But is it common practice to test constants? The tests
would end up being a duplication of the definition, I'm not sure how valuable
that would be. I also couldn't find tests f
timonvo added a comment.
Logan, how should we proceed here? Can you approve the patch?
I also have no committer rights to the project, so does that mean you (or
someone else) need to commit it on my behalf?
http://reviews.llvm.org/D15883
___
cfe-c
11 matches
Mail list logo
