tom-anders wrote:
Hi everyone, I shifted focus to other projects and currently don't have time to
work on this PR anymore. If somebody wants to take over, feel free to do so
https://github.com/llvm/llvm-project/pull/78491
___
cfe-commits mailing list
tom-anders wrote:
> ping - [Support for textDocument/rangesFormatting is about to be merged into
> neovim](https://github.com/neovim/neovim/pull/27323), so we'll soon have at
> least two editors (nvim, vscode) with support for this
Update: neovim PR has been merged
https://github.com/llvm/llv
https://github.com/tom-anders edited
https://github.com/llvm/llvm-project/pull/89557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3941,6 +3945,157 @@ TEST(Hover, DisableShowAKA) {
EXPECT_EQ(H->Type, HoverInfo::PrintedType("m_int"));
}
+TEST(Hover, ShowFields) {
+ struct {
+const char *const Code;
+const std::function ExpectedBuilder;
+ } Cases[] = {
+{
+ R"cpp(// Struct
+
https://github.com/tom-anders commented:
Looks really useful, especially for enums!
https://github.com/llvm/llvm-project/pull/89557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tom-anders wrote:
ping
https://github.com/llvm/llvm-project/pull/77766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tom-anders wrote:
ping - [Support for textDocument/rangesFormatting is about to be merged into
neovim](https://github.com/neovim/neovim/pull/27323), so we'll soon have at
least two editors (nvim, vscode) with support for this
https://github.com/llvm/llvm-project/pull/80180
tom-anders wrote:
> We should probably rekindle the discussion on the associated bug report; I
> think users (rightly) expect this feature.
Agreed, [maybe a protocol extension would also be an
option](https://github.com/clangd/clangd/issues/445#issuecomment-1250355799)
https://github.com/llvm
tom-anders wrote:
> The new patch set properly considers "external" definitions (using the
> frowned-upon index lookup).
I've been using this patch for a few weeks now, and it works very well. Haven't
encountered any issues/crashes yet. Performance also seems reasonable (working
in a medium-s
tom-anders wrote:
Rebased to fixed merge conflict, extend lit test with test for new
`rangesFormatting` request
@sam-mccall @HighCommander4 ping
https://github.com/llvm/llvm-project/pull/80180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/tom-anders updated
https://github.com/llvm/llvm-project/pull/80180
>From 19ae86fb821c908fbd29515f36282c3aa0745048 Mon Sep 17 00:00:00 2001
From: tom-anders <13141438+tom-and...@users.noreply.github.com>
Date: Thu, 18 May 2023 12:05:01 +0200
Subject: [PATCH] [clangd] Add suppor
tom-anders wrote:
(ping)
https://github.com/llvm/llvm-project/pull/80180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tom-anders closed
https://github.com/llvm/llvm-project/pull/78454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tom-anders updated
https://github.com/llvm/llvm-project/pull/78454
>From 3a1ef6006764bd4d307ceec74199ed81a18aba2d Mon Sep 17 00:00:00 2001
From: tom-anders <13141438+tom-and...@users.noreply.github.com>
Date: Wed, 17 Jan 2024 15:36:02 +0100
Subject: [PATCH] [clangd] forward cl
tom-anders wrote:
> Something else I noticed while trying out the patch locally: before the
> patch, the description of the code action in the editor is "change 'foo' to
> 'Foo'", i.e. a description of what the code action will do.
>
> After the patch, the description of the code action is now
@@ -648,6 +649,27 @@ tweakSelection(const Range &Sel, const InputsAndAST &AST,
return std::move(Result);
}
+// Some fixes may perform local renaming, we want to convert those to clangd
+// rename commands, such that we can leverage the index for more accurate
+// results.
+s
https://github.com/tom-anders updated
https://github.com/llvm/llvm-project/pull/78454
>From 0f4be9fe945a23598c6eb49d733e0a709375669d Mon Sep 17 00:00:00 2001
From: tom-anders <13141438+tom-and...@users.noreply.github.com>
Date: Wed, 17 Jan 2024 15:36:02 +0100
Subject: [PATCH] [clangd] forward cl
tom-anders wrote:
(fixed formatting issues)
https://github.com/llvm/llvm-project/pull/78454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tom-anders wrote:
> Looks pretty good!
>
> Are there further changes you're planning to make, or is this ready to
> graduate from "Draft" status?
Ah, thanks about the heads up, forgot about this
https://github.com/llvm/llvm-project/pull/78454
___
c
https://github.com/tom-anders ready_for_review
https://github.com/llvm/llvm-project/pull/78454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tom-anders updated
https://github.com/llvm/llvm-project/pull/80180
>From d7a498dea69a8e1efb9cc143635a1c32246756f0 Mon Sep 17 00:00:00 2001
From: tom-anders <13141438+tom-and...@users.noreply.github.com>
Date: Thu, 18 May 2023 12:05:01 +0200
Subject: [PATCH] [clangd] Add suppor
https://github.com/tom-anders ready_for_review
https://github.com/llvm/llvm-project/pull/80180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tom-anders wrote:
Adapted to spec, it's now a separate request
(`textDocument/range**s**Formatting`).
Will add some tests if this gets positive feedback
https://github.com/llvm/llvm-project/pull/80180
___
cfe-commits mailing list
cfe-commits@lists.l
https://github.com/tom-anders updated
https://github.com/llvm/llvm-project/pull/80180
>From 0377dc355affd982033469a3a6be97c434e88286 Mon Sep 17 00:00:00 2001
From: tom-anders <13141438+tom-and...@users.noreply.github.com>
Date: Thu, 18 May 2023 12:05:01 +0200
Subject: [PATCH] [clangd] Add suppor
https://github.com/tom-anders updated
https://github.com/llvm/llvm-project/pull/80180
>From 5a807c6039e7213cea38f7f8c2413e8b6cc8b4ba Mon Sep 17 00:00:00 2001
From: tom-anders <13141438+tom-and...@users.noreply.github.com>
Date: Thu, 18 May 2023 12:05:01 +0200
Subject: [PATCH] [clangd] Add multiR
https://github.com/tom-anders edited
https://github.com/llvm/llvm-project/pull/80180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tom-anders converted_to_draft
https://github.com/llvm/llvm-project/pull/80180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tom-anders wrote:
Hmm so it looks like there have been some changes to the proposed LSP spec
since my original phabricator diff, so I think I need to adapt this PR a bit.
Will convert to a draft for now.
https://github.com/llvm/llvm-project/pull/80180
__
https://github.com/tom-anders created
https://github.com/llvm/llvm-project/pull/80180
Uses the protocol changes proposed in
https://github.com/microsoft/language-server-protocol/pull/1556 and
https://github.com/microsoft/vscode/pull/163190
Related issue: https://github.com/clangd/clangd/issue
https://github.com/tom-anders updated
https://github.com/llvm/llvm-project/pull/78454
>From 579d681323db5f92d494f0cd0aaa9158dc8c4e3b Mon Sep 17 00:00:00 2001
From: tom-anders <13141438+tom-and...@users.noreply.github.com>
Date: Wed, 17 Jan 2024 15:36:02 +0100
Subject: [PATCH] [clangd] forward cl
tom-anders wrote:
Thanks for the feedback!
> Thanks, the approach in this patch looks pretty good to me.
>
> My only feedback is to encapsulate the "hard coding" into a function like:
>
> ```
> Option TryConvertToRename(const Diag *D, const Fix
> *F)
> ```
>
> because I can imagine in the fu
tom-anders wrote:
Duplicate issue: https://github.com/clangd/clangd/issues/741
https://github.com/llvm/llvm-project/pull/78454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tom-anders updated
https://github.com/llvm/llvm-project/pull/78491
>From 640318fcf475a82b5483889795e2bd906b7b3c9c Mon Sep 17 00:00:00 2001
From: Tom Praschan <13141438+tom-and...@users.noreply.github.com>
Date: Sat, 18 Feb 2023 15:54:09 +0100
Subject: [PATCH] [clangd] Support
https://github.com/tom-anders edited
https://github.com/llvm/llvm-project/pull/78491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tom-anders created
https://github.com/llvm/llvm-project/pull/78491
This is in preparation for implementing doxygen parsing, see discussion in
https://github.com/clangd/clangd/issues/529.
(Old Phabricator review: https://reviews.llvm.org/D143112)
>From b5b4ddc967df436d0879cb
https://github.com/tom-anders updated
https://github.com/llvm/llvm-project/pull/78454
>From 1fb6fb163bf2e63cb30571b179768bae2f43eb71 Mon Sep 17 00:00:00 2001
From: tom-anders <13141438+tom-and...@users.noreply.github.com>
Date: Wed, 17 Jan 2024 15:36:02 +0100
Subject: [PATCH] [clangd] forward cl
https://github.com/tom-anders created
https://github.com/llvm/llvm-project/pull/78454
None
>From 71619f8dc07ca038b8e2e30d89f308c1e38a0726 Mon Sep 17 00:00:00 2001
From: tom-anders <13141438+tom-and...@users.noreply.github.com>
Date: Wed, 17 Jan 2024 15:36:02 +0100
Subject: [PATCH] [clangd] forw
https://github.com/tom-anders created
https://github.com/llvm/llvm-project/pull/77766
Relevant issue: https://github.com/clangd/clangd/issues/1361
The problem here was that writing something like `using ns::ScopedEnum` does
not cause Sema to visit this scope, to it won't be added into
`CodeCo
Author: Tom Praschan
Date: 2023-04-29T14:37:16+02:00
New Revision: cb133a4629a56f8c8a67fb7549356839917b52f9
URL:
https://github.com/llvm/llvm-project/commit/cb133a4629a56f8c8a67fb7549356839917b52f9
DIFF:
https://github.com/llvm/llvm-project/commit/cb133a4629a56f8c8a67fb7549356839917b52f9.diff
Author: Tom Praschan
Date: 2023-04-28T21:46:32+02:00
New Revision: a7b4fd953f44b790f8832a5b57d7598bd12adfb2
URL:
https://github.com/llvm/llvm-project/commit/a7b4fd953f44b790f8832a5b57d7598bd12adfb2
DIFF:
https://github.com/llvm/llvm-project/commit/a7b4fd953f44b790f8832a5b57d7598bd12adfb2.diff
Author: Tom Praschan
Date: 2023-02-09T20:53:33+01:00
New Revision: ce87b031437071f011026bb850a2fb2e5f9a72b4
URL:
https://github.com/llvm/llvm-project/commit/ce87b031437071f011026bb850a2fb2e5f9a72b4
DIFF:
https://github.com/llvm/llvm-project/commit/ce87b031437071f011026bb850a2fb2e5f9a72b4.diff
Author: Tom Praschan
Date: 2023-01-14T23:20:42+01:00
New Revision: 343b1ae3622afed50c9734a8f40b368d8afef5c5
URL:
https://github.com/llvm/llvm-project/commit/343b1ae3622afed50c9734a8f40b368d8afef5c5
DIFF:
https://github.com/llvm/llvm-project/commit/343b1ae3622afed50c9734a8f40b368d8afef5c5.diff
Author: Tom Praschan
Date: 2023-01-01T15:25:18+01:00
New Revision: d408c34d1f588e518b0ee15c00b55db131944cfb
URL:
https://github.com/llvm/llvm-project/commit/d408c34d1f588e518b0ee15c00b55db131944cfb
DIFF:
https://github.com/llvm/llvm-project/commit/d408c34d1f588e518b0ee15c00b55db131944cfb.diff
Author: v1nh1shungry
Date: 2022-12-28T13:34:43+01:00
New Revision: 46575f60380b18bf20c5f4cafc5fd06f561c4e7b
URL:
https://github.com/llvm/llvm-project/commit/46575f60380b18bf20c5f4cafc5fd06f561c4e7b
DIFF:
https://github.com/llvm/llvm-project/commit/46575f60380b18bf20c5f4cafc5fd06f561c4e7b.diff
Author: Tom Praschan
Date: 2022-11-18T15:00:23+01:00
New Revision: 3cf14a7bdce08f8fe03d987a2d99c6ea47c58c03
URL:
https://github.com/llvm/llvm-project/commit/3cf14a7bdce08f8fe03d987a2d99c6ea47c58c03
DIFF:
https://github.com/llvm/llvm-project/commit/3cf14a7bdce08f8fe03d987a2d99c6ea47c58c03.diff
Author: Tom Praschan
Date: 2022-11-17T00:37:16+01:00
New Revision: 0e00611cbc2b2f27e247a58b512cb2cec0624290
URL:
https://github.com/llvm/llvm-project/commit/0e00611cbc2b2f27e247a58b512cb2cec0624290
DIFF:
https://github.com/llvm/llvm-project/commit/0e00611cbc2b2f27e247a58b512cb2cec0624290.diff
Author: v1nh1shungry
Date: 2022-11-09T21:04:21+01:00
New Revision: 82ca918b5755f3c442e247563dc011f7b310e446
URL:
https://github.com/llvm/llvm-project/commit/82ca918b5755f3c442e247563dc011f7b310e446
DIFF:
https://github.com/llvm/llvm-project/commit/82ca918b5755f3c442e247563dc011f7b310e446.diff
Author: v1nh1shungry
Date: 2022-11-06T18:31:20+01:00
New Revision: f5a2ef80fa47d657877d5be314ce29ff7195d887
URL:
https://github.com/llvm/llvm-project/commit/f5a2ef80fa47d657877d5be314ce29ff7195d887
DIFF:
https://github.com/llvm/llvm-project/commit/f5a2ef80fa47d657877d5be314ce29ff7195d887.diff
Author: Tom Praschan
Date: 2022-11-02T20:38:01+01:00
New Revision: 990c189379679f92cd9af4cd384e476a94c0e819
URL:
https://github.com/llvm/llvm-project/commit/990c189379679f92cd9af4cd384e476a94c0e819
DIFF:
https://github.com/llvm/llvm-project/commit/990c189379679f92cd9af4cd384e476a94c0e819.diff
Author: Tom Praschan
Date: 2022-11-02T12:50:50+01:00
New Revision: a68bcd81dcc90fc7d6fbe4013569774a19097c4a
URL:
https://github.com/llvm/llvm-project/commit/a68bcd81dcc90fc7d6fbe4013569774a19097c4a
DIFF:
https://github.com/llvm/llvm-project/commit/a68bcd81dcc90fc7d6fbe4013569774a19097c4a.diff
Author: Tom Praschan
Date: 2022-10-26T12:51:36+02:00
New Revision: d2135df4b5fb7eb5ca9135318adc3e20536301c0
URL:
https://github.com/llvm/llvm-project/commit/d2135df4b5fb7eb5ca9135318adc3e20536301c0
DIFF:
https://github.com/llvm/llvm-project/commit/d2135df4b5fb7eb5ca9135318adc3e20536301c0.diff
Author: Tom Praschan
Date: 2022-10-13T21:09:25+02:00
New Revision: a8124eea9df513a5565805b480c227fa88751359
URL:
https://github.com/llvm/llvm-project/commit/a8124eea9df513a5565805b480c227fa88751359
DIFF:
https://github.com/llvm/llvm-project/commit/a8124eea9df513a5565805b480c227fa88751359.diff
Author: Tom Praschan
Date: 2022-10-09T14:16:12+02:00
New Revision: ac21938fbdfa75f1eb4ca399dac4fbf3e90d472d
URL:
https://github.com/llvm/llvm-project/commit/ac21938fbdfa75f1eb4ca399dac4fbf3e90d472d
DIFF:
https://github.com/llvm/llvm-project/commit/ac21938fbdfa75f1eb4ca399dac4fbf3e90d472d.diff
Author: Tom Praschan
Date: 2022-09-21T00:45:26+02:00
New Revision: 60528c690a4c334d2a3a2c22eb97af9e67d7a91d
URL:
https://github.com/llvm/llvm-project/commit/60528c690a4c334d2a3a2c22eb97af9e67d7a91d
DIFF:
https://github.com/llvm/llvm-project/commit/60528c690a4c334d2a3a2c22eb97af9e67d7a91d.diff
Author: Tom Praschan
Date: 2022-09-15T13:02:58+02:00
New Revision: 220d850823494aad48d984395512e2ac74c666de
URL:
https://github.com/llvm/llvm-project/commit/220d850823494aad48d984395512e2ac74c666de
DIFF:
https://github.com/llvm/llvm-project/commit/220d850823494aad48d984395512e2ac74c666de.diff
Author: Tom Praschan
Date: 2022-08-11T08:50:23+02:00
New Revision: 15bf2aa44aa1ffa049782316273f84c2db682e50
URL:
https://github.com/llvm/llvm-project/commit/15bf2aa44aa1ffa049782316273f84c2db682e50
DIFF:
https://github.com/llvm/llvm-project/commit/15bf2aa44aa1ffa049782316273f84c2db682e50.diff
56 matches
Mail list logo
