[PATCH] D134425: [NFC] Create a AllocLikeOpInterface and make memref::AllocOp, memref::AllocaOp and gpu::AllocOp implement it.

bondhugula added a comment. This is looking good to me. Please pull out changes unrelated to AllocLikeOpInterface into a separate revision (the ones just switching to `hasSingleEffect`). Comment at: mlir/lib/Dialect/Affine/Transforms/LoopFusion.cpp:1967 auto *op =

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

bondhugula added inline comments. Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:42 -template -struct DenseMapInfo { +template struct DenseMapInfo { //static inline T getEmptyKey(); A code comment here? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

bondhugula added a comment. In D112284#3088531 , @tra wrote: > In D112284#3086499 , @bondhugula > wrote: > >> @tra While on this, I also wanted to ask as to why clang cuda codegen is >> using an argument on the

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

This revision was automatically updated to reflect the committed changes. bondhugula marked an inline comment as done. Closed by commit rG9fb9c6b91e3a: [Clang][NFC] Clang CUDA codegen clean-up (authored by bondhugula). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

bondhugula added a comment. @tra While on this, I also wanted to ask as to why clang cuda codegen is using an argument on the global ctor and the dtor it's generating. The argument is unused and I couldn't find any code comments to support it in either `CGCUDANV.cpp` or `CodeGenModule.cpp`. I

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

bondhugula updated this revision to Diff 382201. bondhugula marked an inline comment as done. bondhugula retitled this revision from "[Clang][NFC] Clang CUDA codegen: a dyn_cast -> cast instance + clang-tidy fixes" to "[Clang][NFC] Clang CUDA codegen clean-up". bondhugula edited the summary of

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen: a dyn_cast -> cast instance + clang-tidy fixes

bondhugula marked an inline comment as done. bondhugula added a comment. In D112284#3085086 , @tra wrote: > The description is a bit misleading. The dyn_cast->cast appears to be a minor > part of this patch. > I'd separate clang-tidy cleanups into a

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen: a dyn_cast -> cast instance + clang-tidy fixes

bondhugula added a comment. Gentle ping to reviewers @tra @yaxunl on this NFC PR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112284/new/ https://reviews.llvm.org/D112284 ___ cfe-commits mailing list

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen: a dyn_cast -> cast instance + clang-tidy fixes

bondhugula updated this revision to Diff 381441. bondhugula added a comment. Drop redundant cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112284/new/ https://reviews.llvm.org/D112284 Files: clang/lib/CodeGen/CGCUDANV.cpp Index:

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen: a dyn_cast -> cast instance + clang-tidy fixes

bondhugula created this revision. bondhugula added a reviewer: tra. Herald added subscribers: carlosgalvezp, Groverkss, bollu, yaxunl. bondhugula requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update an instance of dyn_cast -> cast in

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

bondhugula added a comment. This is a really welcome change! Multiple registration issues were really an inconvenience - I had no clue this was the pattern to use to fix it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105959/new/

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

bondhugula added a comment. In D77984#1979644 , @bondhugula wrote: > This revision has broken an MLIR test case that test conversion to LLVM IR > (test/Target/llvmir.mlir - an llvm.alloca in MLIR with its alignment > attribute set to 0 now converts into

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

bondhugula added a comment. This revision has broken MLIR test cases that test conversion to llvm IR (test/Target/llvmir.mlir - an llvm.alloca in MLIR with its alignment attribute set to 0 now converts into an LLVM IR alloca with alignment automatically set to 4 - I think the fix is trivial).

[PATCH] D77859: Revert "[DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff."

bondhugula abandoned this revision. bondhugula added a comment. Another revision performed this revert. Dropping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77859/new/ https://reviews.llvm.org/D77859

[PATCH] D77859: Revert "[DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff."

bondhugula created this revision. bondhugula added reviewers: asbirlea, mehdi_amini, rriddle. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. This reverts commit a90374988e4eb8c50d91e11f4e61cdbd5debb235

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

bondhugula added a comment. @asbirlea This has broken the MLIR build. Could you please build with `-DLLVM_ENABLE_PROJECTS=mlir`? FAILED: tools/mlir/lib/Analysis/CMakeFiles/MLIRAnalysis.dir/Dominance.cpp.o /usr/lib64/ccache/clang++ -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=1