[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon abandoned this revision. segoon added a comment. see https://reviews.llvm.org/D94622#2617417 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon abandoned this revision. segoon added a comment. see https://reviews.llvm.org/D94622#2617417 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added a comment. It seems that the related file structure (IOW, "separated coroutine code and non-coroutine code" rule) is indeed specific to Yandex.Taxi. I asked multiple developers in different companies and no one could confirm they align with the rule. The checks in the current form

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon updated this revision to Diff 323008. segoon added a comment. -fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 Files: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon updated this revision to Diff 323006. segoon added a comment. - add WinAPI support CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 Files: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp:22 +/* C++ std */ +"::std::async", // + aaron.ballman wrote: > segoon wrote: > > aaron.ballman wrote: > > > The trailing comment markers don't

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp:22 +/* C++ std */ +"::std::async", // + aaron.ballman wrote: > The trailing comment markers don't really add much. it's a hack for

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added a comment. alexfh, aaron.ballman, hi! Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. alexfh, aaron.ballman, hi! Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added a reviewer: alexfh_. segoon added a comment. alexfh, aaron.ballman, hi! Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 ___ cfe-commits mailing list

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon updated this revision to Diff 322696. segoon added a comment. Herald added a subscriber: nullptr.cpp. - explicitly state in docs that the check must be used only for async code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 Files:

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon updated this revision to Diff 322695. segoon added a comment. Herald added a subscriber: nullptr.cpp. - explicitly state in docs that the check must be used only for async code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 Files:

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon updated this revision to Diff 322685. segoon added a comment. Herald added a subscriber: nullptr.cpp. - explicitly state in docs that the check must be used only for async code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 Files:

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added a comment. alexfh, hi! any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added a comment. Eugene.Zelenko, njames93, any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. Eugene.Zelenko, njames93, any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added a comment. Eugene.Zelenko, njames93, any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added a comment. Eugene.Zelenko, thanks for the review! fixed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. Eugene.Zelenko, thanks for the review! fixed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon updated this revision to Diff 316667. segoon added a comment. - use back-ticks - fix the first document line - add default values CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 Files:

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon updated this revision to Diff 316664. segoon edited the summary of this revision. segoon added a comment. - fix the first document line - add default values CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 Files:

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. njames93, the purpose is to flag it indeed. This approach was found valueable in Yandex.Taxi, as it is very easy to forget that you're in a coroutine and may not use blocking API. The bug does affect performance (e.g. all coroutine threads wait for fs), it cannot be

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon updated this revision to Diff 316460. segoon retitled this revision from "docs" to "[clang-tidy] add concurrency-async-fs". segoon edited the summary of this revision. segoon added a comment. Herald added subscribers: ormris, xazax.hun, mgorny. fix CHANGES SINCE LAST ACTION

[PATCH] D94621: docs

segoon created this revision. segoon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94621 Files: clang-tools-extra/docs/clang-tidy/checks/concurrency-async-fs.rst

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added a comment. friendly ping, any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon updated this revision to Diff 314631. segoon edited the summary of this revision. segoon added a comment. Herald added a subscriber: lxfind. - review fixes - drop of atomic::is_always_lock_free check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/concurrency-async-blocking.cpp:450 + +// TODO: remove CHECKT-MESSAGES njames93 wrote: > Whats this for? WIP tests for not yet ready atomic::is_always_lock_free check CHANGES

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp:35 +/* C++ std */ +"std::mutex", // +"std::timed_mutex", // njames93 wrote: > Is it wise to fully qualify these? >

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon updated this revision to Diff 314136. segoon marked 19 inline comments as done. segoon added a comment. review fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 Files: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon updated this revision to Diff 314093. segoon retitled this revision from "Add a check for blocking types and functions." to "[clang-tidy] Add a check for blocking types and functions.". segoon added a comment. Herald added a reviewer: jfb. Herald added subscribers: xazax.hun, mgorny.

[PATCH] D93940: Add a check for blocking types and functions.

segoon updated this revision to Diff 314092. segoon added a comment. up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 Files: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp Index:

[PATCH] D93940: Add a check for blocking types and functions.

segoon created this revision. Herald added a subscriber: jfb. segoon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The preemptive functions/types can be separated into the following categories: - explicit sleep(3)-like functions -

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon added a comment. In D90944#2419420 , @lebedev.ri wrote: > Please upload all patches with full context (`-U`) Done. > I'm guessing you'll need help committing this, in which case please specify > `Author ` to be used for `git commit

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 307981. segoon added a comment. - git diff -U CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/concurrency/CMakeLists.txt

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 307979. segoon added a comment. - git dif -U CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/ClangTidyForceLinker.h

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 307903. segoon added a comment. - revert decls marking CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/concurrency/CMakeLists.txt

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon added a comment. In D90944#2418845 , @lebedev.ri wrote: > In D90944#2418792 , @segoon wrote: > >> - mark mt-unsafe decls and check for marks in exprs > > Eeeh. > I was thinking of either some smart matcher

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 307883. segoon added a comment. - fix sort order CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/ClangTidyForceLinker.h

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 307884. segoon added a comment. - move static vectors out of namespace - mark mt-unsafe decls and check for marks in exprs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files:

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. lebedev.ri, any comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. In D91656#2411072 , @lebedev.ri wrote: > LGTM thanks for comments, fixed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 307039. segoon added a comment. - sort order - do not link with FrontendOpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. jdoerfert, alexfh, hokein, aaron.ballman, Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. In D91656#2402245 , @njames93 wrote: > Can you remove the code related to adding the mt-unsafe-posix check. Sorry, I've added unnecessary files. Removed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 306044. segoon added a comment. - remove garbage files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 306022. segoon retitled this revision from "[clang-tidy] add concurrent module" to "[clang-tidy] add concurrency module". segoon added a comment. - concurrent -> concurrency CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 306020. segoon retitled this revision from "[clang-tidy] implement concurrent-mt-unsafe" to "[clang-tidy] implement concurrency-mt-unsafe". segoon added a comment. - concurrent -> concurrency - split the patch apart CHANGES SINCE LAST ACTION

[PATCH] D91656: [clang-tidy] add concurrent module

segoon created this revision. segoon added a reviewer: njames93. Herald added subscribers: cfe-commits, lxfind, arphaman, modocache, xazax.hun, mgorny. Herald added a project: clang. segoon requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1.

[PATCH] D90944: [clang-tidy] implement concurrent-mt-unsafe

segoon updated this revision to Diff 305764. segoon retitled this revision from "[clang-tidy] implement misc-mt-unsafe" to "[clang-tidy] implement concurrent-mt-unsafe". segoon added a comment. Herald added subscribers: sstefan1, arphaman. Herald added a reviewer: jdoerfert. - move plugin to

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MtUnsafeCheck.cpp:295 + case MtUnsafeCheck::LibcType::Any: +return hasAnyName(anyFunctions); + } lebedev.ri wrote: > return anyOf(hasAnyName(posixFunctions),

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon added a comment. In D90944#2380910 , @lebedev.ri wrote: > What i would however like to be improved, is better docs. I hope I'll addressed your questions in documentation. Please tell me whether you still have any unanswered questions. CHANGES

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 305460. segoon added a comment. - minor changes to docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 304189. segoon edited the summary of this revision. segoon added a comment. - add `Libc` option - improve docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files:

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 303532. segoon added a comment. - use static instead of namespace {} - don't use SourceRange() - revert unrelated changes to .rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files:

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon added a comment. In D90944#2379688 , @njames93 wrote: > It appears to not check for signs that the code is running in a multi > threaded manner, This will result in many false positives in code that is > known to be single threaded. I'm not sure

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon marked an inline comment as done. segoon added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:33 `abseil-upgrade-duration-conversions `_, "Yes" - `altera-struct-pack-align `_, + `altera-struct-pack-align `_, "Yes"

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon marked an inline comment as done. segoon added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-mt-unsafe.cpp:3-4 + +#include +#include + lebedev.ri wrote: > Tests should be hermetic, they can not use headers from system

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 303499. segoon added a comment. don't include any system headers in tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon created this revision. segoon added a reviewer: alexfh. Herald added subscribers: cfe-commits, lxfind, modocache, xazax.hun, mgorny. Herald added a project: clang. segoon requested review of this revision. Checks for some thread-unsafe functions against a black list of known-to-be-unsafe