[clang] 0c4935b - [docs/Coverage] Document -show-region-summary

Author: Vedant Kumar Date: 2021-02-12T12:05:45-08:00 New Revision: 0c4935bb85166a4a0bf87a320b81e400d7be04f0 URL: https://github.com/llvm/llvm-project/commit/0c4935bb85166a4a0bf87a320b81e400d7be04f0 DIFF: https://github.com/llvm/llvm-project/commit/0c4935bb85166a4a0bf87a320b81e400d7be04f0.diff

[clang] 13bd6fb - [docs/Coverage] Answer FAQ about optimization

Author: Vedant Kumar Date: 2021-02-12T12:05:38-08:00 New Revision: 13bd6fb43da9e9b1d7e82272325ec781d1f16456 URL: https://github.com/llvm/llvm-project/commit/13bd6fb43da9e9b1d7e82272325ec781d1f16456 DIFF: https://github.com/llvm/llvm-project/commit/13bd6fb43da9e9b1d7e82272325ec781d1f16456.diff

[clang] e05baf4 - [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

Author: Vedant Kumar Date: 2021-01-08T15:13:04-08:00 New Revision: e05baf40de8a3bbfcf4a765761b1147e94b7309c URL: https://github.com/llvm/llvm-project/commit/e05baf40de8a3bbfcf4a765761b1147e94b7309c DIFF: https://github.com/llvm/llvm-project/commit/e05baf40de8a3bbfcf4a765761b1147e94b7309c.diff

[clang] 06bc685 - [ubsan] nullability-arg: Fix crash on C++ member pointers

Author: Vedant Kumar Date: 2020-09-28T09:41:18-07:00 New Revision: 06bc685fa2400cc28282ab6dd3c917d45bfa662f URL: https://github.com/llvm/llvm-project/commit/06bc685fa2400cc28282ab6dd3c917d45bfa662f DIFF: https://github.com/llvm/llvm-project/commit/06bc685fa2400cc28282ab6dd3c917d45bfa662f.diff

[clang] 62c3727 - [profile] Add %t LLVM_PROFILE_FILE option to substitute $TMPDIR

Author: Vedant Kumar Date: 2020-09-25T09:39:40-07:00 New Revision: 62c372770d2e87f3e882a20d43c6814e6c4fe0f5 URL: https://github.com/llvm/llvm-project/commit/62c372770d2e87f3e882a20d43c6814e6c4fe0f5 DIFF: https://github.com/llvm/llvm-project/commit/62c372770d2e87f3e882a20d43c6814e6c4fe0f5.diff

Re: [PATCH] D79219: [CMake] Simplify CMake handling for zlib

Thanks, that addressed the issue. > On Jul 24, 2020, at 1:41 PM, Petr Hosek wrote: > > Thanks for the heads up, this should be addressed by > c86f56e32e724c6018e579bb2bc11e667c96fc96, let me know if there are other > issues. > > On Fri, Jul 24, 2020 at 12:33 PM Vedant Kumar via Phabricator >

[clang] 8c4a65b - [ubsan] Check implicit casts in ObjC for-in statements

Author: Vedant Kumar Date: 2020-07-13T15:11:18-07:00 New Revision: 8c4a65b9b2ca6961139beca92de37eea479f00fa URL: https://github.com/llvm/llvm-project/commit/8c4a65b9b2ca6961139beca92de37eea479f00fa DIFF: https://github.com/llvm/llvm-project/commit/8c4a65b9b2ca6961139beca92de37eea479f00fa.diff

[clang] a66e1d2 - [os_log][test] Remove -O1 from a test, NFC

Author: Vedant Kumar Date: 2020-06-01T16:54:16-07:00 New Revision: a66e1d2aa943959e158821be8956109cb5ef3b3b URL: https://github.com/llvm/llvm-project/commit/a66e1d2aa943959e158821be8956109cb5ef3b3b DIFF: https://github.com/llvm/llvm-project/commit/a66e1d2aa943959e158821be8956109cb5ef3b3b.diff

[clang] cfb4f8c - [DirectoryWatcher] Do not use FSEvents on non-macOS platforms

Author: Vedant Kumar Date: 2020-04-23T10:22:28-07:00 New Revision: cfb4f8c5fbc6fd8ad06bcfc6f91926b6d55d3766 URL: https://github.com/llvm/llvm-project/commit/cfb4f8c5fbc6fd8ad06bcfc6f91926b6d55d3766 DIFF: https://github.com/llvm/llvm-project/commit/cfb4f8c5fbc6fd8ad06bcfc6f91926b6d55d3766.diff

[clang] 47622ef - [clang/test] Add test for DIFlagAllCallsDescribed under -ggdb + -gdwarf-4, NFC

Author: Vedant Kumar Date: 2020-03-18T15:24:13-07:00 New Revision: 47622efc6f01532ef1c23490f516efb9081827f8 URL: https://github.com/llvm/llvm-project/commit/47622efc6f01532ef1c23490f516efb9081827f8 DIFF: https://github.com/llvm/llvm-project/commit/47622efc6f01532ef1c23490f516efb9081827f8.diff

[clang] dd1ea9d - Reland: [Coverage] Revise format to reduce binary size

Author: Vedant Kumar Date: 2020-02-28T18:12:04-08:00 New Revision: dd1ea9de2e3e3ac80a620f71411a9a36449f2697 URL: https://github.com/llvm/llvm-project/commit/dd1ea9de2e3e3ac80a620f71411a9a36449f2697 DIFF: https://github.com/llvm/llvm-project/commit/dd1ea9de2e3e3ac80a620f71411a9a36449f2697.diff

[clang] 3388871 - Revert "[Coverage] Revise format to reduce binary size"

Author: Vedant Kumar Date: 2020-02-28T18:03:15-08:00 New Revision: 3388871714d3b718b823e76499b0c03877105e5d URL: https://github.com/llvm/llvm-project/commit/3388871714d3b718b823e76499b0c03877105e5d DIFF: https://github.com/llvm/llvm-project/commit/3388871714d3b718b823e76499b0c03877105e5d.diff

[clang] c54597b - [ubsan] Add support for -fsanitize=nullability-* suppressions

Author: Vedant Kumar Date: 2020-02-28T14:30:40-08:00 New Revision: c54597b99d6f6ea51616168a0c2ff3850c3869eb URL: https://github.com/llvm/llvm-project/commit/c54597b99d6f6ea51616168a0c2ff3850c3869eb DIFF: https://github.com/llvm/llvm-project/commit/c54597b99d6f6ea51616168a0c2ff3850c3869eb.diff

[clang] 8b81ebf - [ubsan] Null-check and adjust TypeLoc before using it

Author: Vedant Kumar Date: 2020-02-10T14:10:06-08:00 New Revision: 8b81ebfe7eba089ed2016d523cc5ee9d05e957a7 URL: https://github.com/llvm/llvm-project/commit/8b81ebfe7eba089ed2016d523cc5ee9d05e957a7 DIFF: https://github.com/llvm/llvm-project/commit/8b81ebfe7eba089ed2016d523cc5ee9d05e957a7.diff

[clang] 65f0785 - [ubsan] Omit return value check when return block is unreachable

Author: Vedant Kumar Date: 2020-02-06T10:24:03-08:00 New Revision: 65f0785fff0e45f8cd1b9e90328597197beef899 URL: https://github.com/llvm/llvm-project/commit/65f0785fff0e45f8cd1b9e90328597197beef899 DIFF: https://github.com/llvm/llvm-project/commit/65f0785fff0e45f8cd1b9e90328597197beef899.diff

[clang] a156da5 - [clang/Darwin] Remove __llvm_profile_counter_bias from export list for profiling

Author: Vedant Kumar Date: 2020-01-21T16:52:01-08:00 New Revision: a156da5fb361fd38ba379ec20856626c9e35f829 URL: https://github.com/llvm/llvm-project/commit/a156da5fb361fd38ba379ec20856626c9e35f829 DIFF: https://github.com/llvm/llvm-project/commit/a156da5fb361fd38ba379ec20856626c9e35f829.diff

Re: [clang] 12038be - [Concepts] Fix crash in D41910

I've temporarily reverted the D41910 patchset in order to get the lldb bot unstuck (5094e6dad64). vedant > On Dec 18, 2019, at 1:34 PM, Vedant Kumar wrote: > > Hey Saar, > Do you expect this to address this crash seen on the lldb bot after D41910 > landed? > > Assertion failed: (Idx < size()

Re: [clang] 12038be - [Concepts] Fix crash in D41910

Hey Saar, Do you expect this to address this crash seen on the lldb bot after D41910 landed? Assertion failed: (Idx < size() && "Out-of-bounds Bit access."), function operator[], file /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ADT/SmallBitVector.h, line 452.

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

Thanks John, the bot has recovered. > On Dec 16, 2019, at 1:08 PM, John McCall via cfe-commits > wrote: > > On 16 Dec 2019, at 15:11, John McCall wrote: >> On 16 Dec 2019, at 15:07, Vedant Kumar wrote: >>> Hi John, >>> >>> The lldb bot went red after your clang AST changes landed: >>> http://

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

Hi John, The lldb bot went red after your clang AST changes landed: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4801/changes#detail0 All of the test failures were due to a clang assertion: Assertion fail

[clang] 3e1562e - Debug Info: Strengthen the synthesized-property-cleanup.mm test, NFC

Author: Vedant Kumar Date: 2019-12-10T13:39:22-08:00 New Revision: 3e1562e83339bb1e18fb36a5a2fc629c75f5f239 URL: https://github.com/llvm/llvm-project/commit/3e1562e83339bb1e18fb36a5a2fc629c75f5f239 DIFF: https://github.com/llvm/llvm-project/commit/3e1562e83339bb1e18fb36a5a2fc629c75f5f239.diff

[clang] 859bf4d - [Coverage] Emit a gap region to cover switch bodies

Author: Vedant Kumar Date: 2019-12-03T12:35:54-08:00 New Revision: 859bf4d2bea2404bd2eac92451f2db4371ec6eb4 URL: https://github.com/llvm/llvm-project/commit/859bf4d2bea2404bd2eac92451f2db4371ec6eb4 DIFF: https://github.com/llvm/llvm-project/commit/859bf4d2bea2404bd2eac92451f2db4371ec6eb4.diff

[clang] 568db78 - [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

Author: Vedant Kumar Date: 2019-11-19T12:49:27-08:00 New Revision: 568db780bb7267651a902da8e85bc59fc89aea70 URL: https://github.com/llvm/llvm-project/commit/568db780bb7267651a902da8e85bc59fc89aea70 DIFF: https://github.com/llvm/llvm-project/commit/568db780bb7267651a902da8e85bc59fc89aea70.diff

[clang] ea1db31 - [CodeGen] Assign locations to calls to special struct helpers

Author: Vedant Kumar Date: 2019-11-18T15:07:59-08:00 New Revision: ea1db31d20a74e5025a86b0df49163d5bfecb67b URL: https://github.com/llvm/llvm-project/commit/ea1db31d20a74e5025a86b0df49163d5bfecb67b DIFF: https://github.com/llvm/llvm-project/commit/ea1db31d20a74e5025a86b0df49163d5bfecb67b.diff

[clang] 2492b5a - [profile] Support online merging with continuous sync mode

Author: Vedant Kumar Date: 2019-11-18T12:56:58-08:00 New Revision: 2492b5a12550f7c4bb428c3761392f2ce47fa269 URL: https://github.com/llvm/llvm-project/commit/2492b5a12550f7c4bb428c3761392f2ce47fa269 DIFF: https://github.com/llvm/llvm-project/commit/2492b5a12550f7c4bb428c3761392f2ce47fa269.diff

[clang] b95bb08 - [CodeGenModule] Group blocks runtime globals together, NFC

Author: Vedant Kumar Date: 2019-11-07T12:46:26-08:00 New Revision: b95bb0847a1ea366dda69901c24415e0d00a9527 URL: https://github.com/llvm/llvm-project/commit/b95bb0847a1ea366dda69901c24415e0d00a9527 DIFF: https://github.com/llvm/llvm-project/commit/b95bb0847a1ea366dda69901c24415e0d00a9527.diff

[clang] a5c8ec4 - [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

Author: Vedant Kumar Date: 2019-11-04T15:14:24-08:00 New Revision: a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed URL: https://github.com/llvm/llvm-project/commit/a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed DIFF: https://github.com/llvm/llvm-project/commit/a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed.diff

r375301 - [profile] Do not cache __llvm_profile_get_filename result

Author: vedantk Date: Fri Oct 18 16:33:40 2019 New Revision: 375301 URL: http://llvm.org/viewvc/llvm-project?rev=375301&view=rev Log: [profile] Do not cache __llvm_profile_get_filename result When the %m filename pattern is used, the filename is unique to each image, so the cached value is wrong.

r372903 - [Mangle] Add flag to asm labels to disable '\01' prefixing

Author: vedantk Date: Wed Sep 25 11:00:31 2019 New Revision: 372903 URL: http://llvm.org/viewvc/llvm-project?rev=372903&view=rev Log: [Mangle] Add flag to asm labels to disable '\01' prefixing LLDB synthesizes decls using asm labels. These decls cannot have a mangle different than the one specifi

r369964 - [DebugInfo] Add debug-entry-values test coverage, NFC

Author: vedantk Date: Mon Aug 26 13:50:54 2019 New Revision: 369964 URL: http://llvm.org/viewvc/llvm-project?rev=369964&view=rev Log: [DebugInfo] Add debug-entry-values test coverage, NFC Check that call site descriptions are emitted in dwarf4 + lldb + debug-entry-values mode. Modified: cfe/

r367270 - [docs] Add a note about where UBSan emits logs

Author: vedantk Date: Mon Jul 29 15:54:43 2019 New Revision: 367270 URL: http://llvm.org/viewvc/llvm-project?rev=367270&view=rev Log: [docs] Add a note about where UBSan emits logs Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst

r367269 - [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627)

Author: vedantk Date: Mon Jul 29 15:49:55 2019 New Revision: 367269 URL: http://llvm.org/viewvc/llvm-project?rev=367269&view=rev Log: [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627) The `this` parameter of a thunk requires adjustment. Stop emitting an incorrect dbg.declare

r366744 - [Driver] Set the default win32-macho debug format to DWARF

Author: vedantk Date: Mon Jul 22 14:46:45 2019 New Revision: 366744 URL: http://llvm.org/viewvc/llvm-project?rev=366744&view=rev Log: [Driver] Set the default win32-macho debug format to DWARF rdar://53267670 Differential Revision: https://reviews.llvm.org/D65116 Modified: cfe/trunk/lib/Dri

r365814 - Revert "[CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC"

Author: vedantk Date: Thu Jul 11 12:28:07 2019 New Revision: 365814 URL: http://llvm.org/viewvc/llvm-project?rev=365814&view=rev Log: Revert "[CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC" This reverts commit 1af41074445229fea66b99710a850e5f42ecfa95. Modified: cfe/trunk/lib/CodeGen

r365809 - [CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC

Author: vedantk Date: Thu Jul 11 12:11:46 2019 New Revision: 365809 URL: http://llvm.org/viewvc/llvm-project?rev=365809&view=rev Log: [CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC Replace a `llvm::Function *` parameter with a bool, which seems harder to set to the wrong value by acciden

Re: r364424 - [clang/DIVar] Emit the flag for params that have unmodified value

Hi Djordje, Just a heads-up that I’ve landed r365716 to fix a crash in a stage2 build of AppleClang with -femit-debug-entry-values enabled. I went ahead and landed the fix as it seemed simple enough. Let me know if you have any concerns. Thanks, Vedant > On Jun 26, 2019, at 6:32 AM, Djordje T

r365716 - [CGDebugInfo] Fix -femit-debug-entry-values crash on os_log_helpers

Author: vedantk Date: Wed Jul 10 17:09:16 2019 New Revision: 365716 URL: http://llvm.org/viewvc/llvm-project?rev=365716&view=rev Log: [CGDebugInfo] Fix -femit-debug-entry-values crash on os_log_helpers An os_log_helper FunctionDecl may not have a body. Ignore these for the purposes of debug entry

r357501 - [os_log] Mark os_log_helper `nounwind`

Author: vedantk Date: Tue Apr 2 10:42:38 2019 New Revision: 357501 URL: http://llvm.org/viewvc/llvm-project?rev=357501&view=rev Log: [os_log] Mark os_log_helper `nounwind` Allow the optimizer to remove unnecessary EH cleanups surrounding calls to os_log_helper, to save some code size. As a foll

r350952 - [MergeFunc] Update clang test for r350939

Author: vedantk Date: Fri Jan 11 10:51:02 2019 New Revision: 350952 URL: http://llvm.org/viewvc/llvm-project?rev=350952&view=rev Log: [MergeFunc] Update clang test for r350939 In r350939, the MergeFunc pass learned to erase duplicate functions which are discardable if unused. Modified: cfe/t

r349542 - [CodeGen] Handle mixed-width ops in mixed-sign mul-with-overflow lowering

Author: vedantk Date: Tue Dec 18 13:05:03 2018 New Revision: 349542 URL: http://llvm.org/viewvc/llvm-project?rev=349542&view=rev Log: [CodeGen] Handle mixed-width ops in mixed-sign mul-with-overflow lowering The special lowering for __builtin_mul_overflow introduced in r320902 fixed an ICE seen w

r348187 - [gcov/Darwin] Ensure external symbols are exported when using an export list

Author: vedantk Date: Mon Dec 3 12:53:58 2018 New Revision: 348187 URL: http://llvm.org/viewvc/llvm-project?rev=348187&view=rev Log: [gcov/Darwin] Ensure external symbols are exported when using an export list Make sure that symbols needed to implement runtime support for gcov are exported when

r347804 - [Coverage] Specify the Itanium ABI triple for a C++ test

Author: vedantk Date: Wed Nov 28 12:51:09 2018 New Revision: 347804 URL: http://llvm.org/viewvc/llvm-project?rev=347804&view=rev Log: [Coverage] Specify the Itanium ABI triple for a C++ test Modified: cfe/trunk/test/CoverageMapping/default-method.cpp Modified: cfe/trunk/test/CoverageMapping/

r347803 - [Coverage] Do not visit artificial stmts in defaulted methods (PR39822)

Author: vedantk Date: Wed Nov 28 12:48:07 2018 New Revision: 347803 URL: http://llvm.org/viewvc/llvm-project?rev=347803&view=rev Log: [Coverage] Do not visit artificial stmts in defaulted methods (PR39822) There is no reason to emit coverage mappings for artificial statements contained within def

r347261 - [Sema] Fix PR38987: keep end location of a direct initializer list

Author: vedantk Date: Mon Nov 19 12:10:21 2018 New Revision: 347261 URL: http://llvm.org/viewvc/llvm-project?rev=347261&view=rev Log: [Sema] Fix PR38987: keep end location of a direct initializer list If PerformConstructorInitialization of a direct initializer list constructor is called while ins

r347262 - [Coverage] Fix PR39258: support coverage regions that start deeper than they end

Author: vedantk Date: Mon Nov 19 12:10:22 2018 New Revision: 347262 URL: http://llvm.org/viewvc/llvm-project?rev=347262&view=rev Log: [Coverage] Fix PR39258: support coverage regions that start deeper than they end popRegions used to assume that the start location of a region can't be nested deep

r346276 - [Darwin] Export new weak external symbols when compiling with coverage

Author: vedantk Date: Tue Nov 6 14:25:00 2018 New Revision: 346276 URL: http://llvm.org/viewvc/llvm-project?rev=346276&view=rev Log: [Darwin] Export new weak external symbols when compiling with coverage Some weak external symbols were added to the profile runtime in D49953, and on Darwin, these

r343883 - [DebugInfo] Add support for DWARF5 call site-related attributes

Author: vedantk Date: Fri Oct 5 13:37:17 2018 New Revision: 343883 URL: http://llvm.org/viewvc/llvm-project?rev=343883&view=rev Log: [DebugInfo] Add support for DWARF5 call site-related attributes DWARF v5 introduces DW_AT_call_all_calls, a subprogram attribute which indicates that all calls (bo

r342196 - Relax alignment assumptions in a test after r342194

Author: vedantk Date: Thu Sep 13 17:16:37 2018 New Revision: 342196 URL: http://llvm.org/viewvc/llvm-project?rev=342196&view=rev Log: Relax alignment assumptions in a test after r342194 Don't hardcode align 8. Fixes a bot failure: http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/6

[clang-tools-extra] r342195 - Update a clang-tidy test for r342194

Author: vedantk Date: Thu Sep 13 16:50:20 2018 New Revision: 342195 URL: http://llvm.org/viewvc/llvm-project?rev=342195&view=rev Log: Update a clang-tidy test for r342194 The location of implicit captures has changed. Update a use-after-move checker test to reflect that. This fixes a bot failure

r342194 - [Sema] Remove location from implicit capture init expr

Author: vedantk Date: Thu Sep 13 16:28:25 2018 New Revision: 342194 URL: http://llvm.org/viewvc/llvm-project?rev=342194&view=rev Log: [Sema] Remove location from implicit capture init expr A lambda's closure is initialized when the lambda is declared. For implicit captures, the initialization cod

r341985 - [gcov] Update a clang test for r341977

Author: vedantk Date: Tue Sep 11 12:42:58 2018 New Revision: 341985 URL: http://llvm.org/viewvc/llvm-project?rev=341985&view=rev Log: [gcov] Update a clang test for r341977 Update test/CodeGen/code-coverage.c so that it doesn't refer to a gcov function which is no longer emitted after r341977. F

r340849 - [ubsan] Enable -fsanitize=vptr on Apple devices and simulators

Author: vedantk Date: Tue Aug 28 11:01:42 2018 New Revision: 340849 URL: http://llvm.org/viewvc/llvm-project?rev=340849&view=rev Log: [ubsan] Enable -fsanitize=vptr on Apple devices and simulators It seems like an oversight that this check was not always enabled for on-device or device simulator

r340559 - [docs] Regenerate ClangCommandLineReference.rst

Author: vedantk Date: Thu Aug 23 10:55:03 2018 New Revision: 340559 URL: http://llvm.org/viewvc/llvm-project?rev=340559&view=rev Log: [docs] Regenerate ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst

r340558 - [options] Document -(static|shared)-libsan

Author: vedantk Date: Thu Aug 23 10:54:48 2018 New Revision: 340558 URL: http://llvm.org/viewvc/llvm-project?rev=340558&view=rev Log: [options] Document -(static|shared)-libsan Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Driver/Options.td URL: http:

r339964 - Relax a CHECK line to allow for dso_local

Author: vedantk Date: Thu Aug 16 16:19:50 2018 New Revision: 339964 URL: http://llvm.org/viewvc/llvm-project?rev=339964&view=rev Log: Relax a CHECK line to allow for dso_local Fixes a bot failure: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/11806 Modified:

r339955 - [InstrProf] Use atomic profile counter updates for TSan

Author: vedantk Date: Thu Aug 16 15:24:47 2018 New Revision: 339955 URL: http://llvm.org/viewvc/llvm-project?rev=339955&view=rev Log: [InstrProf] Use atomic profile counter updates for TSan Thread sanitizer instrumentation fails to skip all loads and stores to profile counters. This can happen if

Re: r337928 - [OPENMP] Fix PR38256: Fix locations of the artificial conditional op.

Ah, great. Thanks again! vedant > On Jul 25, 2018, at 10:33 AM, Alexey Bataev wrote: > > This is visible to the user, the statement under #pragma omp parallel > directive is outlined as a function. > - > Best regards, > Alexey Bataev > 25.07.2018 13:31, Vedant Kumar пишет: >> Thank

Re: r337928 - [OPENMP] Fix PR38256: Fix locations of the artificial conditional op.

Thanks! Just out of curiosity, what is the "omp_outlined" function you're checking for? Is it implicitly-defined? If it's not user-visible, i.e it doesn't actually appear in the source code of a program, why should we generate a code coverage mapping for it at all? vedant > On Jul 25, 2018, a

r336937 - [Driver] Conform warn_drv_object_size_disabled_O0 to DefaultWarnNoError

Author: vedantk Date: Thu Jul 12 12:53:15 2018 New Revision: 336937 URL: http://llvm.org/viewvc/llvm-project?rev=336937&view=rev Log: [Driver] Conform warn_drv_object_size_disabled_O0 to DefaultWarnNoError This diagnostic triggers when -fsanitize=object-size is explicitly specified but will be a

r335890 - [Darwin] Remove _VPMergeHook from the auto-export list

Author: vedantk Date: Thu Jun 28 10:53:35 2018 New Revision: 335890 URL: http://llvm.org/viewvc/llvm-project?rev=335890&view=rev Log: [Darwin] Remove _VPMergeHook from the auto-export list Remove _VPMergeHook from Darwin's automatically-exported symbol list for PGO. As of r328987 this symbol is n

r335577 - Fix an ambiguous overload issue pointed out by MSVC

Author: vedantk Date: Mon Jun 25 20:53:06 2018 New Revision: 335577 URL: http://llvm.org/viewvc/llvm-project?rev=335577&view=rev Log: Fix an ambiguous overload issue pointed out by MSVC Log: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11390 Modified: cfe/trunk/include/clang

r335571 - Modernize a function, NFC.

Author: vedantk Date: Mon Jun 25 19:50:01 2018 New Revision: 335571 URL: http://llvm.org/viewvc/llvm-project?rev=335571&view=rev Log: Modernize a function, NFC. Modified: cfe/trunk/lib/Sema/SemaLambda.cpp Modified: cfe/trunk/lib/Sema/SemaLambda.cpp URL: http://llvm.org/viewvc/llvm-project/c

r335572 - [ubsan] Relax nullability-return for blocks with deduced types

Author: vedantk Date: Mon Jun 25 19:50:04 2018 New Revision: 335572 URL: http://llvm.org/viewvc/llvm-project?rev=335572&view=rev Log: [ubsan] Relax nullability-return for blocks with deduced types When the return type of an ObjC-style block literals is deduced, pick the candidate type with the st

r333775 - [Coverage] Remove a test dependency on the itanium ABI

Author: vedantk Date: Fri Jun 1 10:11:18 2018 New Revision: 333775 URL: http://llvm.org/viewvc/llvm-project?rev=333775&view=rev Log: [Coverage] Remove a test dependency on the itanium ABI This should address a bot failure: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/

r333715 - [Coverage] End deferred regions before labels, fixes PR35867

Author: vedantk Date: Thu May 31 17:37:13 2018 New Revision: 333715 URL: http://llvm.org/viewvc/llvm-project?rev=333715&view=rev Log: [Coverage] End deferred regions before labels, fixes PR35867 A deferred region should end before the start of a label, and should not extend to the start of the la

r333609 - [Coverage] Discard the last uncompleted deferred region in a decl

Author: vedantk Date: Wed May 30 16:35:44 2018 New Revision: 333609 URL: http://llvm.org/viewvc/llvm-project?rev=333609&view=rev Log: [Coverage] Discard the last uncompleted deferred region in a decl Discard the last uncompleted deferred region in a decl, if one exists. This prevents lines at the

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

> On May 18, 2018, at 11:48 AM, Eric Liu wrote: > > So I have reverted this with r332751. Thanks! > I can't see how this introduced cyclic dependencies in module build, as the > dependencies should be clangTooling -> clangFormat -> clangToolingInclusions. > I'm wondering if there is any modu

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

I wiped my build directory, updated to r332734 and rebuilt, but hit the same error while building check-clang. For completeness, I did: $ cmake -G Ninja /Users/vsk/src/llvm.org-master/llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=On -DCLANG_ENABLE_ARCMT=Off -DCLANG_ ENABLE_STATIC_ANA

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

Hi Eric, I think there might be a cyclic dependency issue here, possibly one that's only visible with LLVM_ENABLE_MODULES=On. I see: While building module 'Clang_Tooling' imported from /Users/vsk/src/llvm.org-master/llvm/tools/clang/lib/Tooling/Execution.cpp:10: Wh

Re: r330068 - [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

oing to revert this now, and I would > like to kick off a discussion about this in the future. > > Thanks, > > — > Davide > >> On Apr 13, 2018, at 18:36, Vedant Kumar wrote: >> >> + Davide >> >>> On Apr 13, 2018, at 6:36 PM, Vedant Kumar via

r330080 - Revert "[Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC)."

Author: vedantk Date: Fri Apr 13 18:40:48 2018 New Revision: 330080 URL: http://llvm.org/viewvc/llvm-project?rev=330080&view=rev Log: Revert "[Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC)." This reverts commit r330068. It breaks the lldb

r330077 - [Driver] Export profiling symbols for -exported_symbols_list

Author: vedantk Date: Fri Apr 13 16:43:59 2018 New Revision: 330077 URL: http://llvm.org/viewvc/llvm-project?rev=330077&view=rev Log: [Driver] Export profiling symbols for -exported_symbols_list When profiling is enabled and -exported_symbols_list is specified for the Darwin linker, export the re

r327317 - Check that ubsan is the only supported sanitizer on OpenBSD

Author: vedantk Date: Mon Mar 12 12:18:51 2018 New Revision: 327317 URL: http://llvm.org/viewvc/llvm-project?rev=327317&view=rev Log: Check that ubsan is the only supported sanitizer on OpenBSD Patch by David Carlier! Differential Revision: https://reviews.llvm.org/D44069 Modified: cfe/trun

[libcxx] r327064 - Low-hanging fruit optimization in string::__move_assign().

Author: vedantk Date: Thu Mar 8 13:15:26 2018 New Revision: 327064 URL: http://llvm.org/viewvc/llvm-project?rev=327064&view=rev Log: Low-hanging fruit optimization in string::__move_assign(). shrink_to_fit() ends up doing a lot work to get information that we already know since we just called cl

r325319 - [Coverage] Handle break/continue outside of loop bodies

Author: vedantk Date: Thu Feb 15 23:59:43 2018 New Revision: 325319 URL: http://llvm.org/viewvc/llvm-project?rev=325319&view=rev Log: [Coverage] Handle break/continue outside of loop bodies Teach the coverage mapping logic to handle break or continue statements within for loop increments. Fixes

r324527 - [clang-import-test] Run clang-format, NFC

Author: vedantk Date: Wed Feb 7 13:17:22 2018 New Revision: 324527 URL: http://llvm.org/viewvc/llvm-project?rev=324527&view=rev Log: [clang-import-test] Run clang-format, NFC I ran across clang-import-test while looking into testing for lldb. There shouldn't be any harm in running clang-format o

Re: [PATCH] D35338: Add the -fdestroy-globals flag

Yeah, I think we have internal users who would be happy to use this flag as well. Stepping back a bit. It's been a while since I followed the discussion on cfe-dev, but I don't recall there being any objections to the flag name or to using it for particular targets. IIRC the objections are abo

r322729 - [Parse] Forward brace locations to TypeConstructExpr

Author: vedantk Date: Wed Jan 17 10:53:51 2018 New Revision: 322729 URL: http://llvm.org/viewvc/llvm-project?rev=322729&view=rev Log: [Parse] Forward brace locations to TypeConstructExpr When parsing C++ type construction expressions with list initialization, forward the locations of the braces t

Re: [analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

+ Devin and George > On Jan 14, 2018, at 10:44 AM, Felix Kostenzer via cfe-commits > wrote: > > > Hi, > > Added evaluation of __builtin_constant_p to the dedicated StaticAnalyzer > checker > along with a regression test. > > 'make clang-test' results: > > Testing Time: 335.63s > Expected

r321771 - [CGBuiltin] Handle unsigned mul overflow properly (PR35750)

Author: vedantk Date: Wed Jan 3 15:11:32 2018 New Revision: 321771 URL: http://llvm.org/viewvc/llvm-project?rev=321771&view=rev Log: [CGBuiltin] Handle unsigned mul overflow properly (PR35750) r320902 fixed the IRGen for some types of checked multiplications. It did not handle unsigned overflow

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

Oops, the build log was too big to attach. Resending with just the bot link, then: http://lab.llvm.org:8080/green/view/Experimental/job/clang-stage2-coverage-R/2193/consoleText vedant > On Jan 3, 20

r321230 - [Driver] Ensure no overlap between trapping & recoverable sanitizers. NFC.

Author: vedantk Date: Wed Dec 20 16:10:24 2017 New Revision: 321230 URL: http://llvm.org/viewvc/llvm-project?rev=321230&view=rev Log: [Driver] Ensure no overlap between trapping & recoverable sanitizers. NFC. This is NFC because in EmitCheck(), -fsanitize-trap=X overrides -fsanitize-recover=X. M

r321231 - [ubsan] Diagnose noreturn functions which return

Author: vedantk Date: Wed Dec 20 16:10:25 2017 New Revision: 321231 URL: http://llvm.org/viewvc/llvm-project?rev=321231&view=rev Log: [ubsan] Diagnose noreturn functions which return Diagnose 'unreachable' UB when a noreturn function returns. 1. Insert a check at the end of functions marked no

r320902 - [CodeGen] Specialize mixed-sign mul-with-overflow (fix PR34920)

Author: vedantk Date: Fri Dec 15 17:28:25 2017 New Revision: 320902 URL: http://llvm.org/viewvc/llvm-project?rev=320902&view=rev Log: [CodeGen] Specialize mixed-sign mul-with-overflow (fix PR34920) This patch introduces a specialized way to lower overflow-checked multiplications with mixed-sign o

r320185 - [ubsan] array-bounds: Ignore params with constant size

Author: vedantk Date: Fri Dec 8 11:51:42 2017 New Revision: 320185 URL: http://llvm.org/viewvc/llvm-project?rev=320185&view=rev Log: [ubsan] array-bounds: Ignore params with constant size This is a follow-up to r320128. Eli pointed out that there is some gray area in the language standard about

r320132 - [Blocks] Inherit sanitizer options from parent decl

Author: vedantk Date: Thu Dec 7 18:47:58 2017 New Revision: 320132 URL: http://llvm.org/viewvc/llvm-project?rev=320132&view=rev Log: [Blocks] Inherit sanitizer options from parent decl There is no way to apply sanitizer suppressions to ObjC blocks. A reasonable default is to have blocks inherit

r320128 - [ubsan] Use pass_object_size info in bounds checks

Author: vedantk Date: Thu Dec 7 17:51:47 2017 New Revision: 320128 URL: http://llvm.org/viewvc/llvm-project?rev=320128&view=rev Log: [ubsan] Use pass_object_size info in bounds checks Teach UBSan's bounds check to opportunistically use pass_object_size information to check array accesses. rdar:

r319373 - [Coverage] Emit gap areas in braces-optional statements (PR35387)

Author: vedantk Date: Wed Nov 29 14:25:14 2017 New Revision: 319373 URL: http://llvm.org/viewvc/llvm-project?rev=319373&view=rev Log: [Coverage] Emit gap areas in braces-optional statements (PR35387) Emit a gap area starting after the r-paren location and ending at the start of the body for the b

r318229 - [PGO] Detect more structural changes with the stable hash

Author: vedantk Date: Tue Nov 14 15:56:53 2017 New Revision: 318229 URL: http://llvm.org/viewvc/llvm-project?rev=318229&view=rev Log: [PGO] Detect more structural changes with the stable hash Lifting from Bob Wilson's notes: The hash value that we compute and store in PGO profile data to detect o

r317759 - [Coverage] Complete top-level deferred regions before labels

Author: vedantk Date: Wed Nov 8 18:33:39 2017 New Revision: 317759 URL: http://llvm.org/viewvc/llvm-project?rev=317759&view=rev Log: [Coverage] Complete top-level deferred regions before labels The area immediately after a terminated region in the function top-level should have the same count as

r317760 - [Coverage] Emit deferred regions in headers

Author: vedantk Date: Wed Nov 8 18:33:40 2017 New Revision: 317760 URL: http://llvm.org/viewvc/llvm-project?rev=317760&view=rev Log: [Coverage] Emit deferred regions in headers There are some limitations with emitting regions in macro expansions because we don't gather file IDs within the expans

r317758 - [Coverage] Emit a gap area after if conditions

Author: vedantk Date: Wed Nov 8 18:33:38 2017 New Revision: 317758 URL: http://llvm.org/viewvc/llvm-project?rev=317758&view=rev Log: [Coverage] Emit a gap area after if conditions The area immediately after the closing right-paren of an if condition should have a count equal to the 'then' block'

r316704 - [CGBlocks] Improve line info in backtraces containing *_helper_block

Author: vedantk Date: Thu Oct 26 14:27:24 2017 New Revision: 316704 URL: http://llvm.org/viewvc/llvm-project?rev=316704&view=rev Log: [CGBlocks] Improve line info in backtraces containing *_helper_block Instead of only setting a non-zero debug location on the return instruction in *_helper_block

r315982 - [Coverage] Discard deferred region in closing if-else

Author: vedantk Date: Tue Oct 17 00:47:39 2017 New Revision: 315982 URL: http://llvm.org/viewvc/llvm-project?rev=315982&view=rev Log: [Coverage] Discard deferred region in closing if-else A trailing deferred region isn't necessary in a function that ends with this pattern: ... else { ...

r315979 - [Coverage] Explicitly mark the l.h.s of && and || (fixes PR33465)

Author: vedantk Date: Mon Oct 16 23:51:54 2017 New Revision: 315979 URL: http://llvm.org/viewvc/llvm-project?rev=315979&view=rev Log: [Coverage] Explicitly mark the l.h.s of && and || (fixes PR33465) This makes it possible to view sub-line region counts for the l.h.s of && and || expressions in c

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

gt; compiler-rt but we could have missing coverage there. >>>>>>> >>>>>>> The original version of this patch restricted the prologue data changes >>>>>>> to Darwin only. We can switch back to that easily, just let me know. >>>>>

r315786 - [ubsan] Don't emit function signatures for non-static member functions

Author: vedantk Date: Fri Oct 13 18:23:30 2017 New Revision: 315786 URL: http://llvm.org/viewvc/llvm-project?rev=315786&view=rev Log: [ubsan] Don't emit function signatures for non-static member functions The function sanitizer only checks indirect calls through function pointers. This excludes a

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

;>>>> Appreciated :) >>>>> >>>>> Basically we were getting an error of: >>>>> >>>>> error: Cannot represent a difference across sections >>>>> >>>>> trying to compile things with the current co

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

sing -ffunction-sections, using data-sections, >>> etc). Basically I'm not sure why this would work on some Linux setups but >>> not others. >>> >>> >>> Definitely using the latter two options and gold as a linker. I'll see what &g

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

he *-sections options there. I'm not sure whether that's what > caused the failure, but the extra coverage couldn't hurt :). I would do it > myself but I don't have a Linux machine to test on. > > vedant > >> >> While we figure that out here&

  1   2   3   4   5   6   >