[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. Thanks. Can you land it for me? I'm a newcommer without landing privilege. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___ cfe-commi

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. In D60055#1459602 , @lebedev.ri wrote: > I won't be able to properly review this, sorry. Can you suggest someone with familiarity for this part of code? The reviewers I randomly added by `git blame` doesn't seem to be reviewing.

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet marked 2 inline comments as done. Violet added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2895 // function and isn't necessarily referring to one of FD's parameters. - if (FD->getParamDecl(i) == PV) + if (i < FD->getNumParams()

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 194152. Violet added a comment. Address reviewer comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp clang/test

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. PING ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 193045. Violet added a comment. a more straightforward testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp cla

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 193041. Violet added a comment. Wrong bug number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp clang/test/SemaCXX

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As was already stated in a previous comment, the parameter isn't necessarily referring to one of the DeclContext's parameter. We should check the index is within the range to avoid out-of-boundary