[clang] Revert "[OpenMP][TR12] change property of map-type modifier." (PR #90885)

2024-05-02 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > BTW, Hi @vitalybuka, do you know how to reproduce the problem with sanitizer > build? Thanks. There is a basic instruction, should work with Linux https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild I guess this issue should be detectable with appropriate

[clang] Revert "[OpenMP][TR12] change property of map-type modifier." (PR #90885)

2024-05-02 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Oh, it's not landed. I looked at wrong PR. Lets revert if it can't be landed soon. https://github.com/llvm/llvm-project/pull/90885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Revert "[OpenMP][TR12] change property of map-type modifier." (PR #90885)

2024-05-02 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > How long do you need? Looks like it's landed. Thanks! https://github.com/llvm/llvm-project/pull/90885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[OpenMP][TR12] change property of map-type modifier." (PR #90885)

2024-05-02 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > I already has patch in #90800 waiting for test to finish. Fix forward is good for something < 1H, but looks like you started 19H ago. Such cases must be reverted and then fixed. How long do you need? https://github.com/llvm/llvm-project/pull/90885

[clang] [OpenMP][TR12] change property of map-type modifier. (PR #90499)

2024-05-02 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: I am not sure what should be a correct fix, so I'll revert? https://github.com/llvm/llvm-project/pull/90499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[OpenMP][TR12] change property of map-type modifier." (PR #90885)

2024-05-02 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/90885 Breaks https://lab.llvm.org/buildbot/#/builders/5/builds/43086/steps/9/logs/stdio Reverts llvm/llvm-project#90499 >From a6ca95f5e2991fb7f857f70436148a6abdecec00 Mon Sep 17 00:00:00 2001 From: Vitaly Buka

[clang] [OpenMP][TR12] change property of map-type modifier. (PR #90499)

2024-05-02 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Breaks https://lab.llvm.org/buildbot/#/builders/5/builds/43086 https://github.com/llvm/llvm-project/pull/90499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] Reland "[clang] Enable sized deallocation by default in C++14 onwards" (PR #90373)

2024-04-30 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > Thanks a lot, that was quick! There is another AddressSanitizer issue that > may possibly be fixed by #90292. cc @vitalybuka Yes, please wait for #90292. https://github.com/llvm/llvm-project/pull/90373 ___ cfe-commits mailing

[clang] [clang-tools-extra] [libcxx] Revert "[clang] Enable sized deallocation by default in C++14 onwards (#83774)" (PR #90299)

2024-04-26 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka demilestoned https://github.com/llvm/llvm-project/pull/90299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] Revert "[clang] Enable sized deallocation by default in C++14 onwards (#83774)" (PR #90299)

2024-04-26 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka milestoned https://github.com/llvm/llvm-project/pull/90299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] Revert "[clang] Enable sized deallocation by default in C++14 onwards (#83774)" (PR #90299)

2024-04-26 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/90299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-04-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Lets revert #90299 to recover bots before the weekend. https://github.com/llvm/llvm-project/pull/83774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] Revert "[clang] Enable sized deallocation by default in C++14 onwards (#83774)" (PR #90299)

2024-04-26 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/90299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] Revert "[clang] Enable sized deallocation by default in C++14 onwards (#83774)" (PR #90299)

2024-04-26 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/90299 https://lab.llvm.org/buildbot/#/builders/168/builds/20063 This reverts commit cf5a8b489464d09dfdd7a48ce7c8b41d3c9bf819. >From b4c0a3f4835a686a15a3ed90a4058f353f844f26 Mon Sep 17 00:00:00 2001 From: Vitaly

[clang] [compiler-rt] [asan][windows] Eliminate the static asan runtime on windows (PR #81677)

2024-04-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: It's LGTM, but it's going to be annoying to merge. I bet this patch has several reasons to be reverted, and will be reverted multiple times. It would be nice to try to split into smaller parts. https://github.com/llvm/llvm-project/pull/81677

[clang] [compiler-rt] [asan][windows] Eliminate the static asan runtime on windows (PR #81677)

2024-04-26 Thread Vitaly Buka via cfe-commits
@@ -35,6 +35,9 @@ // RUN: %p/../../../../lib/sanitizer_common/sanitizer_coverage_interface.inc \ // RUN: | grep -e "INTERFACE_\(WEAK_\)\?FUNCTION" \ // RUN: | grep -v "__sanitizer_weak_hook" \ +//

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-04-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Delete uses __get_long_cap() ``` _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void __set_long_cap(size_type __s) _NOEXCEPT { __r_.first().__l.__cap_ = __s / __endian_factor; __r_.first().__l.__is_long_ = true; } _LIBCPP_HIDE_FROM_ABI

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-04-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: @ldionne looks like a bug in std::string ``` --- a/libcxx/include/string +++ b/libcxx/include/string @@ -1123,7 +1123,7 @@ public: inline _LIBCPP_CONSTEXPR_SINCE_CXX20 ~basic_string() { __annotate_delete(); if (__is_long()) -

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-04-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: This is causing new/delete mismatch https://lab.llvm.org/buildbot/#/builders/168/builds/20063 ``` = ==2164144==ERROR: AddressSanitizer: new-delete-type-mismatch on 0x503035b0 in thread T0: object passed to

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/87568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Improve stack usage to increase recursive initialization depth" (PR #89006)

2024-04-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/89006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Improve stack usage to increase recursive initialization depth" (PR #89006)

2024-04-16 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > I would not run clang-format on the revert Done. Reverted to github generated 1d59298 https://github.com/llvm/llvm-project/pull/89006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Revert "Improve stack usage to increase recursive initialization depth" (PR #89006)

2024-04-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/89006 >From 1d59298cd9ed21e1ac860d64f965514a577f45bb Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 16 Apr 2024 17:23:47 -0700 Subject: [PATCH 1/2] Revert "Improve stack usage to increase recursive

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

2024-04-16 Thread Vitaly Buka via cfe-commits
@@ -1163,12 +1136,7 @@ class Sema; ConversionSequenceList allocateConversionSequences(unsigned NumConversions) { ImplicitConversionSequence *Conversions = - slabAllocate(NumConversions); - - // Construct the new objects. - for (unsigned I = 0;

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

2024-04-16 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: have ideas about leak, but not sure what to do with perf regression and #88330 Proposing revert https://github.com/llvm/llvm-project/pull/89006 https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list

[clang] Revert "Improve stack usage to increase recursive initialization depth" (PR #89006)

2024-04-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/89006 Reverts llvm/llvm-project#88546 Leak and performance regression. Details in #88546 >From 1d59298cd9ed21e1ac860d64f965514a577f45bb Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 16 Apr 2024 17:23:47

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

2024-04-16 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: A new memory leak https://lab.llvm.org/buildbot/#/builders/5/builds/42694 https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-12 Thread Vitaly Buka via cfe-commits
@@ -3233,6 +3233,17 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, if (BuiltinCountZeroBitsGeneric(*this, TheCall)) return ExprError(); break; + + case Builtin::BI__builtin_allow_runtime_check: { +Expr *Arg = TheCall->getArg(0);

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-12 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/87568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-12 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/87568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-12 Thread Vitaly Buka via cfe-commits
@@ -3464,6 +3464,34 @@ Query for this feature with ``__has_builtin(__builtin_trap)``. ``__builtin_arm_trap`` is lowered to the ``llvm.aarch64.break`` builtin, and then to ``brk #payload``. +``__builtin_allow_runtime_check`` vitalybuka wrote: Similar

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-12 Thread Vitaly Buka via cfe-commits
@@ -3464,6 +3464,34 @@ Query for this feature with ``__has_builtin(__builtin_trap)``. ``__builtin_arm_trap`` is lowered to the ``llvm.aarch64.break`` builtin, and then to ``brk #payload``. +``__builtin_allow_runtime_check`` vitalybuka wrote: Not sure how

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-12 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/87568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][UBSan] Remove rigid metadata checks for `ubsan-bitfield-conversion` (PR #88116)

2024-04-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/88116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: ok please paste here what ever looks like real failure from the patch buildbot does not sent me, as I am not on the blame list https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: I'll land after presubmit checks https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka commented: Fail i386 ``` UBSan-AddressSanitizer-i386 :: TestCases/ImplicitConversion/bitfield-conversion.c UBSan-Standalone-i386 :: TestCases/ImplicitConversion/bitfield-conversion.c ``` https://github.com/llvm/llvm-project/pull/87761

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-05 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: This is fixed version of https://github.com/llvm/llvm-project/pull/75481 ? https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [UBSAN] Preserve ubsan code with ubsan-unique-traps (PR #83470)

2024-04-05 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/83470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSAN] Preserve ubsan code with ubsan-unique-traps (PR #83470)

2024-04-05 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: abandoning https://github.com/llvm/llvm-project/pull/83470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSAN] Preserve ubsan code with ubsan-unique-traps (PR #83470)

2024-04-05 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: I changed my design, so I don't need that change as is. Given https://godbolt.org/z/4KfEKq7zb, I can revert your patch, or just leave it as is. I have no preference. https://github.com/llvm/llvm-project/pull/83470 ___ cfe-commits

[clang] [clang][CodeGen] Guard ubsan checks with `llvm.allow.ubsan.check` (PR #87436)

2024-04-05 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/87436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Guard ubsan checks with `llvm.allow.ubsan.check` (PR #87436)

2024-04-05 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: I will land, and address followup comments, if any. It does not change behavior without -mllvm flags. https://github.com/llvm/llvm-project/pull/87436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [UBSAN] Rename `remove-traps` to `lower-allow-check` (PR #84853)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/84853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [UBSAN] Rename `remove-traps` to `lower-allow-check` (PR #84853)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84853 >From d98585586148f2084e36d06996d6c9190cec57d7 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Mon, 11 Mar 2024 16:32:06 -0700 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=

[clang] [llvm] [UBSAN] Rename `remove-traps` to `lower-allow-check` (PR #84853)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/84853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Rename `remove-traps` to `lower-builtin-hot` (PR #84853)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/84853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/84852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/84852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ubsan] Switch UBSAN optimization to `llvm.allow.{runtime,ubsan}.check()` (PR #84858)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/84858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ubsan] Switch UBSAN optimization to `llvm.allow.{runtime,ubsan}.check()` (PR #84858)

2024-04-04 Thread Vitaly Buka via cfe-commits
@@ -3805,6 +3812,12 @@ void CodeGenFunction::EmitTrapCheck(llvm::Value *Checked, SanitizerHandler CheckHandlerID) { llvm::BasicBlock *Cont = createBasicBlock("cont"); + if (ClSanitizeExpHot) { +Checked = +

[clang] [llvm] [clang][ubsan] Switch UBSAN optimization to `llvm.allow.{runtime,ubsan}.check()` (PR #84858)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84858 >From 014644897f25ed88a1e17192531cf92110758470 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Mon, 11 Mar 2024 16:58:15 -0700 Subject: [PATCH] [clang][ubsan] Switch UBSAN optimization to

[clang] [llvm] [clang][ubsan] Switch UBSAN optimization to `llvm.allow.{runtime,ubsan}.check()` (PR #84858)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/84858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Guard ubsan checks with `llvm.allow.ubsan.check` (PR #87436)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/87436 >From eec9a27ff0451b923d8ca7d4ff23eb6b8dffa56c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 2 Apr 2024 17:18:58 -0700 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=

[clang] 96a99a5 - [NFC][UBSAN] Regenerate a test

2024-04-04 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2024-04-04T15:54:54-07:00 New Revision: 96a99a5e2f62475f13d7ba18b15acad733909e7f URL: https://github.com/llvm/llvm-project/commit/96a99a5e2f62475f13d7ba18b15acad733909e7f DIFF: https://github.com/llvm/llvm-project/commit/96a99a5e2f62475f13d7ba18b15acad733909e7f.diff

[clang] [clang][CodeGen] Guard ubsan checks with `llvm.allow.ubsan.check` (PR #87436)

2024-04-04 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/87436 >From eec9a27ff0451b923d8ca7d4ff23eb6b8dffa56c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 2 Apr 2024 17:18:58 -0700 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=

[clang] abd05eb - [clang] Init fields added by #87357

2024-04-03 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2024-04-03T17:48:25-07:00 New Revision: abd05eb4a53e6c7760496620da417733f52d4bf9 URL: https://github.com/llvm/llvm-project/commit/abd05eb4a53e6c7760496620da417733f52d4bf9 DIFF: https://github.com/llvm/llvm-project/commit/abd05eb4a53e6c7760496620da417733f52d4bf9.diff

[clang] 633bc3b - [CodeGen][NFC] Make an opt<> static

2024-04-02 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2024-04-02T15:47:04-07:00 New Revision: 633bc3bfda71c55bc38d5a3bfdb426bab61ff101 URL: https://github.com/llvm/llvm-project/commit/633bc3bfda71c55bc38d5a3bfdb426bab61ff101 DIFF: https://github.com/llvm/llvm-project/commit/633bc3bfda71c55bc38d5a3bfdb426bab61ff101.diff

[clang] [clang] Better bitfield access units (PR #65742)

2024-04-01 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: This failure is caused by the patch https://lab.llvm.org/buildbot/#/builders/239/builds/6363/steps/10/logs/stdio cc @hctim https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Fix bitfield access unit for vbase corner case (PR #87238)

2024-04-01 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: This failure is caused by the patch https://lab.llvm.org/buildbot/#/builders/239/builds/6363/steps/10/logs/stdio https://github.com/llvm/llvm-project/pull/87238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] e93b5f5 - [ubsan][NFC] Remove recently added `cl::init(false)`

2024-04-01 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2024-04-01T13:37:42-07:00 New Revision: e93b5f5a4776ffea12d03652559dfdf8d421184c URL: https://github.com/llvm/llvm-project/commit/e93b5f5a4776ffea12d03652559dfdf8d421184c DIFF: https://github.com/llvm/llvm-project/commit/e93b5f5a4776ffea12d03652559dfdf8d421184c.diff

[clang] [llvm] [InstCombiner] Remove trivially dead `llvm.allow.{runtime,ubsan}.check()` (PR #84851)

2024-04-01 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/84851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstCombiner] Remove trivially dead `llvm.allow.{runtime,ubsan}.check()` (PR #84851)

2024-03-31 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/84851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix buffer overflow in compareHeaders (PR #87213)

2024-03-31 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/87213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix buffer overflow in compareHeaders (PR #87213)

2024-03-31 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/87213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix buffer overflow in compareHeaders (PR #87213)

2024-03-31 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/87213 `RHS` can be shorter than `LHS`. Reported by asan after #83440. >From a6d57814761cb74de98b40a4cc3acdd9b262e854 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Sun, 31 Mar 2024 18:42:25 -0700 Subject:

[clang] [compiler-rt] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [NFC][IR] Add SetNoSanitize helpers (PR #86772)

2024-03-27 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/86772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [NFC][IR] Add SetNoSanitize helpers (PR #86772)

2024-03-27 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/86772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > ah I see. I feel like this should be a more principled approach that other > sanitizers also share, as you've mentioned as an alternative. do people not > care about other sanitizers in production? Actually Asan should not exhibit this behavior, by some lack it does not

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka converted_to_draft https://github.com/llvm/llvm-project/pull/86739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Looked into IR and HWASAN instrument stuff which it should not https://godbolt.org/z/MnYs75Meq Should be easy to fix. https://github.com/llvm/llvm-project/pull/86739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > I think I'm still confused on exactly what the use case is and why we can't > just ask the user to not specify hwasan in the PGO instrumented build. Just > for user convenience? Or does clang change the emitted IR when hwasan is > enabled? And that's what will lead to

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Alternative is we need a new clang fronted flag to control this behavior. Assuming that this is rather strange use case, I'd prefer to land the patch and introduce new flag only when we have request for that case. https://github.com/llvm/llvm-project/pull/86739

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: We already have similar stuff: ``` if (PGOOpt && Phase != ThinOrFullLTOPhase::ThinLTOPostLink && !PGOOpt->MemoryProfile.empty()) MPM.addPass(MemProfUsePass(PGOOpt->MemoryProfile, PGOOpt->FS)); ``` https://github.com/llvm/llvm-project/pull/86739

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > > > why can't hwasan and PGO instrumentation coexist? > > > > > > They can, but binary is like 5x times slower, on top of 10x slowdown of PGO > > instrumentation. (don't quote me on these numbers, they are from large but > > single benchmark, still it's very slow) > > If

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > why can't hwasan and PGO instrumentation coexist? They can, but binary is like 5x times slower, on top of 10x slowdown of PGO instrumentation. > > and this seems like it should be an error at the clang driver level, instead > of silently turning off one of the requested

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/86739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/86739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/86739 None >From 7e20d811d86854d4bea6282245c9aca51c8968c5 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 26 Mar 2024 14:07:07 -0700 Subject: [PATCH]

[clang] [compiler-rt] [llvm] Add numerical sanitizer (PR #85916)

2024-03-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: clang changes LGTM, but they are missing testst https://github.com/llvm/llvm-project/pull/85916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] Add numerical sanitizer (PR #85916)

2024-03-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Can we split the patch into smaller pieces? e.g. clang, transform, runtime ? This one has transform, comments, so we can keep it for transform. https://github.com/llvm/llvm-project/pull/85916 ___ cfe-commits mailing list

[clang] [Driver] -fsanitize=undefined: don't expand to signed-integer-overflow if -fwrapv (PR #85501)

2024-03-18 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/85501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2024-03-14 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: This is broken by the patch https://lab.llvm.org/buildbot/#/builders/5/builds/41773/steps/9/logs/stdio https://github.com/llvm/llvm-project/pull/67999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [compiler-rt] [clang][UBSan] Add implicit conversion check for bitfields (PR #75481)

2024-03-12 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/75481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [clang][UBSan] Add implicit conversion check for bitfields (PR #75481)

2024-03-12 Thread Vitaly Buka via cfe-commits
@@ -1094,6 +1114,27 @@ void ScalarExprEmitter::EmitIntegerTruncationCheck(Value *Src, QualType SrcType, {Src, Dst}); } +static llvm::Value *EmitIsNegativeTestHelper(Value *V, QualType VType, vitalybuka wrote: I still see it here, does it

[clang] [llvm] [ASan][Driver] Add sanitize-target flag to support enabling ASan in device or host compilation (PR #76127)

2024-03-12 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka requested changes to this pull request. Removing from my pending reviews https://github.com/llvm/llvm-project/pull/76127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 6397f22 - [clang] Fix test after #84214

2024-03-11 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2024-03-11T15:33:32-07:00 New Revision: 6397f223c456ce5a0cc246cd81673794a4860fd1 URL: https://github.com/llvm/llvm-project/commit/6397f223c456ce5a0cc246cd81673794a4860fd1 DIFF: https://github.com/llvm/llvm-project/commit/6397f223c456ce5a0cc246cd81673794a4860fd1.diff

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-11 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > @vitalybuka the test you added `remote-traps.c` seems to be failing on a few > buildbots, can you take a look? > > * https://lab.llvm.org/buildbot/#/builders/231/builds/21492 > * https://lab.llvm.org/buildbot/#/builders/280/builds/6 looking

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-11 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/84214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-11 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84214 >From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 6 Mar 2024 10:03:46 -0800 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-11 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > yes, but I'd like to that after we collect feedback from first users They are introduced by earlier transformations Note: I'd like to have special intrinsic for this optimization. When we have it, we likely don't need this SimplifyCFG.

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84214 >From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 6 Mar 2024 10:03:46 -0800 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84214 >From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 6 Mar 2024 10:03:46 -0800 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84214 >From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 6 Mar 2024 10:03:46 -0800 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

[clang] Revert "[clang] Fix crash when declaring invalid lambda member" (PR #84615)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/84615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang] Fix crash when declaring invalid lambda member" (PR #84615)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/84615 Reverts llvm/llvm-project#74110 Fails on many bots: https://lab.llvm.org/buildbot/#/builders/5/builds/41633 >From 780ee1d80aa1b8cf54bd642e7c2a7e59c2dc9e11 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date:

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84214 >From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 6 Mar 2024 10:03:46 -0800 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-08 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84214 >From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 6 Mar 2024 10:03:46 -0800 Subject: [PATCH 1/6] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

<    1   2   3   4   5   6   7   8   >