r369992 - NFC: Make test work with or without assertions

Author: vitalybuka Date: Mon Aug 26 17:11:33 2019 New Revision: 369992 URL: http://llvm.org/viewvc/llvm-project?rev=369992=rev Log: NFC: Make test work with or without assertions Modified: cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp Modified:

r369980 - hwasan, codegen: Keep more lifetime markers used for hwasan

Author: vitalybuka Date: Mon Aug 26 15:16:05 2019 New Revision: 369980 URL: http://llvm.org/viewvc/llvm-project?rev=369980=rev Log: hwasan, codegen: Keep more lifetime markers used for hwasan Reviewers: eugenis Subscribers: cfe-commits Tags: #clang Differential Revision:

r369979 - msan, codegen, instcombine: Keep more lifetime markers used for msan

Author: vitalybuka Date: Mon Aug 26 15:15:50 2019 New Revision: 369979 URL: http://llvm.org/viewvc/llvm-project?rev=369979=rev Log: msan, codegen, instcombine: Keep more lifetime markers used for msan Reviewers: eugenis Subscribers: hiraditya, cfe-commits, #sanitizers, llvm-commits Tags:

r369971 - Revert r369843 "[Testing] Unbreak r369830"

Author: vitalybuka Date: Mon Aug 26 14:29:06 2019 New Revision: 369971 URL: http://llvm.org/viewvc/llvm-project?rev=369971=rev Log: Revert r369843 "[Testing] Unbreak r369830" That was not the fix. This reverts commit 8bcf690ae03db85608b2ea22eac7a91c84df4dc. Modified:

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

found in input > > // CHECK-LABEL: cond.true: > > ^ > > :21:8: note: scanning from here > > br i1 %7, label %8, label %10 > > ^ > > :25:6: note: possible intended match here > > store i1 true, i1* %4, align 1 > > ^ > >

r369830 - NFC: Rename some sanitizer related lifetime checks

Author: vitalybuka Date: Fri Aug 23 18:31:38 2019 New Revision: 369830 URL: http://llvm.org/viewvc/llvm-project?rev=369830=rev Log: NFC: Rename some sanitizer related lifetime checks Added: cfe/trunk/test/CodeGen/lifetime-sanitizer.c cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp

r365921 - CodeGet: Init 32bit pointers with 0xFFFFFFFF

Author: vitalybuka Date: Fri Jul 12 10:21:55 2019 New Revision: 365921 URL: http://llvm.org/viewvc/llvm-project?rev=365921=rev Log: CodeGet: Init 32bit pointers with 0x Summary: Patch makes D63967 effective for 32bit platforms and improves pattern initialization there. It cuts size of

r365858 - Handle IntToPtr in isBytewiseValue

Author: vitalybuka Date: Thu Jul 11 18:42:03 2019 New Revision: 365858 URL: http://llvm.org/viewvc/llvm-project?rev=365858=rev Log: Handle IntToPtr in isBytewiseValue Summary: This helps with more efficient use of memset for pattern initialization From @pcc prototype for

r365857 - Codegen, NFC: 32bit test in auto-var-init.cpp

Author: vitalybuka Date: Thu Jul 11 18:36:11 2019 New Revision: 365857 URL: http://llvm.org/viewvc/llvm-project?rev=365857=rev Log: Codegen, NFC: 32bit test in auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp URL:

r365835 - CodeGen: Suppress c++ warnings in test

Author: vitalybuka Date: Thu Jul 11 14:59:09 2019 New Revision: 365835 URL: http://llvm.org/viewvc/llvm-project?rev=365835=rev Log: CodeGen: Suppress c++ warnings in test Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp URL:

r365822 - CodeGen, NFC: Test for auto-init for 32bit pointers

Author: vitalybuka Date: Thu Jul 11 13:51:59 2019 New Revision: 365822 URL: http://llvm.org/viewvc/llvm-project?rev=365822=rev Log: CodeGen, NFC: Test for auto-init for 32bit pointers Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp

r365709 - NFC: Pass DataLayout into isBytewiseValue

Author: vitalybuka Date: Wed Jul 10 15:53:52 2019 New Revision: 365709 URL: http://llvm.org/viewvc/llvm-project?rev=365709=rev Log: NFC: Pass DataLayout into isBytewiseValue Summary: We will need to handle IntToPtr which I will submit in a separate patch as it's not going to be NFC. Reviewers:

r365708 - NFC: Convert large lambda into method

Author: vitalybuka Date: Wed Jul 10 15:53:50 2019 New Revision: 365708 URL: http://llvm.org/viewvc/llvm-project?rev=365708=rev Log: NFC: Convert large lambda into method Reviewers: pcc, eugenis Reviewed By: eugenis Subscribers: cfe-commits, lldb-commits Tags: #clang, #lldb Differential

r365706 - GodeGen, NFC: Add test to track emitStoresForConstant behavior

Author: vitalybuka Date: Wed Jul 10 15:47:07 2019 New Revision: 365706 URL: http://llvm.org/viewvc/llvm-project?rev=365706=rev Log: GodeGen, NFC: Add test to track emitStoresForConstant behavior Reviewers: eugenis, pcc Reviewed By: eugenis Subscribers: cfe-commits Tags: #clang Differential

r364495 - [NFC] Return early for types with size zero

Author: vitalybuka Date: Wed Jun 26 19:08:15 2019 New Revision: 364495 URL: http://llvm.org/viewvc/llvm-project?rev=364495=rev Log: [NFC] Return early for types with size zero Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp URL:

r364492 - [NFC] Remove unneeded local variables

Author: vitalybuka Date: Wed Jun 26 18:34:21 2019 New Revision: 364492 URL: http://llvm.org/viewvc/llvm-project?rev=364492=rev Log: [NFC] Remove unneeded local variables Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp URL:

Re: [PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

Not much, but it's not abandoned. I was interrupted by other stuff. Also I am concerned by the fact that zero initialization without any new optimization is cheaper than pattern even with patches in progress. On Thu, Jun 20, 2019 at 9:05 AM JF Bastien via Phabricator < revi...@reviews.llvm.org>

r359366 - [AArch64] Initialize HasMTE

Author: vitalybuka Date: Fri Apr 26 19:40:01 2019 New Revision: 359366 URL: http://llvm.org/viewvc/llvm-project?rev=359366=rev Log: [AArch64] Initialize HasMTE Modified: cfe/trunk/lib/Basic/Targets/AArch64.cpp Modified: cfe/trunk/lib/Basic/Targets/AArch64.cpp URL:

Re: r357323 - [analyzer] Introduce a simplified API for adding custom path notes.

Bot detects memory leak probably after this patch http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/30957/steps/check-clang%20asan/logs/stdio = ==22233==ERROR: LeakSanitizer: detected memory leaks Direct leak

r355445 - [docs] Add some architectures into the list of supported ThreadSanitizer platforms

Author: vitalybuka Date: Tue Mar 5 13:10:42 2019 New Revision: 355445 URL: http://llvm.org/viewvc/llvm-project?rev=355445=rev Log: [docs] Add some architectures into the list of supported ThreadSanitizer platforms Some platforms for which TSAN has build rules are omitted for the lack of known

r355442 - [docs] Update the list of ThreadSanitizer supported OSes

Author: vitalybuka Date: Tue Mar 5 12:53:34 2019 New Revision: 355442 URL: http://llvm.org/viewvc/llvm-project?rev=355442=rev Log: [docs] Update the list of ThreadSanitizer supported OSes Modified: cfe/trunk/docs/ThreadSanitizer.rst Modified: cfe/trunk/docs/ThreadSanitizer.rst URL:

r349015 - [asan] Don't check ODR violations for particular types of globals

Author: vitalybuka Date: Thu Dec 13 01:47:39 2018 New Revision: 349015 URL: http://llvm.org/viewvc/llvm-project?rev=349015=rev Log: [asan] Don't check ODR violations for particular types of globals Summary: private and internal: should not trigger ODR at all. unnamed_addr: current ODR checking

r348327 - [asan] Add clang flag -fsanitize-address-use-odr-indicator

Author: vitalybuka Date: Tue Dec 4 17:44:31 2018 New Revision: 348327 URL: http://llvm.org/viewvc/llvm-project?rev=348327=rev Log: [asan] Add clang flag -fsanitize-address-use-odr-indicator Reviewers: eugenis, m.ostapenko, ygribov Subscribers: hiraditya, llvm-commits Differential Revision:

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

https://reviews.llvm.org/rL343369 On Fri, Sep 28, 2018 at 4:51 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke couple of our builders: > > http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/12924 >

r343369 - [cxx2a] Fix warning triggered by r343285

Author: vitalybuka Date: Fri Sep 28 19:17:12 2018 New Revision: 343369 URL: http://llvm.org/viewvc/llvm-project?rev=343369=rev Log: [cxx2a] Fix warning triggered by r343285 Modified: cfe/trunk/include/clang/AST/DeclBase.h Modified: cfe/trunk/include/clang/AST/DeclBase.h URL:

[clang-tools-extra] r343369 - [cxx2a] Fix warning triggered by r343285

Author: vitalybuka Date: Fri Sep 28 19:17:12 2018 New Revision: 343369 URL: http://llvm.org/viewvc/llvm-project?rev=343369=rev Log: [cxx2a] Fix warning triggered by r343285 Modified: clang-tools-extra/trunk/clang-doc/BitcodeWriter.h Modified:

r343183 - Revert "[DebugInfo] Generate debug information for labels."

Author: vitalybuka Date: Thu Sep 27 01:15:24 2018 New Revision: 343183 URL: http://llvm.org/viewvc/llvm-project?rev=343183=rev Log: Revert "[DebugInfo] Generate debug information for labels." This reverts commit r343148. It crashes on sanitizer-x86_64-linux-autoconf. Removed:

r343150 - Init LookupResult::AmbiguityKind

Author: vitalybuka Date: Wed Sep 26 15:58:53 2018 New Revision: 343150 URL: http://llvm.org/viewvc/llvm-project?rev=343150=rev Log: Init LookupResult::AmbiguityKind We don't expect useful value there unless it's "ambiguous". However we use read it for copying and moving, so we need either init

Re: r342925 - P0962R1: only use the member form of 'begin' and 'end' in a range-based

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/24083 FAIL: Clang :: CXX/stmt.stmt/stmt.iter/stmt.ranged/p1.cpp (1692 of 13357) TEST 'Clang :: CXX/stmt.stmt/stmt.iter/stmt.ranged/p1.cpp' FAILED Script: -- : 'RUN: at line 1';

[libcxx] r339971 - Revert "Establish the header. NFC yet. Reviewed as https://reviews.llvm.org/D50815"

Author: vitalybuka Date: Thu Aug 16 16:57:16 2018 New Revision: 339971 URL: http://llvm.org/viewvc/llvm-project?rev=339971=rev Log: Revert "Establish the header. NFC yet. Reviewed as https://reviews.llvm.org/D50815; Breaks build on sanitizer bots. This reverts commit r339943. Removed:

Re: [libcxx] r339943 - Establish the header. NFC yet. Reviewed as https://reviews.llvm.org/D50815

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/27733 http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/14670 On Thu, Aug 16, 2018 at 3:30 PM Vitaly Buka wrote: > This brakes some bots >

Re: [libcxx] r339943 - Establish the header. NFC yet. Reviewed as https://reviews.llvm.org/D50815

This brakes some bots http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/22441 /b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1/algorithm:648:10: fatal error: 'bit' file not found #include ^ 1 error generated. On Thu, Aug 16, 2018 at 2:36 PM

Re: r339581 - [SEMA] add more -Wfloat-conversion to compound assigment analysis

Looks like this patch: http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/13867/steps/ninja%20check%201/logs/stdio FAIL: Clang :: Sema/conversion.c (12530 of 44133) TEST 'Clang :: Sema/conversion.c' FAILED Script: -- : 'RUN: at line 1';

[libcxxabi] r334926 - Fix libcxxabi tests after clang r334924

Author: vitalybuka Date: Sun Jun 17 23:43:55 2018 New Revision: 334926 URL: http://llvm.org/viewvc/llvm-project?rev=334926=rev Log: Fix libcxxabi tests after clang r334924 Modified: libcxxabi/trunk/test/libcxxabi/test/config.py Modified: libcxxabi/trunk/test/libcxxabi/test/config.py URL:

Re: r334677 - P0096R5, P0941R2: Update to match latest feature test macro specification.

the issue is. I'll take a look >> in the morning. If this is blocking anything in the mean time, feel free to >> revert this (or fix libc++ yourself). >> >> >> On Sun, 17 Jun 2018, 01:40 Vitaly Buka via cfe-commits, < >> cfe-commits@lists.llvm.org> wro

[libcxxabi] r334924 - Fix libcxx tests after clang r334677.

Author: vitalybuka Date: Sun Jun 17 23:24:29 2018 New Revision: 334924 URL: http://llvm.org/viewvc/llvm-project?rev=334924=rev Log: Fix libcxx tests after clang r334677. Modified: libcxxabi/trunk/test/libcxxabi/test/config.py Modified: libcxxabi/trunk/test/libcxxabi/test/config.py URL:

Re: r334677 - P0096R5, P0941R2: Update to match latest feature test macro specification.

Hi Richard, After this patch check-all fails for me with: llvm-project/libcxx/utils/libcxx/test/config.py", line 467, in configure_features int(macros['__cpp_deduction_guides']) < 201611: ValueError: invalid literal for int() with base 10: '201703L' On Wed, Jun 13, 2018 at 5:44 PM Richard

r334216 - Introducing single for loop into clang_proto_fuzzer

Author: vitalybuka Date: Thu Jun 7 12:17:46 2018 New Revision: 334216 URL: http://llvm.org/viewvc/llvm-project?rev=334216=rev Log: Introducing single for loop into clang_proto_fuzzer Summary: Created a new protobuf and protobuf-to-C++ "converter" that wraps the entire C++ code in a single for

r329612 - asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address

Author: vitalybuka Date: Mon Apr 9 13:10:29 2018 New Revision: 329612 URL: http://llvm.org/viewvc/llvm-project?rev=329612=rev Log: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address Summary: Right now to disable -fsanitize=kernel-address instrumentation,

r325411 - [ThinLTO] Allow indexing to request backend to ignore the module

Author: vitalybuka Date: Fri Feb 16 15:38:22 2018 New Revision: 325411 URL: http://llvm.org/viewvc/llvm-project?rev=325411=rev Log: [ThinLTO] Allow indexing to request backend to ignore the module Summary: Gold plugin does not add pass to ThinLTO modules without useful symbols. In this case

r325410 - [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

Author: vitalybuka Date: Fri Feb 16 15:34:16 2018 New Revision: 325410 URL: http://llvm.org/viewvc/llvm-project?rev=325410=rev Log: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set Summary: ThinLTO compilation may decide not to split module and keep at as regular

r325184 - Moved CHECK in test closer to source code

Author: vitalybuka Date: Wed Feb 14 14:52:49 2018 New Revision: 325184 URL: http://llvm.org/viewvc/llvm-project?rev=325184=rev Log: Moved CHECK in test closer to source code Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll Modified:

r325182 - [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

Author: vitalybuka Date: Wed Feb 14 14:41:15 2018 New Revision: 325182 URL: http://llvm.org/viewvc/llvm-project?rev=325182=rev Log: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK Summary: TypeID summaries are used by CFI and need to be serialized by ThinLTO indexing for

r317035 - [clang-fuzzer] Fix incremental builds of the fuzzer

Author: vitalybuka Date: Tue Oct 31 13:49:57 2017 New Revision: 317035 URL: http://llvm.org/viewvc/llvm-project?rev=317035=rev Log: [clang-fuzzer] Fix incremental builds of the fuzzer Summary: Don't use BUILD_IN_SOURCE keep git checkout clean Don't forward CMAKE_GENERATOR as ExternalProject_Add

Re: r314037 - DR1113: anonymous namespaces formally give their contents internal linkage.

This breaks check-clang-tools http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12310/steps/test/logs/stdio On Fri, Sep 22, 2017 at 3:21 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Sep 22 15:21:44

Re: r313827 - Give external linkage and mangling to lambdas inside inline variables and variable templates.

reverted by r313856 On Wed, Sep 20, 2017 at 6:30 PM, Richard Smith <rich...@metafoo.co.uk> wrote: > Thanks, I'll fix this tomorrow; if that's not soon enough, please go ahead > and revert (or fix by adding a dummy enumerator in lib/AST/Linkage.h). > > On 20 Sep 2017 17:39, &q

r313856 - Revert "Give external linkage and mangling to lambdas inside inline variables and variable templates."

Author: vitalybuka Date: Wed Sep 20 19:51:56 2017 New Revision: 313856 URL: http://llvm.org/viewvc/llvm-project?rev=313856=rev Log: Revert "Give external linkage and mangling to lambdas inside inline variables and variable templates." To fix: runtime error: load of value 15, which is not a

Re: r313827 - Give external linkage and mangling to lambdas inside inline variables and variable templates.

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8038/steps/check-clang%20ubsan/logs/stdio -- /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/clang/lib/AST/Decl.cpp:1333:42: runtime error: load of value 15, which is not a valid value for type

r313521 - Another attempt to fix warning discovered by r313487. [-Wunused-lambda-capture]

Author: vitalybuka Date: Mon Sep 18 01:26:01 2017 New Revision: 313521 URL: http://llvm.org/viewvc/llvm-project?rev=313521=rev Log: Another attempt to fix warning discovered by r313487. [-Wunused-lambda-capture] Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified:

r312407 - Don't search libxml2 if using msan. LLVM already has similar check.

Author: vitalybuka Date: Fri Sep 1 20:53:42 2017 New Revision: 312407 URL: http://llvm.org/viewvc/llvm-project?rev=312407=rev Log: Don't search libxml2 if using msan. LLVM already has similar check. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.txt URL:

r311428 - Update libprotobuf-mutator revision

Author: vitalybuka Date: Mon Aug 21 22:18:28 2017 New Revision: 311428 URL: http://llvm.org/viewvc/llvm-project?rev=311428=rev Log: Update libprotobuf-mutator revision Modified: cfe/trunk/cmake/modules/ProtobufMutator.cmake Modified: cfe/trunk/cmake/modules/ProtobufMutator.cmake URL:

r310441 - [clang-fuzzer] Resolve proto dependencies

Author: vitalybuka Date: Tue Aug 8 21:45:00 2017 New Revision: 310441 URL: http://llvm.org/viewvc/llvm-project?rev=310441=rev Log: [clang-fuzzer] Resolve proto dependencies Modified: cfe/trunk/tools/clang-fuzzer/proto-to-cxx/CMakeLists.txt Modified:

Re: r310057 - Revert r304953 for release 5.0.0

Probably not, r310056 fails as well On Fri, Aug 4, 2017 at 3:19 PM, Vitaly Buka wrote: > Looks like it's causing > http://lab.llvm.org:8011/builders/sanitizer-x86_64- > linux-bootstrap/builds/1969/steps/build%20clang%2Fmsan/logs/stdio > > FAILED:

Re: r310057 - Revert r304953 for release 5.0.0

Looks like it's causing http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1969/steps/build%20clang%2Fmsan/logs/stdio FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRPrinter.cpp.o /mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm_build0/bin/clang++

Re: r304017 - CodeGen: Define Swift's legal vector types for AArch64, ARM

Could this be the patch http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5228/steps/check-llvm%20msan/logs/stdio FAIL: LLVM :: CodeGen/ARM/arm-shrink-wrapping.ll (5392 of 20818) TEST 'LLVM :: CodeGen/ARM/arm-shrink-wrapping.ll' FAILED

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

Clang produces some confusing macro errors. According to Richard it's miscompilation: https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg57270.html On Thu, May 18, 2017 at 1:14 PM Dehao Chen wrote: > What's the issue? Build breaking? Performance regression? It's not

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

Local build: r302937 no issue, r302938 has issue. On Thu, May 18, 2017 at 7:23 AM Dehao Chen wrote: > Could you give some context on how r302938 is related to this? > > Thanks, > Dehao > > On Wed, May 17, 2017 at 11:14 PM, Vitaly Buka > wrote: > >>

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

+Dehao Chen it started from r302938 On Wed, May 17, 2017 at 8:09 PM Jordan Rose via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Thanks, this is helpful! > > > On May 16, 2017, at 12:26, Richard Smith wrote: > > On 15 May 2017 at 10:28, Jordan

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

Actually it was not "-w" but -DCMAKE_BUILD_TYPE=Release Also now I am not sure that it was r302966. Looking. On Wed, May 17, 2017 at 2:15 PM Vitaly Buka wrote: > And looks like "-w" is needed to trigger this. > > On Wed, May 17, 2017 at 1:43 PM Vitaly Buka

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

And looks like "-w" is needed to trigger this. On Wed, May 17, 2017 at 1:43 PM Vitaly Buka wrote: > On Tue, May 16, 2017 at 12:19 PM Richard Smith > wrote: > >> On 16 May 2017 at 11:54, Vitaly Buka wrote: >> >>> The patch

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

On Tue, May 16, 2017 at 12:19 PM Richard Smith wrote: > On 16 May 2017 at 11:54, Vitaly Buka wrote: > >> The patch breaks this test >> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1349/steps/check-clang%20msan/logs/stdio

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

The patch breaks this test http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1349/steps/check-clang%20msan/logs/stdio Script: -- /mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm_build_msan/./bin/clang -cc1 -internal-isystem

r303121 - [Sema] Use CK_NoOp instead CK_Invalid in tryGCCVectorConvertAndSplat

Author: vitalybuka Date: Mon May 15 17:04:03 2017 New Revision: 303121 URL: http://llvm.org/viewvc/llvm-project?rev=303121=rev Log: [Sema] Use CK_NoOp instead CK_Invalid in tryGCCVectorConvertAndSplat This fix UBSAN bots after r302935. Storing non-defined values in enum is undefined behavior.

Re: r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

We should file a bug and disable the test. Red bots are inconvenient for build cop. I have not notice this on non-asan builds, but I didn't look. On Mon, May 1, 2017 at 12:14 PM Richard Smith wrote: > Looks like this test has found a bug in the compiler. I've not repro'd

Re: r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

crash-vfs-ivfsoverlay.m does not work http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1322/steps/check-clang%20asan/logs/stdio On Fri, Apr 28, 2017 at 6:51 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Apr 28

Re: r298392 - [index/AST] Determine if a typedef shares a name and spelling location with its underlying tag type

Could you please take a look at these leaks http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/3606/steps/check-clang%20asan/logs/stdio = ==32547==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24

Re: [libcxx] r294707 - Split exception.cpp and new.cpp implementation into different files for different runtimes.

As I understand it's not the builder but cmake files of compiler-rt need to be fixed, somewhere near add_custom_libcxx in tsan and msan. Something just like this should work, but it's broken after the patch. cmake -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ../../llvm && ninja

Re: [libcxx] r294707 - Split exception.cpp and new.cpp implementation into different files for different runtimes.

Thanks. looking... On Thu, Feb 9, 2017 at 9:51 PM Eric Fiselier wrote: > To all those who wander here from the sanitizer autoconf buildbot failures > . > > Yes, this commit is responsible for that breakage. The

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

Both work: #define DECLARE_ASM_REP_MOVS(Type, Movs) \ template <> void asm_rep_movs(Type * dst, Type * src, size_t size) { \ __asm__("rep " Movs " \n\t" \ : "+D"(dst), "+S"(src), "+c"(size) \ : \ : "memory"); \

Re: r290533 - Driver: warn on -fPIC/-fpic/-fPIE/-fpie on Windows

This fails here http://lab.llvm.org:8011/builders/sanitizer-windows/builds/3537/steps/run%20tests/logs/stdio On Sun, Dec 25, 2016 at 7:45 PM Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Sun Dec 25 21:35:24 2016 > New Revision: 290533 > > URL:

Re: r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

etails in the policy, but I assumed that was a reasonable approach. So what is the process for after commit review? Alex On 5 December 2016 at 19:25, Vitaly Buka via cfe-commits < cfe-commits@lists.llvm.org> wrote: Author: vitalybuka Date: Mon Dec 5 13:25:00 2016 New Revision: 288689 URL: htt

r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

Author: vitalybuka Date: Mon Dec 5 13:25:00 2016 New Revision: 288689 URL: http://llvm.org/viewvc/llvm-project?rev=288689=rev Log: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec Summary: Similar to r288685. getExceptionSpec returned structure with pointers to

r288685 - Fix stack-use-after-scope in EvaluateImplicitExceptionSpec

Author: vitalybuka Date: Mon Dec 5 12:30:22 2016 New Revision: 288685 URL: http://llvm.org/viewvc/llvm-project?rev=288685=rev Log: Fix stack-use-after-scope in EvaluateImplicitExceptionSpec Summary: getExceptionSpec returns structure with pointers to temporarily object created by

Re: r287025 - [OPENMP] Fix stack use after delete, NFC.

I've reverted them both to fix bots: https://reviews.llvm.org/D26720 On Tue, Nov 15, 2016 at 3:40 PM Vitaly Buka wrote: > With this patch it's "after-scope" instead of return but still there: >

[PATCH] D26720: Revert "[OPENMP] Fixed codegen for 'omp cancel' construct."

This revision was automatically updated to reflect the committed changes. Closed by commit rL287069: Revert "[OPENMP] Fixed codegen for 'omp cancel' construct." (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D26720?vs=78107=78109#toc Repository: rL LLVM

r287069 - Revert "[OPENMP] Fixed codegen for 'omp cancel' construct."

Author: vitalybuka Date: Tue Nov 15 19:01:22 2016 New Revision: 287069 URL: http://llvm.org/viewvc/llvm-project?rev=287069=rev Log: Revert "[OPENMP] Fixed codegen for 'omp cancel' construct." Summary: r286944 introduced bugs detected by ASAN as use-after-return. r287025 have not fixed them

[PATCH] D26720: Revert "[OPENMP] Fixed codegen for 'omp cancel' construct."

vitalybuka created this revision. vitalybuka added a reviewer: ABataev. vitalybuka added a subscriber: cfe-commits. r286944 introduced bugs detected by ASAN as use-after-return. r287025 have not fixed them completely. This reverts commit r286944 and r287025. https://reviews.llvm.org/D26720

Re: r287025 - [OPENMP] Fix stack use after delete, NFC.

With this patch it's "after-scope" instead of return but still there: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/650/steps/check-clang%20asan/logs/stdio On Tue, Nov 15, 2016 at 1:07 PM Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: abataev

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

vitalybuka added a comment. This is probably caused by this patch http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/649/steps/check-clang%20msan/logs/stdio Repository: rL LLVM https://reviews.llvm.org/D26522 ___ cfe-commits

[PATCH] D26695: Revert "[OPENMP] Fixed codegen for 'omp cancel' construct."

vitalybuka created this revision. vitalybuka added a reviewer: ABataev. vitalybuka added a subscriber: cfe-commits. It introduced stack-use-after-return detected by ASAN. Here: ''' auto & = [ELoc](CodeGenFunction ) { CGF.CGM.getOpenMPRuntime().emitForStaticFinish(CGF, ELoc); };

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL285176: [CodeGen] Don't emit lifetime intrinsics for some local variables (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D24693?vs=74814=75832#toc Repository: rL LLVM

r285176 - [CodeGen] Don't emit lifetime intrinsics for some local variables

Author: vitalybuka Date: Wed Oct 26 00:42:30 2016 New Revision: 285176 URL: http://llvm.org/viewvc/llvm-project?rev=285176=rev Log: [CodeGen] Don't emit lifetime intrinsics for some local variables Summary: Current generation of lifetime intrinsics does not handle cases like: ``` { char

[PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

This revision was automatically updated to reflect the committed changes. Closed by commit rL285158: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D24695?vs=72908=75827#toc Repository: rL LLVM

r285159 - [Sema] Handle CaseStmt and DefaultStmt as SwitchCase

Author: vitalybuka Date: Tue Oct 25 21:00:00 2016 New Revision: 285159 URL: http://llvm.org/viewvc/llvm-project?rev=285159=rev Log: [Sema] Handle CaseStmt and DefaultStmt as SwitchCase Summary: rsmith Differential Revision: https://reviews.llvm.org/D25665 Modified:

r285158 - [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

Author: vitalybuka Date: Tue Oct 25 20:59:57 2016 New Revision: 285158 URL: http://llvm.org/viewvc/llvm-project?rev=285158=rev Log: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place Summary: D24693 will need access to it from other places Reviewers: eugenis Subscribers:

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka marked an inline comment as done. vitalybuka added a comment. Slowdown from this function is below: 0.05% and it's mostly just traversing AST. https://reviews.llvm.org/D24693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka marked an inline comment as done. vitalybuka added a comment. Please take a look. Meanwhile, I will investigate performance footprint. In https://reviews.llvm.org/D24693#559781, @rsmith wrote: > Is there some reasonable base set of functionality between this and > JumpDiagnostics

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka updated this revision to Diff 74814. vitalybuka added a comment. - fixed comment - added test for indirect jumps https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka updated this revision to Diff 74813. vitalybuka marked 5 inline comments as done. vitalybuka added a comment. Herald added a subscriber: modocache. - updated comments - indirect jumps - optimized Detect() https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp

[libcxxabi] r284295 - Fix typo in comment

Author: vitalybuka Date: Fri Oct 14 19:02:20 2016 New Revision: 284295 URL: http://llvm.org/viewvc/llvm-project?rev=284295=rev Log: Fix typo in comment Modified: libcxxabi/trunk/src/cxa_thread_atexit.cpp Modified: libcxxabi/trunk/src/cxa_thread_atexit.cpp URL:

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

vitalybuka added a comment. Thanks, done https://reviews.llvm.org/D25636 https://reviews.llvm.org/D24864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r284294 - Don't compile cxa_thread_atexit.cpp with -DLIBCXX_ENABLE_THREADS=OFF

Author: vitalybuka Date: Fri Oct 14 18:51:41 2016 New Revision: 284294 URL: http://llvm.org/viewvc/llvm-project?rev=284294=rev Log: Don't compile cxa_thread_atexit.cpp with -DLIBCXX_ENABLE_THREADS=OFF Reviewers: rmaprath Subscribers: beanz, mgorny Differential Revision:

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

vitalybuka added a comment. Maybe? - if (UNIX AND NOT (APPLE OR CYGWIN)) + if (LIBCXXABI_ENABLE_THREADS AND UNIX AND NOT (APPLE OR CYGWIN)) list(APPEND LIBCXXABI_SOURCES cxa_thread_atexit.cpp) endif() https://reviews.llvm.org/D24864 ___

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

vitalybuka added a comment. So there is: - Looking for __cxa_thread_atexit_impl in c - Looking for __cxa_thread_atexit_impl in c - not found and libcxx is configured with -DLIBCXX_ENABLE_THREADS=OFF https://reviews.llvm.org/D24864 ___ cfe-commits

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

vitalybuka added a comment. This change breaks http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/25625/steps/build%2032-bit%20symbolizer%20for%20compiler_rt_build/logs/stdio https://reviews.llvm.org/D24864 ___ cfe-commits mailing

[PATCH] D25453: Add -fno-sanitize-address-use-after-scope flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL283801: Add -fno-sanitize-address-use-after-scope flag (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D25453?vs=74176=74210#toc Repository: rL LLVM

r283801 - Add -fno-sanitize-address-use-after-scope flag

Author: vitalybuka Date: Mon Oct 10 16:31:50 2016 New Revision: 283801 URL: http://llvm.org/viewvc/llvm-project?rev=283801=rev Log: Add -fno-sanitize-address-use-after-scope flag Reviewers: eugenis Differential Revision: https://reviews.llvm.org/D25453 Modified:

[PATCH] D25453: Add -fno-sanitize-address-use-after-scope flag

vitalybuka updated this revision to Diff 74176. vitalybuka added a comment. resolved comments https://reviews.llvm.org/D25453 Files: include/clang/Driver/Options.td lib/Driver/SanitizerArgs.cpp lib/Frontend/CompilerInvocation.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c

[PATCH] D25453: Add -fno-sanitize-address-use-after-scope flag

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: test/Driver/fsanitize.c:124 +// RUN: %clang -target x86_64-linux-gnu -fsanitize=address %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-WITHOUT-USE-AFTER-SCOPE +//

[PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

vitalybuka added a comment. Out of curiosity, how was MSVC crash solved? Repository: rL LLVM https://reviews.llvm.org/D24916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    2   3   4   5   6   7   8   >