[PATCH] D46452: [sanitizer] Don't add --export-dynamic for Myriad

2018-05-04 Thread Walter Lee via Phabricator via cfe-commits
waltl created this revision. waltl added reviewers: vitalybuka, eugenis, alekseyshl. Herald added a subscriber: llvm-commits. This is to work around a bug in some versions of gnu ld, where --export-dynamic implies -shared even if -static is explicitly given. Myriad supports static linking only, so

[PATCH] D41713: [Myriad] Remove invalidated -elf flag for MoviAsm

2018-01-03 Thread Walter Lee via Phabricator via cfe-commits
waltl created this revision. waltl added a reviewer: jyknight. The flag has been deprecated, and is becoming invalid in the latest MDK. https://reviews.llvm.org/D41713 Files: clang/lib/Driver/ToolChains/Myriad.cpp clang/test/Driver/myriad-toolchain.c Index: clang/test/Driver/myriad-toolch

[PATCH] D41713: [Myriad] Remove invalidated -elf flag for MoviAsm

2018-01-08 Thread Walter Lee via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322023: [Myriad] Remove invalidated -elf flag for MoviAsm (authored by waltl, committed by ). Changed prior to commit: https://reviews.llvm.org/D41713?vs=128557&id=128970#toc Repository: rC Clang ht

[PATCH] D46452: [sanitizer] Don't add --export-dynamic for Myriad

2018-05-16 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 147233. waltl added a comment. Address CR comments Repository: rL LLVM https://reviews.llvm.org/D46452 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp Index: clang/lib/Driver/ToolChains/CommonArgs.cpp =

[PATCH] D46452: [sanitizer] Don't add --export-dynamic for Myriad

2018-05-17 Thread Walter Lee via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC332635: [sanitizer] Don't add --export-dynamic for Myriad (authored by waltl, committed by ). Changed prior to commit: https://reviews.llvm.org/D46452?vs=147233&id=147355#toc Repository: rC Clang ht

[PATCH] D42882: [Myriad] Define __ma2x5x and __ma2x8x

2018-02-06 Thread Walter Lee via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324420: [Myriad] Define __ma2x5x and __ma2x8x (authored by waltl, committed by ). Changed prior to commit: https://reviews.llvm.org/D42882?vs=132739&id=133086#toc Repository: rC Clang https://review

[PATCH] D34105: Define _GNU_SOURCE for rtems c++

2017-06-12 Thread Walter Lee via Phabricator via cfe-commits
waltl created this revision. This is required by the libc++ locale support. https://reviews.llvm.org/D34105 Files: lib/Basic/Targets.cpp test/Preprocessor/init.c Index: test/Preprocessor/init.c === --- test/Preprocessor/init.

[PATCH] D32146: PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+

2017-06-12 Thread Walter Lee via Phabricator via cfe-commits
waltl commandeered this revision. waltl added a reviewer: bcraig. waltl added a comment. Thanks for submitting the patch -- I will make the necessary revision and test it. https://reviews.llvm.org/D32146 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D32146: PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+

2017-06-12 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 102265. waltl added a comment. PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+ Newlib 2.5 added the locale management functions, so it should not include __nop_local_mgmt.h. This change adds proper guard around that include statement. For newlib 2.4,

[PATCH] D32146: PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+

2017-06-14 Thread Walter Lee via Phabricator via cfe-commits
waltl added a comment. In https://reviews.llvm.org/D32146#780231, @bcraig wrote: > LGTM. > @waltl : Do you need me to submit the changes, or will you handle that? Thanks -- I think jyknight will handle it. https://reviews.llvm.org/D32146 ___ cfe

[PATCH] D33020: [Myriad] Pass -Xclang and -mllvm flags to moviCompile

2017-05-09 Thread Walter Lee via Phabricator via cfe-commits
waltl created this revision. https://reviews.llvm.org/D33020 Files: lib/Driver/ToolChains/Myriad.cpp test/Driver/myriad-toolchain.c Index: test/Driver/myriad-toolchain.c === --- test/Driver/myriad-toolchain.c +++ test/Driver/my

[PATCH] D33020: [Myriad] Pass -Xclang and -mllvm flags to moviCompile

2017-05-09 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 98369. https://reviews.llvm.org/D33020 Files: lib/Driver/ToolChains/Myriad.cpp test/Driver/myriad-toolchain.c Index: test/Driver/myriad-toolchain.c === --- test/Driver/myriad-toolchain.c +++

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

2021-06-15 Thread Walter Lee via Phabricator via cfe-commits
waltl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:761 + // There's no libpthread or librt on Android. + if (!TC.getTriple().isAndroid()) { CmdArgs.push_back("-lpthread"); Just to be super cautious, can be keep this line an

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

2021-09-08 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 371467. waltl added a comment. Herald added a subscriber: dang. As suggested, I put the optimization behind an off-by-default flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.o

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

2021-09-10 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 372017. waltl added a comment. Delete redundant tests in arc-blocks-avoid-heapify.m. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

2021-09-10 Thread Walter Lee via Phabricator via cfe-commits
waltl added a comment. In D108243#2995476 , @ahatanak wrote: > Do you need `arc-blocks-avoid-heapify.m`? It seems like the other tests > already cover all the cases we care about. You're right much of it is redundant, but test10a() and test10b() are sti

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

2021-09-10 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 372031. waltl edited the summary of this revision. waltl added a comment. Merge arc-blocks-avoid-heapify.m into arc-blocks.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

2021-09-10 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 372035. waltl added a comment. Trivial cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cl

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

2021-09-10 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 372056. waltl added a comment. Added driver flags, and tests for them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/CodeGenOptions.

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

2021-09-13 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 372306. waltl added a comment. Remove driver flags and corresponding tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/CodeGenOpt

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

2021-09-13 Thread Walter Lee via Phabricator via cfe-commits
waltl added a comment. In D108243#2998077 , @ahatanak wrote: > I was just asking for test cases as I thought it was already a driver option, > but it turns out it wasn't. I agree that this shouldn't be a driver option. > > Sorry @waltl, please revert the

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

2021-09-13 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 372383. waltl added a comment. Mark new option as NoDriverOption Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

2021-09-14 Thread Walter Lee via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66c6bbe7ff56: Put code that avoids heapifying local blocks behind a flag (authored by waltl). Repository: rG LLVM Github Monorepo CHANGES SINCE L