[PATCH] D158252: Fix regression of D157680

2023-08-18 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 added a comment. In D158252#4597933 , @Hahnfeld wrote: > LG. IMHO such fixes to the tests can be committed without review :) OK, Thanks for explanation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D158252: Fix regression of D157680

2023-08-17 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 created this revision. Herald added a subscriber: pengfei. Herald added a project: All. XinWang10 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Test cases in D157680 should be

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

2023-08-16 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 updated this revision to Diff 551001. XinWang10 added a comment. - update fe test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.td clang/lib/Drive

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

2023-08-13 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 marked an inline comment as done. XinWang10 added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoS

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

2023-08-13 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 updated this revision to Diff 549802. XinWang10 added a comment. - mov definition to tuning features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.t

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

2023-08-13 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 marked an inline comment as done. XinWang10 added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoS

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

2023-08-11 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 marked 4 inline comments as done. XinWang10 added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoS

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

2023-08-11 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 updated this revision to Diff 549571. XinWang10 added a comment. - resolve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

2023-08-11 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 updated this revision to Diff 549337. XinWang10 added a comment. - mv driver implement to x86 specific code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Op

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

2023-08-11 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 updated this revision to Diff 549268. XinWang10 added a comment. - restore blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.td clang/lib/D

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

2023-08-11 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. XinWang10 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wangpc, MaskRay. Herald added projects: clang, LLVM. Gather instructions could lead to secur

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

2023-06-02 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 added a comment. In D151863#4390132 , @craig.topper wrote: > I still think replacing the `1` with a valid register for the mode is the > better fix. But if you give that, we couldn't take a mem operand without base reg. Repository: rG LLV

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

2023-06-01 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-64.c:79 + int arr[1000]; + __asm enqcmds rax, zmmword ptr [arr] + // CHECK: call void asm sideeffect inteldialect "enqcmds rax, zmmword ptr $0", "*m,~{flags},~{dirflag},~{fpsr},~{flags}"(ptr element

[PATCH] D144244: [X86]rearange X86InstrInfo.td

2023-02-20 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 added a comment. Thanks for your reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144244/new/ https://reviews.llvm.org/D144244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D144244: [X86]rearange X86InstrInfo.td

2023-02-20 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 added a comment. In D144244#4134569 , @RKSimon wrote: > LGTM - although it might be nice to pull out more ISAs from X86InstrMisc into > their own files (X86InstrTBM, etc.) as its always annoying trying to find > their defs. Many instructions