[clang-tools-extra] [clang] [llvm] [IR] Disallow ZeroInit for spirv.Image (PR #73887)

https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/73887 >From e369b5d62094c9b48f3c33075d764c115a208a74 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Thu, 30 Nov 2023 09:57:06 +0800 Subject: [PATCH] [IR] Disallow ZeroInit for spirv.Image According to spirv spec, OpCo

[clang-tools-extra] [clang] [llvm] [libc] [flang] [compiler-rt] [libcxx] [IR] Disallow ZeroInit for spirv.Image (PR #73887)

https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/73887 >From e369b5d62094c9b48f3c33075d764c115a208a74 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Thu, 30 Nov 2023 09:57:06 +0800 Subject: [PATCH] [IR] Disallow ZeroInit for spirv.Image According to spirv spec, OpCo

[compiler-rt] [llvm] [clang] [flang] [libcxx] [clang-tools-extra] [libc] [IR] Disallow ZeroInit for spirv.Image (PR #73887)

wenju-he wrote: > image-unoptimized.ll backtrace: ``` #0 0x01d2f0e1 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/export/users/wenjuhe/llvm/llvm-project/build/bin/llc+0x1d2f0e1) #1 0x01d2c644 SignalHandler(int) Signals.cpp:0:0 #2 0x7fd516a7ddb0 __restore_rt (/lib6

[clang] [llvm] [compiler-rt] [clang-tools-extra] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/70611 >From 7c41be75c1ef661e757bfaca8d693b3937df649e Mon Sep 17 00:00:00 2001 From: Wenju He Date: Mon, 30 Oct 2023 08:36:52 +0800 Subject: [PATCH 1/2] [InferAddressSpaces] Fix constant replace to avoid modifying oth

[clang] [llvm] [compiler-rt] [clang-tools-extra] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/70611 >From 7c41be75c1ef661e757bfaca8d693b3937df649e Mon Sep 17 00:00:00 2001 From: Wenju He Date: Mon, 30 Oct 2023 08:36:52 +0800 Subject: [PATCH 1/3] [InferAddressSpaces] Fix constant replace to avoid modifying oth

[clang] [llvm] [compiler-rt] [clang-tools-extra] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

https://github.com/wenju-he ready_for_review https://github.com/llvm/llvm-project/pull/70611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [compiler-rt] [clang-tools-extra] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

@@ -0,0 +1,40 @@ +; RUN: opt -assume-default-is-flat-addrspace -print-module-scope -print-after-all -S -disable-output -passes=infer-address-spaces <%s 2>&1 | FileCheck %s + +; CHECK: IR Dump After InferAddressSpacesPass on f2 + +; Check that after running infer-address-spaces o

[clang] [llvm] [compiler-rt] [clang-tools-extra] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

@@ -0,0 +1,40 @@ +; RUN: opt -assume-default-is-flat-addrspace -print-module-scope -print-after-all -S -disable-output -passes=infer-address-spaces <%s 2>&1 | FileCheck %s + +; CHECK: IR Dump After InferAddressSpacesPass on f2 + +; Check that after running infer-address-spaces o

[compiler-rt] [llvm] [clang] [clang-tools-extra] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

@@ -334,6 +335,15 @@ template<> struct simplify_type { } }; +template <> struct GraphTraits { wenju-he wrote: > In any case, this should not be in a public IR header. I've reverted the change in this file. https://github.com/llvm/llvm-project/pull/70611 _

[compiler-rt] [clang] [clang-tools-extra] [llvm] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

@@ -334,6 +335,15 @@ template<> struct simplify_type { } }; +template <> struct GraphTraits { wenju-he wrote: I measured llvm-project compile time impact of this change to llvm/IR/User.h on intel icx 8358 cpu. Build command: ` cmake -GNinja -DLLVM_ENABLE_

[compiler-rt] [clang-tools-extra] [llvm] [clang] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

https://github.com/wenju-he edited https://github.com/llvm/llvm-project/pull/70611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [compiler-rt] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

https://github.com/wenju-he edited https://github.com/llvm/llvm-project/pull/70611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang-tools-extra] [clang] [llvm] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

@@ -334,6 +335,15 @@ template<> struct simplify_type { } }; +template <> struct GraphTraits { wenju-he wrote: added 3 more runs on RHEL9 today, the compile time diff is very small. https://github.com/llvm/llvm-project/pull/70611 ___

[llvm] [compiler-rt] [clang-tools-extra] [clang] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

@@ -334,6 +335,15 @@ template<> struct simplify_type { } }; +template <> struct GraphTraits { wenju-he wrote: > For the specific problem here, I'd consider expanding all constant > expressions in the function upfront, and then not having to deal with it.

[llvm] [clang-tools-extra] [clang] [compiler-rt] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

wenju-he wrote: > I think it would be better if we could eliminate ConstantExpr addrspacecasts > from the IR altogether, which would avoid most of the complexity here. I > would also somewhat prefer to push this DFS into a helper function, but can > live with it inline as-is thank you for the