[PATCH] D39120: [rename] Don't overwrite the template argument when renaming a template function.

2017-10-20 Thread Wojciech Cierpucha via Phabricator via cfe-commits
cierpuchaw added inline comments. Comment at: unittests/Rename/RenameFunctionTest.cpp:232 + std::string Expected = R"( + namespace na { + template T Y(); Shouldn't this be `namespace nb {`? https://reviews.llvm.org/D39120 _

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

2017-02-15 Thread Wojciech Cierpucha via Phabricator via cfe-commits
cierpuchaw added inline comments. Comment at: clangd/DocumentStore.h:42 /// Delete a document from the store. - void removeDocument(StringRef Uri) { Docs.erase(Uri); } + void removeDocument(StringRef Uri) { Docs.erase(Uri); +for (const auto &Listener : Listeners) ---

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

2017-02-13 Thread Wojciech Cierpucha via Phabricator via cfe-commits
cierpuchaw added inline comments. Comment at: clangd/DocumentStore.h:42 /// Delete a document from the store. - void removeDocument(StringRef Uri) { Docs.erase(Uri); } + void removeDocument(StringRef Uri) { Docs.erase(Uri); +for (const auto &Listener : Listeners) ---

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

2017-02-13 Thread Wojciech Cierpucha via Phabricator via cfe-commits
cierpuchaw added inline comments. Comment at: clangd/DocumentStore.h:42 /// Delete a document from the store. - void removeDocument(StringRef Uri) { Docs.erase(Uri); } + void removeDocument(StringRef Uri) { Docs.erase(Uri); +for (const auto &Listener : Listeners) ---