[clang] [llvm] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-10-31 Thread Wolfgang Pieb via cfe-commits
wolfy1961 wrote: Superseded by PR [70014](https://github.com/llvm/llvm-project/pull/70014). https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [llvm] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-10-31 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 closed https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-10-23 Thread Wolfgang Pieb via cfe-commits
wolfy1961 wrote: Ping... Any takers? https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-10-10 Thread Wolfgang Pieb via cfe-commits
wolfy1961 wrote: Ping ... https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-10-02 Thread Wolfgang Pieb via cfe-commits
wolfy1961 wrote: Ping ... https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-19 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 updated https://github.com/llvm/llvm-project/pull/65512 >From 2e5abcec65c189fbb7f789816373969ee81ecfa5 Mon Sep 17 00:00:00 2001 From: wpieb Date: Tue, 5 Sep 2023 10:43:23 -0700 Subject: [PATCH 1/2] [LTO] A static relocation model can override the PIC level wrt trea

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-11 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 review_requested https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 review_requested https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 review_requested https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 review_requested https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 review_requested https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 created https://github.com/llvm/llvm-project/pull/65512: As described in issue [#64999](https://github.com/llvm/llvm-project/issues/64999), commit [e018cbf7208](https://github.com/llvm/llvm-project/commit/e018cbf7208b3d34f18997ddee84c66cee32fb1b) caused the symbol

[clang] 477f9ce - [MSCV][dllexport/dllimport][PS] Allow UniqueExternal linkage classes with dllexport/dllimport

2023-03-29 Thread Wolfgang Pieb via cfe-commits
Author: Wolfgang Pieb Date: 2023-03-29T18:15:04Z New Revision: 477f9cea77e6d55ecddaafbedccd418750c40dbd URL: https://github.com/llvm/llvm-project/commit/477f9cea77e6d55ecddaafbedccd418750c40dbd DIFF: https://github.com/llvm/llvm-project/commit/477f9cea77e6d55ecddaafbedccd418750c40dbd.diff LOG:

[clang] 634430d - [MSVC][dllexport/dllimport] Propagate a dllexport/dllimport attribute to template baseclass

2023-03-15 Thread Wolfgang Pieb via cfe-commits
Author: Wolfgang Pieb Date: 2023-03-15T11:47:54-07:00 New Revision: 634430d5857e395cff62534b11c460f51c6c846a URL: https://github.com/llvm/llvm-project/commit/634430d5857e395cff62534b11c460f51c6c846a DIFF: https://github.com/llvm/llvm-project/commit/634430d5857e395cff62534b11c460f51c6c846a.diff

[clang] 5d07e04 - [TLS]: Clamp the alignment of TLS global variables if required by the target

2023-02-08 Thread Wolfgang Pieb via cfe-commits
Author: Wolfgang Pieb Date: 2023-02-08T10:34:56-08:00 New Revision: 5d07e0448e38d4be0cc7b1079d72b5e3644e941c URL: https://github.com/llvm/llvm-project/commit/5d07e0448e38d4be0cc7b1079d72b5e3644e941c DIFF: https://github.com/llvm/llvm-project/commit/5d07e0448e38d4be0cc7b1079d72b5e3644e941c.diff

[clang] 8564e2f - [Inlining] Add a clang option to limit inlining of functions

2022-08-18 Thread Wolfgang Pieb via cfe-commits
Author: Wolfgang Pieb Date: 2022-08-18T11:56:24-07:00 New Revision: 8564e2fea559c58fecab3c7c01acf498bbe7820a URL: https://github.com/llvm/llvm-project/commit/8564e2fea559c58fecab3c7c01acf498bbe7820a DIFF: https://github.com/llvm/llvm-project/commit/8564e2fea559c58fecab3c7c01acf498bbe7820a.diff

[clang] d789ea7 - [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

2022-01-10 Thread Wolfgang Pieb via cfe-commits
Author: Wolfgang Pieb Date: 2022-01-10T16:38:01-08:00 New Revision: d789ea713372d44e50ff52a85a198ac6bbedaef9 URL: https://github.com/llvm/llvm-project/commit/d789ea713372d44e50ff52a85a198ac6bbedaef9 DIFF: https://github.com/llvm/llvm-project/commit/d789ea713372d44e50ff52a85a198ac6bbedaef9.diff

[clang-tools-extra] f805c60 - Revert "[clangd] Implement rename by using SelectionTree and findExplicitReferences."

2019-11-18 Thread Wolfgang Pieb via cfe-commits
Author: Wolfgang Pieb Date: 2019-11-18T15:39:05-08:00 New Revision: f805c60a093325c16ce4200d2615ef48555d9cb8 URL: https://github.com/llvm/llvm-project/commit/f805c60a093325c16ce4200d2615ef48555d9cb8 DIFF: https://github.com/llvm/llvm-project/commit/f805c60a093325c16ce4200d2615ef48555d9cb8.diff

r317053 - Making a couple of tests a bit more flexible wrt thunk mangling. Fixes checkin for r317047.

2017-10-31 Thread Wolfgang Pieb via cfe-commits
Author: wolfgangp Date: Tue Oct 31 17:01:20 2017 New Revision: 317053 URL: http://llvm.org/viewvc/llvm-project?rev=317053&view=rev Log: Making a couple of tests a bit more flexible wrt thunk mangling. Fixes checkin for r317047. Modified: cfe/trunk/test/CodeGenCXX/tmp-md-nodes1.cpp cfe/tr

r317047 - Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk.

2017-10-31 Thread Wolfgang Pieb via cfe-commits
Author: wolfgangp Date: Tue Oct 31 15:49:48 2017 New Revision: 317047 URL: http://llvm.org/viewvc/llvm-project?rev=317047&view=rev Log: Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk. The cloning happens before all metadata nodes are resolved. Prevent the value mapper

r277094 - Change a test to be less prone to random failures due to

2016-07-28 Thread Wolfgang Pieb via cfe-commits
Author: wolfgangp Date: Thu Jul 28 19:54:13 2016 New Revision: 277094 URL: http://llvm.org/viewvc/llvm-project?rev=277094&view=rev Log: Change a test to be less prone to random failures due to unintended matches of label numbers to debug metadata handles in release builds. Modified: cfe/trunk

r276361 - Reverting r275115 which caused PR28634.

2016-07-21 Thread Wolfgang Pieb via cfe-commits
Author: wolfgangp Date: Thu Jul 21 18:28:18 2016 New Revision: 276361 URL: http://llvm.org/viewvc/llvm-project?rev=276361&view=rev Log: Reverting r275115 which caused PR28634. When empty (forwarding) basic blocks that are referenced by user labels are removed, incorrect code may be generated. Re

r275128 - Correcting the previous fix for test submitted with r275115.

2016-07-11 Thread Wolfgang Pieb via cfe-commits
Author: wolfgangp Date: Mon Jul 11 18:27:19 2016 New Revision: 275128 URL: http://llvm.org/viewvc/llvm-project?rev=275128&view=rev Log: Correcting the previous fix for test submitted with r275115. Modified: cfe/trunk/test/CodeGen/forwarding-blocks-if.c Modified: cfe/trunk/test/CodeGen/forwar

r275127 - Fix test submitted with r275115 (failed on ppc64 buildbots).

2016-07-11 Thread Wolfgang Pieb via cfe-commits
Author: wolfgangp Date: Mon Jul 11 18:20:28 2016 New Revision: 275127 URL: http://llvm.org/viewvc/llvm-project?rev=275127&view=rev Log: Fix test submitted with r275115 (failed on ppc64 buildbots). Modified: cfe/trunk/test/CodeGen/forwarding-blocks-if.c Modified: cfe/trunk/test/CodeGen/forwar

r275115 - Prevent the creation of empty (forwarding) blocks resulting from nested ifs.

2016-07-11 Thread Wolfgang Pieb via cfe-commits
Author: wolfgangp Date: Mon Jul 11 17:22:23 2016 New Revision: 275115 URL: http://llvm.org/viewvc/llvm-project?rev=275115&view=rev Log: Prevent the creation of empty (forwarding) blocks resulting from nested ifs. Summary: Nested if statements can generate empty BBs whose terminator branches unco

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

2016-07-06 Thread Wolfgang Pieb via cfe-commits
wolfgangp added inline comments. Comment at: test/CodeGen/forwarding-blocks-if.c:17 @@ +16,3 @@ +return 0; +} + mehdi_amini wrote: > Any reason to not stick with LLVM coding convention here? No reason, thanks for pointing this out. http://reviews.llvm.org/D1

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

2016-07-06 Thread Wolfgang Pieb via cfe-commits
wolfgangp updated this revision to Diff 62916. wolfgangp added a comment. Addressed review comments: documented changes and clang-formatted the test case. http://reviews.llvm.org/D11360 Files: lib/CodeGen/CGStmt.cpp test/CodeGen/forwarding-blocks-if.c Index: test/CodeGen/forwarding-blocks-

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

2016-07-05 Thread Wolfgang Pieb via cfe-commits
wolfgangp added a comment. Ping... http://reviews.llvm.org/D11360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

2016-06-27 Thread Wolfgang Pieb via cfe-commits
wolfgangp updated this revision to Diff 61987. wolfgangp added a comment. Herald added a subscriber: mehdi_amini. Updating this patch against a recent revision. http://reviews.llvm.org/D11360 Files: lib/CodeGen/CGStmt.cpp test/CodeGen/forwarding-blocks-if.c Index: test/CodeGen/forwarding-b

Re: [PATCH] D8822: Proposed fix for PR23076 (conditional branch debug line info)

2016-01-28 Thread Wolfgang Pieb via cfe-commits
wolfgangp added a comment. > Clang (with patch) > 3, 5, 4, 5, 7 > 9, 11, 10, 11, 14 > > So that's somewhat problematic - we shouldn't visit 11 at all. (but we are > today, as is GCC... so maybe NBD?) Well, if op&& is overloaded, wouldn't we lose the short-circuit property? If so it ma