Author: wizard
Date: Thu Mar 14 17:17:41 2019
New Revision: 356220
URL: http://llvm.org/viewvc/llvm-project?rev=356220=rev
Log:
Fixed global constant/variable naming check on C++ class for ObjC++ files.
Subscribers: cfe-commits
Tags: #clang
Differential Revision:
Author: wizard
Date: Wed Feb 20 09:32:41 2019
New Revision: 354485
URL: http://llvm.org/viewvc/llvm-project?rev=354485=rev
Log:
Update property prefix regex to allow numbers.
Subscribers: jfb, cfe-commits
Differential Revision: https://reviews.llvm.org/D56896
Modified:
Author: wizard
Date: Fri Nov 9 15:19:14 2018
New Revision: 346566
URL: http://llvm.org/viewvc/llvm-project?rev=346566=rev
Log:
Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when
message target is a result of a C-style method.
Summary:
The issue is that for array
Author: wizard
Date: Thu Nov 1 10:36:18 2018
New Revision: 345858
URL: http://llvm.org/viewvc/llvm-project?rev=345858=rev
Log:
Fix the issue that not recognizing single acronym with prefix as ObjC property
name.
Summary: This will make clang-tidy accept property names like xyz_URL (URL is a
Author: wizard
Date: Mon Jun 11 15:44:06 2018
New Revision: 334448
URL: http://llvm.org/viewvc/llvm-project?rev=334448=rev
Log:
- Add "AV" as new default acronym. - Add support for "I" and "A" in
lowerCamelCase pattern
Summary: Now we can support property names like "hasADog" correctly.
Author: wizard
Date: Tue May 15 11:13:51 2018
New Revision: 332382
URL: http://llvm.org/viewvc/llvm-project?rev=332382=rev
Log:
add AR to acronyms of clang-tidy property check
Reviewers: hokein, benhamilton
Reviewed By: benhamilton
Subscribers: klimek, cfe-commits
Differential Revision:
Author: wizard
Date: Fri May 4 11:14:08 2018
New Revision: 331545
URL: http://llvm.org/viewvc/llvm-project?rev=331545=rev
Log:
Add support for ObjC property name to be a single acronym.
Summary:
This change will support cases like:
```
@property(assign, nonatomic) int ID;
```
Reviewers:
to ensure they are
> happy. But if you can't figure out how to restore the bots you'll end up
> needing to revert the whole series and get some help from someone with access
> to another platform.
>
>> On Sun, Apr 22, 2018, 18:03 Yan Zhang via cfe-commits
>> &
But if you can't figure out how to restore the bots
> you'll end up needing to revert the whole series and get some help from
> someone with access to another platform.
>
> On Sun, Apr 22, 2018, 18:03 Yan Zhang via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
&g
Author: wizard
Date: Sun Apr 22 18:05:02 2018
New Revision: 330562
URL: http://llvm.org/viewvc/llvm-project?rev=330562=rev
Log:
update readability-identifier-naming-objc test to use interface ivar.
Implementation ivars are not supported in 32-bits OS.
Reviewers: alexfh, chandlerc
Subscribers:
ppc64be-linux/builds/17830
>>>> http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/1979
>>>> http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/11659
>>>>
>>>> I'm not sure how you're running your tests that you don't see t
hat you don't see these
>> issues, but they seem to reproduce on many build bots and the error message
>> doesn't seem to be architecture specific at all...
>>
>> I suspect something about how you are trying to run tests isn't actually
>> running this test if you are
specific at all...
>
> I suspect something about how you are trying to run tests isn't actually
> running this test if you aren't able to locally reproduce.
>
> On Sun, Apr 22, 2018 at 5:19 PM Yan Zhang via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Aut
Author: wizard
Date: Sun Apr 22 17:15:15 2018
New Revision: 330559
URL: http://llvm.org/viewvc/llvm-project?rev=330559=rev
Log:
update test to use ivar in implementation instead of class extension
Summary: using ivar in class extension is not supported in 32-bit architecture
of MacOS.
sts
> yourself? Nothing configuration specific here. Still, no hurry.
>
>> On Sat, Apr 21, 2018 at 6:02 PM Yan Zhang via cfe-commits
>> <cfe-commits@lists.llvm.org> wrote:
>> Sorry I was out today. What is the new error? Can u send it to me?
>>
>> Best regards
hing configuration specific here. Still, no hurry.
>
>> On Sat, Apr 21, 2018 at 6:02 PM Yan Zhang via cfe-commits
>> <cfe-commits@lists.llvm.org> wrote:
>> Sorry I was out today. What is the new error? Can u send it to me?
>>
>> Best regards
>> Yan Zh
;
>>>> On Apr 20, 2018, at 19:08, Chandler Carruth <chandl...@gmail.com> wrote:
>>>>
>>>> This has broken most of the build bots. Are you working on a fix or revert?
>>>>
>>>> Might be useful to get on the IRC channel to help coor
e IRC channel to help coordinate this kind of
> thing.
>
>> On Fri, Apr 20, 2018 at 4:45 PM Yan Zhang via cfe-commits
>> <cfe-commits@lists.llvm.org> wrote:
>> Author: wizard
>> Date: Fri Apr 20 16:18:09 2018
>> New Revision: 330492
>>
>> URL: htt
Author: wizard
Date: Fri Apr 20 16:18:09 2018
New Revision: 330492
URL: http://llvm.org/viewvc/llvm-project?rev=330492=rev
Log:
[clang-tidy] add new check to find out objc ivars which do not have prefix '_'
Summary:
For code of ivar declaration:
int barWithoutPrefix;
The fix will be:
Author: wizard
Date: Wed Apr 18 13:09:10 2018
New Revision: 330286
URL: http://llvm.org/viewvc/llvm-project?rev=330286=rev
Log:
add extra acronyms for objc property names
Summary: This is to support general acronyms in Objective-C like 2G/3G/4G/...
and coordinates X, Y, Z and W.
Reviewers:
Author: wizard
Date: Wed Mar 7 10:59:25 2018
New Revision: 326928
URL: http://llvm.org/viewvc/llvm-project?rev=326928=rev
Log:
do not register matcher for objc-only checks when analyzing non-objc sources to
save resources
Summary: I did not put lang opt check in AvoidSpinlockCheck since
Author: wizard
Date: Tue Feb 27 10:35:53 2018
New Revision: 326222
URL: http://llvm.org/viewvc/llvm-project?rev=326222=rev
Log:
add UUID to the acronyms list of objc property name checks
Reviewers: benhamilton, hokein
Reviewed By: benhamilton
Subscribers: klimek, cfe-commits
Differential
Author: wizard
Date: Tue Feb 6 13:40:38 2018
New Revision: 324407
URL: http://llvm.org/viewvc/llvm-project?rev=324407=rev
Log:
Support special acronyms inside property names and allow plural forms
Reviewers: benhamilton, hokein
Reviewed By: benhamilton, hokein
Subscribers: klimek, cfe-commits
Author: wizard
Date: Mon Jan 29 17:44:00 2018
New Revision: 323722
URL: http://llvm.org/viewvc/llvm-project?rev=323722=rev
Log:
add prefix with '_' support for property name. Corresponding apple dev doc:
https://developer.apple.com/library/content/qa/qa1908/_index.html
Reviewers: benhamilton,
Author: wizard
Date: Tue Jan 16 16:19:35 2018
New Revision: 322602
URL: http://llvm.org/viewvc/llvm-project?rev=322602=rev
Log:
add ID as a special acronym to objc property declaration check for property
names like bundleID.allow using acronyms as suffix.
Reviewers: benhamilton, hokein
Author: wizard
Date: Thu Nov 30 11:05:09 2017
New Revision: 319460
URL: http://llvm.org/viewvc/llvm-project?rev=319460=rev
Log:
add new check to find NSError init invocation
Subscribers: klimek, mgorny, cfe-commits
Differential Revision: https://reviews.llvm.org/D40528
Added:
Author: wizard
Date: Thu Nov 30 11:05:08 2017
New Revision: 319459
URL: http://llvm.org/viewvc/llvm-project?rev=319459=rev
Log:
add new check to find NSError init invocation
Summary:
This check will find out improper initialization of NSError objects.
According to Apple developer document, we
Author: wizard
Date: Mon Nov 27 13:30:10 2017
New Revision: 319098
URL: http://llvm.org/viewvc/llvm-project?rev=319098=rev
Log:
add new check to find OSSpinlock usage
Summary:
This check finds the use of methods related to OSSpinlock in Objective-C code,
which should be deprecated due to
Author: wizard
Date: Wed Nov 15 17:28:29 2017
New Revision: 318366
URL: http://llvm.org/viewvc/llvm-project?rev=318366=rev
Log:
add check to avoid throwing objc exception according to Google Objective-C guide
Summary:
This is a small check to avoid throwing objc exceptions.
In specific it will
29 matches
Mail list logo