[PATCH] D66964: Sort Java imports without newline

2019-08-29 Thread Yannic Bonenberger via Phabricator via cfe-commits
yannic created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66964 Files: clang/unittests/Format/SortImportsTestJava.cpp Index: clang/unittests/Format/SortImportsTestJava.cpp =

[PATCH] D66964: Sort Java imports without newline

2019-08-29 Thread Yannic Bonenberger via Phabricator via cfe-commits
yannic added reviewers: SamMaier, thakis. yannic added a comment. Right now, this change only adds a test that shows the broken behavior. SamMaier@ you're the author of https://reviews.llvm.org/D52800 which implemented Java import sorting. Is there a reason to not sort imports when there's more

[PATCH] D76234: [AST] Simplify implementation of Type::isXXXType()

2020-03-27 Thread Yannic Bonenberger via Phabricator via cfe-commits
yannic added a comment. sammccall, hokein: you've recently created or reviewed changes in this area. Can you help review this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76234/new/ https://reviews.llvm.org/D76234 _

[PATCH] D76234: [AST] Simplify implementation of Type::isXXXType()

2020-03-27 Thread Yannic Bonenberger via Phabricator via cfe-commits
yannic added a comment. Thank you! I don't have commit access, would you mind committing this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76234/new/ https://reviews.llvm.org/D76234 ___ cfe-co

[PATCH] D76234: clang: Simplify implementation of Type::isXXXType()

2020-03-16 Thread Yannic Bonenberger via Phabricator via cfe-commits
yannic created this revision. yannic added reviewers: klimek, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76234 Files: clang/include/clang/AST/Type.h Index: clang/include/clang/AST/Type.h =