[PATCH] D83731: Add Debug Info Size to Symbol Status

This revision was automatically updated to reflect the committed changes. Closed by commit rG986e3af53bfe: Add Debug Info Size to Symbol Status (authored by aelitashen, committed by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 280261. aelitashen added a comment. Fix run_test to cover every system case and attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen marked an inline comment as done. aelitashen added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +active_modules = self.vscode.get_active_modules() +program_module =

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279936. aelitashen added a comment. Fix the accidentally removed test contents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279351. aelitashen added a comment. Add a white space in Symbols loaded info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279303. aelitashen added a comment. Remove white space for test_module_event Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278922. aelitashen added a comment. Add TODO comment for Linux, Use ostringstream for Debug Info Size message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278900. aelitashen added a comment. Merge if statements in GetDebugInfoSizeInSection() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278898. aelitashen added a comment. Merge Codes and Improve Readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278894. aelitashen added a comment. Create help function in tests for code re-use. Take care of both macOS and Linux system. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278631. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. The tests added are only for macOS, Walter will help me write tests on Linux. This update optimize the code and apply git clang format.

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7f80159753b: [lldb-vscode] Add Support for Module Event (authored by aelitashen, committed by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276294. aelitashen added a comment. Add Path Verification in Test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files:

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276274. aelitashen added a comment. Fix messy diff stack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files:

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276172. aelitashen added a comment. Add test for loading symbols, other module info and Add version to module info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 274634. aelitashen added a comment. Make LLDB take care of the directory delimiter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files:

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen marked 3 inline comments as done. aelitashen added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:337-340 +std::string(module.GetFileSpec().GetFilename())); + std::string module_path = std::string(module.GetFileSpec().GetDirectory()) + +

[PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen abandoned this revision. aelitashen added a comment. Mistakenly created two diffs on same commit, See D82477 for the original diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82505/new/

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 273378. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Formatting the codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/

[PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 273189. aelitashen added a comment. Formatting the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82505/new/ https://reviews.llvm.org/D82505 Files: clang/tools/clang-format/git-clang-format

[PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. aelitashen added a project: LLDB. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make lldb-vscode receive and process module events so that modules can be rendered in the IDE. Repository: