[clang] [LTO] Add unified LTO tests for the PS targets. (PR #148229)

https://github.com/MaggieYingYi closed https://github.com/llvm/llvm-project/pull/148229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] Add unified LTO tests for the PS targets. (PR #148229)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/148229 >From ab2917f40d2690ce1af05d48269e2fb999002638 Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Mon, 9 Jun 2025 11:14:24 +0100 Subject: [PATCH] [LTO] Enhance unified/nonunified LTO checks. For the PS targets,

[clang] [LTO] Add unified LTO tests for the PS targets. (PR #148229)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/148229 >From 673cdd38180bbf2a9d7eab056d74aea2a6316c7f Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Mon, 9 Jun 2025 11:14:24 +0100 Subject: [PATCH] [LTO] Enhance unified/nonunified LTO checks. For the PS targets,

[clang] [LTO] Add unified LTO tests for the PS targets. (PR #148229)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/148229 >From bbda5a3c055e258b961df30f493443e344b57cfa Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Mon, 9 Jun 2025 11:14:24 +0100 Subject: [PATCH] [LTO] Enhance unified/nonunified LTO checks. For the PS targets,

[clang] [LTO] Add unified LTO tests for the PS targets. (PR #148229)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/148229 >From c1a8e6af4e7e87ccc10ae282763925e16716b8fa Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Mon, 9 Jun 2025 11:14:24 +0100 Subject: [PATCH] [LTO] Enhance unified/nonunified LTO checks. For the PS targets,

[clang] [LTO] Add unified LTO tests for the PS targets. (PR #148229)

MaggieYingYi wrote: gentle pinging ... https://github.com/llvm/llvm-project/pull/148229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

MaggieYingYi wrote: > I had created #144737 for code review. Fixed the issue. Bot https://lab.llvm.org/buildbot/#/builders/64/builds/4311 build successfully. https://github.com/llvm/llvm-project/pull/143614 ___ cfe-commits mailing list cfe-commits@li

[clang] [Clang] Fix the clang/test/PCH/ignored-pch.c test. (PR #144737)

https://github.com/MaggieYingYi closed https://github.com/llvm/llvm-project/pull/144737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the clang/test/PCH/ignored-pch.c test. (PR #144737)

https://github.com/MaggieYingYi created https://github.com/llvm/llvm-project/pull/144737 Change the test to check the exit status of the 'ls' command line (instead of error message) since the error message is different when running 'ls' command on the different Host machine. >From 6d3bd2fb459

[clang] Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

MaggieYingYi wrote: I had created https://github.com/llvm/llvm-project/pull/144737 for code review. https://github.com/llvm/llvm-project/pull/143614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

MaggieYingYi wrote: Thanks @lei137, I am working on fixing the test. https://github.com/llvm/llvm-project/pull/143614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][headers]Remove unnecessary guard of !defined(__SCE__). (PR #144522)

https://github.com/MaggieYingYi closed https://github.com/llvm/llvm-project/pull/144522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][headers]Remove unnecessary guard of !defined(__SCE__). (PR #144522)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/144522 >From 80d8a8ed4705cbfd24f473e484a0c0546a9e665d Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Mon, 9 Jun 2025 20:01:21 +0100 Subject: [PATCH] Remove unnecessary guard of !defined(__SCE__). Sony PlayStation n

[clang] [clang][headers]Remove unnecessary guard of !defined(__SCE__). (PR #144522)

MaggieYingYi wrote: Thanks @phoebewang. https://github.com/llvm/llvm-project/pull/144522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

@@ -0,0 +1,19 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t + +// Create PCH without -ignore-pch. +// RUN: %clang -x c++-header %S/../Modules/Inputs/codegen-flags/foo.h -### 2>&1 | FileCheck %s -check-prefix=CHECK-EMIT-PCH MaggieYingYi wrote: Hi @MaskRay, Assuming

[clang] Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

@@ -0,0 +1,19 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t + +// Create PCH without -ignore-pch. +// RUN: %clang -x c++-header %S/../Modules/Inputs/codegen-flags/foo.h -### 2>&1 | FileCheck %s -check-prefix=CHECK-EMIT-PCH MaggieYingYi wrote: Hi @MaskRay, Could yo

[clang] [Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (PR #142409)

MaggieYingYi wrote: I had created https://github.com/llvm/llvm-project/pull/143614 for code review in order to reload the patch. https://github.com/llvm/llvm-project/pull/142409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

@@ -0,0 +1,19 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t + +// Create PCH without -ignore-pch. +// RUN: %clang -x c++-header %S/../Modules/Inputs/codegen-flags/foo.h -### 2>&1 | FileCheck %s -check-prefix=CHECK-EMIT-PCH MaggieYingYi wrote: Thanks, fixed in http

[clang] Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/143614 >From a581eb7725f88d49b65376dcf113299e35aacf78 Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Tue, 10 Jun 2025 20:09:57 +0100 Subject: [PATCH 1/2] Reload "[Frontend][PCH]-Add support for ignoring PCH options

[clang] Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

MaggieYingYi wrote: > LGTM. > Thanks @mizvekov. > So what changed since the last commit is that preprocessing-only mode doesn't > imply the semantics of this flag anymore. > Yes, only ignore PCH option when `-ignore-pch` is used in the command line. The preprocessing-only mode (-E) doesn't

[clang] Reload "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

https://github.com/MaggieYingYi created https://github.com/llvm/llvm-project/pull/143614 Visual Studio has an argument to ignore all PCH related switches. clang-cl has also support option /Y-. Having the same option in clang would be helpful. This commit is to add support for ignoring PCH opti

[clang] [Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (PR #142409)

MaggieYingYi wrote: Thanks @dyung for helping me verify the possible fixes. Unfortunately, the test would not pass by removing `-E`. Therefore, I had reverted the commit 4fb81f11cea0fce9f1f5409fcd55ae3aba70d368. https://github.com/llvm/llvm-project/pull/142409

[clang] c926bff - Revert "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)"

Author: Ying Yi Date: 2025-06-10T17:19:58+01:00 New Revision: c926bff560ba733a661bb494932c612ee6c207e5 URL: https://github.com/llvm/llvm-project/commit/c926bff560ba733a661bb494932c612ee6c207e5 DIFF: https://github.com/llvm/llvm-project/commit/c926bff560ba733a661bb494932c612ee6c207e5.diff LOG:

[clang] [Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (PR #142409)

MaggieYingYi wrote: I can see the test `Clang::crash-vfs-include-pch.m` using -E when including a pch file. This PR applied the following change: if command is prepossess (`-E`), `-include-pch` is ignored. This caused the test failure. I think the `-E` needs to be removed in the command line.

[clang] [Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (PR #142409)

MaggieYingYi wrote: > LLVM Buildbot has detected a new failure on builder > `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang` > at step 6 "test-build-unified-tree-check-all". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/190/builds/2

[clang] [Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (PR #142409)

MaggieYingYi wrote: > LLVM Buildbot has detected a new failure on builder > `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while > building `clang` at step 5 "compile-openmp". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/10/builds/7030 > It

[clang] 700d93b - Add two time-trace scope variables.

Author: Ying Yi Date: 2023-11-01T13:37:52Z New Revision: 700d93b0584c9d6401ec646fc3e343e90f326fa2 URL: https://github.com/llvm/llvm-project/commit/700d93b0584c9d6401ec646fc3e343e90f326fa2 DIFF: https://github.com/llvm/llvm-project/commit/700d93b0584c9d6401ec646fc3e343e90f326fa2.diff LOG: Add t

[clang] 33b8586 - Add two time-trace scope variables.

Author: Ying Yi Date: 2023-10-31T09:16:06Z New Revision: 33b85867e30e1adc2ff2173039c199b81c10f52b URL: https://github.com/llvm/llvm-project/commit/33b85867e30e1adc2ff2173039c199b81c10f52b DIFF: https://github.com/llvm/llvm-project/commit/33b85867e30e1adc2ff2173039c199b81c10f52b.diff LOG: Add t

[clang] 9ef536a - [UBSan] Disable the function and kcfi sanitizers on an execute-only target.

Author: Ying Yi Date: 2023-08-30T17:17:37+01:00 New Revision: 9ef536a12ea65a2b9e2511936327c7b621af38fb URL: https://github.com/llvm/llvm-project/commit/9ef536a12ea65a2b9e2511936327c7b621af38fb DIFF: https://github.com/llvm/llvm-project/commit/9ef536a12ea65a2b9e2511936327c7b621af38fb.diff LOG:

[clang] 94dd476 - [Coverage] Fix an issue: a statement after calling 'assert()' function is wrongly

Author: Ying Yi Date: 2023-03-02T09:14:44Z New Revision: 94dd4766a61bb18b263415e17e745dc2fa609162 URL: https://github.com/llvm/llvm-project/commit/94dd4766a61bb18b263415e17e745dc2fa609162 DIFF: https://github.com/llvm/llvm-project/commit/94dd4766a61bb18b263415e17e745dc2fa609162.diff LOG: [Cove

[clang] 5de4d97 - Driver tests: remove `REQUIRES: x86-registered-target` and set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`.

Author: Ying Yi Date: 2022-09-05T09:59:47+01:00 New Revision: 5de4d97a00b2a5d710892e96d77810784fd2cd5c URL: https://github.com/llvm/llvm-project/commit/5de4d97a00b2a5d710892e96d77810784fd2cd5c DIFF: https://github.com/llvm/llvm-project/commit/5de4d97a00b2a5d710892e96d77810784fd2cd5c.diff LOG:

[clang] 41b1c9f - Re-add the REQUIRES line to fix a failed build on builder llvm-clang-win-x-aarch64.

Author: Ying Yi Date: 2022-08-31T20:22:18+01:00 New Revision: 41b1c9ff70142dc38a381517718cd3f95e8d62b7 URL: https://github.com/llvm/llvm-project/commit/41b1c9ff70142dc38a381517718cd3f95e8d62b7 DIFF: https://github.com/llvm/llvm-project/commit/41b1c9ff70142dc38a381517718cd3f95e8d62b7.diff LOG:

[clang] 0e5fe1c - Remove `REQUIRES: x86-registered-target` from ps4/ps5 driver tests

Author: Ying Yi Date: 2022-08-31T09:56:37+01:00 New Revision: 0e5fe1cdacdca65edc84c89cc7a6de27f406de61 URL: https://github.com/llvm/llvm-project/commit/0e5fe1cdacdca65edc84c89cc7a6de27f406de61 DIFF: https://github.com/llvm/llvm-project/commit/0e5fe1cdacdca65edc84c89cc7a6de27f406de61.diff LOG:

[clang] bfe191d - Disable stack-sizes section by default for PS4.

Author: Ying Yi Date: 2022-07-27T09:37:20+01:00 New Revision: bfe191dfa79bbccb57506055db9c89bfb891f65c URL: https://github.com/llvm/llvm-project/commit/bfe191dfa79bbccb57506055db9c89bfb891f65c DIFF: https://github.com/llvm/llvm-project/commit/bfe191dfa79bbccb57506055db9c89bfb891f65c.diff LOG:

[clang] b09ba42 - Bug 51277: [DWARF] DW_AT_alignment incorrect when

Author: Ying Yi Date: 2022-04-22T12:15:00+01:00 New Revision: b09ba42620768c0092b20cf526a30b14752a5dc9 URL: https://github.com/llvm/llvm-project/commit/b09ba42620768c0092b20cf526a30b14752a5dc9 DIFF: https://github.com/llvm/llvm-project/commit/b09ba42620768c0092b20cf526a30b14752a5dc9.diff LOG:

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi added a comment. Thanks Paul for your help. Repository: rL LLVM http://reviews.llvm.org/D15222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi added a comment. Could someone commit it for me please (as I do not have commit access)? Thanks http://reviews.llvm.org/D15222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi updated this revision to Diff 42874. MaggieYi added a comment. Thanks, I have updated the test following your comments. http://reviews.llvm.org/D15222 Files: lib/Driver/Tools.cpp test/Driver/ps4-runtime-flags.c Index: test/Driver/ps4-runtime-flags.c ===

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi added a comment. My patch changes 6 compiler flags, which are –coverage, -fprofile-arcs, -fprofile-generate, -fprofile-generate=, -fprofile-instr-generate, -fprofile-instr-generate=. I would like to keep line 7-10 in order to verify the change to using “hasFlag” instead of “hasArg”. Fo

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi updated this revision to Diff 42711. MaggieYi added a comment. Following Vedant's comments, two test issues have been fixed. http://reviews.llvm.org/D15222 Files: lib/Driver/Tools.cpp test/Driver/ps4-runtime-flags.c Index: test/Driver/ps4-runtime-flags.c ==

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi added a comment. Thanks for reviewing the patch. I try to answer your questions, could you please let me know if this makes sense to you? Regards, Comment at: lib/Driver/Tools.cpp:4064 @@ -4046,1 +4063,3 @@ + // Add runtime flag for PS4 when PGO or Coverage are ena

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi added a comment. Ping http://reviews.llvm.org/D15222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi created this revision. MaggieYi added reviewers: filcab, probinson, jmagee, phillip.power. MaggieYi added a subscriber: cfe-commits. Dear All, This patch adds “--dependent-lib= libclang_rt.profile-x86_64.a” to the compiler command line when enabling code coverage on the PS4 target. A

Re: [PATCH] D12163: [Patch] [Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" (PR 24184)

MaggieYi added a comment. Thanks for helping me review and submit the patch. http://reviews.llvm.org/D12163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12163: [Patch] [Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" (PR 24184)

MaggieYi added a comment. Ping http://reviews.llvm.org/D12163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12163: [Patch] [Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" (PR 24184)

MaggieYi updated this revision to Diff 32671. MaggieYi added a comment. Hi Anna, Many thanks for your comments. I have modified the patch to address your comments. Please let me know what you think. PS: If the updated patch looks good to you, could you please commit it for me (as I do not have

[PATCH] D12163: [Patch] [Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" (PR 24184)

MaggieYi created this revision. MaggieYi added a reviewer: krememek. MaggieYi added a subscriber: cfe-commits. Dear All, I would like to propose a patch to solve an assertion failure reported by Dmitry in https://llvm.org/bugs/show_bug.cgi?id=24184. The assertion is caused by reusing a “filler”