[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Haha. My bad for misunderstanding. > I think rather if the common ancestor isn't completely selected, evaluation > shouldn't happen. I don't think it is a feasible approach to simply opt out of partial selection. Please consider this snippet: #define SizeOf sizeof

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Oops, an inline comment disappears accidentally. > #define PLUS_TWO + 2 > int x = 40 PLUS_TW^O; // huh, the value of "+ 2" is "42"? The reason is we're getting a `SelectionNode` with a wider range. Here is the layout of the tree: txt Built selection tree

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Sorry for responding late and thank you for the good catch! I've updated the code and please feel free to leave comments. :) Comment at: clang-tools-extra/clangd/Hover.cpp:728 } + SelectionTree::createEach( + AST.getASTContext(),

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 517865. zyounan added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan updated this revision to Diff 513979. zyounan added a comment. zyounan updated this revision to Diff 514019. zyounan updated this revision to Diff 514028. zyounan added reviewers:

[PATCH] D147909: [clang] Implement CWG 2397

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9826433f31c: [clang] Implement CWG 2397 (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147909/new/ https://reviews.llvm.org/D147909

[PATCH] D147909: [clang] Implement CWG 2397

zyounan added a comment. Thank you for the suggestion and I've updated my patch. :) Comment at: clang/test/CXX/dcl.decl/dcl.meaning/dcl.array/cwg2397.cpp:11 +} + +void g() { aaron.ballman wrote: > I think it'd be good to also show a constexpr test, like: > ```

[PATCH] D147909: [clang] Implement CWG 2397

zyounan updated this revision to Diff 512656. zyounan marked an inline comment as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147909/new/ https://reviews.llvm.org/D147909 Files:

[PATCH] D147909: [clang] Implement CWG 2397

zyounan created this revision. Herald added a project: All. zyounan added a comment. zyounan added reviewers: aaron.ballman, erichkeane, rsmith. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Note GCC had implemented such feature

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b103edf5b2c: [clangd] Fix a hover crash on unsigned 64bit value (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146874/new/

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan updated this revision to Diff 508401. zyounan marked an inline comment as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146874/new/ https://reviews.llvm.org/D146874 Files:

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan marked 2 inline comments as done. zyounan added a comment. Thank you! Comment at: clang-tools-extra/clangd/Hover.cpp:396 // -2=> 0xfffe -// -2^32 => 0xfffe +// -2^32 => 0x static llvm::FormattedNumber printHex(const llvm::APSInt )

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan updated this revision to Diff 508316. zyounan added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146874/new/ https://reviews.llvm.org/D146874 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This patch adapts to D140059

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

This revision was automatically updated to reflect the committed changes. Closed by commit rG138adb098032: [clangd] Refine logic on $0 in completion snippets (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:60 +bool shouldPatchPlaceholder0(CodeCompletionResult::ResultKind ResultKind, + CXCursorKind CursorKind) { nridge wrote: > nit: let's add

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 506001. zyounan marked an inline comment as done. zyounan added a comment. Add description to shouldPatchPlaceholder0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added a comment. Updated now. Thank you again for your patient review. :) Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:213 ++SnippetArg; - if (SnippetArg == CursorSnippetArg) { + if (ShouldPatchPlaceholder0 && SnippetArg ==

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 505420. zyounan marked 3 inline comments as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 Files:

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.h:45 /// /// When \p CompletingPattern is true, the last placeholder will be of the form /// ${0:…}, indicating the cursor should stay there. Sorry, I forget to revise

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 504950. zyounan added a comment. Update doxygen comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:441 getSignature(*SemaCCS, , , - , IsPattern); + , IsPattern, C.SemaResult); if (!C.SemaResult->FunctionCanBeCall) nridge

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 504947. zyounan marked 3 inline comments as done. zyounan added a comment. Address the comments. Revise parameters of `getSignature` to avoid passing CCR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan added reviewers: nridge, kadircet. zyounan published this revision for review. zyounan added inline comments. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb2d04d41e47: [clangd] Hide inlay hints when using a macro as a calling argument that with a… (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan updated this revision to Diff 500388. zyounan added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144074/new/ https://reviews.llvm.org/D144074 Files: clang-tools-extra/clangd/InlayHints.cpp

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:520 auto ExprStartLoc = SM.getTopMacroCallerLoc(E->getBeginLoc()); -auto Decomposed = SM.getDecomposedLoc(ExprStartLoc); +auto Decomposed = SM.getDecomposedExpansionLoc(ExprStartLoc);

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan updated this revision to Diff 500387. zyounan marked an inline comment as done. zyounan added a comment. Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144074/new/ https://reviews.llvm.org/D144074 Files:

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan updated this revision to Diff 499417. zyounan added a comment. Move parsing logic to Record.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144074/new/ https://reviews.llvm.org/D144074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan added reviewers: kadircet, nridge. zyounan added a comment. zyounan retitled this revision from "[clangd] Hide extra inlay hints for macro as argument" to "[clangd] Hide inlay hints

[PATCH] D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4021ed3d79d: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem` (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496971. zyounan added a comment. Apply clang-format to StandardLibrary.cpp to fix pipeline failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files:

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) zyounan wrote: > kadircet wrote: > > zyounan wrote: > > > kadircet wrote:

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. Thank you for your detailed explanation and sorry again for my dumb mistake before. :) Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, )

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) kadircet wrote: > zyounan wrote: > > kadircet wrote: > > > can you strip

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:1 +// These symbols are exported from N4100[fs.filesystem.synopsis], the final +// draft for experimental filesystem. Note that not all of these symbols were

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496963. zyounan marked 4 inline comments as done. zyounan added a comment. Revise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files:

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) kadircet wrote: > can you strip clang-format pragmas to be similar to

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496934. zyounan added a comment. Rebase to main && Move tests to clang/Tooling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files:

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. Sorry for the late update, I'm rebasing my branch now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 ___ cfe-commits mailing list

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496875. zyounan added a comment. Revise symbols from N4100 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files:

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan added a comment. In D143319#4115186 , @kadircet wrote: > thanks a lot for the patch! > > we're migrating IWYU related functionality in clangd to make use of > include-cleaner library nowadays. so can you actually move the IWYU > no_include

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan updated this revision to Diff 494921. zyounan added a comment. Fix test on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan updated this revision to Diff 494911. zyounan added a comment. Herald added a subscriber: ormris. Update tests && Use Preprocessor.LookupFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan updated this revision to Diff 494815. zyounan added a comment. zyounan updated this revision to Diff 494816. zyounan added reviewers: hokein, sammccall, kadircet, nridge. zyounan

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. In D142836#4089721 , @kadircet wrote: > And to follow up, I definitely see the problem you're facing and it's > something we'd like to address as well, just not in the way you proposed. > > This falls under the bucket of "we

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. Another question is that file `clang/Tooling/Inclusions/StdSymbolMap.inc` seems to be out-of-date. What's worse, the archive of cppref doesn't always update on time The latest version from official is published in

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 493195. zyounan added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang-tools-extra/clangd/index/CanonicalIncludes.cpp

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 493081. zyounan added a comment. Do not format inc file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang-tools-extra/clangd/index/CanonicalIncludes.cpp

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan edited the summary of this revision. zyounan added reviewers: hokein, sammccall, nridge. zyounan published this revision for review. Herald added subscribers: cfe-commits, MaskRay,

<    1   2