https://github.com/zyn0217 approved this pull request.
LGTM, but please wait for other reviewers as the change is really large.
> The user expectation is that getAs only removes top level sugar nodes,
> leaving all the type sugar on the returned node
So suppose there are really some users who
@@ -2922,8 +2931,31 @@ class alignas(TypeAlignment) Type : public
ExtQualsTypeCommonBase {
///
/// There are some specializations of this member template listed
/// immediately following this class.
+ ///
+ /// If you are interested only in the canonical properties of
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/155028
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/154458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/154458
>From befaf0fa99bfcdd09434345e93fc24765c70d243 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 18 Aug 2025 20:16:14 +0800
Subject: [PATCH 1/3] [Clang] Only remove lambda scope after computing
evaluation
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/154458
The immediate evaluation context needs the lambda scope info to propagate some
flags, however that LSI was removed in ActOnFinishFunctionBody which happened
before rebuilding a lambda expression.
This also con
@@ -2170,6 +2172,12 @@ ExprResult Sema::BuildLambdaExpr(SourceLocation
StartLoc, SourceLocation EndLoc,
PopExpressionEvaluationContext();
+sema::AnalysisBasedWarnings::Policy WP =
+AnalysisWarnings.getPolicyInEffectAt(EndLoc);
+// We cannot release LSI un
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/154382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/154382
Revert due to breakage as reported in
https://github.com/llvm/llvm-project/pull/154106#discussion_r2285824084
Reverts llvm/llvm-project#154106
>From a32c83413bc68d00fa7431877856767828c7c217 Mon Sep 17 00:00:00
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/106730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -228,7 +228,9 @@ void threadSafetyCleanup(BeforeSet *Cache);
// FIXME: No way to easily map from TemplateTypeParmTypes to
// TemplateTypeParmDecls, so we have this horrible PointerUnion.
-typedef std::pair,
+typedef std::pair,
zyn0217 wrote:
I think we cou
https://github.com/zyn0217 approved this pull request.
Sorry for not responding in time, I'm spending time in #141776 and there are
many things to be done there.
Overall, this LGTM. Thanks again for improving template packs!
https://github.com/llvm/llvm-project/pull/106730
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/154106
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -16681,7 +16677,8 @@ Decl *Sema::ActOnFinishFunctionBody(Decl *dcl, Stmt
*Body,
if (!IsInstantiation)
PopDeclContext();
- PopFunctionScopeInfo(ActivePolicy, dcl);
+ if (!RetainFunctionScopeInfo)
+PopFunctionScopeInfo(ActivePolicy, dcl);
zyn0217
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/154106
>From befaf0fa99bfcdd09434345e93fc24765c70d243 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 18 Aug 2025 20:16:14 +0800
Subject: [PATCH 1/2] [Clang] Only remove lambda scope after computing
evaluation
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/154106
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15791,12 +15791,9 @@ TreeTransform::TransformLambdaExpr(LambdaExpr
*E) {
return ExprError();
}
- // Copy the LSI before ActOnFinishFunctionBody removes it.
zyn0217 wrote:
Ugh it turns out we are able to keep the LSI if we don't drop the result of
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/154106
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/154106
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15791,12 +15791,9 @@ TreeTransform::TransformLambdaExpr(LambdaExpr
*E) {
return ExprError();
}
- // Copy the LSI before ActOnFinishFunctionBody removes it.
zyn0217 wrote:
Yes, this is just an inevitable consequence of PopScope deleting the scope
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/154106
The immediate evaluation context needs the lambda scope info to propagate some
flags, however that LSI was removed in ActOnFinishFunctionBody which happened
before rebuilding a lambda expression.
This also con
@@ -0,0 +1,43 @@
+#!/usr/bin/env python3
+
+# This script clears release notes, which is needed when bumping trunk version.
zyn0217 wrote:
We may want a copyright header
https://github.com/llvm/llvm-project/pull/153593
___
@@ -1887,7 +1887,19 @@ class CodeCompleteFlow {
for (auto &Cand : C.first) {
if (Cand.SemaResult &&
Cand.SemaResult->Kind == CodeCompletionResult::RK_Declaration) {
-auto ID = clangd::getSymbolID(Cand.SemaResult->getDeclaration());
+
@@ -1887,7 +1887,19 @@ class CodeCompleteFlow {
for (auto &Cand : C.first) {
if (Cand.SemaResult &&
Cand.SemaResult->Kind == CodeCompletionResult::RK_Declaration) {
-auto ID = clangd::getSymbolID(Cand.SemaResult->getDeclaration());
+
zyn0217 wrote:
(I'll issue a backport in a few days)
https://github.com/llvm/llvm-project/pull/151276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/151276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/150814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/139066
>From a6ee1af04225063bab4d853611c7a57b1db37aa9 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 8 May 2025 19:42:51 +0800
Subject: [PATCH 1/4] [Clang] Do not eat SFINAE diagnostics for explicit
template a
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/150559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12166,6 +12174,15 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl
*Found, Decl *Templated,
diag::note_ovl_candidate_explicit_arg_mismatch_unnamed)
<< (index + 1);
}
+
+if (PartialDiagnosticAt *PDiag = DeductionFailure.getSFINAEDiagnost
zyn0217 wrote:
@tstellar thanks! Feel free to open an issue about that if you got something :)
https://github.com/llvm/llvm-project/pull/143096
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/149782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/139066
>From a6ee1af04225063bab4d853611c7a57b1db37aa9 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 8 May 2025 19:42:51 +0800
Subject: [PATCH 1/4] [Clang] Do not eat SFINAE diagnostics for explicit
template a
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/149782
>From 32be32e2ae072f920389c61e42b9e392a6b92798 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 21 Jul 2025 17:17:48 +0800
Subject: [PATCH 1/2] [Clang] Fix a partial ordering bug involving CTAD
injected t
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/150186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -588,6 +588,9 @@ static bool CheckConstraintSatisfaction(
return true;
for (const AssociatedConstraint &AC : AssociatedConstraints) {
+if (AC.isNull())
+ return true;
zyn0217 wrote:
Can we continue?
https://github.com/llvm/llvm-project/pull
@@ -5525,6 +5525,8 @@ static TemplateDeductionResult CheckDeductionConsistency(
// FIXME: A substitution can be incomplete on a non-structural part of the
// type. Use the canonical type for now, until the TemplateInstantiator can
// deal with that.
+ if (auto *Injected
https://github.com/zyn0217 ready_for_review
https://github.com/llvm/llvm-project/pull/149782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/149782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/149782
>From 32be32e2ae072f920389c61e42b9e392a6b92798 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 21 Jul 2025 17:17:48 +0800
Subject: [PATCH] [Clang] Fix a partial ordering bug involving CTAD injected
templ
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/149782
None
>From cf42677637ce165d185c01fec974e83c246b0cf9 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 21 Jul 2025 17:17:48 +0800
Subject: [PATCH] [Clang] Fix a partial ordering bug involving CTAD injected
zyn0217 wrote:
@tstellar Thanks for letting us know. Do you have a reduced version? Even just
compling that reproducer on my machine takes ~30s so it's hard for me to run
cvise
https://github.com/llvm/llvm-project/pull/143096
___
cfe-commits mailing
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/149264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/149264
>From 728de4d995079208605879a0ec30e8f76fe5220c Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 17 Jul 2025 14:17:02 +0800
Subject: [PATCH 1/2] [Clang] Ensure correct parameters are in the scope for
const
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/149272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/149264
>From 728de4d995079208605879a0ec30e8f76fe5220c Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 17 Jul 2025 14:17:02 +0800
Subject: [PATCH 1/2] [Clang] Ensure correct parameters are in the scope for
const
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/149121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/149121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/149121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15512,6 +15512,8 @@ TreeTransform::TransformLambdaExpr(LambdaExpr
*E) {
DC = DC->getParent();
if ((getSema().isUnevaluatedContext() ||
getSema().isConstantEvaluatedContext()) &&
+ !(dyn_cast_or_null(DC->getParent()) &&
+cast(DC->getParent())->isGe
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/147675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1061,15 +1061,36 @@ BuildDeductionGuideForTypeAlias(Sema &SemaRef,
SmallVector DeduceResults(
F->getTemplateParameters()->size());
+ // We don't have to deduce against the alias template specialization,
+ // if the source template is a synthesized alias deduction
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/147675
>From f8b1894ad39560edb5bb0c14194a3a2d54a911ff Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Wed, 9 Jul 2025 16:29:45 +0800
Subject: [PATCH 1/4] [Clang] Consider default template arguments when
synthesizing
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/147675
>From f8b1894ad39560edb5bb0c14194a3a2d54a911ff Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Wed, 9 Jul 2025 16:29:45 +0800
Subject: [PATCH 1/3] [Clang] Consider default template arguments when
synthesizing
@@ -1061,15 +1061,36 @@ BuildDeductionGuideForTypeAlias(Sema &SemaRef,
SmallVector DeduceResults(
F->getTemplateParameters()->size());
+ // We don't have to deduce against the alias template specialization,
+ // if the source template is a synthesized alias deduction
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/147675
>From f8b1894ad39560edb5bb0c14194a3a2d54a911ff Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Wed, 9 Jul 2025 16:29:45 +0800
Subject: [PATCH 1/2] [Clang] Consider default template arguments when
synthesizing
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/147675
>From f8b1894ad39560edb5bb0c14194a3a2d54a911ff Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Wed, 9 Jul 2025 16:29:45 +0800
Subject: [PATCH] [Clang] Consider default template arguments when synthesizing
CTA
zyn0217 wrote:
Given the scale of the patch, it's not surprising if it undergoes some
revert-reapplies cycles after the initial commit.
To reduce the churn, would it be possible to ask google to test it internally
before we merge? @AaronBallman
https://github.com/llvm/llvm-project/pull/14783
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/147894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/147894
>From 17e42982fc947dccfc724ee6de6cf93fa8de3222 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 10 Jul 2025 13:26:09 +0800
Subject: [PATCH 1/2] [Clang] Fix the template argument collection after
CWG2369
@@ -1078,15 +1078,19 @@ static bool
CheckFunctionConstraintsWithoutInstantiation(
// template. We need the entire list, since the constraint is completely
// uninstantiated at this point.
- // FIXME: Add TemplateArgs through the 'Innermost' parameter once
- // the refac
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/147894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/147894
>From 17e42982fc947dccfc724ee6de6cf93fa8de3222 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 10 Jul 2025 13:26:09 +0800
Subject: [PATCH] [Clang] Fix the template argument collection after CWG2369
Since
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/147894
Since the function template isn't instantiated before constraint checking,
we'll not be able to find the outer template arguments through function
specialization when evaluating the inner constraint that is nes
@@ -1061,15 +1061,36 @@ BuildDeductionGuideForTypeAlias(Sema &SemaRef,
SmallVector DeduceResults(
F->getTemplateParameters()->size());
+ // We don't have to deduce against the alias template specialization,
+ // if the source template is a synthesized alias deduction
@@ -1088,6 +1088,9 @@ void CXXNameMangler::mangleNameWithAbiTags(GlobalDecl GD,
return;
}
+ while (DC->isRequiresExprBody())
+DC = DC->getParent();
zyn0217 wrote:
We had a similar while loop in TransformLambdaExpr, is that still needed?
Also I was
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/147675
We copy arguments from different template parameter lists depending on the
deducibility of the template parameters. In particular, we may lose the default
template argument from the original alias declaration,
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/147463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 ready_for_review
https://github.com/llvm/llvm-project/pull/147463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/147463
We were using the lexical DC as the starting point of template argument
collection when comparing declarations. This caused an issue that template
arguments from out-of-line declarations are ignored when substi
https://github.com/zyn0217 commented:
Why doesn't C++20 below suffer from the issue?
I think it's a waste to add a Sema scope object just for diagnostic issues.
It's more like that there's an underlying issue that would be otherwise hidden
by the patch. Can you explore?
https://github.com/ll
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/146986
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -93,6 +94,12 @@ class HeuristicResolver {
// during simplification, and the operation fails if no pointer type is
found.
QualType simplifyType(QualType Type, const Expr *E, bool UnwrapPointer);
+ // Given an expression `Fn` representing the callee in a function call,
https://github.com/zyn0217 approved this pull request.
Thanks, this looks great
Though part of me is curious about which bug was caught :)
https://github.com/llvm/llvm-project/pull/143345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/143345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/146153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/145260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -98,7 +98,36 @@ namespace {
CXXCastPath BasePath;
bool IsARCUnbridgedCast;
-SourceRange OpRange;
+struct OpRangeType {
+ SourceLocation Ranges[3];
zyn0217 wrote:
Renamed to Locations :)
https://github.com/llvm/llvm-project/pull/145260
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/145260
>From 504c05c3a076ecafb4f11ce0703caddfac6e06d1 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 23 Jun 2025 12:31:39 +0800
Subject: [PATCH 1/2] [Clang] Back out the source location workaround for
CXXConst
zyn0217 wrote:
@maryammo I managed to reduce it to
https://godbolt.org/z/vjcoq1qaG
.. will look into it tomorrow
https://github.com/llvm/llvm-project/pull/122423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/145260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 ready_for_review
https://github.com/llvm/llvm-project/pull/145260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/145260
>From 96f1c3bbbf7c07bf9d11bb907e3a35e196d181aa Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 23 Jun 2025 12:31:39 +0800
Subject: [PATCH] [Clang] Back out the source location workaround for
CXXConstruct
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/145260
>From 504c05c3a076ecafb4f11ce0703caddfac6e06d1 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 23 Jun 2025 12:31:39 +0800
Subject: [PATCH] [Clang] Back out the source location workaround for
CXXConstruct
https://github.com/zyn0217 ready_for_review
https://github.com/llvm/llvm-project/pull/145260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 converted_to_draft
https://github.com/llvm/llvm-project/pull/145260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/145260
>From f642a6d25a2bd3f12e6629f93152edc784bddbaa Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 23 Jun 2025 12:31:39 +0800
Subject: [PATCH] [Clang] Back out the source location workaround for
CXXConstruct
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/145260
This removes the workaround introduced in 3e1a9cf3b8 and 1ba7dc38d.
The issues should have been already resolved elsewhere, at least removing these
lines doesn't break any existing tests.
The workaround overwr
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/140680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
thanks
Do we also want to add some tests?
https://github.com/llvm/llvm-project/pull/143345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/143268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
Thanks
https://github.com/llvm/llvm-project/pull/143291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6998,6 +7007,31 @@ namespace {
else
return C.getRValueReferenceType(New);
}
+ case Elaborated: {
+auto *ET = cast(Old);
+return C.getElaboratedType(ET->getKeyword(), ET->getQualifier(),
+ wrap(C,
@@ -6998,6 +7007,31 @@ namespace {
else
return C.getRValueReferenceType(New);
}
+ case Elaborated: {
+auto *ET = cast(Old);
+return C.getElaboratedType(ET->getKeyword(), ET->getQualifier(),
+ wrap(C,
@@ -6998,6 +7007,31 @@ namespace {
else
return C.getRValueReferenceType(New);
}
+ case Elaborated: {
+auto *ET = cast(Old);
+return C.getElaboratedType(ET->getKeyword(), ET->getQualifier(),
+ wrap(C,
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/143143
https://github.com/llvm/llvm-project/issues/142608 reflects a case where the
type sugar on the attributed type alias is lost.
It might be possible to add the sugar back at the cost of duplicating the type
alia
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/143096
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
@rupprecht I sent out https://github.com/llvm/llvm-project/pull/143096 for the
fix :)
https://github.com/llvm/llvm-project/pull/122423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/143096
>From 020160fde7a3cc13b104a5f5577a8037cf412c66 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 6 Jun 2025 17:09:08 +0800
Subject: [PATCH 1/2] [Clang] Fail the constraint substitution early after
CWG2369
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/143096
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 1811 matches
Mail list logo
