ZarkoCA marked 4 inline comments as done.
ZarkoCA added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019
+ return SetCGInfo(
+ new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI ==
"soft"));
return SetCGInfo(
jasonliu
ZarkoCA updated this revision to Diff 254193.
ZarkoCA added a comment.
Fixed test cases that were breaking.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76130/new/
https://reviews.llvm.org/D76130
Files:
llvm/lib/Target/PowerPC/PPCISelLowering.c
ZarkoCA planned changes to this revision.
ZarkoCA added a comment.
Fixing test case issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76130/new/
https://reviews.llvm.org/D76130
___
cfe-commits mail
ZarkoCA updated this revision to Diff 253774.
ZarkoCA added a comment.
Rebased to include byval changes.
Fixed name of array.
Fixed up test case as per comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76130/new/
https://reviews.llvm.org/D76
ZarkoCA updated this revision to Diff 253776.
ZarkoCA added a comment.
Fixed test cases to use builtins again, set no soft float abi for AIX.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76360/new/
https://reviews.llvm.org/D76360
Files:
clang/l
ZarkoCA marked 4 inline comments as done.
ZarkoCA added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019
+ return SetCGInfo(
+ new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI ==
"soft"));
return SetCGInfo(
jasonliu
ZarkoCA marked 2 inline comments as done.
ZarkoCA added inline comments.
Comment at: llvm/test/CodeGen/PowerPC/aix32-cc-abi-vaarg.ll:17
+call void @llvm.va_start(i8* nonnull %0)
+call void @llvm.va_copy(i8* nonnull %0, i8* nonnull %0)
+%argp.cur = load i8*, i8** %arg,
ZarkoCA marked 2 inline comments as done.
ZarkoCA added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205
-CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const {
+CharUnits PowerPC32ABIInfo::getParamTypeAlignment(QualType Ty) const {
// Com
ZarkoCA updated this revision to Diff 253127.
ZarkoCA added a comment.
Created PPCAIX32TargetCodeGenInfo class so that initDwarfEHRegSizeTable now
returns true on AIX and added a test.
Fixed formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
ZarkoCA marked 6 inline comments as done.
ZarkoCA added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4175
namespace {
/// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ELF (SVR4) ABI information.
class PPC32_SVR4_ABIInfo : public DefaultABIInfo {
sf
ZarkoCA updated this revision to Diff 252325.
ZarkoCA marked 2 inline comments as done.
ZarkoCA added a comment.
Renamed PPC32_SVR4ABIInfo class to PPC32ABIInfo.
Fixed test case to use builtins.
Changed comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
ZarkoCA updated this revision to Diff 252147.
ZarkoCA added a comment.
Simplified testcases.
Added testcases for variadic arguments being passed directly to the stack when
all registers are used.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76130/
ZarkoCA added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7076
+static const MCPhysReg GPR_64[] = {PPC::X3, PPC::X4, PPC::X5, PPC::X6,
+ PPC::X7, PPC::X8, PPC::X9, PPC::X10};
+unsigned const NumGPArgRegs =
ZarkoCA updated this revision to Diff 251408.
ZarkoCA marked 11 inline comments as done.
ZarkoCA added a comment.
Addressed code comments, working on adding and fixing tests for further clarity.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76130/ne
ZarkoCA marked 8 inline comments as done.
ZarkoCA added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4175
namespace {
/// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ELF (SVR4) ABI information.
class PPC32_SVR4_ABIInfo : public DefaultABIInfo {
sf
ZarkoCA updated this revision to Diff 251407.
ZarkoCA marked 3 inline comments as done.
ZarkoCA added a comment.
Changed comments per suggestions.
Added `va_copy` in test case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76360/new/
https://reviews.llvm.org/D76360
Files:
clang/lib/
ZarkoCA updated this revision to Diff 25.
ZarkoCA marked an inline comment as done.
ZarkoCA added a comment.
Fixed testcase breakages.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76130/new/
https://reviews.llvm.org/D76130
Files:
llvm/lib/T
ZarkoCA marked 8 inline comments as done.
ZarkoCA added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7088
+ GPRIndex < NumGPArgRegs; ++GPRIndex) {
+unsigned VReg = MF.getRegInfo().getLiveInVirtReg(
+IsPPC64 ? GPR_64[GPRInd
ZarkoCA updated this revision to Diff 251065.
ZarkoCA retitled this revision from "[PPC][AIX] Implement variadic function
handling in LowerFormalArguments_AIX in 32-bit mode." to "[PPC][AIX] Implement
variadic function handling in LowerFormalArguments_AIX".
ZarkoCA edited the summary of this revi
ZarkoCA created this revision.
Herald added subscribers: cfe-commits, kbarton, nemanjai.
Herald added a project: clang.
ZarkoCA added reviewers: jasonliu, sfertile, cebowleratibm.
Herald added a subscriber: wuzish.
This patch contains only the FE changes previously found in
https://reviews.llvm.o
ZarkoCA planned changes to this revision.
ZarkoCA added a comment.
I will split this patch up in two. One for changes in clang specific for 32BIT
AIX varargs, and a second for changes in llc for 32/64BIT varargs.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76130/new/
https://reviews.
ZarkoCA updated this revision to Diff 250772.
ZarkoCA added a comment.
Removed unrelated changes in aix-cc-abi.ll
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76130/new/
https://reviews.llvm.org/D76130
Files:
clang/lib/Basic/Targets/PPC.h
clang/lib/CodeGen/TargetInfo.cpp
clang/t
ZarkoCA updated this revision to Diff 250749.
ZarkoCA added a comment.
- Removed 64BIT support varargs.
- Added a fatal error for 64bit varargs on AIX.
- Removed 64bit testcases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76130/new/
https://revie
ZarkoCA updated this revision to Diff 250213.
ZarkoCA added a comment.
Clang formatted the patch and fixed typo in testcase.
Repository:
rZORG LLVM Github Zorg
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76130/new/
https://reviews.llvm.org/D76130
Files:
clang/lib/Basic/Targets/P
ZarkoCA created this revision.
ZarkoCA added reviewers: cebowleratibm, sfertile.
Herald added subscribers: cfe-commits, kbarton, hiraditya, nemanjai.
Herald added a project: clang.
This patch adds support for handling of variadic functions for AIX. This
includes ensuring that use and consume corr
201 - 225 of 225 matches
Mail list logo
