[clang] fix access checking about function overloading (PR #107768)

2024-10-13 Thread Zhikai Zeng via cfe-commits
Backl1ght wrote: After some more debugging, I find out that we will check access here at https://github.com/llvm/llvm-project/blob/8e010ac5a173c9dee44b44324169a3e100a1a6fc/clang/lib/Sema/SemaInit.cpp#L7807 And for `f()` inside code below, `Found.getAccess()` is `AS_none` hence `CheckAddressOfM

[clang] fix access checking about function overloading (PR #107768)

2024-10-11 Thread Zhikai Zeng via cfe-commits
Backl1ght wrote: Sorry for the late response, I will continue to look into this issue this sunday. https://github.com/llvm/llvm-project/pull/107768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] fix access checking about function overloading (PR #107768)

2024-09-08 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght created https://github.com/llvm/llvm-project/pull/107768 fix https://github.com/llvm/llvm-project/issues/107629 TODO: add UT. TODO: test UB mentioned in https://github.com/llvm/llvm-project/issues/107629. >From 65172d8391cef4c0c7e239c9a09b34e061f4963a Mon Sep 17 00

[clang] [Clang] fix generic lambda inside requires-clause of friend function template (PR #99813)

2024-08-10 Thread Zhikai Zeng via cfe-commits
Backl1ght wrote: > So, friend functions do not increase the template depth? That seems... weird! This is not the cause, as for template depth friend functions behave just the same as other functions I think. Maybe you are confused by my first comment in https://github.com/llvm/llvm-project/iss

[clang] [Clang] fix generic lambda inside requires-clause of friend function template (PR #99813)

2024-07-26 Thread Zhikai Zeng via cfe-commits
@@ -1691,10 +1691,7 @@ class ConstraintRefersToContainingTemplateChecker using inherited::TransformTemplateTypeParmType; QualType TransformTemplateTypeParmType(TypeLocBuilder &TLB, TemplateTypeParmTypeLoc TL, bool) { -assert(TL.g

[clang] [Clang] fix generic lambda inside requires-clause of friend function template (PR #99813)

2024-07-26 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/99813 >From 5d7f291e35930e07f52a7ac17a09f93690b64def Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sun, 21 Jul 2024 23:43:24 +0800 Subject: [PATCH 1/2] fix --- clang/docs/ReleaseNotes.rst | 2 ++

[clang] [Clang] fix generic lambda inside requires-clause of friend function template (PR #99813)

2024-07-21 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght created https://github.com/llvm/llvm-project/pull/99813 fixes https://github.com/llvm/llvm-project/issues/98258 The cause is that the assertion "Nothing should reference a value below the actual template depth" is incorrect since we can have a generic lambda inside

[clang] [Clang][ExprConstant] fix constant expression did not evaluate to integer (PR #97146)

2024-07-06 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght closed https://github.com/llvm/llvm-project/pull/97146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ExprConstant] fix constant expression did not evaluate to integer (PR #97146)

2024-07-06 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/97146 >From 804c18269ab0c8018834a89f286e05c7e479ed42 Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sat, 29 Jun 2024 15:26:21 +0800 Subject: [PATCH 1/2] fix --- clang/docs/ReleaseNotes.rst | 1 + clang/lib

[clang] [Clang][ExprConstant] fix constant expression did not evaluate to integer (PR #97146)

2024-07-06 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/97146 >From 7e14846e93df9f86b994c526b0da1f729c9b7cd4 Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sat, 29 Jun 2024 15:26:21 +0800 Subject: [PATCH 1/2] fix --- clang/docs/ReleaseNotes.rst | 1 + clang/lib

[clang] [Clang][ExprConstant] fix constant expression did not evaluate to integer (PR #97146)

2024-06-29 Thread Zhikai Zeng via cfe-commits
Backl1ght wrote: > I'm concerned that we're calling EvaluateKnownConstInt on an lvalue; that > might indicate there's something wrong with the AST. Usually there should be > an lvalue-to-rvalue cast somewhere. @efriedma-quic lvalue-to-rvalue cast is done here at https://github.com/llvm/llvm-p

[clang] [Clang][ExprConstant] fix constant expression did not evaluate to integer (PR #97146)

2024-06-29 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/97146 >From 5a443296eecbdf90d1cf274c3e52797be380bdd3 Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sat, 29 Jun 2024 15:26:21 +0800 Subject: [PATCH 1/2] fix --- clang/docs/ReleaseNotes.rst | 1 + clang/lib

[clang] [Clang][ExprConstant] fix constant expression did not evaluate to integer (PR #97146)

2024-06-29 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght created https://github.com/llvm/llvm-project/pull/97146 fixes https://github.com/llvm/llvm-project/issues/96670 The cause is that we might return a lvalue here at https://github.com/llvm/llvm-project/blob/3e53c97d33210db68188e731e93ee48dbaeeae32/clang/lib/AST/ExprC

[clang] [Clang][Sema] fix assertion failure about invalid conversion when calling lambda (PR #96431)

2024-06-28 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght closed https://github.com/llvm/llvm-project/pull/96431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix assertion failure about invalid conversion when calling lambda (PR #96431)

2024-06-28 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/96431 >From ce317e4c2f1bca3e81b81ac8909c576b14a16a6b Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sun, 23 Jun 2024 21:44:03 +0800 Subject: [PATCH] fix --- clang/docs/ReleaseNotes.rst| 1 + clang/lib/Sema

[clang] [Clang][Sema] fix assertion failure about invalid conversion when calling lambda (PR #96431)

2024-06-23 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght created https://github.com/llvm/llvm-project/pull/96431 fixes https://github.com/llvm/llvm-project/issues/96205 The cause is that some `Conversions[ConvIdx]` here is not initialized https://github.com/llvm/llvm-project/blob/eb76bc38ffc286e62fdb8f8d897b5de04b2575be

[clang] [Clang] fix access checking inside return-type-requirement of compound requirements (PR #95651)

2024-06-22 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght closed https://github.com/llvm/llvm-project/pull/95651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix access checking inside return-type-requirement of compound requirements (PR #95651)

2024-06-22 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/95651 >From 64ee10bf71d79c97f45779dbbd9f74e85a5676ee Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sat, 15 Jun 2024 16:56:00 +0800 Subject: [PATCH] fix --- clang/docs/ReleaseNotes.rst | 1 + cla

[clang] [Clang] fix access checking inside return-type-requirement of compound requirements (PR #95651)

2024-06-21 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/95651 >From 1c283900fc4bc984ebd917ead6ddd8c5d0364d80 Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sat, 15 Jun 2024 16:56:00 +0800 Subject: [PATCH] fix --- clang/docs/ReleaseNotes.rst | 1 + cla

[clang] [Clang] fix access checking inside return-type-requirement of compound requirements (PR #95651)

2024-06-16 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/95651 >From 49f0d1aff888b2a96ed3a19d8d2e30d367caf14f Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sat, 15 Jun 2024 16:56:00 +0800 Subject: [PATCH] fix --- clang/docs/ReleaseNotes.rst | 1 + cla

[clang] [Clang] fix access checking inside return-type-requirement of compound requirements (PR #95651)

2024-06-15 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght created https://github.com/llvm/llvm-project/pull/95651 fixes https://github.com/llvm/llvm-project/issues/93788 . >From 7911a757d6b97a12baf465d0fe1a9442ca2ee76b Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sat, 15 Jun 2024 16:56:00 +0800 Subject: [PATCH] fix ---

[clang] [clang] fix typo (PR #73644)

2023-11-28 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght closed https://github.com/llvm/llvm-project/pull/73644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix typo (PR #73644)

2023-11-28 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/73644 >From 1381fd047b27a019166b6c9552c55afaa916ee39 Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Tue, 28 Nov 2023 21:18:49 +0800 Subject: [PATCH] [clang] fix typo --- clang/lib/Sema/SemaInit.cpp | 2 +- 1 file c

[openmp] [clang] [llvm] [clang] fix typo (PR #73644)

2023-11-28 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/73644 >From a417fb4d421cc28115bb2ea2062fb400586a7042 Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Tue, 28 Nov 2023 21:18:49 +0800 Subject: [PATCH] [clang] fix typo --- clang/lib/Sema/SemaInit.cpp | 2 +- 1 file c

[clang] [clang] fix typo (PR #73644)

2023-11-28 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght created https://github.com/llvm/llvm-project/pull/73644 None >From a417fb4d421cc28115bb2ea2062fb400586a7042 Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Tue, 28 Nov 2023 21:18:49 +0800 Subject: [PATCH] [clang] fix typo --- clang/lib/Sema/SemaInit.cpp | 2 +- 1