[PATCH] D153580: [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs)

zibi accepted this revision. zibi added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153580/new/ https://reviews.llvm.org/D153580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152016: Remove 3-byte characters causing clang-tblgen to get I/O error.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a27ddd42333: Remove 3-byte characters causing clang-tblgen to get I/O error. (authored by zibi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152016/new/

[PATCH] D152016: Remove 3-byte characters causing clang-tblgen to get I/O error.

zibi created this revision. zibi added reviewers: Kai, fanbo-meng, abhina.sreeskantharajan. Herald added a reviewer: aaron.ballman. Herald added a project: All. zibi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [SystemZ} This revision

[PATCH] D151828: [z/OS] Disable pr59765-modules-global-ctor-dtor.cppm on z/OS to make it unsupported.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f0f171d7f8: [z/OS] Disable pr59765-modules-global-ctor-dtor.cppm on z/OS to make it… (authored by zibi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151828: Disable pr59765-modules-global-ctor-dtor.cppm on z/OS to make it unsupported.

zibi created this revision. Herald added a project: All. zibi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [z/OS] Disable pr59765-modules-global-ctor-dtor.cppm Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151828

[PATCH] D134034: [test] Use host platform specific error message substitution

zibi accepted this revision. zibi added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134034/new/ https://reviews.llvm.org/D134034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

zibi added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

zibi added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

zibi accepted this revision. zibi added a comment. This revision is now accepted and ready to land. LTGM, thx for an extra mile, Abhina. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ https://reviews.llvm.org/D97785

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

zibi added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:771 +TempPath, fd, TempPath, +llvm::sys::fs::all_read | llvm::sys::fs::all_write, +Binary ? llvm::sys::fs::OF_None : llvm::sys::fs::OF_Text); The `

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

zibi added a comment. LGTM, I just wonder if we can make an extra parameter to be default. I notice some places that is a default parameter but not in all instances. With default parameter some of the calls might be simplified if there is no need to override it. Comment at: