[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze added a comment. @NoQ gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124244/new/ https://reviews.llvm.org/D124244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze added a comment. In D124244#3588671 , @steakhal wrote: > Sorry for my late reply. > > It feels like we have some serious obstacles. > The `check::PostCall` handler wants to mark some memory region immutable. > Currently, the checker creates

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze added a comment. In D124244#3493307 , @martong wrote: >> The patch adds two new checkers. > > I don't see any technical dependencies between the two, so, please split it > into two independent patches. StoreToImmutable does not depend on th

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:767-769 assert(isa(sreg) || isa(sreg) || - isa(sreg)); + isa(sreg) || + isa(sreg)); steakhal wrote: > Please merg

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze updated this revision to Diff 430204. zukatsinadze marked 14 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124244/new/ https://reviews.llvm.org/D124244 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyzer/Checkers/Checkers.t

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze updated this revision to Diff 424493. zukatsinadze added a comment. fix clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124244/new/ https://reviews.llvm.org/D124244 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyzer/Checkers/Checkers.

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze created this revision. zukatsinadze added reviewers: NoQ, martong, steakhal, balazske, vsavchenko. zukatsinadze added a project: clang. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xaza

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

This revision was automatically updated to reflect the committed changes. zukatsinadze marked an inline comment as done. Closed by commit rG811b1736d91b: [analyzer] Add InvalidPtrChecker (authored by zukatsinadze). Changed prior to commit: https://reviews.llvm.org/D97699?vs=372237&id=376902#toc

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze marked 4 inline comments as done. zukatsinadze added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:163 +// memory region returned by previous call of this function +REGISTER_MAP_WITH_PROGRAMSTATE(PreviousCallResultMap, cons

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 372237. zukatsinadze added a comment. Thanks for the review @martong I've fixed all the suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 Files: clang/docs/analyzer/checkers.rst clang/in

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze marked an inline comment as done and an inline comment as not done. zukatsinadze added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:947 + +} // end "alpha.cert.env" + balazske wrote: > I have multiple issues wi

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 350656. zukatsinadze marked 2 inline comments as done. zukatsinadze added a comment. @balazske Thanks for the comments! Updated diff after suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze added a comment. Herald added a subscriber: manas. @NoQ can you please have another look at this? I think it will be a useful checker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 _

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 335334. zukatsinadze edited the summary of this revision. zukatsinadze added a comment. Gentle ping - Diff with context - Added some more tests - Updated documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2103-2104 +puts(envp[i]); +// envp may no longer point to the current environment +// this program has unanticipated behavior. + } zukatsinadze wrote: >

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2103-2104 +puts(envp[i]); +// envp may no longer point to the current environment +// this program has unanticipated behavior. + } Charusso wrote: > NoQ

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze added a comment. @NoQ, thanks for the comments. In D97699#2601804 , @NoQ wrote: > ... and whether flagged code is expected to be always invalid. C standard says "may be overwritten", so I guess it's undefined behavior. In D97699#2601804

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 327173. zukatsinadze added a comment. Removed code repetition from the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 Files: clang/docs/analyzer/checkers

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze added a comment. Attaching results of CodeChecker run on some projects.F15697529: cc_results.zip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 __

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 327150. zukatsinadze added a comment. Fixed docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 Files: clang/docs/analyzer/checkers.rst clang/include/clang/S

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze added a comment. Please suggest which package to use for the checker. CERT rules are ENV, however, it deals with non-ENV functions as well. Also, I am having a problem with `checkDeadSymbols`, it is similar to one xazax.hun faced here: http://reviews.llvm.org/D14203 (many many year

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze created this revision. zukatsinadze added reviewers: NoQ, vsavchenko, Charusso, Szelethus, martong. zukatsinadze added a project: clang. Herald added subscribers: steakhal, ASDenysPetrov, ormris, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xaz

[PATCH] D85093: [analyzer] StdLibraryFunctionsChecker: Add support for new functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG25bbe234e4e7: [analyzer] StdLibraryFunctionsChecker: Add support for new functions (authored by zukatsinadze). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D85093: [analyzer] StdLibraryFunctionsChecker: Add support for new functions

zukatsinadze created this revision. zukatsinadze added reviewers: NoQ, Charusso, martong, Szelethus. zukatsinadze added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. zukatsina

[PATCH] D79358: [analyzer] CERT: STR37-C

zukatsinadze added a comment. In D79358#2019755 , @Szelethus wrote: > Adding @martong, because I fear that this is colliding with > StdLibraryFunctionsChecker. The warnings added here seem to be, in essence, > identical to D73898

[PATCH] D79358: [analyzer] CERT: STR37-C

zukatsinadze created this revision. zukatsinadze added reviewers: NoQ, Charusso, Szelethus. zukatsinadze added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. This patc

[PATCH] D71433: [analyzer] CERT: POS34-C

This revision was automatically updated to reflect the committed changes. Closed by commit rGa54d81f59796: [analyzer] CERT: POS34-C (authored by zukatsinadze). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/ https://reviews.llvm.org/D71433

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze added a comment. In D71433#1880436 , @Szelethus wrote: > I think for an alpha checker this is ready to land if you're ready -- do you > have commit access or need assistance? Thank you. @Charusso will help. CHANGES SINCE LAST ACTION htt

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze updated this revision to Diff 243149. zukatsinadze marked an inline comment as done. zukatsinadze added a comment. - Removed dead code. - Removed unnecessary if condition. - Changed error phrasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/ https://reviews.l

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze marked 2 inline comments as done. zukatsinadze added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:3383-3386 +std::unique_ptr getMallocBRVisitor(SymbolRef Sym) { + return std::make_unique(Sym); +} + Szelethus wrote

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze added a comment. In D71433#1863638 , @Charusso wrote: > In D71433#1808316 , @Charusso wrote: > > > In D71433#1784238 , @NoQ wrote: > > > > > Currently the check

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze updated this revision to Diff 243127. zukatsinadze added a comment. Addressed new inline comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/ https://reviews.llvm.org/D71433 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyzer/Checke

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze updated this revision to Diff 233955. zukatsinadze added a comment. - Removed extra test - Used `CallDescription` for checking call. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/ https://reviews.llvm.org/D71433 Files: clang/docs/analyzer/checkers.rst clang

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze added a comment. In D71433#1784238 , @NoQ wrote: > Thanks! This looks like a simple and efficient check. I have one overall > suggestion. > > Currently the check may warn on non-bugs of the following kind: > > void foo() { > char env[]

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze marked 4 inline comments as done. zukatsinadze added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:765 + HelpText<"Finds calls to the `putenv` function which pass a pointer to " + "an automatic variable as the argumen

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze updated this revision to Diff 233946. zukatsinadze added a comment. Addressed most of the inline comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/ https://reviews.llvm.org/D71433 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyze

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze created this revision. zukatsinadze added a reviewer: NoQ. zukatsinadze added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. This patch introduces a new checker: `alpha

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

zukatsinadze marked an inline comment as done. zukatsinadze added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PutenvWithAutoCheck.cpp:27 + hasAutomaticStorageDuration(), + unless(hasDescendant(callExpr(callee(functionDecl(hasAn

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

zukatsinadze updated this revision to Diff 231465. zukatsinadze added a comment. changes after review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70823/new/ https://reviews.llvm.org/D70823 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp clang-tools-extra/clang-tidy/c

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

zukatsinadze marked 5 inline comments as done. zukatsinadze added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PutenvWithAutoCheck.cpp:28 + unless(hasDescendant(callExpr(callee(functionDecl(hasAnyName( + "::alloc", "::malloc

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

zukatsinadze created this revision. zukatsinadze added reviewers: aaron.ballman, alexfh, hokein, Charusso. zukatsinadze added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, mgehre, xazax.hun, mgorny. According to https://wiki.sei.cmu.edu/confluence/display/c/POS34-C.+Do